Add view parameter to get_search_terms method of SearchFilter class #9731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
winie force-pushed the add-view-to-get_search_term-method branch from dccf3d6 to 990d265 Compare 
Collaborator
| Thanks but no:
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This merge request adds the new view parameter as discussed in issue #9730.
For compatibility reasons, the view parameter has been appended to the end of the parameter list, rather than being positioned to match the order used in the get_search_fields method.
While this does not align with the order of parameters in get_search_fields, it ensures backward compatibility and avoids breaking existing implementations.