feat:The request in the dispatch function has been type annotated #9727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| @auvipy @browniebroke This looks like an easy win. |
Contributor
| Why? 😔 |
Author
| Are these more complete type annotations inspired by me? Is that correct? (It makes sense in terms of the timeline.) Even without a physical contribution, a spiritual contribution is worth being happy about. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds an explicit type annotation to
self.requestwithin thedispatchmethod.By assigning
self.request: Request = request, it helps IDEs like PyCharm correctly infer the type ofself.request, improving type checking and code navigation.There are no functional changes, only a minor internal improvement for developer experience.
No related issue.