Skip to content

Conversation

@peterthomassen
Copy link
Collaborator

@peterthomassen peterthomassen commented Jun 25, 2025

The new behavior reported in #9410 is not really a bug, but makes for consistent treatment of uniqueness constraints from a model's constraints and unique_together attribute.

Presence of a uniqueness constraint impacts the default value of required, which was surprising to certain users. This PR makes this more explicit in documentation.

Fix #9410

@peterthomassen
Copy link
Collaborator Author

@auvipy For some reason I can't formally request a review, so I'm doing it this way :)

Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@browniebroke browniebroke changed the title docs: unique constraints cause 'required=True', fixes #9410 docs: unique constraints cause 'required=True' Jun 25, 2025
@peterthomassen
Copy link
Collaborator Author

I don't have merge permission (used to have, hmm). Anyway, can you please merge? Thx.

@browniebroke browniebroke merged commit 3038494 into encode:master Jun 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants