Merge pull request #11 from swiftype/handling-missing-facets

Fixed reference app error

Author: JasonStoltz

src/app-search/AppSearchDriver.js

@@ -160,7 +160,7 @@ export default class AppSearchDriver {
  this._setState({
  current,
  error: "",
- facets: resultList.info.facets,
+ facets: resultList.info.facets || {},
  filters,
  requestId: resultList.info.meta.request_id,
  results: resultList.results,

src/app-search/AppSearchDriver.test.js

@@ -15,6 +15,18 @@ const resultList = {
  results: [{}, {}]
 };
 
+const resultListWithoutFacets = {
+ info: {
+ meta: {
+ page: {
+ total_results: 1000
+ },
+ request_id: "12345"
+ }
+ },
+ results: [{}, {}]
+};
+
 const params = {
  engineName: "some-engine",
  hostIdentifier: "host-XXXX",
@@ -31,6 +43,11 @@ beforeAll(() => {
  SwiftypeAppSearch.createClient.mockReturnValue(mockClient);
 });
 
+beforeEach(() => {
+ mockClient.search = jest.fn().mockReturnValue({ then: cb => cb(resultList) });
+ mockClient.click = jest.fn().mockReturnValue({ then: () => {} });
+});
+
 it("can be initialized", () => {
  const driver = new AppSearchDriver(params);
  expect(driver).toBeInstanceOf(AppSearchDriver);
@@ -62,6 +79,30 @@ it("will use initial state if provided", () => {
  });
 });
 
+it("will default facets to {} in state if facets is missing from the response", () => {
+ const initialState = {
+ searchTerm: "test"
+ };
+
+ mockClient.search = jest
+ .fn()
+ .mockReturnValue({ then: cb => cb(resultListWithoutFacets) });
+
+ const driver = new AppSearchDriver({
+ ...params,
+ initialState
+ });
+ const stateAfterCreation = driver.getState();
+
+ expect(stateAfterCreation).toEqual({
+ ...DEFAULT_STATE,
+ ...initialState,
+ requestId: "12345",
+ results: [{}, {}],
+ totalResults: 1000
+ });
+});
+
 it("will trigger a search if searchTerm or filters are provided in initial state", () => {
  const initialState = {
  filters: [{ initial: "value" }],

src/config/config-helper.js

@@ -153,11 +153,11 @@ export function buildSearchOptionsFromConfig() {
  return acc;
  }, undefined);
 
- return {
-  facets,
-  result_fields: resultFields,
-  search_fields: searchFields
- };
+ const searchOptions = {};
+ if (facets) searchOptions.facets = facets;
+ searchOptions.result_fields = resultFields;
+ searchOptions.search_fields = searchFields;
+ return searchOptions;
 }
 
 export function buildSortOptionsFromConfig() {