Skip to content

Commit 55f9edd

Browse files
authored
Merge pull request microsoft#3835 from southworks/external/fix/southworks/fix-va-pipeline-yaml
[C#][VA] Fix Virtual Assistant's Pipeline compatibility issues
2 parents 1c4b04e + c9dd96b commit 55f9edd

File tree

2 files changed

+24
-28
lines changed

2 files changed

+24
-28
lines changed

samples/csharp/assistants/virtual-assistant/VirtualAssistantSample/Pipeline/VirtualAssistantSample.yml

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,28 @@
11
# specific branch build
22
trigger:
3-
branches:
3+
branches:
44
include:
55
- master
66
- feature/*
7-
7+
88
pool:
9-
name: Hosted VS2017
10-
demands:
11-
- msbuild
12-
- visualstudio
9+
vmimage: 'windows-2019'
1310

1411
variables:
1512
buildPlatform: 'Any CPU'
1613
buildConfiguration: 'Release'
1714

1815
steps:
19-
- task: DotNetCoreInstaller@0
20-
displayName: 'Use .NET Core sdk 2.2.100'
16+
- task: DotNetCoreInstaller@2
17+
displayName: 'Use .NET Core sdk 3.1'
2118
inputs:
22-
version: 2.2.100
19+
version: 3.1.x
2320
continueOnError: true
2421

2522
- task: NuGetToolInstaller@0
26-
displayName: 'Use NuGet 4.9.1'
23+
displayName: 'Use NuGet 5.3.0'
2724
inputs:
28-
versionSpec: 4.9.1
25+
versionSpec: 5.3.0
2926

3027
- task: NuGetCommand@2
3128
displayName: 'NuGet restore'
@@ -60,12 +57,13 @@ steps:
6057
summaryFileLocation: '$(Build.SourcesDirectory)\VirtualAssistantSample.Tests\coverage.cobertura.xml'
6158
reportDirectory: '$(Build.SourcesDirectory)\VirtualAssistantSample.Tests'
6259

63-
- task: CopyFiles@2
60+
- task: CopyFiles@2
6461
displayName: 'Copy VA'
6562
inputs:
66-
SourceFolder: '$(System.DefaultWorkingDirectory)\templates\Virtual-Assistant-Template\csharp\Sample\VirtualAssistantSample'
63+
# if your working directory is not root, you may change the following path
64+
SourceFolder: '$(System.DefaultWorkingDirectory)\VirtualAssistantSample'
6765
Contents: '**\*'
6866
TargetFolder: '$(Build.ArtifactStagingDirectory)\VA'
6967

7068
- task: PublishBuildArtifacts@1
71-
displayName: 'Artifacts'
69+
displayName: 'Artifacts'

templates/csharp/VA/VA/Pipeline/VirtualAssistantSample.yml

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,28 @@
11
# specific branch build
22
trigger:
3-
branches:
3+
branches:
44
include:
55
- master
66
- feature/*
7-
7+
88
pool:
9-
name: Hosted VS2017
10-
demands:
11-
- msbuild
12-
- visualstudio
9+
vmimage: 'windows-2019'
1310

1411
variables:
1512
buildPlatform: 'Any CPU'
1613
buildConfiguration: 'Release'
1714

1815
steps:
19-
- task: DotNetCoreInstaller@0
20-
displayName: 'Use .NET Core sdk 2.2.100'
16+
- task: DotNetCoreInstaller@2
17+
displayName: 'Use .NET Core sdk 3.1'
2118
inputs:
22-
version: 2.2.100
19+
version: 3.1.x
2320
continueOnError: true
2421

2522
- task: NuGetToolInstaller@0
26-
displayName: 'Use NuGet 4.9.1'
23+
displayName: 'Use NuGet 5.3.0'
2724
inputs:
28-
versionSpec: 4.9.1
25+
versionSpec: 5.3.0
2926

3027
- task: NuGetCommand@2
3128
displayName: 'NuGet restore'
@@ -60,12 +57,13 @@ steps:
6057
summaryFileLocation: '$(Build.SourcesDirectory)\$safeprojectname$.Tests\coverage.cobertura.xml'
6158
reportDirectory: '$(Build.SourcesDirectory)\$safeprojectname$.Tests'
6259

63-
- task: CopyFiles@2
60+
- task: CopyFiles@2
6461
displayName: 'Copy VA'
6562
inputs:
66-
SourceFolder: '$(System.DefaultWorkingDirectory)\templates\Virtual-Assistant-Template\csharp\Sample\VirtualAssistantSample'
63+
# if your working directory is not root, you may change the following path
64+
SourceFolder: '$(System.DefaultWorkingDirectory)\$safeprojectname$'
6765
Contents: '**\*'
6866
TargetFolder: '$(Build.ArtifactStagingDirectory)\VA'
6967

7068
- task: PublishBuildArtifacts@1
71-
displayName: 'Artifacts'
69+
displayName: 'Artifacts'

0 commit comments

Comments
 (0)