Skip to content

Commit 3d320c1

Browse files
committed
Added _coerce for fields that require it
As discussed in elastic#791. Also fixed some newlines and removed duplicate Percolator.
1 parent 8a7b282 commit 3d320c1

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

elasticsearch_dsl/field.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,7 @@ class Keyword(Field):
272272

273273
class Boolean(Field):
274274
name = 'boolean'
275+
_coerce = True
275276

276277
def _deserialize(self, data):
277278
if data is None:
@@ -287,9 +288,9 @@ def clean(self, data):
287288
raise ValidationException("Value required for this field.")
288289
return data
289290

290-
291291
class Float(Field):
292292
name = 'float'
293+
_coerce = True
293294

294295
def _deserialize(self, data):
295296
if data is None:
@@ -305,20 +306,18 @@ class ScaledFloat(Float):
305306
def __init__(self, scaling_factor, *args, **kwargs):
306307
super(ScaledFloat, self).__init__(scaling_factor=scaling_factor, *args, **kwargs)
307308

308-
309309
class Double(Float):
310310
name = 'double'
311311

312-
313312
class Integer(Field):
314313
name = 'integer'
314+
_coerce = True
315315

316316
def _deserialize(self, data):
317317
if data is None:
318318
return None
319319
return int(data)
320320

321-
322321
class Byte(Integer):
323322
name = 'byte'
324323

@@ -330,6 +329,7 @@ class Long(Integer):
330329

331330
class Ip(Field):
332331
name = 'ip'
332+
_coerce = True
333333

334334
def _deserialize(self, data):
335335
if data is None:
@@ -345,6 +345,7 @@ def _serialize(self, data):
345345

346346
class Binary(Field):
347347
name = 'binary'
348+
_coerce = True
348349

349350
def _deserialize(self, data):
350351
if data is None:
@@ -391,6 +392,3 @@ class TokenCount(Field):
391392

392393
class Murmur3:
393394
name = 'murmur3'
394-
395-
class Percolator:
396-
name = 'percolator'

0 commit comments

Comments
 (0)