Replace message worker/sup with poolboy worker pool

Author: craigp

lib/gmail/message/pool.ex

@@ -0,0 +1,54 @@
+defmodule Gmail.Message.Pool do
+
+ @moduledoc """
+ A pool of workers for handling message operations.
+ """
+
+ alias Gmail.Message.PoolWorker
+
+ @default_pool_size 20
+
+ @doc false
+ def start_link do
+ poolboy_config = [
+ {:name, {:local, :message_pool}},
+ {:worker_module, PoolWorker},
+ {:size, pool_size},
+ {:max_overflow, 0}
+ ]
+
+ children = [
+ :poolboy.child_spec(:message_pool, poolboy_config, [])
+ ]
+
+ options = [
+ strategy: :one_for_one,
+ name: __MODULE__
+ ]
+
+ Supervisor.start_link(children, options)
+ end
+
+ @doc """
+ Gets a message.
+ """
+ @spec get(String.t, String.t, map, map) :: {atom, map}
+ def get(user_id, message_id, params, state) do
+ :poolboy.transaction(
+ :message_pool,
+ fn pid ->
+ PoolWorker.get(pid, user_id, message_id, params, state)
+ end,
+ :infinity)
+ end
+
+ def pool_size do
+ case Application.get_env(:gmail, :message) do
+ [pool: size] when is_integer(size) ->
+ size
+ _ ->
+ @default_pool_size
+ end
+ end
+
+end

lib/gmail/message/pool_worker.ex

@@ -0,0 +1,39 @@
+defmodule Gmail.Message.PoolWorker do
+
+ @moduledoc """
+ A message pool worker.
+ """
+
+ use GenServer
+ alias Gmail.{Message, User}
+
+ @doc false
+ def start_link([]) do
+ GenServer.start_link(__MODULE__, [], [])
+ end
+
+ @doc false
+ def init(state) do
+ {:ok, state}
+ end
+
+ @doc false
+ def handle_call({:get, user_id, message_id, params, state}, _from, worker_state) do
+ result =
+ user_id
+ |> Message.get(message_id, params)
+ |> User.http_execute(state)
+ |> Message.handle_message_response
+ {:reply, result, worker_state}
+ end
+
+ @doc """
+ Gets a message.
+ """
+ @spec get(pid, String.t, String.t, map, map) :: {atom, map}
+ def get(pid, user_id, message_id, params, state) do
+ GenServer.call(pid, {:get, user_id, message_id, params, state}, :infinity)
+ end
+
+end
+

lib/gmail/message/supervisor.ex

@@ -16,7 +16,7 @@ defmodule Gmail.Supervisor do
  children = [
  supervisor(Gmail.UserManager, []),
  supervisor(Gmail.Thread.Pool, []),
- supervisor(Gmail.Message.Supervisor, [])
+ supervisor(Gmail.Message.Pool, [])
  ]
  supervise(children, strategy: :one_for_one)
  end

lib/gmail/message/worker.ex

@@ -148,14 +148,22 @@ defmodule Gmail.User do
  end
 
  @doc false
- def handle_call({:message, {:get, message_ids, params}}, from, state) when is_list(message_ids) do
- Gmail.Message.Worker.fetch(from, message_ids, params, state)
- {:noreply, state}
+ def handle_call({:message, {:get, message_ids, params}}, _from, %{user_id: user_id} = state) when is_list(message_ids) do
+ messages =
+ message_ids
+ |> Enum.map(fn id ->
+ Task.async(fn ->
+ {:ok, message} = Gmail.Message.Pool.get(user_id, id, params, state)
+ message
+ end)
+ end)
+ |> Enum.map(fn task -> Task.await(task, :infinity) end)
+ {:reply, {:ok, messages}, state}
  end
 
  @doc false
- def handle_call({:message, {:get, message_id, params}}, _from, state) do
- result = Gmail.Message.Worker.get(message_id, params, state);
+ def handle_call({:message, {:get, message_id, params}}, _from, %{user_id: user_id} = state) do
+ result = Gmail.Message.Pool.get(user_id, message_id, params, state)
  {:reply, result, state}
  end