Skip to content
This repository was archived by the owner on Aug 11, 2023. It is now read-only.

Various CMake improvements #170

Merged
merged 5 commits into from
Jan 14, 2019
Merged

Various CMake improvements #170

merged 5 commits into from
Jan 14, 2019

Conversation

@Rbiessy
Copy link
Contributor

@Rbiessy Rbiessy commented Jan 10, 2019 •
edited
Loading

Various changes mostly needed by Eigen:

  • fix issue if multiple targets use the same source file
  • take into account arguments from the COMPILE_FLAGS target property Removed as it may break the compiler if some flags are meant for a different host compiler only (i.e. gcc)
  • call separate_arguments on COMPUTECPP_USER_FLAGS as the user should just be able to give space separated string
  • remove unused device_compiler_includes variable
@Rbiessy Rbiessy requested a review from DuncanMcBain January 10, 2019 12:06
jwlawson
jwlawson reviewed Jan 10, 2019
View reviewed changes
DuncanMcBain
DuncanMcBain reviewed Jan 10, 2019
View reviewed changes
DuncanMcBain
DuncanMcBain reviewed Jan 11, 2019
View reviewed changes
@DuncanMcBain DuncanMcBain merged commit ff126b9 into codeplaysoftware:master Jan 14, 2019
@Rbiessy Rbiessy deleted the various_improvements branch January 17, 2019 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cmake enhancement

3 participants

@Rbiessy @jwlawson @DuncanMcBain