Skip to content
This repository was archived by the owner on Aug 11, 2023. It is now read-only.

Conversation

@cjdb
Copy link
Contributor

@cjdb cjdb commented Dec 11, 2018

No description provided.

@MathiasMagnus
Copy link
Contributor

This sounds awesome, but what on Earth is the on_chip_memory extension? :D If you'd have a link in the comments, I'd definitely read it before scanning through the sample.

@keryell
Copy link
Contributor

keryell commented Dec 11, 2018

Yes the example should direct somehow to a specification.
@MathiasMagnus full disclosure is on codeplaysoftware/standards-proposals#83
I am pretty sure you would love following this git repository. :-)
But by the way, when do you join the Khronos SYCL group? :)

@MathiasMagnus
Copy link
Contributor

I'm an unfrequent committer to this repo, but will star it. ;) As for joining Khronos… next year's funding is problematic to say the least. I'm willing to discuss in greater detail, but not on public forums. :)

Copy link

@Ruyk Ruyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes requested, thanks for the example!

Copy link
Member

@DuncanMcBain DuncanMcBain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! It's very well commented, which is making me feel guilty about all the samples I've added that are not so well-described!

Copy link
Contributor

@AerialMantis AerialMantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

"\n"
"This particular error has occurred because you are requiring "
"the policy use_onchip_memory be available, and your hardware "
"doesn't support the use_onchip_memory, so the SYCL ecosystem "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be clearer to say "implementation" instead of "ecosystem".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

Copy link
Member

@DuncanMcBain DuncanMcBain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know what you think of that last change and I'll smash that merge button

@DuncanMcBain DuncanMcBain merged commit 266b9e0 into master Dec 14, 2018
@DuncanMcBain DuncanMcBain deleted the use-onchip-memory branch December 14, 2018 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

7 participants