- Notifications
You must be signed in to change notification settings - Fork 89
Added use-onchip-memory sample #165
Conversation
| This sounds awesome, but what on Earth is the |
| Yes the example should direct somehow to a specification. |
| I'm an unfrequent committer to this repo, but will star it. ;) As for joining Khronos… next year's funding is problematic to say the least. I'm willing to discuss in greater detail, but not on public forums. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes requested, thanks for the example!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! It's very well commented, which is making me feel guilty about all the samples I've added that are not so well-described!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
| "\n" | ||
| "This particular error has occurred because you are requiring " | ||
| "the policy use_onchip_memory be available, and your hardware " | ||
| "doesn't support the use_onchip_memory, so the SYCL ecosystem " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be clearer to say "implementation" instead of "ecosystem".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know what you think of that last change and I'll smash that merge button
No description provided.