This repository was archived by the owner on Aug 11, 2023. It is now read-only.
Update depfile generation for device compiler #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Ninja has a problem if the name of the object doesn't match what it expects, so this changes the generation to output a relative path, not an absolute one. Additionally, the quotes in the optional DEPFILE variable were causing problems, so they have also been removed.
| @mmha you might be interested in this! |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Ninja has a problem if the name of the object doesn't match what it
expects, so this changes the generation to output a relative path, not
an absolute one. Additionally, the quotes in the optional DEPFILE
variable were causing problems, so they have also been removed.