Skip to content

Commit e2a0a58

Browse files
ahunter6cjb
authored andcommitted
mmc: sdhci-pci: remove SDHCI_QUIRK2_OWN_CARD_DETECTION
Even if a driver provides separate card detection, an interrupt is still needed to abort mmc requests that are in progress. SDHCI_QUIRK2_OWN_CARD_DETECTION prevents that, so remove it. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Signed-off-by: Chris Ball <cjb@laptop.org>
1 parent c5e027a commit e2a0a58

File tree

3 files changed

+0
-4
lines changed

3 files changed

+0
-4
lines changed

drivers/mmc/host/sdhci-pci.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,6 @@ static void sdhci_pci_add_own_cd(struct sdhci_pci_slot *slot)
212212

213213
slot->cd_gpio = gpio;
214214
slot->cd_irq = irq;
215-
slot->host->quirks2 |= SDHCI_QUIRK2_OWN_CARD_DETECTION;
216215

217216
return;
218217

drivers/mmc/host/sdhci.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,6 @@ static void sdhci_set_card_detection(struct sdhci_host *host, bool enable)
147147
u32 present, irqs;
148148

149149
if ((host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION) ||
150-
(host->quirks2 & SDHCI_QUIRK2_OWN_CARD_DETECTION) ||
151150
!mmc_card_is_removable(host->mmc))
152151
return;
153152

include/linux/mmc/sdhci.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,6 @@ struct sdhci_host {
9090

9191
unsigned int quirks2;/* More deviations from spec. */
9292

93-
#define SDHCI_QUIRK2_OWN_CARD_DETECTION(1<<0)
94-
9593
int irq;/* Device IRQ */
9694
void __iomem *ioaddr;/* Mapped address */
9795

0 commit comments

Comments
 (0)