Skip to content

Commit 43231b5

Browse files
committed
Merge commit '7185684' into omap-for-v3.10/timer
Conflicts: arch/arm/plat-omap/dmtimer.c Resolve merge conflict in omap_device.c as per Lothar Waßmann <LW@KARO-electronics.de>.
2 parents 1056124 + 7185684 commit 43231b5

File tree

17 files changed

+49
-58
lines changed

17 files changed

+49
-58
lines changed

arch/arm/kernel/entry-armv.S

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -562,21 +562,21 @@ ENDPROC(__und_usr)
562562
@ Fall-through from Thumb-2 __und_usr
563563
@
564564
#ifdef CONFIG_NEON
565+
get_thread_info r10@ get current thread
565566
adr r6, .LCneon_thumb_opcodes
566567
b 2f
567568
#endif
568569
call_fpe:
570+
get_thread_info r10@ get current thread
569571
#ifdef CONFIG_NEON
570572
adr r6, .LCneon_arm_opcodes
571-
2:
572-
ldr r7, [r6], #4@ mask value
573-
cmpr7, #0@ end mask?
574-
beq 1f
575-
andr8, r0, r7
573+
2: ldr r5, [r6], #4@ mask value
576574
ldr r7, [r6], #4@ opcode bits matching in mask
575+
cmpr5, #0@ end mask?
576+
beq 1f
577+
andr8, r0, r5
577578
cmpr8, r7 @ NEON instruction?
578579
bne 2b
579-
get_thread_info r10
580580
movr7, #1
581581
strb r7, [r10, #TI_USED_CP + 10]@ mark CP#10 as used
582582
strb r7, [r10, #TI_USED_CP + 11]@ mark CP#11 as used
@@ -586,7 +586,6 @@ call_fpe:
586586
tst r0, #0x08000000@ only CDP/CPRT/LDC/STC have bit 27
587587
tstne r0, #0x04000000@ bit 26 set on both ARM and Thumb-2
588588
moveq pc, lr
589-
get_thread_info r10@ get current thread
590589
andr8, r0, #0x00000f00@ mask out CP number
591590
THUMB( lsrr8, r8, #8)
592591
movr7, #1

arch/arm/kernel/process.c

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -459,15 +459,16 @@ unsigned long arch_randomize_brk(struct mm_struct *mm)
459459
* atomic helpers and the signal restart code. Insert it into the
460460
* gate_vma so that it is visible through ptrace and /proc/<pid>/mem.
461461
*/
462-
static struct vm_area_struct gate_vma;
462+
static struct vm_area_struct gate_vma = {
463+
.vm_start= 0xffff0000,
464+
.vm_end= 0xffff0000 + PAGE_SIZE,
465+
.vm_flags= VM_READ | VM_EXEC | VM_MAYREAD | VM_MAYEXEC,
466+
.vm_mm= &init_mm,
467+
};
463468

464469
static int __init gate_vma_init(void)
465470
{
466-
gate_vma.vm_start= 0xffff0000;
467-
gate_vma.vm_end= 0xffff0000 + PAGE_SIZE;
468-
gate_vma.vm_page_prot= PAGE_READONLY_EXEC;
469-
gate_vma.vm_flags= VM_READ | VM_EXEC |
470-
VM_MAYREAD | VM_MAYEXEC;
471+
gate_vma.vm_page_prot = PAGE_READONLY_EXEC;
471472
return 0;
472473
}
473474
arch_initcall(gate_vma_init);

arch/arm/mach-integrator/integrator_ap.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -536,16 +536,14 @@ static void __init ap_init_of(void)
536536
'A' + (ap_sc_id & 0x0f));
537537

538538
soc_dev = soc_device_register(soc_dev_attr);
539-
if (IS_ERR_OR_NULL(soc_dev)) {
539+
if (IS_ERR(soc_dev)) {
540540
kfree(soc_dev_attr->revision);
541541
kfree(soc_dev_attr);
542542
return;
543543
}
544544

545545
parent = soc_device_to_device(soc_dev);
546-
547-
if (!IS_ERR_OR_NULL(parent))
548-
integrator_init_sysfs(parent, ap_sc_id);
546+
integrator_init_sysfs(parent, ap_sc_id);
549547

550548
of_platform_populate(root, of_default_bus_match_table,
551549
ap_auxdata_lookup, parent);

arch/arm/mach-integrator/integrator_cp.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -360,17 +360,14 @@ static void __init intcp_init_of(void)
360360
'A' + (intcp_sc_id & 0x0f));
361361

362362
soc_dev = soc_device_register(soc_dev_attr);
363-
if (IS_ERR_OR_NULL(soc_dev)) {
363+
if (IS_ERR(soc_dev)) {
364364
kfree(soc_dev_attr->revision);
365365
kfree(soc_dev_attr);
366366
return;
367367
}
368368

369369
parent = soc_device_to_device(soc_dev);
370-
371-
if (!IS_ERR_OR_NULL(parent))
372-
integrator_init_sysfs(parent, intcp_sc_id);
373-
370+
integrator_init_sysfs(parent, intcp_sc_id);
374371
of_platform_populate(root, of_default_bus_match_table,
375372
intcp_auxdata_lookup, parent);
376373
}

arch/arm/mach-omap2/board-omap3beagle.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ static int __init beagle_opp_init(void)
479479

480480
/* Initialize the omap3 opp table if not already created. */
481481
r = omap3_opp_init();
482-
if (IS_ERR_VALUE(r) && (r != -EEXIST)) {
482+
if (r < 0 && (r != -EEXIST)) {
483483
pr_err("%s: opp default init failed\n", __func__);
484484
return r;
485485
}

arch/arm/mach-omap2/clock.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ int __init omap2_clk_switch_mpurate_at_boot(const char *mpurate_ck_name)
596596
return -ENOENT;
597597

598598
r = clk_set_rate(mpurate_ck, mpurate);
599-
if (IS_ERR_VALUE(r)) {
599+
if (r < 0) {
600600
WARN(1, "clock: %s: unable to set MPU rate to %d: %d\n",
601601
mpurate_ck_name, mpurate, r);
602602
clk_put(mpurate_ck);

arch/arm/mach-omap2/gpmc-onenand.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ static int omap2_onenand_setup_async(void __iomem *onenand_base)
303303
t = omap2_onenand_calc_async_timings();
304304

305305
ret = gpmc_set_async_mode(gpmc_onenand_data->cs, &t);
306-
if (IS_ERR_VALUE(ret))
306+
if (ret < 0)
307307
return ret;
308308

309309
omap2_onenand_set_async_mode(onenand_base);
@@ -325,7 +325,7 @@ static int omap2_onenand_setup_sync(void __iomem *onenand_base, int *freq_ptr)
325325
t = omap2_onenand_calc_sync_timings(gpmc_onenand_data, freq);
326326

327327
ret = gpmc_set_sync_mode(gpmc_onenand_data->cs, &t);
328-
if (IS_ERR_VALUE(ret))
328+
if (ret < 0)
329329
return ret;
330330

331331
set_onenand_cfg(onenand_base);

arch/arm/mach-omap2/gpmc.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -716,7 +716,7 @@ static int gpmc_setup_irq(void)
716716
return -EINVAL;
717717

718718
gpmc_irq_start = irq_alloc_descs(-1, 0, GPMC_NR_IRQ, 0);
719-
if (IS_ERR_VALUE(gpmc_irq_start)) {
719+
if (gpmc_irq_start < 0) {
720720
pr_err("irq_alloc_descs failed\n");
721721
return gpmc_irq_start;
722722
}
@@ -801,7 +801,7 @@ static int gpmc_mem_init(void)
801801
continue;
802802
gpmc_cs_get_memconf(cs, &base, &size);
803803
rc = gpmc_cs_insert_mem(cs, base, size);
804-
if (IS_ERR_VALUE(rc)) {
804+
if (rc < 0) {
805805
while (--cs >= 0)
806806
if (gpmc_cs_mem_enabled(cs))
807807
gpmc_cs_delete_mem(cs);
@@ -1370,14 +1370,14 @@ static int gpmc_probe(struct platform_device *pdev)
13701370
GPMC_REVISION_MINOR(l));
13711371

13721372
rc = gpmc_mem_init();
1373-
if (IS_ERR_VALUE(rc)) {
1373+
if (rc < 0) {
13741374
clk_disable_unprepare(gpmc_l3_clk);
13751375
clk_put(gpmc_l3_clk);
13761376
dev_err(gpmc_dev, "failed to reserve memory\n");
13771377
return rc;
13781378
}
13791379

1380-
if (IS_ERR_VALUE(gpmc_setup_irq()))
1380+
if (gpmc_setup_irq() < 0)
13811381
dev_warn(gpmc_dev, "gpmc_setup_irq failed\n");
13821382

13831383
/* Now the GPMC is initialised, unreserve the chip-selects */

arch/arm/mach-omap2/omap_device.c

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ static int omap_device_build_from_dt(struct platform_device *pdev)
131131
int oh_cnt, i, ret = 0;
132132

133133
oh_cnt = of_property_count_strings(node, "ti,hwmods");
134-
if (!oh_cnt || IS_ERR_VALUE(oh_cnt)) {
134+
if (oh_cnt <= 0) {
135135
dev_dbg(&pdev->dev, "No 'hwmods' to build omap_device\n");
136136
return -ENODEV;
137137
}
@@ -815,20 +815,17 @@ struct device *omap_device_get_by_hwmod_name(const char *oh_name)
815815
}
816816

817817
oh = omap_hwmod_lookup(oh_name);
818-
if (IS_ERR_OR_NULL(oh)) {
818+
if (!oh) {
819819
WARN(1, "%s: no hwmod for %s\n", __func__,
820820
oh_name);
821-
return ERR_PTR(oh ? PTR_ERR(oh) : -ENODEV);
821+
return ERR_PTR(-ENODEV);
822822
}
823-
if (IS_ERR_OR_NULL(oh->od)) {
823+
if (!oh->od) {
824824
WARN(1, "%s: no omap_device for %s\n", __func__,
825825
oh_name);
826-
return ERR_PTR(oh->od ? PTR_ERR(oh->od) : -ENODEV);
826+
return ERR_PTR(-ENODEV);
827827
}
828828

829-
if (IS_ERR_OR_NULL(oh->od->pdev))
830-
return ERR_PTR(oh->od->pdev ? PTR_ERR(oh->od->pdev) : -ENODEV);
831-
832829
return &oh->od->pdev->dev;
833830
}
834831

arch/arm/mach-omap2/omap_hwmod.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1659,7 +1659,7 @@ static int _deassert_hardreset(struct omap_hwmod *oh, const char *name)
16591659
return -ENOSYS;
16601660

16611661
ret = _lookup_hardreset(oh, name, &ohri);
1662-
if (IS_ERR_VALUE(ret))
1662+
if (ret < 0)
16631663
return ret;
16641664

16651665
if (oh->clkdm) {
@@ -2409,7 +2409,7 @@ static int __init _init(struct omap_hwmod *oh, void *data)
24092409
_init_mpu_rt_base(oh, NULL);
24102410

24112411
r = _init_clocks(oh, NULL);
2412-
if (IS_ERR_VALUE(r)) {
2412+
if (r < 0) {
24132413
WARN(1, "omap_hwmod: %s: couldn't init clocks\n", oh->name);
24142414
return -EINVAL;
24152415
}

0 commit comments

Comments
 (0)