Skip to content

Commit 3f6fa3d

Browse files
Jaganath KanakkasseryGustavo Padovan
authored andcommitted
Bluetooth: Fix invalid length check in l2cap_information_rsp()
The length check is invalid since the length varies with type of info response. This was introduced by the commit cb3b315 Because of this, l2cap info rsp is not handled and command reject is sent. > ACL data: handle 11 flags 0x02 dlen 16 L2CAP(s): Info rsp: type 2 result 0 Extended feature mask 0x00b8 Enhanced Retransmission mode Streaming mode FCS Option Fixed Channels < ACL data: handle 11 flags 0x00 dlen 10 L2CAP(s): Command rej: reason 0 Command not understood Cc: stable@vger.kernel.org Signed-off-by: Jaganath Kanakkassery <jaganath.k@samsung.com> Signed-off-by: Chan-Yeol Park <chanyeol.park@samsung.com> Acked-by: Johan Hedberg <johan.hedberg@intel.com> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
1 parent fcb3701 commit 3f6fa3d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/bluetooth/l2cap_core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4333,7 +4333,7 @@ static inline int l2cap_information_rsp(struct l2cap_conn *conn,
43334333
struct l2cap_info_rsp *rsp = (struct l2cap_info_rsp *) data;
43344334
u16 type, result;
43354335

4336-
if (cmd_len != sizeof(*rsp))
4336+
if (cmd_len < sizeof(*rsp))
43374337
return -EPROTO;
43384338

43394339
type = __le16_to_cpu(rsp->type);

0 commit comments

Comments
 (0)