Skip to content

Commit 9b1ade1

Browse files
committed
feat: added sg description
1 parent 5a0cf3a commit 9b1ade1

File tree

5 files changed

+26
-12
lines changed

5 files changed

+26
-12
lines changed

_example/memcached/example.tf

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,11 @@ module "memcached" {
7474
####----------------------------------------------------------------------------------
7575
## will create ROUTE-53 for redis which will add the dns of the cluster.
7676
####----------------------------------------------------------------------------------
77-
dns_record_name = "prod"
78-
route53_ttl = "300"
79-
route53_type = "CNAME"
80-
route53_zone_id = "FTOFGXXXXDFDFF"
77+
route53_record_enabled = false
78+
ssm_parameter_endpoint_enabled = false
79+
dns_record_name = "prod"
80+
route53_ttl = "300"
81+
route53_type = "CNAME"
82+
route53_zone_id = "SERFxxxx6XCsY9Lxxxxx"
8183

8284
}

_example/redis-cluster/example.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ module "redis-cluster" {
7575
####----------------------------------------------------------------------------------
7676
## will create ROUTE-53 for redis which will add the dns of the cluster.
7777
####----------------------------------------------------------------------------------
78-
ssm_parameter_endpoint_enabled = true
79-
route53_record_enabled = true
78+
route53_record_enabled = false
79+
ssm_parameter_endpoint_enabled = false
8080
dns_record_name = "prod"
8181
route53_ttl = "300"
8282
route53_type = "CNAME"
83-
route53_zone_id = "Z0xxxx16XCxxxxxxx4"
83+
route53_zone_id = "SERFxxxx6XCsY9Lxxxxx"
8484
}

_example/redis/example.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ module "redis" {
9191
####----------------------------------------------------------------------------------
9292
## will create ROUTE-53 for redis which will add the dns of the cluster.
9393
####----------------------------------------------------------------------------------
94-
route53_record_enabled = true
95-
ssm_parameter_endpoint_enabled = true
94+
route53_record_enabled = false
95+
ssm_parameter_endpoint_enabled = false
9696
dns_record_name = "prod"
9797
route53_ttl = "300"
9898
route53_type = "CNAME"

main.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ data "aws_security_group" "existing" {
4242
resource "aws_security_group_rule" "egress" {
4343
count = (var.enable_security_group == true && length(var.sg_ids) < 1 && var.is_external == false && var.egress_rule == true) ? 1 : 0
4444

45-
description = var.sg_egress_description
45+
description = var.sg_egress_description
4646
type = "egress"
4747
from_port = 0
4848
to_port = 65535
@@ -54,7 +54,7 @@ resource "aws_security_group_rule" "egress" {
5454
resource "aws_security_group_rule" "egress_ipv6" {
5555
count = (var.enable_security_group == true && length(var.sg_ids) < 1 && var.is_external == false) && var.egress_rule == true ? 1 : 0
5656

57-
description = var.sg_egress_description
57+
description = var.sg_egress_ipv6_description
5858
type = "egress"
5959
from_port = 0
6060
to_port = 65535
@@ -65,7 +65,7 @@ resource "aws_security_group_rule" "egress_ipv6" {
6565
resource "aws_security_group_rule" "ingress" {
6666
count = length(var.allowed_ip) > 0 == true && length(var.sg_ids) < 1 ? length(compact(var.allowed_ports)) : 0
6767

68-
description = var.sg_egress_description
68+
description = var.sg_ingress_description
6969
type = "ingress"
7070
from_port = element(var.allowed_ports, count.index)
7171
to_port = element(var.allowed_ports, count.index)

variables.tf

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -381,6 +381,18 @@ variable "sg_egress_description" {
381381
description = "Description of the egress and ingress rule"
382382
}
383383

384+
variable "sg_egress_ipv6_description" {
385+
type = string
386+
default = "Description of the rule."
387+
description = "Description of the egress_ipv6 rule"
388+
}
389+
390+
variable "sg_ingress_description" {
391+
type = string
392+
default = "Description of the ingress rule use elasticache."
393+
description = "Description of the ingress rule"
394+
}
395+
384396
##---------------------route53------------------------
385397
variable "route53_record_enabled" {
386398
type = bool

0 commit comments

Comments
 (0)