Skip to content

Commit 476d172

Browse files
committed
Add default return value for CURLINFO_CERTINFO
1 parent 41f5321 commit 476d172

File tree

2 files changed

+22
-0
lines changed

2 files changed

+22
-0
lines changed

src/VCR/Util/CurlHelper.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,10 @@ public static function getCurlOptionFromResponse(Response $response, $option = 0
111111
case CURLINFO_HEADER_SIZE:
112112
$info = mb_strlen(HttpUtil::formatAsStatusWithHeadersString($response), 'ISO-8859-1');
113113
break;
114+
case CURLINFO_CERTINFO:
115+
$curlInfo = $response->getCurlInfo($option);
116+
$info = (!is_null($curlInfo)) ? $curlInfo : [];
117+
break;
114118
default:
115119
$info = $response->getCurlInfo($option);
116120
break;

tests/VCR/Util/CurlHelperTest.php

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,24 @@ public function testHandleResponseWritesFile()
294294
$this->assertEquals($expectedBody, file_get_contents($testFile));
295295
}
296296

297+
public function testGetCurlOptionFromResponseHandleCertinfo()
298+
{
299+
$status = array(
300+
'code' => 200,
301+
'message' => 'OK',
302+
'http_version' => '1.1',
303+
);
304+
$headers = array(
305+
'Content-Length' => 0,
306+
);
307+
$response = new Response($status, $headers, 'example response');
308+
309+
$this->assertEquals(
310+
[],
311+
CurlHelper::getCurlOptionFromResponse($response, CURLINFO_CERTINFO)
312+
);
313+
}
314+
297315
/**
298316
* @dataProvider getCurlOptionProvider()
299317
*

0 commit comments

Comments
 (0)