Allow for startup to proceed even if status subresource is missing

We have a guard to only allow a cluster to be started up if we know that it is in a shut down state. However, there appears to be cases independentof the Operator where the pgclusters.crunchydata.com "status" subresource is missing, which would cause that guard to be too aggressive. This change allows for the condition that there is no state registered in the status subresource, which allows for the start up to proceed regardless. Issue: [ch10811]

Author: jkatz

internal/controller/pgcluster/pgclustercontroller.go

@@ -191,11 +191,21 @@ func (c *Controller) onUpdate(oldObj, newObj interface{}) {
 // if the 'shutdown' parameter in the pgcluster update shows that the cluster should be either
 // shutdown or started but its current status does not properly reflect that it is, then
 // proceed with the logic needed to either shutdown or start the cluster
+//
+// we do need to check if the status has info in it. There have been cases
+// where the entire status has been removed that could be external to the
+// operator itself. In the case of checking that the state is in a shutdown
+// phase, we also want to check if the status is completely empty. If it is,
+// we will proceed with the shutdown.
 if newcluster.Spec.Shutdown && newcluster.Status.State != crv1.PgclusterStateShutdown {
-_ = clusteroperator.ShutdownCluster(c.Client, *newcluster)
+if err := clusteroperator.ShutdownCluster(c.Client, *newcluster); err != nil {
+log.Error(err)
+}
 } else if !newcluster.Spec.Shutdown &&
-newcluster.Status.State == crv1.PgclusterStateShutdown {
-_ = clusteroperator.StartupCluster(c.Client, *newcluster)
+(newcluster.Status.State == crv1.PgclusterStateShutdown || newcluster.Status.State == "") {
+if err := clusteroperator.StartupCluster(c.Client, *newcluster); err != nil {
+log.Error(err)
+}
 }
 
 // check to see if autofail setting has been changed. If set to "true", it