Skip to content

Commit d66323a

Browse files
committed
added deprecation messages instructions to RELEASE_CHECK_LIST.md and updated the file with regions and hints to when a feature will be removed
1 parent 5488a34 commit d66323a

File tree

2 files changed

+25
-4
lines changed

2 files changed

+25
-4
lines changed

RELEASE_CHECK_LIST.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,3 +29,8 @@
2929
17. Create Release from the release tag on GitHub
3030
18. Update a KDF version in the [Kotlin Jupyter Descriptor](https://github.com/Kotlin/kotlin-jupyter-libraries/blob/master/dataframe.json). Now the Renovate bot doing this
3131
19. Update DataFrame version in gradle.properties file for next release cycle (i.e. 0.10.0 -> 0.11.0)
32+
20. Update deprecated functions in [deprecationMessages.kt](/core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/util/deprecationMessages.kt)
33+
such that
34+
- `Level.WARNING` messages are changed to `Level.ERROR`
35+
- `Level.ERROR` messages and their functions are removed.
36+
- Update regions in the file accordingly.
Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,29 @@
11
package org.jetbrains.kotlinx.dataframe.util
22

3-
internal const val DF_READ_DEPRECATION_MESSAGE = "Replaced with `unfold` operation."
3+
/*
4+
* This file contains deprecation messages for the whole core module.
5+
* After each release, all messages should be reviewed and updated.
6+
* Level.WARNING -> Level.ERROR
7+
* Level.ERROR -> Remove
8+
*/
49

10+
// region WARNING in 0.10.0, ERROR in 0.11.0
11+
12+
internal const val DF_READ_DEPRECATION_MESSAGE = "Replaced with `unfold` operation. Removed in 0.11.0."
513
internal const val DF_READ_REPLACE_MESSAGE = "this.unfold(*columns)"
614

7-
internal const val ITERABLE_COLUMNS_DEPRECATION_MESSAGE = "Replaced with `toColumnSet()` operation."
15+
internal const val ITERABLE_COLUMNS_DEPRECATION_MESSAGE = "Replaced with `toColumnSet()` operation. Removed in 0.11.0."
816

9-
internal const val DIFF_DEPRECATION_MESSAGE = "Replaced to explicitly indicate nullable return value; added a new non-null overload."
17+
// endregion
1018

11-
internal const val DIFF_REPLACE_MESSAGE = "this.diffOrNull(expression)"
19+
// region WARNING in 0.11.0, ERROR in 0.12.0
1220

21+
internal const val DIFF_DEPRECATION_MESSAGE = "Replaced to explicitly indicate nullable return value; added a new non-null overload. Will be removed in 0.12.0."
22+
internal const val DIFF_REPLACE_MESSAGE = "this.diffOrNull(expression)"
1323
internal const val DIFF_OR_NULL_IMPORT = "org.jetbrains.kotlinx.dataframe.api.diffOrNull"
24+
25+
// endregion
26+
27+
// region WARNING in 0.12.0, ERROR in 0.13.0
28+
29+
// endregion

0 commit comments

Comments
 (0)