Skip to content

Commit 507a74d

Browse files
remove multi-whitelist method
1 parent 02f3f55 commit 507a74d

File tree

3 files changed

+1
-53
lines changed

3 files changed

+1
-53
lines changed

contracts/network/BancorNetwork.sol

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -925,21 +925,6 @@ contract BancorNetwork is IBancorNetwork, Upgradeable, ReentrancyGuardUpgradeabl
925925
_addToWhitelist(addr);
926926
}
927927

928-
/**
929-
* @dev adds multiple addresses to the fee exemption whitelist
930-
*
931-
* requirements:
932-
*
933-
* - the caller must be the admin of the contract
934-
*/
935-
function addAddressesToWhitelist(address[] calldata addrs) external onlyAdmin {
936-
uint256 length = addrs.length;
937-
938-
for (uint256 i = 0; i < length; ++i) {
939-
_addToWhitelist(addrs[i]);
940-
}
941-
}
942-
943928
/**
944929
* @dev removes an address from the fee exemption whitelist
945930
*

hardhat.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ const config: HardhatUserConfig = {
124124
settings: {
125125
optimizer: {
126126
enabled: true,
127-
runs: 180
127+
runs: 200
128128
},
129129
metadata: {
130130
bytecodeHash: 'none'

test/network/BancorNetwork.ts

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -3378,43 +3378,6 @@ describe('BancorNetwork', () => {
33783378
expect(await network.isWhitelisted(user1.address)).to.be.true;
33793379
expect(await network.feeExemptionWhitelist()).to.include(user1.address);
33803380
});
3381-
3382-
it('should revert when a non-admin attempts to add addresses', async () => {
3383-
await expect(
3384-
network.connect(nonOwner).addAddressesToWhitelist([user1.address])
3385-
).to.be.revertedWithError('AccessDenied');
3386-
});
3387-
3388-
it('should revert when adding invalid addresses', async () => {
3389-
await expect(network.addAddressesToWhitelist([ZERO_ADDRESS])).to.be.revertedWithError(
3390-
'InvalidExternalAddress'
3391-
);
3392-
});
3393-
3394-
it('should revert when adding already whitelisted addresses in the same transaction', async () => {
3395-
await expect(network.addAddressesToWhitelist([user1.address, user1.address])).to.be.revertedWithError(
3396-
'AlreadyExists'
3397-
);
3398-
});
3399-
3400-
it('should revert when adding already whitelisted addresses in different transactions', async () => {
3401-
await network.addAddressesToWhitelist([user1.address]);
3402-
await expect(network.addAddressesToWhitelist([user1.address])).to.be.revertedWithError('AlreadyExists');
3403-
});
3404-
3405-
it('should whitelist addresses', async () => {
3406-
expect(await network.isWhitelisted(user1.address)).to.be.false;
3407-
expect(await network.isWhitelisted(user2.address)).to.be.false;
3408-
expect(await network.feeExemptionWhitelist()).not.to.have.members([user1.address, user2.address]);
3409-
3410-
const res = await network.addAddressesToWhitelist([user1.address, user2.address]);
3411-
await expect(res).to.emit(network, 'AddressAddedToWhitelist').withArgs(user1.address);
3412-
await expect(res).to.emit(network, 'AddressAddedToWhitelist').withArgs(user2.address);
3413-
3414-
expect(await network.isWhitelisted(user1.address)).to.be.true;
3415-
expect(await network.isWhitelisted(user2.address)).to.be.true;
3416-
expect(await network.feeExemptionWhitelist()).to.have.members([user1.address, user2.address]);
3417-
});
34183381
});
34193382

34203383
describe('removing', () => {

0 commit comments

Comments
 (0)