build fails because of null conversion error #3033
Description
Describe the bug
When building the sdk using the steps in this tutorial, the build fails on the step Building CXX object src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/ub_core.cpp.o.
Expected Behavior
Expected behavior would be to make without error.
Current Behavior
Here's the trace:
In file included from /home/annaprins/sdk_build/src/aws-cpp-sdk-core/ub_core.cpp:26: /home/annaprins/aws-sdk-cpp/src/aws-cpp-sdk-core/source/client/RequestCompression.cpp: In member function ‘iostream_outcome Aws::Client::RequestCompression::compress(std::shared_ptr<std::basic_iostream<char> >, const Aws::Client::CompressionAlgorithm&) const’: /home/annaprins/aws-sdk-cpp/src/aws-cpp-sdk-core/source/client/RequestCompression.cpp:102:19: error: converting to non-pointer type ‘int’ from NULL [-Werror=conversion-null] 102 | int ret = Z_NULL; | ^~~~~~ /home/annaprins/aws-sdk-cpp/src/aws-cpp-sdk-core/source/client/RequestCompression.cpp: In member function ‘Aws::Utils::Outcome<std::shared_ptr<std::basic_iostream<char> >, bool> Aws::Client::RequestCompression::uncompress(std::shared_ptr<std::basic_iostream<char> >, const Aws::Client::CompressionAlgorithm&) const’: /home/annaprins/aws-sdk-cpp/src/aws-cpp-sdk-core/source/client/RequestCompression.cpp:221:19: error: converting to non-pointer type ‘int’ from NULL [-Werror=conversion-null] 221 | int ret = Z_NULL; | ^~~~~~ cc1plus: all warnings being treated as errors make[2]: *** [src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/build.make:977: src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/ub_core.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:987: src/aws-cpp-sdk-core/CMakeFiles/aws-cpp-sdk-core.dir/all] Error 2 make: *** [Makefile:156: all] Error 2 Reproduction Steps
I used this line to cmake:
cmake ../aws-sdk-cpp -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH=/usr/local/ -DCMAKE_INSTALL_PREFIX=/usr/local/ -DBUILD_ONLY="logs"
and then it failed on make
I tried both Debug and Release build types. I don't know why I thought that would change anything, but I thought it was worth a shot.. It fails the same way with both.
Possible Solution
No response
Additional Information/Context
No response
AWS CPP SDK version used
latest
Compiler and Version used
gcc 14.1.1
Operating System and version
Fedora 40