Modified Sniffer to check dockblocks and inline structures #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Check for the class dockblocks * Check for function dockblocks * Allow inline conditional structures, like if (true) return;
| @@ -1,12 +1,12 @@ | |||
| { | |||
| "name": "pragmarx/laravelcs", | |||
| "name": "lukzgois/laravelcs", | |||
Owner
There was a problem hiding this comment.
But why are you changing the name of the package?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I wrote this to check if the class and functions docblocks are present. I used the PEAR check with some modifications (no requirements of tags, just the dockblock). I also allowed inline control structures, because on certain cases it be useful.