Level 2

Author: JeroenVanOort

phpstan.neon

@@ -18,6 +18,8 @@ parameters:
  - '/Parameter #2 \$eventName of method Symfony\\Contracts\\EventDispatcher\\EventDispatcherInterface::dispatch\(\) expects string\|null, VCR\\Event\\Event given./'
  # PHPStan cannot deal with manually defined constants - can be removed once php 7.2 no longer supported
  - '#Constant CURLPROXY_HTTPS not found.#'
+ - '#Call to an undefined method (VCR\\Util\\|)SoapClient::GetCityWeatherByZIP\(\)\.#'
+ - '#Call to an undefined method org\\bovigo\\vfs\\vfsStreamContent::hasChild\(\)\.#'
 includes:
  - vendor/thecodingmachine/phpstan-strict-rules/phpstan-strict-rules.neon
  - vendor/phpstan/phpstan-beberlei-assert/extension.neon

tests/VCR/LibraryHooks/SoapHookTest.php

@@ -34,6 +34,7 @@ public function testShouldInterceptCallWhenEnabled(): void
  {
  $this->soapHook->enable($this->getContentCheckCallback());
 
+ /** @var \VCR\Util\SoapClient $client */
  $client = new \SoapClient(self::WSDL, ['soap_version' => \SOAP_1_2]);
  $client->setLibraryHook($this->soapHook);
  $actual = $client->GetCityWeatherByZIP(['ZIP' => '10013']);
@@ -51,6 +52,7 @@ public function testShouldHandleSOAPVersion11(): void
  ];
  $this->soapHook->enable($this->getHeadersCheckCallback($expectedHeaders));
 
+ /** @var \VCR\Util\SoapClient $client */
  $client = new \SoapClient(
  self::WSDL,
  ['soap_version' => \SOAP_1_1]
@@ -67,6 +69,7 @@ public function testShouldHandleSOAPVersion12(): void
 
  $this->soapHook->enable($this->getHeadersCheckCallback($expectedHeaders));
 
+ /** @var \VCR\Util\SoapClient $client */
  $client = new \SoapClient(
  self::WSDL,
  ['soap_version' => \SOAP_1_2]
@@ -79,6 +82,7 @@ public function testShouldReturnLastRequestWithTraceOn(): void
  {
  $this->soapHook->enable($this->getContentCheckCallback());
 
+ /** @var \VCR\Util\SoapClient $client */
  $client = new \SoapClient(
  self::WSDL,
  ['soap_version' => \SOAP_1_1, 'trace' => 1]

tests/VCR/Util/CurlHelperTest.php

@@ -213,7 +213,7 @@ public function testHandleResponseReturnsBody(): void
 
  $output = CurlHelper::handleOutput($response, $curlOptions, curl_init());
 
- $this->assertEquals($response->getBody(true), $output);
+ $this->assertEquals($response->getBody(), $output);
  }
 
  public function testHandleResponseEchosBody(): void
@@ -224,7 +224,7 @@ public function testHandleResponseEchosBody(): void
  CurlHelper::handleOutput($response, [], curl_init());
  $output = ob_get_clean();
 
- $this->assertEquals($response->getBody(true), $output);
+ $this->assertEquals($response->getBody(), $output);
  }
 
  public function testHandleResponseIncludesHeader(): void

tests/VCR/Util/StreamHelperTest.php

@@ -74,8 +74,8 @@ function (Request $request) use ($test): void {
  /**
  * @dataProvider streamContexts
  *
- * @param $context
- * @param $testCallback
+ * @param array $context
+ * @param callable $testCallback
  */
  public function testStreamHttpContext($context, $testCallback): void
  {