Level 5

Author: JeroenVanOort

src/VCR/Request.php

@@ -40,7 +40,7 @@ class Request
  protected $curlOptions = [];
 
  /**
- * @param array<string,string> $headers
+ * @param array<string,string|null> $headers
  */
  public function __construct(string $method, ?string $url, array $headers = [])
  {

src/VCR/Storage/Storage.php

@@ -15,7 +15,7 @@ interface Storage extends \Iterator
  /**
  * Stores an array of data.
  *
- * @param array<string,array<string,mixed>> $recording array to store in storage
+ * @param array<string,string|null|array<string,mixed>> $recording array to store in storage
  */
  public function storeRecording(array $recording): void;
 

tests/VCR/CassetteTest.php

@@ -29,8 +29,8 @@ public function testGetName(): void
  public function testDontOverwriteRecord(): void
  {
  $request = new Request('GET', 'https://example.com');
- $response1 = new Response(200, [], 'sometest');
- $response2 = new Response(200, [], 'sometest');
+ $response1 = new Response('200', [], 'sometest');
+ $response2 = new Response('200', [], 'sometest');
  $this->cassette->record($request, $response1);
  $this->cassette->record($request, $response2);
 
@@ -40,7 +40,7 @@ public function testDontOverwriteRecord(): void
  public function testPlaybackAlreadyRecordedRequest(): void
  {
  $request = new Request('GET', 'https://example.com');
- $response = new Response(200, [], 'sometest');
+ $response = new Response('200', [], 'sometest');
  $this->cassette->record($request, $response);
 
  $this->assertEquals($response->toArray(), $this->cassette->playback($request)->toArray());
@@ -56,7 +56,7 @@ public function testHasResponseNotFound(): void
  public function testHasResponseFound(): void
  {
  $request = new Request('GET', 'https://example.com');
- $response = new Response(200, [], 'sometest');
+ $response = new Response('200', [], 'sometest');
  $this->cassette->record($request, $response);
 
  $this->assertTrue($this->cassette->hasResponse($request), 'Expected true if request was found.');

tests/VCR/Event/AfterHttpRequestEventTest.php

@@ -15,7 +15,7 @@ class AfterHttpRequestEventTest extends TestCase
 
  protected function setUp(): void
  {
- $this->event = new AfterHttpRequestEvent(new Request('GET', 'http://example.com'), new Response(200));
+ $this->event = new AfterHttpRequestEvent(new Request('GET', 'http://example.com'), new Response('200'));
  }
 
  public function testGetRequest(): void

tests/VCR/Event/AfterPlaybackEventTest.php

@@ -20,7 +20,7 @@ protected function setUp(): void
  {
  $this->event = new AfterPlaybackEvent(
  new Request('GET', 'http://example.com'),
- new Response(200),
+ new Response('200'),
  new Cassette('test', new Configuration(), new Storage\Blackhole())
  );
  }

tests/VCR/Event/BeforeRecordEventTest.php

@@ -20,7 +20,7 @@ protected function setUp(): void
  {
  $this->event = new BeforeRecordEvent(
  new Request('GET', 'http://example.com'),
- new Response(200),
+ new Response('200'),
  new Cassette('test', new Configuration(), new Storage\Blackhole())
  );
  }

tests/VCR/LibraryHooks/CurlHookTest.php

@@ -133,7 +133,7 @@ function (Request $request) use ($testClass) {
  'Post query string was not parsed and set correctly.'
  );
 
- return new Response(200);
+ return new Response('200');
  }
  );
 
@@ -155,7 +155,7 @@ function (Request $request) use ($testClass) {
  'Post query string was not parsed and set correctly.'
  );
 
- return new Response(200);
+ return new Response('200');
  }
  );
 
@@ -287,7 +287,7 @@ function (Request $request) use ($testClass, &$callCount) {
  );
  ++$callCount;
 
- return new Response(200);
+ return new Response('200');
  }
  );
 
@@ -299,11 +299,11 @@ function (Request $request) use ($testClass, &$callCount) {
  curl_multi_add_handle($curlMultiHandle, $curlHandle2);
 
  $stillRunning = null;
- $mh = curl_multi_exec($curlMultiHandle, $stillRunning);
+ curl_multi_exec($curlMultiHandle, $stillRunning);
 
- $lastInfo = curl_multi_info_read($mh);
- $secondLastInfo = curl_multi_info_read($mh);
- $afterLastInfo = curl_multi_info_read($mh);
+ $lastInfo = curl_multi_info_read($curlMultiHandle);
+ $secondLastInfo = curl_multi_info_read($curlMultiHandle);
+ $afterLastInfo = curl_multi_info_read($curlMultiHandle);
 
  curl_multi_remove_handle($curlMultiHandle, $curlHandle1);
  curl_multi_remove_handle($curlMultiHandle, $curlHandle2);
@@ -364,7 +364,7 @@ function (Request $request) use ($testClass) {
  ''
  );
 
- return new Response(200);
+ return new Response('200');
  }
  );
 

tests/VCR/LibraryHooks/SoapHookTest.php

@@ -100,7 +100,7 @@ protected function getContentCheckCallback(): Closure
  $testClass = $this;
 
  return Closure::fromCallable(function () use ($testClass) {
- return new Response(200, [], $testClass->expected);
+ return new Response('200', [], $testClass->expected);
  });
  }
 
@@ -113,7 +113,7 @@ protected function getHeadersCheckCallback(array $expectedHeaders): Closure
  $test->assertEquals($expectedHeader, $request->getHeader($expectedHeaderName));
  }
 
- return new Response(200, [], '');
+ return new Response('200', [], '');
  });
  }
 }

tests/VCR/LibraryHooks/StreamWrapperHookTest.php

@@ -32,7 +32,7 @@ public function testSeek(): void
  {
  $hook = new StreamWrapperHook();
  $hook->enable(function ($request) {
- return new Response(200, [], 'A Test');
+ return new Response('200', [], 'A Test');
  });
  $hook->stream_open('http://example.com', 'r', 0, $openedPath);
 

tests/VCR/ResponseTest.php

@@ -35,7 +35,7 @@ public function testRestoreHeadersFromArray(): void
  'Connection' => 'close',
  'Date' => 'Fri, 31 Jan 2014 15:37:13 GMT',
  ];
- $response = new Response(200, $headers);
+ $response = new Response('200', $headers);
  $restoredResponse = Response::fromArray($response->toArray());
 
  $this->assertEquals($headers, $restoredResponse->getHeaders());
@@ -59,7 +59,7 @@ public function testGetBodyNoneDefined(): void
  public function testRestoreBodyFromArray(): void
  {
  $body = 'this is an example body';
- $response = new Response(200, [], $body);
+ $response = new Response('200', [], $body);
  $restoredResponse = Response::fromArray($response->toArray());
 
  $this->assertEquals($body, $restoredResponse->getBody());
@@ -68,7 +68,7 @@ public function testRestoreBodyFromArray(): void
  public function testBase64EncodeCompressedBody(): void
  {
  $body = 'this is an example body';
- $response = new Response(200, ['Content-Type' => 'application/x-gzip'], $body);
+ $response = new Response('200', ['Content-Type' => 'application/x-gzip'], $body);
  $responseArray = $response->toArray();
 
  $this->assertEquals(base64_encode($body), $responseArray['body']);
@@ -89,15 +89,15 @@ public function testBase64DecodeCompressedBody(): void
  public function testRestoreCompressedBody(): void
  {
  $body = 'this is an example body';
- $response = new Response(200, ['Content-Type' => 'application/x-gzip'], $body);
+ $response = new Response('200', ['Content-Type' => 'application/x-gzip'], $body);
  $restoredResponse = Response::fromArray($response->toArray());
 
  $this->assertEquals($body, $restoredResponse->getBody());
  }
 
  public function testGetStatus(): void
  {
- $expectedStatus = 200;
+ $expectedStatus = '200';
 
  $response = new Response($expectedStatus);
 
@@ -106,7 +106,7 @@ public function testGetStatus(): void
 
  public function testRestoreStatusFromArray(): void
  {
- $expectedStatus = 200;
+ $expectedStatus = '200';
 
  $response = new Response($expectedStatus);
  $restoredResponse = Response::fromArray($response->toArray());
@@ -117,15 +117,15 @@ public function testRestoreStatusFromArray(): void
  public function testGetCurlInfo(): void
  {
  $curlOptions = ['option' => 'value'];
- $response = new Response(200, [], null, $curlOptions);
+ $response = new Response('200', [], null, $curlOptions);
 
  $this->assertEquals($curlOptions, $response->getCurlInfo());
  }
 
  public function testRestoreCurlInfoFromArray(): void
  {
  $expectedCurlOptions = ['option' => 'value'];
- $response = new Response(200, [], null, $expectedCurlOptions);
+ $response = new Response('200', [], null, $expectedCurlOptions);
  $restoredResponse = Response::fromArray($response->toArray());
 
  $this->assertEquals($expectedCurlOptions, $response->getCurlInfo());