Type casting added to several ImapProtocol return values #261

Author: Webklex

CHANGELOG.md

@@ -6,7 +6,7 @@ Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) princip
 
 ## [UNRELEASED]
 ### Fixed
-- NaN
+- Type casting added to several ImapProtocol return values #261
 
 ### Added
 - NaN

src/Connection/Protocols/ImapProtocol.php

@@ -891,7 +891,7 @@ public function moveMessage(string $folder, $from, $to = null, $uid = IMAP::ST_U
  $set = $this->buildSet($from, $to);
  $command = $this->buildUIDCommand("MOVE", $uid);
 
- return $this->requestAndResponse($command, [$set, $this->escapeString($folder)], true);
+ return (bool)$this->requestAndResponse($command, [$set, $this->escapeString($folder)], true);
  }
 
  /**
@@ -943,7 +943,7 @@ public function ID($ids = null) {
  * @throws RuntimeException
  */
  public function createFolder(string $folder): bool {
- return $this->requestAndResponse('CREATE', [$this->escapeString($folder)], true);
+ return (bool)$this->requestAndResponse('CREATE', [$this->escapeString($folder)], true);
  }
 
  /**
@@ -955,7 +955,7 @@ public function createFolder(string $folder): bool {
  * @throws RuntimeException
  */
  public function renameFolder(string $old, string $new): bool {
- return $this->requestAndResponse('RENAME', $this->escapeString($old, $new), true);
+ return (bool)$this->requestAndResponse('RENAME', $this->escapeString($old, $new), true);
  }
 
  /**
@@ -966,7 +966,7 @@ public function renameFolder(string $old, string $new): bool {
  * @throws RuntimeException
  */
  public function deleteFolder(string $folder): bool {
- return $this->requestAndResponse('DELETE', [$this->escapeString($folder)], true);
+ return (bool)$this->requestAndResponse('DELETE', [$this->escapeString($folder)], true);
  }
 
  /**
@@ -977,7 +977,7 @@ public function deleteFolder(string $folder): bool {
  * @throws RuntimeException
  */
  public function subscribeFolder(string $folder): bool {
- return $this->requestAndResponse('SUBSCRIBE', [$this->escapeString($folder)], true);
+ return (bool)$this->requestAndResponse('SUBSCRIBE', [$this->escapeString($folder)], true);
  }
 
  /**
@@ -988,7 +988,7 @@ public function subscribeFolder(string $folder): bool {
  * @throws RuntimeException
  */
  public function unsubscribeFolder(string $folder): bool {
- return $this->requestAndResponse('UNSUBSCRIBE', [$this->escapeString($folder)], true);
+ return (bool)$this->requestAndResponse('UNSUBSCRIBE', [$this->escapeString($folder)], true);
  }
 
  /**
@@ -998,7 +998,7 @@ public function unsubscribeFolder(string $folder): bool {
  * @throws RuntimeException
  */
  public function expunge(): bool {
- return $this->requestAndResponse('EXPUNGE');
+ return (bool)$this->requestAndResponse('EXPUNGE');
  }
 
  /**
@@ -1008,7 +1008,7 @@ public function expunge(): bool {
  * @throws RuntimeException
  */
  public function noop(): bool {
- return $this->requestAndResponse('NOOP');
+ return (bool)$this->requestAndResponse('NOOP');
  }
 
  /**

src/Connection/Protocols/LegacyProtocol.php

@@ -412,7 +412,7 @@ public function copyMessage(string $folder, $from, $to = null, $uid = IMAP::ST_U
  */
  public function copyManyMessages(array $messages, string $folder, $uid = IMAP::ST_UID) {
  foreach($messages as $msg) {
- if ($this->copyMessage($folder, $msg, null, $uid) == false) {
+ if (!$this->copyMessage($folder, $msg, null, $uid)) {
  return false;
  }
  }
@@ -421,7 +421,7 @@ public function copyManyMessages(array $messages, string $folder, $uid = IMAP::S
  }
 
  /**
- * Move a message set from current folder to an other folder
+ * Move a message set from current folder to another folder
  * @param string $folder destination folder
  * @param $from
  * @param int|null $to if null only one message ($from) is fetched, else it's the
@@ -444,7 +444,7 @@ public function moveMessage(string $folder, $from, $to = null, $uid = IMAP::ST_U
  */
  public function moveManyMessages(array $messages, string $folder, $uid = IMAP::ST_UID) {
  foreach($messages as $msg) {
- if ($this->moveMessage($folder, $msg, null, $uid) == false) {
+ if (!$this->moveMessage($folder, $msg, null, $uid)) {
  return false;
  }
  }