fix tests (cloudposse#36)

* fix tests * rebuild pipeline * set TF_VAR_ * delete bad fixture setting * use GITHUB_TOKEN for testing

Author: osterman

README.md

@@ -42,7 +42,7 @@
 
 [![Cloud Posse][logo]](https://cpco.io/homepage)
 
-# terraform-aws-ecs-codepipeline [![Codefresh Build Status](https://g.codefresh.io/api/badges/pipeline/cloudposse/terraform-modules%2Fterraform-aws-ecs-codepipeline?type=cf-1)](https://g.codefresh.io/public/accounts/cloudposse/pipelines/5db7b474041f802a8893f018) [![Latest Release](https://img.shields.io/github/release/cloudposse/terraform-aws-ecs-codepipeline.svg)](https://github.com/cloudposse/terraform-aws-ecs-codepipeline/releases/latest) [![Slack Community](https://slack.cloudposse.com/badge.svg)](https://slack.cloudposse.com)
+# terraform-aws-ecs-codepipeline [![GitHub Action Tests](https://github.com/cloudposse/terraform-aws-ecs-codepipeline/workflows/test/badge.svg?branch=master)](https://github.com/cloudposse/terraform-aws-ecs-codepipeline/actions) [![Latest Release](https://img.shields.io/github/release/cloudposse/terraform-aws-ecs-codepipeline.svg)](https://github.com/cloudposse/terraform-aws-ecs-codepipeline/releases/latest) [![Slack Community](https://slack.cloudposse.com/badge.svg)](https://slack.cloudposse.com)
 
 
 Terraform Module for CI/CD with AWS Code Pipeline using GitHub webhook triggers and Code Build for ECS.

README.yaml

@@ -18,9 +18,9 @@ github_repo: cloudposse/terraform-aws-ecs-codepipeline
 
 # Badges to display
 badges:
- - name: "Codefresh Build Status"
- image: "https://g.codefresh.io/api/badges/pipeline/cloudposse/terraform-modules%2Fterraform-aws-ecs-codepipeline?type=cf-1"
- url: "https://g.codefresh.io/public/accounts/cloudposse/pipelines/5db7b474041f802a8893f018"
+ - name: "GitHub Action Tests"
+ image: "https://github.com/cloudposse/terraform-aws-ecs-codepipeline/workflows/test/badge.svg?branch=master"
+ url: "https://github.com/cloudposse/terraform-aws-ecs-codepipeline/actions"
  - name: "Latest Release"
  image: "https://img.shields.io/github/release/cloudposse/terraform-aws-ecs-codepipeline.svg"
  url: "https://github.com/cloudposse/terraform-aws-ecs-codepipeline/releases/latest"

examples/complete/fixtures.us-east-2.tfvars

@@ -80,8 +80,6 @@ container_port_mappings = [
 
 github_oauth_token = "test"
 
-github_webhooks_token = "test"
-
 repo_owner = "cloudposse"
 
 repo_name = "terraform-aws-ecs-codepipeline"

examples/complete/main.tf

@@ -24,7 +24,7 @@ module "vpc" {
 }
 
 module "subnets" {
- source = "git::https://github.com/cloudposse/terraform-aws-dynamic-subnets.git?ref=tags/0.16.1"
+ source = "git::https://github.com/cloudposse/terraform-aws-dynamic-subnets.git?ref=tags/0.19.0"
  availability_zones = var.availability_zones
  namespace = var.namespace
  stage = var.stage
@@ -91,7 +91,6 @@ module "ecs_codepipeline" {
  name = var.name
  region = var.region
  github_oauth_token = var.github_oauth_token
- github_webhooks_token = var.github_webhooks_token
  repo_owner = var.repo_owner
  repo_name = var.repo_name
  branch = var.branch

examples/complete/variables.tf

@@ -159,11 +159,6 @@ variable "github_oauth_token" {
  description = "GitHub OAuth Token with permissions to access private repositories"
 }
 
-variable "github_webhooks_token" {
- type = string
- description = "GitHub OAuth Token with permissions to create webhooks. If not provided, can be sourced from the `GITHUB_TOKEN` environment variable"
-}
-
 variable "repo_owner" {
  type = string
  description = "GitHub Organization or Username"

main.tf

@@ -309,7 +309,7 @@ resource "aws_codepipeline_webhook" "webhook" {
 }
 
 module "github_webhooks" {
- source = "git::https://github.com/cloudposse/terraform-github-repository-webhooks.git?ref=tags/0.5.0"
+ source = "git::https://github.com/cloudposse/terraform-github-repository-webhooks.git?ref=tags/0.7.0"
  enabled = var.enabled && var.webhook_enabled ? true : false
  github_organization = var.repo_owner
  github_repositories = [var.repo_name]