Skip to content

Add test #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Add test #3072

wants to merge 8 commits into from

Conversation

@Anhduc2k2
Copy link
Contributor

@Anhduc2k2 Anhduc2k2 commented May 31, 2022 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@Anhduc2k2 Anhduc2k2 requested review from siriak and yanglbme as code owners May 31, 2022 15:39
@Anhduc2k2 Anhduc2k2 marked this pull request as draft June 1, 2022 14:04
@Anhduc2k2 Anhduc2k2 marked this pull request as ready for review June 1, 2022 14:05
siriak
siriak requested changes Jun 4, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why delete the bloom filter tests? And please also fix the CI issues
@yanglbme yanglbme closed this Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Anhduc2k2 @siriak @yanglbme