fix: Incorrect handling of allOf subschemas in testing explicit examples

Ref: schemathesis#2375 Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>

Author: Stranger6667

docs/changelog.rst

@@ -7,6 +7,7 @@ Changelog
 **Fixed**
 
 - Incorrect default deadline for stateful tests in CLI.
+- Incorrect handling of ``allOf`` subschemas in testing explicit examples. :issue:`2375`
 
 **Changed**
 

src/schemathesis/specs/openapi/examples.py

@@ -12,6 +12,7 @@
 
 from ..._hypothesis import get_single_example
 from ...constants import DEFAULT_RESPONSE_TIMEOUT
+from ...internal.copy import fast_deepcopy
 from ...models import APIOperation, Case
 from ._hypothesis import get_case_strategy, get_default_format_strategies
 from .constants import LOCATION_TO_CONTAINER
@@ -130,10 +131,26 @@ def extract_top_level(operation: APIOperation[OpenAPIParameter, Case]) -> Genera
 def _expand_subschemas(schema: dict[str, Any] | bool) -> Generator[dict[str, Any] | bool, None, None]:
  yield schema
  if isinstance(schema, dict):
- for key in ("anyOf", "oneOf", "allOf"):
+ for key in ("anyOf", "oneOf"):
  if key in schema:
  for subschema in schema[key]:
  yield subschema
+ if "allOf" in schema:
+ subschema = fast_deepcopy(schema["allOf"][0])
+ for sub in schema["allOf"][1:]:
+ if isinstance(sub, dict):
+ for key, value in sub.items():
+ if key == "properties":
+ subschema.setdefault("properties", {}).update(value)
+ elif key == "required":
+ subschema.setdefault("required", []).extend(value)
+ elif key == "examples":
+ subschema.setdefault("examples", []).extend(value)
+ elif key == "example":
+ subschema.setdefault("examples", []).append(value)
+ else:
+ subschema[key] = value
+ yield subschema
 
 
 def _find_parameter_examples_definition(

src/schemathesis/stateful/runner.py

@@ -7,10 +7,10 @@
 from typing import TYPE_CHECKING, Any, Generator, Iterator, Type
 
 import hypothesis
-from hypothesis.stateful import Rule
 import requests
 from hypothesis.control import current_build_context
 from hypothesis.errors import Flaky
+from hypothesis.stateful import Rule
 
 from ..exceptions import CheckFailed
 from ..targets import TargetMetricCollector

test/cli/test_reporting.py

@@ -1,9 +1,10 @@
-from hypothesis import given, strategies as st
+from hypothesis import given
+from hypothesis import strategies as st
 
 from schemathesis.cli.reporting import group_by_case
 from schemathesis.code_samples import CodeSampleStyle
 from schemathesis.models import Request, Response
-from schemathesis.runner.serialization import SerializedCheck, Status, SerializedCase
+from schemathesis.runner.serialization import SerializedCase, SerializedCheck, Status
 
 
 @given(

test/specs/openapi/test_examples.py

@@ -641,7 +641,7 @@ def test_examples_ref_missing_components(empty_open_api_3_schema):
  assert example.query == {"q": {"foo-1": "foo-11", "spam-1": {"inner": "example"}}}
 
 
-@pytest.mark.parametrize("key", ("anyOf", "oneOf", "allOf"))
+@pytest.mark.parametrize("key", ("anyOf", "oneOf"))
 def test_examples_in_any_of_top_level(empty_open_api_3_schema, key):
  empty_open_api_3_schema["paths"] = {
  "/test": {
@@ -706,7 +706,71 @@ def test_examples_in_any_of_top_level(empty_open_api_3_schema, key):
  ]
 
 
-@pytest.mark.parametrize("key", ("anyOf", "oneOf", "allOf"))
+def test_examples_in_all_of_top_level(empty_open_api_3_schema):
+ empty_open_api_3_schema["paths"] = {
+ "/test": {
+ "post": {
+ "parameters": [
+ {
+ "name": "q",
+ "in": "query",
+ "schema": {
+ "allOf": [
+ {
+ "example": "foo-1-1",
+ "examples": ["foo-1-2"],
+ "type": "string",
+ },
+ {
+ "example": "foo-2-1",
+ "examples": ["foo-2-2"],
+ "type": "string",
+ },
+ True,
+ ]
+ },
+ }
+ ],
+ "requestBody": {
+ "content": {
+ "application/json": {
+ "schema": {
+ "allOf": [
+ {
+ "example": "body-1-1",
+ "examples": ["body-1-2"],
+ "type": "string",
+ },
+ {
+ "example": "body-2-1",
+ "examples": ["body-2-2"],
+ "type": "string",
+ },
+ True,
+ ]
+ }
+ },
+ }
+ },
+ "responses": {"default": {"description": "OK"}},
+ },
+ }
+ }
+ schema = schemathesis.from_dict(empty_open_api_3_schema)
+ extracted = [example_to_dict(example) for example in examples.extract_top_level(schema["/test"]["POST"])]
+ assert extracted == [
+ {"container": "query", "name": "q", "value": "foo-1-1"},
+ {"container": "query", "name": "q", "value": "foo-1-2"},
+ {"container": "query", "name": "q", "value": "foo-2-1"},
+ {"container": "query", "name": "q", "value": "foo-2-2"},
+ {"media_type": "application/json", "value": "body-1-1"},
+ {"media_type": "application/json", "value": "body-1-2"},
+ {"media_type": "application/json", "value": "body-2-1"},
+ {"media_type": "application/json", "value": "body-2-2"},
+ ]
+
+
+@pytest.mark.parametrize("key", ("anyOf", "oneOf"))
 def test_examples_in_any_of_in_schemas(empty_open_api_3_schema, key):
  empty_open_api_3_schema["paths"] = {
  "/test": {
@@ -1245,3 +1309,58 @@ def test_property_examples_behind_ref():
  "media_type": "application/json",
  }
  ]
+
+
+def test_property_examples_with_all_of():
+ # See GH-2375
+ raw_schema = {
+ "openapi": "3.0.3",
+ "info": {"title": "Test API", "version": "1.0.0"},
+ "paths": {
+ "/peers": {
+ "post": {
+ "requestBody": {
+ "content": {
+ "application/json": {
+ "schema": {"$ref": "#/components/schemas/peer"},
+ }
+ }
+ },
+ "responses": {"200": {"description": "Successful operation"}},
+ }
+ }
+ },
+ "components": {
+ "schemas": {
+ "peer": {
+ "type": "object",
+ "properties": {"outbound_proxy": {"$ref": "#/components/schemas/outbound_proxy_with_port"}},
+ "required": ["outbound_proxy"],
+ },
+ "outbound_proxy_common": {
+ "type": "object",
+ "properties": {"host": {"type": "string", "format": "ipv4", "example": "10.22.22.191"}},
+ "required": ["host"],
+ },
+ "outbound_proxy_with_port": {
+ "allOf": [
+ {"$ref": "#/components/schemas/outbound_proxy_common"},
+ {
+ "type": "object",
+ "properties": {"port": {"type": "integer", "example": 8080}},
+ "required": ["port"],
+ },
+ ]
+ },
+ }
+ },
+ }
+ schema = schemathesis.from_dict(raw_schema)
+ operation = schema["/peers"]["POST"]
+ extracted = [example_to_dict(example) for example in examples.extract_from_schemas(operation)]
+ assert extracted == [
+ {
+ "value": {"outbound_proxy": {"host": "10.22.22.191", "port": 8080}},
+ "media_type": "application/json",
+ }
+ ]