Skip to content

Correct data extraction validator #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2018
Merged

Correct data extraction validator #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4a764d
Correct data extraction validator
joaosimbiose Sep 11, 2017
d8b2875
Update changelog
joaosimbiose Sep 11, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## [2.0.1]
### Updated
- Correct data extraction validator to accept columns: all

## [2.0.0]
### Updated
- Update `existsEntity()` method to receive `table` as parameter
Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,5 @@
"async": "^2.0.1",
"sleep": "^4.0.0"
},
"dependencies": {
}
"dependencies": {}
}
4 changes: 3 additions & 1 deletion src/slicer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,9 @@
// Check columns property, columns should have a maximum of 10 itens
if (key == "columns") {
if (value.constructor != Array) {
throw new errors.InvalidQueryException("The key 'columns' in query has a invalid value.");
if (value != 'all') {
throw new errors.InvalidQueryException("The key 'columns' in query has a invalid value.");
}
}
else {
if (value.length > 10) {
Expand Down