Golangci-lint update (ineffassign linter)

internal/controller/postgrescluster/pki_test.go:303:21: ineffectual assignment to err (ineffassign)	intent, existing, err := createInstanceSecrets(ctx, tClient, instance, initialRoot) internal/controller/postgrescluster/patroni_test.go:363:2: ineffectual assignment to ctx (ineffassign) ctx := context.Background()

Author: jmckulk

internal/controller/postgrescluster/patroni_test.go

@@ -342,8 +342,6 @@ func TestPatroniReplicationSecret(t *testing.T) {
 }
 
 func TestReconcilePatroniStatus(t *testing.T) {
-ctx := context.Background()
-
 tEnv, tClient, cfg := setupTestEnv(t, ControllerName)
 t.Cleanup(func() { teardownTestEnv(t, tEnv) })
 r := &Reconciler{}

internal/controller/postgrescluster/pki_test.go

@@ -250,6 +250,7 @@ func TestReconcileCerts(t *testing.T) {
 }
 
 intent, existing, err := createInstanceSecrets(ctx, tClient, instance, initialRoot)
+assert.NilError(t, err)
 
 // apply the secret changes
 err = errors.WithStack(r.apply(ctx, existing))