Merge pull request php-vcr#334 from specialtactics/feature/ssl-paypal

Support for ssl requests in some edge cases like paypal php sdk

Author: JeroenVanOort

phpstan.neon

@@ -2,6 +2,8 @@ parameters:
  level: 7
  paths:
  - src
+ # Can remove reportUnmatchedIgnoredErrors option after php 7.2 is no longer supported
+ reportUnmatchedIgnoredErrors: false
  ignoreErrors:
  # This part of PHP is not very well documented, resulting PHPStan's definitions not being accurate
  - "#Access to an undefined property object::\\$data\\.#"
@@ -14,6 +16,8 @@ parameters:
  # The EventDispatcherInterface::dispatch signature is different (!) between Symfony <4.3 and >=4.3
  - '/Parameter #1 \$event of method Symfony\\Contracts\\EventDispatcher\\EventDispatcherInterface::dispatch\(\) expects object, string\|null given./'
  - '/Parameter #2 \$eventName of method Symfony\\Contracts\\EventDispatcher\\EventDispatcherInterface::dispatch\(\) expects string\|null, VCR\\Event\\Event given./'
+ # PHPStan cannot deal with manually defined constants - can be removed once php 7.2 no longer supported
+ - '#Constant CURLPROXY_HTTPS not found.#'
 includes:
  - vendor/thecodingmachine/phpstan-strict-rules/phpstan-strict-rules.neon
  - vendor/phpstan/phpstan-beberlei-assert/extension.neon

src/VCR/Util/CurlHelper.php

@@ -111,6 +111,9 @@ public static function getCurlOptionFromResponse(Response $response, int $option
  case CURLINFO_HEADER_SIZE:
  $info = mb_strlen(HttpUtil::formatAsStatusWithHeadersString($response), 'ISO-8859-1');
  break;
+ case CURLPROXY_HTTPS:
+ $info = '';
+ break;
  default:
  $info = $response->getCurlInfo(self::$curlInfoList[$option]);
  break;

src/VCR/VCRFactory.php

@@ -32,6 +32,10 @@ class VCRFactory
  protected function __construct(Configuration $config = null)
  {
  $this->config = $config ?: $this->getOrCreate('VCR\Configuration');
+
+ // This constant exists only from PHP 7.3
+ // Once we are no longer supporting 7.2, we can remove this
+ \defined('CURLPROXY_HTTPS') or \define('CURLPROXY_HTTPS', 2);
  }
 
  protected function createVCRVideorecorder(): Videorecorder