AST: Remove Pstr_class (rescript-lang#7242)

* Remove Pstr_class * Remove Psig_class * Remove Pstr_class_type * Remove Psig_class_type * Remove Tstr_class, Tstr_class_type, Tsig_class & Tsig_class_type * Add changelog entry * Remove unit in Texp_coerce * Remove row_bound in row_desc

Author: nojaf

CHANGELOG.md

@@ -26,6 +26,7 @@
 - AST cleanup: Remove `@res.async` attribute from the internal representation, and add a flag to untyped and typed ASTs instead. https://github.com/rescript-lang/rescript/pull/7234
 - AST cleanup: Remove `expression_desc.Pexp_new`, `expression_desc.Pexp_setinstvar`, `expression_desc.Pexp_override`, `expression_desc.Pexp_poly`, `exp_extra.Texp_poly`, `expression_desc.Texp_new`, `expression_desc.Texp_setinstvar`, `expression_desc.Texp_override` & `expression_desc.Texp_instvar` from AST as it is unused. https://github.com/rescript-lang/rescript/pull/7239
 - AST cleanup: Remove `@res.partial` attribute from the internal representation, and add a flag to untyped and typed ASTs instead. https://github.com/rescript-lang/rescript/pull/7238 https://github.com/rescript-lang/rescript/pull/7240
+- AST cleanup: Remove `structure_item_desc.Pstr_class`, `signature_item_desc.Psig_class`, `structure_item_desc.Pstr_class_type`, `signature_item_desc.Psig_class_type`, `structure_item_desc.Tstr_class`, `structure_item_desc.Tstr_class_type`, `signature_item_desc.Tsig_class`, `signature_item_desc.Tsig_class_type` from AST as it is unused. https://github.com/rescript-lang/rescript/pull/7242
 
 # 12.0.0-alpha.7
 

analysis/reanalyze/src/Annotation.ml

@@ -63,8 +63,6 @@ let rec getAttributePayload checkText (attributes : Typedtree.attributes) =
  | PStr ({pstr_desc = Pstr_recmodule _} :: _) -> Some UnrecognizedPayload
  | PStr ({pstr_desc = Pstr_modtype _} :: _) -> Some UnrecognizedPayload
  | PStr ({pstr_desc = Pstr_open _} :: _) -> Some UnrecognizedPayload
- | PStr ({pstr_desc = Pstr_class _} :: _) -> Some UnrecognizedPayload
- | PStr ({pstr_desc = Pstr_class_type _} :: _) -> Some UnrecognizedPayload
  | PStr ({pstr_desc = Pstr_include _} :: _) -> Some UnrecognizedPayload
  | PStr ({pstr_desc = Pstr_attribute _} :: _) -> Some UnrecognizedPayload
  | PPat _ -> Some UnrecognizedPayload

compiler/core/js_implementation.ml

@@ -96,8 +96,7 @@ let all_module_alias (ast : Parsetree.structure) =
  | Pstr_attribute _ -> true
  | Pstr_eval _ | Pstr_value _ | Pstr_primitive _ | Pstr_type _
  | Pstr_typext _ | Pstr_exception _ | Pstr_module _ | Pstr_recmodule _
- | Pstr_modtype _ | Pstr_open _ | Pstr_class _ | Pstr_class_type _
- | Pstr_include _ | Pstr_extension _ ->
+ | Pstr_modtype _ | Pstr_open _ | Pstr_include _ | Pstr_extension _ ->
  false)
 
 let no_export (rest : Parsetree.structure) : Parsetree.structure =

compiler/frontend/bs_ast_invariant.ml

@@ -86,9 +86,6 @@ let emit_external_warnings : iterator =
  [{ptype_kind = Ptype_variant ({pcd_res = Some _} :: _)}] ) ->
  Location.raise_errorf ~loc:str_item.pstr_loc
  "GADT has to be recursive types, please try `type rec'"
- | Pstr_class _ ->
- Location.raise_errorf ~loc:str_item.pstr_loc
- "OCaml style classes are not supported"
  | _ -> super.structure_item self str_item);
  expr =
  (fun self ({pexp_loc = loc} as a) ->

compiler/frontend/bs_ast_mapper.ml

@@ -232,8 +232,6 @@ module MT = struct
  | Psig_modtype x -> modtype ~loc (sub.module_type_declaration sub x)
  | Psig_open x -> open_ ~loc (sub.open_description sub x)
  | Psig_include x -> include_ ~loc (sub.include_description sub x)
- | Psig_class () -> assert false
- | Psig_class_type () -> assert false
  | Psig_extension (x, attrs) ->
  extension ~loc (sub.extension sub x) ~attrs:(sub.attributes sub attrs)
  | Psig_attribute x -> attribute ~loc (sub.attribute sub x)
@@ -287,8 +285,6 @@ module M = struct
  | Pstr_recmodule l -> rec_module ~loc (List.map (sub.module_binding sub) l)
  | Pstr_modtype x -> modtype ~loc (sub.module_type_declaration sub x)
  | Pstr_open x -> open_ ~loc (sub.open_description sub x)
- | Pstr_class () -> {pstr_loc = loc; pstr_desc = Pstr_class ()}
- | Pstr_class_type () -> {pstr_loc = loc; pstr_desc = Pstr_class_type ()}
  | Pstr_include x -> include_ ~loc (sub.include_declaration sub x)
  | Pstr_extension (x, attrs) ->
  extension ~loc (sub.extension sub x) ~attrs:(sub.attributes sub attrs)

compiler/gentype/Annotation.ml

@@ -83,8 +83,6 @@ let rec get_attribute_payload check_text (attributes : Typedtree.attributes) =
  | PStr ({pstr_desc = Pstr_recmodule _} :: _) -> Some UnrecognizedPayload
  | PStr ({pstr_desc = Pstr_modtype _} :: _) -> Some UnrecognizedPayload
  | PStr ({pstr_desc = Pstr_open _} :: _) -> Some UnrecognizedPayload
- | PStr ({pstr_desc = Pstr_class _} :: _) -> Some UnrecognizedPayload
- | PStr ({pstr_desc = Pstr_class_type _} :: _) -> Some UnrecognizedPayload
  | PStr ({pstr_desc = Pstr_include _} :: _) -> Some UnrecognizedPayload
  | PStr ({pstr_desc = Pstr_attribute _} :: _) -> Some UnrecognizedPayload
  | PPat _ -> Some UnrecognizedPayload
@@ -224,7 +222,7 @@ and signature_item_check_annotation ~check_annotation
  module_type_declaration
  |> module_type_declaration_check_annotation ~check_annotation
  | Tsig_typext _ | Tsig_exception _ | Tsig_recmodule _ | Tsig_open _
- | Tsig_include _ | Tsig_class _ | Tsig_class_type _ ->
+ | Tsig_include _ ->
  false
 
 and signature_check_annotation ~check_annotation
@@ -260,9 +258,7 @@ let rec structure_item_check_annotation ~check_annotation
  |> module_type_declaration_check_annotation ~check_annotation
  | Tstr_attribute attribute ->
  [attribute] |> check_annotation ~loc:structure_item.str_loc
- | Tstr_eval _ | Tstr_typext _ | Tstr_exception _ | Tstr_open _ | Tstr_class _
- | Tstr_class_type _ ->
- false
+ | Tstr_eval _ | Tstr_typext _ | Tstr_exception _ | Tstr_open _ -> false
 
 and module_expr_check_annotation ~check_annotation
  (module_expr : Typedtree.module_expr) =

compiler/gentype/TranslateSignature.ml

@@ -156,12 +156,6 @@ and translate_signature_item ~config ~output_file_relative ~resolver ~type_env
  | {Typedtree.sig_desc = Typedtree.Tsig_include _} ->
  log_not_implemented ("Tsig_include " ^ __LOC__);
  Translation.empty
- | {Typedtree.sig_desc = Typedtree.Tsig_class _} ->
- log_not_implemented ("Tsig_class " ^ __LOC__);
- Translation.empty
- | {Typedtree.sig_desc = Typedtree.Tsig_class_type _} ->
- log_not_implemented ("Tsig_class_type " ^ __LOC__);
- Translation.empty
  | {Typedtree.sig_desc = Typedtree.Tsig_attribute _} ->
  log_not_implemented ("Tsig_attribute " ^ __LOC__);
  Translation.empty

compiler/gentype/TranslateStructure.ml

@@ -352,12 +352,6 @@ and translate_structure_item ~config ~output_file_relative ~resolver ~type_env
  | {str_desc = Tstr_open _} ->
  log_not_implemented ("Tstr_open " ^ __LOC__);
  Translation.empty
- | {str_desc = Tstr_class _} ->
- log_not_implemented ("Tstr_class " ^ __LOC__);
- Translation.empty
- | {str_desc = Tstr_class_type _} ->
- log_not_implemented ("Tstr_class_type " ^ __LOC__);
- Translation.empty
  | {str_desc = Tstr_attribute _} ->
  log_not_implemented ("Tstr_attribute " ^ __LOC__);
  Translation.empty

compiler/ml/ast_iterator.ml

@@ -216,8 +216,6 @@ module MT = struct
  | Psig_modtype x -> sub.module_type_declaration sub x
  | Psig_open x -> sub.open_description sub x
  | Psig_include x -> sub.include_description sub x
- | Psig_class () -> ()
- | Psig_class_type () -> ()
  | Psig_extension (x, attrs) ->
  sub.extension sub x;
  sub.attributes sub attrs
@@ -261,8 +259,6 @@ module M = struct
  | Pstr_recmodule l -> List.iter (sub.module_binding sub) l
  | Pstr_modtype x -> sub.module_type_declaration sub x
  | Pstr_open x -> sub.open_description sub x
- | Pstr_class () -> ()
- | Pstr_class_type () -> ()
  | Pstr_include x -> sub.include_declaration sub x
  | Pstr_extension (x, attrs) ->
  sub.extension sub x;

compiler/ml/ast_mapper.ml

@@ -215,8 +215,6 @@ module MT = struct
  | Psig_modtype x -> modtype ~loc (sub.module_type_declaration sub x)
  | Psig_open x -> open_ ~loc (sub.open_description sub x)
  | Psig_include x -> include_ ~loc (sub.include_description sub x)
- | Psig_class _ -> assert false
- | Psig_class_type _ -> assert false
  | Psig_extension (x, attrs) ->
  extension ~loc (sub.extension sub x) ~attrs:(sub.attributes sub attrs)
  | Psig_attribute x -> attribute ~loc (sub.attribute sub x)
@@ -258,8 +256,6 @@ module M = struct
  | Pstr_recmodule l -> rec_module ~loc (List.map (sub.module_binding sub) l)
  | Pstr_modtype x -> modtype ~loc (sub.module_type_declaration sub x)
  | Pstr_open x -> open_ ~loc (sub.open_description sub x)
- | Pstr_class () -> {pstr_loc = loc; pstr_desc = Pstr_class ()}
- | Pstr_class_type () -> {pstr_loc = loc; pstr_desc = Pstr_class_type ()}
  | Pstr_include x -> include_ ~loc (sub.include_declaration sub x)
  | Pstr_extension (x, attrs) ->
  extension ~loc (sub.extension sub x) ~attrs:(sub.attributes sub attrs)