Skip to content

Commit 9a9d575

Browse files
mr-robbotjafari-dev
authored andcommitted
Fix some grammatical issues in README.md
1 parent d984447 commit 9a9d575

File tree

1 file changed

+36
-36
lines changed

1 file changed

+36
-36
lines changed

README.md

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -9,48 +9,48 @@ I listed 10 rules for having a professional commit message.
99

1010
### 1. Meaningful messages:
1111

12-
The first and most important rule for a Git commit message is this! Each commit message must have a complete, meaningful and independent description. Commit message has to be valuable for its readers. As a reader, when I looked at the Git's log of your repository, All the commits messages must be clear for me and I be known about the changes of each commit, just by a simple looking!
12+
The first and the most important rule for a Git commit message is this! Each commit message must have a complete, meaningful and independent description. Commit message has to be valuable for its readers. As a reader, when I'm looking at the Git's log of your repository, All the commit messages must be clear for me and I should be aware about the changes of each commit, just by a simple look!
1313

1414
I prepared some examples of bad commit messages and I explained why they are bad, so look at these:
1515

1616

1717
`First commit`
1818

1919
🔷 **Why it's bad?**
20-
> It's not important for the reader to be known about the number of commit in its message. Because he/she can be known about it, by has a looking to the Git's log. Also he/she couldn't have any idea about the what happen's in the codebase in this commit!
20+
> It's not important for the reader to know about the number of commits in its message. Because he/she can be aware about it, by a looking to the Git's log. Also he/she can't have any idea about what's happening in the codebase in this commit!
2121
2222
`Add some codes`
2323

2424
🔷 **Why it's bad?**
25-
> When you works on a codebase, you can **add**, **delete** or **modify** the codes and there is not any other option! So, it has not any benefit for the reader! You must say what you added!
25+
> When you work on a codebase, you can **add**, **delete** or **modify** the code and there is no any other options! So, it has not any benefits for the reader! You must say what you added!
2626
2727
`Refactoring and cleaning codes`
2828

2929
🔷 **Why it's bad?**
30-
> How can I be informed that which section of the codebase had been modified? Or how can I guess what type of refactoring had been applied on codebase? Your commit message have to include the answer of these questions in self!
30+
> How can I be informed that which section of the codebase has been modified? Or how can I guess what type of refactoring has been applied on the codebase? Your commit message have to include the answer of these questions in self!
3131
3232
`Bug resolved`
3333

3434
🔷 **Why it's bad?**
35-
> Which bug is resolved? Have to the reader guess the bug?! Of course no, so please explain what bug is resolved explicitly.
35+
> Which bug is resolved? must the reader guess the bug?! Of course not, so please explain which bug is resolved explicitly.
3636
3737
`I added a new feature`
3838

3939
🔷 **Why it's bad?**
40-
> According to the previous examples, here we haven't any clear vision about the modifications of codebase! Btw, there is no need to use pronoun at the first of this commit message. Git saves that who is the author of each commit by self and we haven't do a duplicated action!
40+
> According to the previous examples, here we haven't any clear vision about the modifications of the codebase! Btw, there is no need to use pronoun at the first of this commit message. Git saves the author of each commit by itself and we haven't to do a duplicated action!
4141
4242

4343
### 2. Neither Long nor Short:
4444

45-
If you want to write a meaningful message for a commit, avoid writing lengthy descriptions. Very summarized texts too! A sign of a good commit message is a suitable length most of the time. Maybe you want to know why we should avoid long/short messages in commit messages? Well, here's an example.
45+
If you want to write a meaningful message for a commit, avoid writing lengthy descriptions. Very summarized texts too! A sign of a good commit message is a suitable length most of the time. Maybe you want to know why we should avoid long/short messages in our commit messages? Well, here's an example.
4646

4747
Assume my friend asks me to lend him some money.
4848

49-
`Please lend me money!`
50-
> It's an example of a short message. When my friend tells it, I ask two pertinent questions: "How much money do you need?" and "When will you get it back?". He could make me clear about them, so there was no need to these questions.
49+
`Please lend me some money!`
50+
> It's an example of a short message. When my friend tells it, I ask two related questions: "How much money do you need?" and "When will you get it back?". He could make me clear about them, so there was no need to these questions.
5151
5252
`Hey Ahmad, get on the bus as soon as it arrives at the bus station. Then go to your bank, fill out a form, and then get the money from the bank and lend me $20. I'm going to return it in three weeks.`
53-
> This is an example of a long message. It's an example of a long message. Don't tell me how I can provide some money! Just tell me your request.
53+
> This is an example of a long message. It's an example of a long message. Don't tell me how can I provide some money! Just tell me your request.
5454
5555
`Ahmad, please lend me 20 dollars. I will return it in 3 weeks.`
5656
> Perfect! It's that I want to hear!
@@ -67,25 +67,25 @@ When you want to write a commit message, suppose you give Git an order. Do not a
6767

6868
For example, suppose you implemented a function that can transform the characters of a text into the upper case characters.
6969

70-
`Implementing a function that transform letters to upper case.`
70+
`Implementing a function that transforms letters to upper case.`
7171

72-
`I added a function to transforming letters to upper case.`
72+
`I added a function to transform letters to upper case.`
7373

74-
`A function to transforming letters to upper case has been added.`
74+
`A function that transforms letters to upper case has been added.`
7575

7676
`Implement a function to transform letters to upper case.`
7777

7878

7979
### 4. Avoid Writing Details:
8080

81-
This rule complements the `Neither Long nor Short` rule. No need to write everything and details.
82-
Remember always, you must tell `What` and `Why` something added/removed/modified in the codebase, not `How`! Also, no need to write the bit or low-priority modifications.
81+
This rule complements the `Neither Long nor Short` rule. No need to write everything in details.
82+
Always remember, you must tell `What` and `Why` something added/removed/modified in the codebase, not `How`! Also, no need to write the bit or low-priority modifications.
8383

84-
For example, assume you want to refactor a function named getUser in your codebase. After refactoring it, you notice that the related file has an unused variable inside itself, so you decide to remove it. When you want to commit your changes, there is no need to write something like this:
84+
For example, assume you want to refactor a function named getUser in your codebase. After refactoring it, you may notice that the related file has an unused variable inside of itself, so you decide to remove it. When you want to commit your changes, there is no need to write something like this:
8585

8686
`Refactor the 'getUser' function and delete an unused variable in its related file.`
8787

88-
Why is it not necessary to refer to the delete variable? Because it wasn't the primary goal of this commit. It was a minor modification that we could fix along with another commit. Of course, you can delete this unused variable in a separate commit, or maybe you want to make a new task for your project to find all unused variables and remove them all in a commit!
88+
Why it's not necessary to refer to the delete variable? Because it wasn't the primary goal of this commit. It was a minor modification that we could fix along with another commit. Of course, you can delete this unused variable in a separate commit, or maybe you want to make a new task for your project to find all unused variables and remove them all in a commit!
8989

9090
I prefer this one:
9191

@@ -98,55 +98,55 @@ This one is an optional offer for your commit messages but can make them very re
9898

9999
Here is a list of the most usable prefixes that I often see in software teams:
100100

101-
* `[BUGFIX]`: For resolving any bug and issue from the codebase.
101+
* `[BUGFIX]`: For resolving any bug and issues from the codebase.
102102
* `[TEST]`: For writing any type of tests (Unit / End-to-End / UserStory / Integration / Regression / ...)
103103
* `[FEATURE]`: For adding a new feature and implementation
104104
* `[REFACTOR]`: For improving current codes for any purpose like better readability, performance, etc.
105105
* `[UPDATE]`: For updating libraries and dependencies, also updating current features by documentation.
106106
* `[BASE]`: For installing new libraries and dependencies and setting up the infrastructures of the codebase, like configuring the project and its packages.
107107
* `[DOCS]`: For adding or modifying the documentations.
108108

109-
The above cases are only some offers for you so, there isn't any force to using them. You can have your own!
109+
The above cases are only some offers for you so, there isn't any force to use them. You can have your own!
110110

111111
🔑 *The text of your prefixes can be lowercase. Please follow a fixed rule. For example, if you want to write your prefixes in lowercase, write them all in lowercase forever in the related repository.*
112112

113113

114114
### 6. Emoji? Please No!
115115

116-
Recently I'm seeing developers use emojis in commit messages. In my opinion, it's not a good practice! Say Why? Because of two reasons:
116+
Recently I've seen developers using emojis in their commit messages. In my opinion, it's not a good practice! Say Why? Because of two reasons:
117117

118-
* That they don't have a clear message.
119-
* Emojis have specific Unicode, maybe we have a terminal that doesn't support those Unicode, so we can't see any emoji in our terminal.
118+
* They don't have a clear message.
119+
* Emojis have specific Unicode, maybe we have a terminal that doesn't support those Unicode, so we can't see any emojis in our terminal.
120120

121-
One of my colleagues disagreed with me about case one. She believed that each emoji has a special meaning, and we can use them in our commit messages. I asked her to give an example. She showed the emoji of a worm (🐛) and said that everybody knows that this emoji refers to a bug! I asked her what should be used for features, refactoring, testing, and ...? She introduced a website to me and said they provide lots of emojis and have a unique meaning for all of them.
121+
One of my colleagues disagreed with me about the case one. She believed that each emoji has a special meaning, and we can use them in our commit messages. I asked her to give an example. She showed the emoji of a worm (🐛) and said that everybody knows that this emoji refers to a bug! I asked her what should be used for features, refactoring, testing, and ...? She introduced a website to me and she said they provide lots of emojis and have a unique meaning for all of them.
122122

123123
It's the address of that website: [Gitmoji](https://gitmoji.dev)
124124

125-
I disagree with my colleague because this website is not a reference for git commits! It's not the product of a famous company with high-level standards! Only one tasteful person has presented some emojis and has written explanations for each of them according to his taste. That and no more!
125+
I disagree with my colleague because this website is not a reference for git commits! It's not the product of a famous company with high-level standards! Only one tasteful person has presented some emojis and has written explanations for each of them according to his taste. And nothing more!
126126
One day, if terminals support showing images, I can create a website for using images in the commit messages! For example, I can provide the picture of a scared man and say that refers to a bug! It's not standard :)
127127

128128

129129
### 7. Referral Prefixes:
130130

131-
This case is similar to `Conceptual Prefixes` with a main different: The *Conceptual Prefixes* have a straight and clear messages for their reader and directly say their content. But the *Referral Prefixes* point to a external description, like a task on Jira, a card on Trello, an issue on Gitlab or anything else! *Referral Prefixes* usually be used in the large teams and teams that they used Scrum methodology.
131+
This case is similar to `Conceptual Prefixes` with a main difference: The *Conceptual Prefixes* have a straight and clear message for their readers and they directly say their content. But the *Referral Prefixes* point to a external description, like a task on Jira, a card on Trello, an issue on Gitlab or anything else! *Referral Prefixes* usually be used in the large teams and teams that they use Scrum methodology.
132132

133-
For using a referral prefix, there are some common styles that I list:
133+
For using a referral prefix, there are some common styles that I listed:
134134

135135
* `[#<CARD-NUMBER>]`, `[#<ISSUE-NUMBER>]` or `[#<TASK-NUMBER>]`
136136
* `[<CARD-NUMBER>]`, `[<ISSUE-NUMBER>]` or `[<TASK-NUMBER>]`
137137
* `(<CARD-NUMBER>)`, `(<ISSUE-NUMBER>)` or `(<TASK-NUMBER>)`
138138

139139

140-
An examples of the above cases:
140+
As an example of the above cases:
141141

142-
* `[#217] Resolve the bug of 'fetchUsers' function that causes some users be missed`
142+
* `[#217] Resolve the bug of 'fetchUsers' function that causes some users to be missed`
143143

144-
> [#217] at the first of this commit can refer to task number 217. It's no matter what tasks manager you are using. You can always use these referral prefixes to point to your tasks/cards/issues.
144+
> [#217] the first part of this commit can refer to a task number 217. It's no matter which tasks manager you are using. You can always use these referral prefixes to point your tasks/cards/issues.
145145
146146

147-
🔑 *You can use both **Conceptual Prefixes** and **Referral Prefixes** together. It relates to your decision.*
147+
🔑 *You can use both **Conceptual Prefixes** and **Referral Prefixes** together. It is related to your decision.*
148148

149-
I list examples of usage of conceptual prefixes and referral prefixes side each other:
149+
I listed some examples for the usage of conceptual prefixes and referral prefixes side by side:
150150

151151

152152
* `[#REFACTOR](217) Use Array's methods like 'forEach' and 'map' instead of simple 'for' and 'while' loops in the codebase`
@@ -156,12 +156,12 @@ I list examples of usage of conceptual prefixes and referral prefixes side each
156156
* `[#217][REFACTOR] Use Array's methods like 'forEach' and 'map' instead of simple 'for' and 'while' loops in the codebase`
157157

158158

159-
🔑 *The above examples are just some template and they are not a rule. You can use them in any other styles.*
159+
🔑 *The above examples are just some template and they are not some rules. You can use them in any other styles.*
160160

161161

162162
### 8. Separate References to The Codes and Specialized Terms
163163

164-
Sometimes commit messages to contain references to variables, functions, methods, classes, and specialized terms. Whenever you need to write a specialized term or the name of a variable/function/method/class or anything similar, wrap its name in a couple of backticks or quotation marks. It helps the reader detect that the wrapped word is different from others and is a reference to the codebase.
164+
Sometimes commit messages contain references to variables, functions, methods, classes, and specialized terms. Whenever you need to write a specialized term or the name of a variable/function/method/class or anything similar, wrap its name in a couple of backticks or quotation marks. It helps the reader detect that the wrapped word is different from the others and there is a reference to the codebase.
165165

166166

167167
`Upgrade Jest and React Testing Library to the latest versions`
@@ -190,15 +190,15 @@ Sometimes commit messages to contain references to variables, functions, methods
190190
`Write integration test for 'Settings' module`
191191

192192

193-
* Wrap lines at 72 characters. (Always there exist exceptions)
193+
* Wrap lines at 72 characters. (Always there exists some exceptions)
194194

195195
* Don't use urls in the messages.
196196

197197
### 10. Have a Coherent Log!
198198

199-
If you have a tour in the log of lots of the famous repositories, you can see a lot of differences between commit messages. For example, some of them have prefixes, and some don't. Some of them include emojis, some of them no. Some start with a capitalized letter, some of them no, etc. It usually happens because teams and persons don't follow typical rules. Always have a complete and clear guideline for yourself and your team. By doing it, you can prevent having inconsistent commit messages.
199+
If you have a tour in the log of lots of the famous repositories, you can see a lot of differences between commit messages. For example, some of them have prefixes, and some other have'nt. Some of them include emojis, some of them no. Some start with a capitalized letter, some of them no, etc. It usually happens because teams and people don't follow typical rules. Always have a complete and clear guideline for yourself and your team. By doing it, you can prevent having inconsistent commit messages.
200200

201201
You can use some external tools and linters for double-checking the commits. Linters and these external tools, ensure that no commit message will conflict with the rules you applied. They force you and your team members to follow the rules.
202202

203203

204-
**If this repository helped you, don't forgive getting a star ;)**
204+
**If this repository helped you, don't forgive getting a star ;)**

0 commit comments

Comments
 (0)