Bug #27532931 CONN WITH BLANK PWD FAILS FOR USER CREATED USING MYSQL_NATIVE_PASSWORD-WL#11285

* Updated the NativePasswordPlugin to handle the GetPassword() method returning a null object. * Fixed bug in the authentication process where the SendPacket() didn't take into account empty byte arrays and would result in not allowing empty passwords for mysql_native_password auth plugin during an authentication change.

Author: Jose Ramirez

Source/MySql.Data/Authentication/MySQLAuthenticationPlugin.cs

@@ -207,7 +207,7 @@ private void ContinueAuthentication(byte[] data = null)
  packet.Clear();
  byte[] moreData = MoreData(data);
 
- while (moreData != null && moreData.Length > 0)
+ while (moreData != null)
  {
  packet.Clear();
  packet.Write(moreData);

Source/MySql.Data/Authentication/NativePasswordPlugins.cs

@@ -1,4 +1,4 @@
-// Copyright © 2012, 2017 Oracle and/or its affiliates. All rights reserved.
+// Copyright © 2012, 2018, Oracle and/or its affiliates. All rights reserved.
 //
 // MySQL Connector/NET is licensed under the terms of the GPLv2
 // <http://www.gnu.org/licenses/old-licenses/gpl-2.0.html>, like most 
@@ -55,7 +55,7 @@ protected override void SetAuthData(byte[] data)
 
  protected override byte[] MoreData(byte[] data)
  {
- byte[] passBytes = GetPassword() as byte[];
+ byte[] passBytes = (GetPassword() ?? new byte[1]) as byte[];
  byte[] buffer = new byte[passBytes.Length - 1];
  Array.Copy(passBytes, 1, buffer, 0, passBytes.Length - 1);
  return buffer;

Source/MySql.Data/MySqlStream.cs

@@ -1,4 +1,4 @@
-// Copyright © 2004, 2013, Oracle and/or its affiliates. All rights reserved.
+// Copyright © 2004, 2018, Oracle and/or its affiliates. All rights reserved.
 //
 // MySQL Connector/NET is licensed under the terms of the GPLv2
 // <http://www.gnu.org/licenses/old-licenses/gpl-2.0.html>, like most 
@@ -238,7 +238,7 @@ public void SendPacket(MySqlPacket packet)
  throw new MySqlException(Resources.QueryTooLarge, (int)MySqlErrorCode.PacketTooLarge);
 
  int offset = 0;
- while (length > 0)
+ do
  {
  int lenToSend = length > maxBlockSize ? maxBlockSize : length;
  buffer[offset] = (byte)(lenToSend & 0xff);
@@ -250,7 +250,7 @@ public void SendPacket(MySqlPacket packet)
  outStream.Flush();
  length -= lenToSend;
  offset += lenToSend;
- }
+ } while (length > 0);
  }
 
  public void SendEntirePacketDirectly(byte[] buffer, int count)

Tests/MySql.Data.Tests/MySqlConnectionTests.cs

@@ -1923,5 +1923,24 @@ public void EmptyPasswordOnSslDisableCachingSha2Password()
  connection.Close();
  }
  }
+
+ [Fact]
+ public void EmptyPasswordOnMySqlNativePassword()
+ {
+ var pluginName = "mysql_native_password";
+ var builder = new MySqlConnectionStringBuilder();
+ builder.UserID = "testNtvPass";
+ builder.Password = "";
+ builder.Server = st.conn.Settings.Server;
+ builder.Port = st.conn.Settings.Port;
+ st.CreateUser(builder.UserID, builder.Password, pluginName);
+
+ using (var connection = new MySqlConnection(builder.ConnectionString))
+ {
+ connection.Open();
+ Assert.True(connection.State == ConnectionState.Open);
+ connection.Close();
+ }
+ }
  }
 }