Replace ECDSA and Schnorr with Ed25519

Author: SeungMin Lee

README.md

@@ -28,12 +28,13 @@ import { blake256, H256 } from "foundry-primitives";
 - blake256
 - blake256WithKey
 - ripemd160
-- signEcdsa
-- verifyEcdsa
-- recoverEcdsa
+- signEd25519
+- verifyEd25519
+- recoverEd25519
 - generatePrivateKey
 - getPublicFromPrivate
 - toHex
+- toArray
 - getAccountIdFromPrivate
 - getAccountIdFromPublic
 

package.json

@@ -59,6 +59,7 @@
  "hmac-drbg": "^1.0.1",
  "lodash": "^4.17.14",
  "node-forge": "^0.7.6",
- "rlp": "^2.1.0"
+ "rlp": "^2.1.0",
+ "tweetnacl": "^1.0.3"
  }
 }

src/index.ts

@@ -25,19 +25,7 @@ export {
 
 export { generatePrivateKey, getPublicFromPrivate } from "./key/key";
 
-export {
- EcdsaSignature,
- signEcdsa,
- verifyEcdsa,
- recoverEcdsa
-} from "./key/ecdsa";
-
-export {
- SchnorrSignature,
- signSchnorr,
- verifySchnorr,
- recoverSchnorr
-} from "./key/schnorr";
+export { Ed25519Signature, signEd25519, verifyEd25519 } from "./key/ed25519";
 
 export {
  toHex,

src/key/ecdsa.ts

@@ -0,0 +1,39 @@
+import * as _ from "lodash";
+import nacl = require("tweetnacl");
+import { toArray, toHex } from "../utility";
+
+export type Ed25519Signature = string;
+
+/**
+ * Gets EdDSA(Ed25519) signature for message from private key.
+ * @param message 32 byte hexadecimal string
+ * @param priv 64 byte hexadecimal string of private key
+ * @returns 64 byte hexadecimal string of Ed25519 signature
+ */
+export const signEd25519 = (
+ message: string,
+ priv: string
+): Ed25519Signature => {
+ return toHex(
+ Buffer.from(nacl.sign.detached(toArray(message), toArray(priv)))
+ );
+};
+
+/**
+ * Checks if the signature from signEd25519 is valid.
+ * @param message 32 byte hexadecimal string
+ * @param signature 64 byte hexadecimal string of Ed25519 signature
+ * @param pub 32 byte hexadecimal string of public key
+ * @returns if signature is valid, true. Else false.
+ */
+export const verifyEd25519 = (
+ message: string,
+ signature: Ed25519Signature,
+ pub: string
+): boolean => {
+ return nacl.sign.detached.verify(
+ toArray(message),
+ toArray(signature),
+ toArray(pub)
+ );
+};

src/key/ed25519.ts

@@ -1,32 +1,22 @@
 import * as _ from "lodash";
-
-/**
- * @hidden
- */
-const EC = require("elliptic").ec;
-/**
- * @hidden
- */
-const secp256k1 = new EC("secp256k1");
+import nacl = require("tweetnacl");
+import { toArray, toHex } from "../utility";
 
 /**
  * Generates a private key.
- * @returns 32 byte hexadecimal string of private key
+ * @returns 64 byte hexadecimal string of private key
  */
 export const generatePrivateKey = (): string => {
- return _.padStart(secp256k1.genKeyPair().priv.toString("hex"), 64, "0");
+ return toHex(Buffer.from(nacl.sign.keyPair().secretKey));
 };
 
 /**
  * Gets public key from private key.
- * @param priv 32 byte hexadecimal string of private key
- * @returns 64 byte hexadecimal string of public key
+ * @param priv 64 byte hexadecimal string of private key
+ * @returns 32 byte hexadecimal string of public key
  */
 export const getPublicFromPrivate = (priv: string): string => {
- const key = secp256k1.keyFromPrivate(priv);
- // Remove prefix "04" which represents it's uncompressed form.
- return key
- .getPublic()
- .encode("hex")
- .slice(2);
+ return toHex(
+ Buffer.from(nacl.sign.keyPair.fromSecretKey(toArray(priv)).publicKey)
+ );
 };