Core: Fix possible exception when injecting method with parameter/s

Author: SamboyCoding

Cpp2IL.Core/Model/Contexts/ConcreteGenericMethodAnalysisContext.cs

@@ -35,8 +35,9 @@ private ConcreteGenericMethodAnalysisContext(Cpp2IlMethodRef methodRef, Assembly
  DeclaringAsm = declaringAssembly;
  BaseMethodContext = ResolveBaseMethod(methodRef, declaringAssembly.GetTypeByDefinition(methodRef.DeclaringType)!);
 
- foreach (var parameter in BaseMethodContext.Parameters)
+ for (var i = 0; i < BaseMethodContext.Parameters.Count; i++)
  {
+ var parameter = BaseMethodContext.Parameters[i];
  var parameterType = parameter.ParameterTypeContext;
  var instantiatedType = GenericInstantiation.Instantiate(
  parameter.ParameterTypeContext,
@@ -45,7 +46,7 @@ private ConcreteGenericMethodAnalysisContext(Cpp2IlMethodRef methodRef, Assembly
 
  Parameters.Add(parameterType == instantiatedType
  ? parameter
- : new InjectedParameterAnalysisContext(parameter.Name, instantiatedType, BaseMethodContext));
+ : new InjectedParameterAnalysisContext(parameter.Name, instantiatedType, i, BaseMethodContext));
  }
 
  if (UnderlyingPointer != 0)

Cpp2IL.Core/Model/Contexts/InjectedMethodAnalysisContext.cs

@@ -24,7 +24,7 @@ public InjectedMethodAnalysisContext(TypeAnalysisContext parent, string name, bo
  var injectedParameterType = injectedParameterTypes[i];
  var injectedParameterName = injectedParameterNames?[i];
 
- Parameters.Add(new InjectedParameterAnalysisContext(injectedParameterName, injectedParameterType, this));
+ Parameters.Add(new InjectedParameterAnalysisContext(injectedParameterName, injectedParameterType, i, this));
  }
  }
 }

Cpp2IL.Core/Model/Contexts/InjectedParameterAnalysisContext.cs

@@ -9,14 +9,14 @@ public class InjectedParameterAnalysisContext : ParameterAnalysisContext
 
  public override bool IsRef => false; //For now
 
- public InjectedParameterAnalysisContext(string? name, Il2CppType type, MethodAnalysisContext declaringMethod)
- : this(name, declaringMethod.DeclaringType!.DeclaringAssembly.ResolveIl2CppType(type) ?? throw new($"Type {type} could not be resolved."), declaringMethod)
+ public InjectedParameterAnalysisContext(string? name, Il2CppType type, int paramIndex, MethodAnalysisContext declaringMethod)
+ : this(name, declaringMethod.DeclaringType!.DeclaringAssembly.ResolveIl2CppType(type) ?? throw new($"Type {type} could not be resolved."), paramIndex, declaringMethod)
  {
  }
 
- public InjectedParameterAnalysisContext(string? name, TypeAnalysisContext typeContext, MethodAnalysisContext declaringMethod) : base(null, 0, declaringMethod)
+ public InjectedParameterAnalysisContext(string? name, TypeAnalysisContext typeContext, int paramIndex, MethodAnalysisContext declaringMethod) : base(null, paramIndex, declaringMethod)
  {
- OverrideName = name;
+ OverrideName = name ?? $"param_{paramIndex}";
  ParameterTypeContext = typeContext;
  }
 }