fix: prevent test timeouts by improving non-interactive mode checks

- Add PHPUNIT environment variable check before stream_isatty() in Dashboard, InputHandler - Fix test output capture by temporarily unsetting PHPUNIT in tests that check CLI output - Update test expectations for error messages in non-interactive mode - Remove unnecessary @runInSeparateProcess from tests using Application->run() directly - Add helper methods unsetPhpunitForOutput() and restorePhpunit() for cleaner test code

Author: tommyknocker

src/cli/commands/TableCommand.php

@@ -100,11 +100,15 @@ protected function create(): int
  $columnsOpt = $this->getOption('columns');
  if (!is_string($columnsOpt) || $columnsOpt === '') {
  // Try interactive prompt for columns definition
- $columnsOpt = static::readInput('Enter columns (e.g., id:int, name:string:nullable)', null);
+ $inputColumns = static::readInput('Enter columns (e.g., id:int, name:string:nullable)', null);
+ if ($inputColumns === '') {
+ return $this->showError('Columns are required. Use --columns option or provide them interactively.');
+ }
+ $columnsOpt = $inputColumns;
  }
  $options = $this->collectCreateOptions();
- /** @var string $columnsOpt */
- $columns = $this->parseColumns($columnsOpt !== '' ? $columnsOpt : null);
+ // At this point $columnsOpt is guaranteed to be a non-empty string
+ $columns = $this->parseColumns($columnsOpt);
  if (empty($columns)) {
  return $this->showError('At least one column is required. Use --columns="id:int, name:string".');
  }

src/cli/ui/Dashboard.php

@@ -328,7 +328,16 @@ public function __construct(PdoDb $db)
  public function run(): void
  {
  // Check if interactive
- if (!stream_isatty(STDOUT) || getenv('PDODB_NON_INTERACTIVE') !== false) {
+ // Check for PDODB_NON_INTERACTIVE and PHPUNIT first (fastest check)
+ $nonInteractive = getenv('PDODB_NON_INTERACTIVE') !== false
+ || getenv('PHPUNIT') !== false;
+
+ // Only check stream_isatty if not already in non-interactive mode (expensive check)
+ if (!$nonInteractive) {
+ $nonInteractive = !stream_isatty(STDOUT);
+ }
+
+ if ($nonInteractive) {
  echo "TUI Dashboard requires an interactive terminal.\n";
  echo "Please run this command in a terminal with TTY support.\n";
  return;

src/cli/ui/InputHandler.php

@@ -18,8 +18,16 @@ class InputHandler
  */
  public static function readKey(int $timeoutMicroseconds = 100000): ?string
  {
- // Check if stdin is available
- if (!stream_isatty(STDIN)) {
+ // Check for non-interactive mode first (fastest check)
+ $nonInteractive = getenv('PDODB_NON_INTERACTIVE') !== false
+ || getenv('PHPUNIT') !== false;
+
+ // Only check stream_isatty if not already in non-interactive mode (expensive check)
+ if (!$nonInteractive) {
+ $nonInteractive = !stream_isatty(STDIN);
+ }
+
+ if ($nonInteractive) {
  return null;
  }
 
@@ -257,7 +265,16 @@ public static function waitForKey(array $allowedKeys = []): string
  */
  public static function hasKey(): bool
  {
- if (!stream_isatty(STDIN)) {
+ // Check for non-interactive mode first (fastest check)
+ $nonInteractive = getenv('PDODB_NON_INTERACTIVE') !== false
+ || getenv('PHPUNIT') !== false;
+
+ // Only check stream_isatty if not already in non-interactive mode (expensive check)
+ if (!$nonInteractive) {
+ $nonInteractive = !stream_isatty(STDIN);
+ }
+
+ if ($nonInteractive) {
  return false;
  }
 

tests/mariadb/UserCommandCliTests.php

@@ -4,16 +4,15 @@
 
 namespace tommyknocker\pdodb\tests\mariadb;
 
+use PHPUnit\Framework\Attributes\PreserveGlobalState;
+use PHPUnit\Framework\Attributes\RunInSeparateProcess;
 use tommyknocker\pdodb\cli\Application;
 use tommyknocker\pdodb\exceptions\AuthenticationException;
 
 final class UserCommandCliTests extends BaseMariaDBTestCase
 {
- /**
- * @runInSeparateProcess
- *
- * @preserveGlobalState disabled
- */
+ #[PreserveGlobalState(false)]
+ #[RunInSeparateProcess]
  public function testUserCreateCommandWithAllOptions(): void
  {
  putenv('PDODB_DRIVER=mariadb');

tests/mysql/UserCommandCliTests.php

@@ -4,16 +4,15 @@
 
 namespace tommyknocker\pdodb\tests\mysql;
 
+use PHPUnit\Framework\Attributes\PreserveGlobalState;
+use PHPUnit\Framework\Attributes\RunInSeparateProcess;
 use tommyknocker\pdodb\cli\Application;
 use tommyknocker\pdodb\exceptions\AuthenticationException;
 
 final class UserCommandCliTests extends BaseMySQLTestCase
 {
- /**
- * @runInSeparateProcess
- *
- * @preserveGlobalState disabled
- */
+ #[PreserveGlobalState(false)]
+ #[RunInSeparateProcess]
  public function testUserCreateCommandWithAllOptions(): void
  {
  putenv('PDODB_DRIVER=mysql');

tests/postgresql/UserCommandCliTests.php

@@ -4,16 +4,15 @@
 
 namespace tommyknocker\pdodb\tests\postgresql;
 
+use PHPUnit\Framework\Attributes\PreserveGlobalState;
+use PHPUnit\Framework\Attributes\RunInSeparateProcess;
 use tommyknocker\pdodb\cli\Application;
 use tommyknocker\pdodb\exceptions\AuthenticationException;
 
 final class UserCommandCliTests extends BasePostgreSQLTestCase
 {
- /**
- * @runInSeparateProcess
- *
- * @preserveGlobalState disabled
- */
+ #[PreserveGlobalState(false)]
+ #[RunInSeparateProcess]
  public function testUserCreateCommandWithAllOptions(): void
  {
  putenv('PDODB_DRIVER=pgsql');