Activity
From 03/23/2024 to 03/29/2024
03/29/2024
-
11:32 PM Revision cdb8d208 (git): [PRISM] Fix error message for duplicate parameter name
-
09:29 PM Bug #20330 (Closed): [BUG] Segmentation fault at 0xffffffffffffffff
- I think this is a duplicate of #20184 and should be fixed in 3.3.1.
- 07:27 PM Revision d7d59ea1 (git): [rubygems/rubygems] add test case to ensure updating with multiple sources + caching maintains the right lockfile
- https://github.com/rubygems/rubygems/commit/65839757e6
-
-
- https://github.com/ruby/prism/commit/9947ab13c0
-
- https://github.com/ruby/prism/commit/79a75258a4
-
-
- I agree, but I still think Ripper should match the parser's behavior here. Otherwise you can't get the AST of those kinds of files.
-
05:11 AM Bug #20399: Ripper doesn't respect implicit -x
- Shebang makes sense only in an executable script file.
```sh
$ echo $'#!/bin/sh\np :sh' | ruby
ruby: no Ruby script found in input (LoadError)
bash: exit 1
$ ruby -e $'#!/bin/sh\np :sh'
:sh
``` -
- I've opened a PR here https://github.com/ruby/ruby/pull/10406. I'm assuming no one has an objection based on the silence, so I'll merge once CI passes.
-
-
- Thank you for the clarification!
-
- `BEGIN` blocks are:
a. executed in the order they appeared in the same nesting level.
b. executed in prior to outside the block.
> ```ruby
> ...
"2" is first because it is in the inner `BEGIN` in the block for "1".
> ```ruby
... - 08:03 AM Revision 38331c89 (git): [rubygems/rubygems] [gemspec_helpers] Fix Rubocop warning.
- https://github.com/rubygems/rubygems/commit/4ebf6ee5ac
- 08:03 AM Revision d19744fb (git): [rubygems/rubygems] [build, rebuild] Split common find_gemspec() out to GemspecHelpers.
- https://github.com/rubygems/rubygems/commit/2f80a595c4
- 08:03 AM Revision d916dbcb (git): [rubygems/rubygems] Improve formatting of "gem rebuild --help" output.
- https://github.com/rubygems/rubygems/commit/701550f9dd
- 08:03 AM Revision 54d90e13 (git): [rubygems/rubygems] [rebuild] If --diff is not passed and a rebuild fails, suggest passing --diff.
- https://github.com/rubygems/rubygems/commit/7caadd182c
- 08:03 AM Revision dfe83df0 (git): [rubygems/rubygems] [rebuild_command] Bail early if the RubyGems version doesn't match.
- https://github.com/rubygems/rubygems/commit/a691170dc7
- 08:03 AM Revision 88d7be46 (git): [rubygems/rubygems] [rebuild_command] Use Gem.* helpers.
- https://github.com/rubygems/rubygems/commit/8644ce7193
- 08:03 AM Revision fe096f64 (git): [rubygems/rubygems] [rebuild_command] Clean up help text.
- https://github.com/rubygems/rubygems/commit/4446389f2e
- 08:03 AM Revision 54e0b807 (git): [rubygems/rubygems] [rebuild_command] Use temporary directory instead of the working directory.
- https://github.com/rubygems/rubygems/commit/f2e4e5b56f
- 08:03 AM Revision a28087af (git): [rubygems/rubygems] [rebuild_command] Add --diff flag to try using diffoscope.
- https://github.com/rubygems/rubygems/commit/3e9545193a
- 08:03 AM Revision cd12dfd3 (git): [rubygems/rubygems] [rebuild_command] Avoid leaking files.
- https://github.com/rubygems/rubygems/commit/3b88553d0d
- 08:03 AM Revision e5def27f (git): [rubygems/rubygems] Add "gem rebuild" command.
- https://github.com/rubygems/rubygems/commit/6d661573f0
-
06:18 AM Bug #20398: heap-buffer-overflow in numeric literal parsing
- Thank you, that fixed it yes. And it's a much better fix :)
-
04:43 AM Bug #20401: Duplicated when clause warning line number
- This behavior was discovered and briefly discussed during the previous dev meeting. The actual warning is
```
test.rb:4: warning: duplicated 'when' clause with line 2 is ignored
```
According to @nobu, this reads "The 'when' clau... -
- On the otherhand, if you have duplicated hash keys you get:
```ruby
{
bar: 1,
baz: 1,
bar: 1
}
```
For the warning: `warning: key :bar is duplicated and overwritten on line 4`. So this seems correct. -
- When you have a duplicated when clause, you get a warning for it. For example:
```ruby
case foo
when :bar
when :baz
when :bar
end
```
you get ``warning: duplicated `when' clause with line 2 is ignored``.
But the when claus... -
02:16 AM Bug #17996 (Closed): Cygwin: thread + pipe behavior since Ruby 2.6
- https://github.com/ruby/ruby/pull/9357 may be fixed this.
03/28/2024
-
11:13 PM Revision 02d40b6c (git): Use ubf list on cygwin
-
09:41 PM Revision f3c35749 (git): YJIT: Optimize putobject+opt_ltlt for integers
- In `jit_rb_int_lshift()`, we guard against the right hand side changing
since we want to avoid generating variable length shifts. When control
reaches a `putobject` and `opt_ltlt` pair, though, we know that the right
hand side never chan... -
-
- https://github.com/ruby/prism/commit/418318e1c8
-
- https://github.com/ruby/prism/commit/bb78d83e88
-
07:21 PM Revision bb3cbdfe (git): YJIT: add iseq_alloc_count to stats (#10398)
- * YJIT: add iseq_alloc_count to stats
* Remove an empty line
---------
Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com> -
-
07:13 PM Feature #20394: Add an offset parameter to `String#to_i`
- byroot (Jean Boussier) wrote in #note-10:
> `StringIO` isn't as convenient as you make it out to be. Maybe it could become that, but it isn't today.
Hmm, it's not like it matters very much, but I get the weird feeling you misundersto... -
08:54 AM Feature #20394: Add an offset parameter to `String#to_i`
- > but rest assured once we can start using IO::Buffer exclusively, I will do so.
I'd be curious to see an HTTP1 parser using IO::Buffer. I don't see how you'd do it today. -
08:52 AM Feature #20394: Add an offset parameter to `String#to_i`
- My protocol gems have been around since Ruby 2.3+ so there are compatibility issues, but rest assured once we can start using `IO::Buffer` exclusively, I will do so. Using `String` for IO buffers is equally fraught with odd issues like e...
-
- > What about IO::Buffer? It was introduced somewhat stealthily and its API is somewhat unique, and yet by its idea it seems to be exactly that.
I'm aware of it, but it only offer binary oriented methods. Perhaps it could be extended t... -
07:20 AM Feature #20394: Add an offset parameter to `String#to_i`
- > I'd be all for a dedicated `Buffer` class that allow to efficiently parse text protocols like HTTP and RESP3, but right now all we got is String.
What about [IO::Buffer](https://docs.ruby-lang.org/en/master/IO/Buffer.html)? It was i... -
- > This interpretation mismatch could be a source of vulnerability.
Good catch @mame, that does indeed make the `to_i` proposal much more problematic. I guess I don't really have much of a proposal anymore.
> ...
Not today no. You c... -
- I thought of a security concern.
I suppose all methods proposed in this ticket would allow underscores as a digit separator. This is natural in Ruby, but usually an unnecessary feature outside of Ruby, including the Redis protocol.
T... -
- Right now there are specs for the order in which `BEGIN{}` should be executed, which is the order they appear in the file. For example:
```ruby
BEGIN { print "1" }
print "4"
BEGIN { print "2" }
print "5"
BEGIN { print "3" }
```
... -
-
-
- https://github.com/ruby/prism/commit/f540e830b5
-
- https://github.com/ruby/prism/commit/020756fb11
-
-
- https://github.com/ruby/prism/commit/2068e3c30a
-
03:54 PM Revision 97b2cc34 (git): Allow FormatError to take either String or Gem for source
- Most of the calls to `FormatError.new` pass `@gem` for the second argument, which has a `path` method.
But in one case—on package.rb:691 in `verify_gz`, the `source` argument is a `String`.
So if there's ever a GZip decode error when a... -
03:54 PM Revision fa0a6241 (git): Don't check for dynamic symbol when reference updating
- All symbols in the GC are dynamic symbols, so we don't need to check it.
-
-
02:48 PM Revision 7055dcf9 (git): [ruby/prism] Improve description for InterpolatedStringNodeFlags
- https://github.com/ruby/prism/commit/caa576d63f
-
- Applied in changeset commit:git|2ab9fb1c2e659f1f819ed63796171b2129255185.
----------
[Bug #20398] Terminate token buffer at invalid octal number -
- Does this fix it?
```diff
diff --git a/parse.y b/parse.y
index 585130c3465..55619273b8e 100644
--- a/parse.y
+++ b/parse.y
@@ -10164,6 +10164,7 @@ parse_numeric(struct parser_params *p, int c)
/* prefixed octal */
... -
- https://github.com/ruby/ruby/pull/10393 should fix this
-
- I found the following ASAN error in `TestRubyLiteral#test_integer`. It appears that this code is calling strdup on a non-null terminated string.
```
[1/1] TestRubyLiteral#test_integer==================================================... -
- For the given script:
```ruby
#!/bin/sh
# -*- ruby -*-
exec "${RUBY-ruby}" "-x" "$0" "$@" && [ ] if false
#!ruby
# This needs ruby 2.0, Subversion and Git.
# As a Ruby committer, run this in an SVN repository
# to commit a chan... -
-
-
08:41 AM Feature #19057: Hide implementation of `rb_io_t`. - "ioquatix (Samuel Williams) via ruby-core" <ruby-core@ml.ruby-lang.org> wrote:
> Issue #19057 has been updated by ioquatix (Samuel Williams).
>
>
> > Why don't you reconsider the "nested public interface" approach?
>
> My asses... -
06:52 AM Misc #20336: DevMeeting-2024-04-17
- * [Bug #19865] Segfault when calling user signal handlers during VM shutdown
* Seems like the bug is well understood and there is a patch for it (https://github.com/nobu/ruby/tree/signal-at-cleanup), can it be merged? -
- Any chance this could be backported into Ruby 3.2? It was a bit tricky because of the VWA-related changes in 3.3, but I did manage to open a PR to do this: https://github.com/ruby/ruby/pull/10394
I'm running into this problem with the... -
- We use the following site for that now:
* https://tools.ietf.org/ or http
* https://datatracker.ietf.org or http
Today, IETF said the official site of RFC is www.rfc-editor.org.
FYI: https://authors.ietf.org/en/references-in-rfcxml
I... -
-
-
01:15 AM Revision 84236132 (git): Launchable: Configure OS correctly in macos.yaml
03/27/2024
-
- I merged another few PR's related to unit tests in ASAN builds:
https://github.com/ruby/ruby/pull/10383
https://github.com/ruby/ruby/pull/10384
https://github.com/ruby/ruby/pull/10385
https://github.com/ruby/ruby/pull/10386 - 10:49 PM Revision dc9d2455 (git): Add a missing asan_unpoisoning_p in gc_set_candidate_object_i
- It walks the heap, and checks for T_NONE and T_ZOMBIE objects, so it
needs to unpoison these slots before accessing them when ASAN is
enabled. - 10:48 PM Revision 75234beb (git): Make TestParallel#test_retry_workers consider RUBY_TEST_TIMEOUT_SCALE
- This test currently fails if RUBY_TEST_TIMEOUT_SCALE is set, because the
worker timeout is scaled out but the duration of the sleep does not;
thus, the test-test-case does not timeout when it should. - 10:48 PM Revision 7bdd742c (git): Set ASAN_OPTIONS=disable_coredump=0 for test_execopts_rlimit test
- By default, ASAN sets RLIMIT_CORE to zero, "to avoid dumping a 16T+ core
file" on 64 bit systems. These tests are just asserting on the expected
value of RLIMIT_CORE, not actually dumping core files, so it's fine to
disable that behaviou... - 10:48 PM Revision 8c7b9bd0 (git): Disable ASAN handle_segv in test_rubyoptions.rb
- ASAN registers a sigsegv handler and causes extra output to be emitted
that these tests are not expecting. -
-
- mame (Yusuke Endoh) wrote in #note-6:
> Generalizing, we may want `IO#scanf`, but that's probably overkill?
This previously existed in the stdlib but was removed: #16170
byroot (Jean Boussier) wrote in #note-7:
> ...
With Stri... -
- > The idea of an offset in a string is perfectly represented via the cursor in IO/StringIO
Indeed, but the problem is that you then have very few methods to parse values or peak in the buffer to find elements. Lots of methods needed f... -
- As @eregon said, `String#to_i(offset:)` with byte offset looks strange to me.
I like `IO#get_i(base=10)` and `StringIO#get_i` (despite the name).
I was a little concerned that it returns infinitely large Bignum when the IO reads "9... -
-
- https://github.com/ruby/prism/commit/85263ade63
-
06:31 PM Bug #20395: Invalid license note in vsnprintf.c
- But wait, maybe the ["old style" license](https://github.com/ruby/ruby/blame/e51014f9c05aa65cbf203442d37fef7c12390015/LEGAL#L1091-L1119) is crippled and it should really contain the additional paragraph, because otherwise as far as I und...
-
- Actually, there is one more occurrence of this situation:
https://github.com/ruby/ruby/blob/51e6becd391eac03fd3842e1db9b6907999d64ba/LEGAL?plain=1#L1090-L1093
and there is some history:
https://github.com/ruby/ruby/commit/cb47ae... -
- nobu (Nobuyoshi Nakada) wrote in #note-1:
> Should we remove that note simply?
Yes, that seems to like something which should have been part of that commit. -
-
- https://github.com/ruby/prism/commit/faadd05693
-
-
-
-
05:41 PM Feature #20390 (Closed): Issue with StringIO and chilled strings
- Applied in changeset commit:git|0f5ab4ad5289d6385b74e800a73de005a48737b6.
----------
[ruby/stringio] Eagerly defrost chilled strings
[Feature #20390]
https://github.com/ruby/stringio/commit/17ee957f34
Co-authored-by: Jean Boussier <b... -
- https://github.com/ruby/stringio/commit/0da5b725c8
-
- https://github.com/ruby/stringio/commit/4e8e82fc30
-
- [Feature #20390]
https://github.com/ruby/stringio/commit/17ee957f34
Co-authored-by: Jean Boussier <byroot@ruby-lang.org> -
-
- The LEGAL file seems to contain [obsolete information](https://github.com/ruby/ruby/blob/a69f0047cb489c136001937442c1d2ffd8ea1dd7/LEGAL?plain=1#L730-L746) about nkf license.
It seems that nkf indeed use such license, but in upstream, ... -
-
- https://github.com/ruby/prism/commit/af0204a8ab
-
04:55 PM Feature #20396: ObjectSpace.dump_all(string_value: false): skip dumping the String contents
- This is a great addition! I've often used a post-processing script to remove the string data, so having it built in would be very helpful.
I think `false` would be a good default (but either way is fine by me). -
- > false on default is safer?
Agreed. Safer and faster. I only set it to `true` on default to not change the current behavior, but wouldn't mind flipping it to `false` by default. -
08:48 AM Feature #20396: ObjectSpace.dump_all(string_value: false): skip dumping the String contents
- false on default is safer?
-
- `ObjectSpace.dump_all` is a very useful method to debug memory leaks and such, hence is frequently needed in production. But since all the 7bit strings content is included in the dump, it incur the risk of leaking personal data, or secre...
-
-
- This is an optimization for compaction so that we only lookup in the
obj_to_id_tbl table only when FL_SEEN_OBJ_ID is set. -
02:12 PM Revision e4d64797 (git): Add array/hash implicit allocation tests
- These are designed to prevent allocation regressions (commits that
increase the number of implicitly allocated arrays and hashes). We
have already had three commits in the last couple weeks to fix
allocation regressions:
* 15dc3aaa311b3... -
- This is to stop crashes like:
.\miniruby.exe: [BUG] Segmentation fault
ruby 3.4.0dev (2024-03-26T15:38:26Z pull/10370/merge 040ea2ae2f) [x64-mswin64_140]
-- Control frame information ----------------------------------------... -
- This reverts commit 3680981c7b71df8c3a426164787ccefe5296bb25.
-
-
- Since ICLASS do not mark the classpath, we need to register it as a
global object before we convert RubyVM::FrozenCore as a ICLASS. -
- If a GC runs right during creating a rb_fix_to_s_static, it may cause
the previous ones to become swept by the GC because they have not been
registered by rb_vm_register_global_object. -
-
-
-
-
-
-
-
11:48 AM Bug #19716: SystemStackError occurs too easily on Alpine Linux (due to small stack size reported by pthread_attr_getstacksize on musl libc)
- hsbt (Hiroshi SHIBATA) wrote in #note-5:
> We welcome patch for them.
[Patch](https://bugs.ruby-lang.org/attachments/7081) has been available for for years. https://bugs.ruby-lang.org/issues/19716#note-2 confirms it still works for... -
-
- Unfortunately, there is no active maintainer for musl or alpine platform.
I tagged them to [musl](https://bugs.ruby-lang.org/projects/ruby-master/issues?fields%5B%5D=issue_tags&operators%5Bissue_tags%5D=%3D&set_filter=1&values%5Bissue... - 11:34 AM Revision 44b5c912 (git): [rubygems/rubygems] Allow installing plugins from path via CLI
- Also bring the man page up to date.
https://github.com/rubygems/rubygems/commit/a849bd6947 -
- 06:59 AM Revision 6498c439 (git): Update bundled gems list as of 2024-03-26
-
-
- This reverts commit a31ca3500d995b6706f94ff72166d699c5faeb27 which
broke debug inspector API. -
-
-
- TruffleRuby temporary
(https://github.com/ruby/strscan/pull/91)
The methods were added in #89 but they aren't implemented in TruffleRuby
yet. So let's omit them for now to have CI green.
https://github.com/ruby/strscan/commit/844d963b56 - 03:16 AM Revision 8896ac02 (git): [ruby/openssl] Fix test_pkey_dsa.rb in FIPS.
- Note that I created the `dsa2048.pem` and signature text
(`signature_encoded.txt`), that is used as a text to create the `signature0` in
the `test_sign_verify` by the following steps with the `openssl` CLI on FIPS
module.
```
$ OPENSSL_... -
- Sorry to my late action.
I recovered your account at redmine, github and our canonical repository. -
-
- Unfortunately, there is no active maintainer for musl or alpine platform.
I tagged them to [musl](https://bugs.ruby-lang.org/projects/ruby-master/issues?fields%5B%5D=issue_tags&operators%5Bissue_tags%5D=%3D&set_filter=1&values%5Bissue... -
-
- Unfortunately, there is no active maintainer for musl or alpine platform.
I tagged them to [musl](https://bugs.ruby-lang.org/projects/ruby-master/issues?fields%5B%5D=issue_tags&operators%5Bissue_tags%5D=%3D&set_filter=1&values%5Bissue... -
- Unfortunately, there is no active maintainer for musl or alpine platform.
I tagged them to [musl](https://bugs.ruby-lang.org/projects/ruby-master/issues?fields%5B%5D=issue_tags&operators%5Bissue_tags%5D=%3D&set_filter=1&values%5Bissue...
03/26/2024
-
- If an exception is raised the FBuffer is leaked.
For example, the following script leaks memory:
o = Object.new
def o.to_json(a) = raise
10.times do
100_000.times do
begin
JSON(o)
rescue
... - 10:52 PM Revision b2b665eb (git): [DOC] remove repetitive words in comments
- Signed-off-by: crazeteam <lilujing@outlook.com>
-
- Nobu approved this change on the PR, so I've merged it: https://github.com/ruby/ruby/commit/a7ff264477105b5dc0ade6facad4176a1b73df0b
I'll introduce a separate PR to add the test to ruby-spec. -
- @nobu can you please review <https://github.com/ruby/ruby/pull/10365> thanks!
Some more background found by @mame:
- Originally introduced in <https://github.com/ruby/ruby/commit/2d5061bd98a59fc1b9a477074f8f7a3500db8342>. It looks ... -
- In the following program, the behaviour of the parent process is affected by whether `Process.fork` is invoked or not.
```ruby
Thread.handle_interrupt(RuntimeError => :never) do
Thread.current.raise(RuntimeError, "Queued error")
... - 09:10 PM Revision a7ff2644 (git): Don't clear pending interrupts in the parent process. (#10365)
-
07:32 PM Feature #20394: Add an offset parameter to `String#to_i`
- Dan0042 (Daniel DeLorme) wrote in #note-4:
> It doesn't seem like String#getbyte is much faster than File#getbyte, and StringIO#getbyte is fastest of all.
I'm seeing a similar result to what you show above with YJIT disabled, but `s... -
- byroot (Jean Boussier) wrote in #note-3:
> We tried this, but it was way slower (https://github.com/redis-rb/redis-client/pull/150), we haven't dug much as to why. But generally I'd love if I could just rely on the internal IO buffer in... -
- > I think #19315 is a more general solution for this.
I don't think so, because for the `to_i` case at least, you can already do this today with `byteslice`:
```ruby
def parse_int(offset)
@buffer.byteslice(offset, -1).to_i
end
```
B... -
11:21 AM Feature #20394: Add an offset parameter to `String#to_i`
- BTW I think the custom String#to_i makes a lot of sense, and might be faster than String#to_i because it needs to handle fewer cases and can e.g. handle reading directly from an IO vs going through a String in between.
-
- I think #19315 is a more general solution for this.
It feels unidiomatic to add `offset` kwargs to core methods just to avoid substrings, I think we should make substrings faster instead.
For unpack it's more natural to have an offse... -
- ### Context
I maintain the `redis-client` gem, and it comes with an optional swapable implementation in C that binds the `hiredis` C client, [which used to performs up to 5 times faster in some cases](https://github.com/redis-rb/redis... -
-
06:41 PM Revision 4a78d752 (git): [ruby/prism] Fix an incorrect range of `Prism::Location` when `PM_ERR_RETURN_INVALID`
- This PR fixes the following incorrect range of `Prism::Location` when `PM_ERR_RETURN_INVALID`.
It may be hard to tell from the text, but this Ruby error highlights `return`:
```console
$ ruby -e 'class Foo return end'
-e:1: Invalid ret... -
06:33 PM Revision 696b2716 (git): Return stdbool from recursive_check()
- The return value is used as a boolean value in C. Since it's not used as
a Ruby object, it just seems confusing that it returns a VALUE. -
06:29 PM Revision e16086b7 (git): Refactor init_copy gc attributes
- This PR moves `rb_copy_wb_protected_attribute` and
`rb_gc_copy_finalizer` into a single function called
`rb_gc_copy_attributes` to be called by `init_copy`. This reduces the
surface area of the GC API.
Co-authored-by: Peter Zhu <peter@p... -
- similarly to 332f4938cf3adbff8f15b647767dc660583a5bef
-
- It gives true/TRUE (int) instead of Qtrue (VALUE).
-
-
05:53 PM Revision 4bdb7961 (git): Mark frame info structs with rb_gc_mark_movable
- Using rb_gc_mark_movable and a reference update function, we can make
frame infos movable in memory, and avoid pinning frame info backtraces.
```
require "objspace"
exceptions = []
GC.disable
50_000.times do
begin
raise "some exce... -
-
- https://github.com/ruby/prism/commit/f49261a9b9
-
- https://github.com/ruby/prism/commit/c1400d8aed
-
- https://github.com/ruby/prism/commit/50372fee5c
-
03:02 PM Bug #20168: Process won't exit when Ractor.select waiting a Ractor
- I think I have encountered the same issue. I was able to reproduce the problem using a simpler code that results in a process hang when a Ractor, which internally raises an exception, is passed to `Ractor.select`.
Here is the minimal co... -
-
- https://github.com/ruby/prism/commit/c7a7af1eac
-
- Should we remove that note simply?
-
- I am looking into Ruby licenses and I stumble upon vsnprintf.c, namely about these lines:
~~~
/*
* IMPORTANT NOTE:
* --------------
* From ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change
* paragraph 3 above is n... -
- Some extensions (like stringio) may need to differentiate between
chilled strings and frozen strings.
They can now use rb_str_chilled_p but must check for its presence since
the function will be removed when chilled strings are removed.... -
- https://github.com/ruby/irb/commit/2057248e40
-
- Applied in changeset commit:git|a850cd1a87bef738c40d9c550fb8823699083f2e.
----------
[Bug #20392] Block arguments duplication check at `super` -
- jeremyevans0 (Jeremy Evans) wrote in #note-4:
> It's missing entries for `NODE_SUPER` and `NODE_ZSUPER` in `get_nd_args`, so the `nd_args` are ignored for those nodes. At least those node types should be fixed, and all other node types... -
- https://github.com/ruby/ruby/pull/10361
-
12:57 AM Bug #20392: Delegate super calls with a block
- tenderlovemaking (Aaron Patterson) wrote in #note-3:
> Dan0042 (Daniel DeLorme) wrote in #note-1:
> ...
It's missing entries for `NODE_SUPER` and `NODE_ZSUPER` in `get_nd_args`, so the `nd_args` are ignored for those nodes. At least t... -
- Dan0042 (Daniel DeLorme) wrote in #note-1:
> In Ruby 3.2, example 3 raised an exception "both block arg and actual block given"
> ...
Thanks, I should have checked older versions. According to git bisect, this was introduced in fdc329... -
- `super(...){}`should be a syntax error, just as `foo(...){}` is.
`super` behavior in general is special. For example, `super(arg)` is not a zsuper, but still passes the block implicitly, you have to do `super(arg, &nil)` to avoid p... -
- After finding the "if if" typo, some additional typos identified by running `codespell` are also being corrected:
https://github.com/codespell-project/codespell
https://github.com/ruby/prism/commit/e6a34cfeeb -
-
- (maybe) from 9cf754b the test fails on some environments:
https://rubyci.s3.amazonaws.com/icc-x64/ruby-master/log/20240325T200004Z.fail.html.gz
```
1) Failure:
TestGc#test_gc_stress_at_startup [/home/chkbuild/chkbuild/tmp/build/20240... -
- Implemented `Hash.new(capacity:)` in https://github.com/ruby/ruby/pull/10357
-
- For the time being, how about using rubylang/ruby image?
https://hub.docker.com/r/rubylang/ruby/
Currently, there is no core developer in Ruby responsible for alpine (or musl) support. Therefore, I don't think there is currently an... -
- https://github.com/ruby/ruby/pull/9673#issuecomment-2019028293
03/25/2024
-
- In Ruby 3.2, example 3 raised an exception "both block arg and actual block given"
So this looks like a Ruby 3.3 regression. -
- I'm seeing strange behavior with calls to `super` when combined with `...` and a block. I'm not sure if this is expected behavior or not, so I'm filing this ticket.
Using delegate `...` with an explicit block will cause an error:
... -
- This mainly targets things like `T.unsafe()` from Sorbet, which is just an
identity function at runtime and only a hint for the static checker.
Only deal with simple caller and callees (no keywords and splat etc.).
Co-authored-by: Takas... -
09:47 PM Bug #20391 (Feedback): Segmentation fault at 0x0000000000000028 on Ruby 3.3.0
- When running a couple apps on Digital Ocean Kubernetes, I am getting a segmentation fault. Reverting to 3.2.3 fixes the error.
I am currently using ruby:3.3.0-alpine3.19 from dockerhub.
=> Booting Puma
=> Rails 7.1.3.2 application ... - 07:45 PM Revision aa900138 (git): [rubygems/rubygems] Fix: vendor_gem takes a block
- https://github.com/rubygems/rubygems/commit/50cda56fc3
-
07:45 PM Revision 06d5d4f1 (git): [rubygems/rubygems] Fix resolver bug where ActivationRequest objects were not properly compared
- They were delegating their `#hash` value to a class not overriding that
method, and so were returning inconsistent results.
https://github.com/rubygems/rubygems/commit/723e4ee0fc -
- https://github.com/ruby/prism/commit/48f2e8c169
-
- https://github.com/ruby/prism/commit/d00977a9bd
-
- https://github.com/ruby/prism/commit/58a127cd5d
-
- ruby_env_debug_option gets called after Init_gc_stress, so the
--debug=gc_stress flag never works. -
-
- https://github.com/ruby/prism/commit/98c85c4acb
-
- https://github.com/ruby/prism/commit/b96bada9ae
-
- https://github.com/ruby/prism/commit/60805d85ca
-
- https://github.com/ruby/prism/commit/aac606301e
-
- https://github.com/ruby/prism/commit/1fbac72485
-
- Using rb_gc_mark_movable and a reference update function, we can make
instruction sequences movable in memory, and avoid pinning compiled iseqs.
```
require "objspace"
iseqs = []
GC.disable
50_000.times do
iseqs << RubyVM::Instruction... - 02:25 PM Revision 55264717 (git): [rubygems/rubygems] Improve validation of `bundle plugin install` options
- Ensure only one source type is specified, and ensure options that
are only relevant to git sources are only specified with git.
https://github.com/rubygems/rubygems/commit/58b043215e -
- This PR fixes the following build error for C99 and C23 Ruby's CI matrix:
```console
../src/prism/prism.c:1241:19: error: initializing 'char *' with an expression of
type 'const char *' discards qualifiers [-Werror,-Wincompatible-pointe... -
01:13 PM Revision 3b4dacf2 (git): Let the docs of base_label and label be similar
-
- Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
-
-
12:16 PM Revision 54428c2b (git): [ruby/prism] Add missing symbol in comment for binding powers for `||=`
- This adds in the descriptive comment the `||=` operator corresponding to `PM_TOKEN_PIPE_PIPE_EQUAL` for pm_binding_powers[PM_TOKEN_MAXIMUM] in prism.c
https://github.com/ruby/prism/commit/315ca16e23 -
- This fixes some comment typos in English in the prism.c file. It fixes some typos and follows the current conventions:
- Sentences in comments end with `.`
- Use infinitive instead of 3rd person present simple to describe functions
http... -
- Fixes https://github.com/ruby/prism/pull/2617.
There was an issue with the lexer as follows.
The following are valid regexp options:
```console
$ bundle exec ruby -Ilib -rprism -ve 'p Prism.lex("/x/io").value.map {|token| token[0].type... - 12:14 PM Revision 9b921f66 (git): Update default gems list at daf1d7bfefa89a0473af9b304a3798 [ci skip]
-
12:13 PM Revision f5a2f55a (git): [ruby/prism] Use Sexp#line_max not Sexp#max_line
- for RubyParser translation
https://github.com/ruby/prism/commit/a37169621a -
12:13 PM Revision daf1d7bf (git): [ruby/reline] Bump version to v0.5.0
- (https://github.com/ruby/reline/pull/664)
https://github.com/ruby/reline/commit/1d6569600c -
11:48 AM Revision f53209f0 (git): [ruby/irb] Cache RDoc::RI::Driver.new
- (https://github.com/ruby/irb/pull/911)
* Cache RDoc::RI::Driver.new to improve performance and to avoid flaky test
* Insert sleep to fix flaky rendering test that renders document dialog
https://github.com/ruby/irb/commit/da84e6cb56 -
11:06 AM Revision 5f334b67 (git): [ruby/reline] Remove useless tests
- (https://github.com/ruby/reline/pull/665)
The pasting tests hadn't been working since as early as v0.2.0. Since
what it tried to cover is already gone for such a long time, I think it's
better to write new ones if needed then to keep th... -
- Followup: https://github.com/ruby/ruby/pull/10347
This avoid directly referencing bootsnap and zeitwerk, and also
handle other gems that may decorate `require`. -
- They were pointing to branches to be chilled string compatible.
Both patches have been merged now. -
- Thank you @nobu, I was about to look into it :)
-
- Applied in changeset commit:git|fdd7ffb70ca6e9f7d790aadde86dbc8172e19f4d.
----------
[Bug #20389] Chilled string cannot be a shared root -
- We need to purge `git ls-files` from gemspec in default gems.
-
- > the nagging from chilled strings
Eric, I understand that it won't make your annoyance go away, but just in case you didn't know, if you wish to get rid of these warnings easily, you can add `# frozen_string_literal: false` at the t... -
- Fix incorrect warning target with Zeitwerk and support warning with Bootsnap.
-
07:42 AM Bug #19161: Cannot compile 3.0.5 or 3.1.3 on Red Hat Enterprise Linux 7
- > From here, I found a simple workaround: ./configure cflags="-std=gnu99". Just FYI.
> ...
Just a notice/heads-up that when modifying CFLAGS you need to remember to keep optimization flags "-O2"/"-O3".
Failure to build Ruby with opti... - 06:39 AM Revision 6c65f11c (git): Bump github/codeql-action from 3.24.8 to 3.24.9
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.8 to 3.24.9.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md... -
- http://rubyci.s3.amazonaws.com/crossruby/crossruby-master-aarch64/log/20240325T041917Z.fail.html.gz
-
- This reverts commit e720a6b48582900efd1bd326210644b2fc0f2c5d.
-
-
-
-
-
-
- 03:57 AM Bug #20310 (Closed): ASAN fake stacks need to be marked during GC for non-current execution context
- Applied in changeset commit:git|48d3bdddbaeabed5fb6a97bfbe65e250d1383a9c.
----------
Move asan_fake_stack_handle to EC, not thread
It's really a property of the EC; each fiber (which has its own EC) also
has its own asan_fake_stack_han... - 03:57 AM Revision 69579ed5 (git): Mark fiber stacks in rb_execution_context_mark
- Currently, fiber stacks are marked separately from the rest of the
execution context. The fiber code deliberately does _NOT_ set
ec->machine.stack_end on the saved EC, so that the code in
`rb_execution_context_mark` does not mark it; ins... - 03:57 AM Revision 2535a09e (git): Check ASAN fake stacks when marking non-current threads
- Currently, we check the values on the machine stack & register state to
see if they're actually a pointer to an ASAN fake stack, and mark the
values on the fake stack too if required. However, we are only doing
that for the _current_ thr... - 03:57 AM Revision 48d3bddd (git): Move asan_fake_stack_handle to EC, not thread
- It's really a property of the EC; each fiber (which has its own EC) also
has its own asan_fake_stack_handle.
[Bug #20310] -
- After reviewing `async-io`, it looks like `wait_readable` and `wait_writable` might not be interrupted by `close`, leading to some odd behaviour.
-
-
- It holds the root directory for each type of default gem (ext/ or lib/).
-
-
-
- So that it also includes requirable features provided by extensions.
-
-
- Instead of hardcoded "ext".
-
- 12:28 AM Revision 95864a6e (git): Bump dependabot/fetch-metadata from 1.6.0 to 2.0.0
- Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.6.0 to 2.0.0.
- [Release notes](https://github.com/dependabot/fetch-metadata/releases)
- [Commits](https://github.com/dependabot/fetch-metadata/compar...
03/24/2024
-
11:34 PM Revision e86a6191 (git): Lrama v0.6.5
-
- This is being discussed at https://github.com/ruby/stringio/pull/93
-
03:46 PM Feature #20390 (Closed): Issue with StringIO and chilled strings
- StringIO doesn't appear to handle chilled strings in a backwards-compatible way after 12be40ae
```ruby
require "stringio"
sio = StringIO.new("")
sio.write("hello")
```
When not specifying a value for `frozen-string-literal`, ... -
- It is more 2 years since #5109, probably enough time to warn.
https://github.com/rubygems/rubygems/commit/1e9433e77f -
- These macros have not been used since the commit "Stop exporting
symbols for MJIT" 233ddfac541749a0da80ea27913dc1ef4ea700bb, and
renamed as RJIT. -
- tagging @byroot @etienne
-
- Commit 12be40ae introduced the concept of "chilled" strings when code is compiled with frozen-string-literals not explicitly enabled or disabled. I believe I've found a related bug, which I've bisected to this commit.
This reproductio... -
- (https://github.com/ruby/reline/pull/663)
https://github.com/ruby/reline/commit/4928e06a24 -
- (https://github.com/ruby/irb/pull/908)
https://github.com/ruby/irb/commit/7c16ce033e -
- (https://github.com/ruby/reline/pull/658)
* Add mode_string to prompt calculation dependencies
* Update vi show-mode-in-prompt test
https://github.com/ruby/reline/commit/a0cee06ec5 -
- (https://github.com/ruby/reline/pull/645)
* Add assertion assert_cursor_line to test helper
* Autofix key_actor test to use assert_cursor_line
* Rename the assertion to assert_line_around_cursor and remove other assertions for line an... -
- Eric, thanks for your comment. I understand your concern about Ruby's incompatibility.
Sometimes it is inevitable to introduce incompatibilities to improve a language specification (you may not agree with me here), but I believe that ...
03/23/2024
-
- It is known that macos-14 runner is small to run CodeQL.
-
- used
(https://github.com/ruby/reline/pull/661)
https://github.com/ruby/reline/commit/3719702808 -
- mutable
(https://github.com/ruby/reline/pull/662)
This avoids the frozen literal warning in Ruby 3.4.
https://github.com/ruby/reline/commit/cccb985804 -
- > Why don't you reconsider the "nested public interface" approach?
My assessment of this approach is that it would require a rewrite of internal code that accesses `rb_io_t` private outer struct. Rewriting code isn't a problem, but it t... - 06:31 PM Feature #19057: Hide implementation of `rb_io_t`.
- ioquatix (Samuel Williams) wrote:
> - Companies could contact Eric and offer incentives for him to make a release.
That's not possible, https://yhbt.net/unicorn/ISSUES states:
The author of unicorn must never be allowed to profit... -
- When `RUBY_DEBUG` is set, accessing a class in an invalid object will
cause a breakpoint trap instead of a segfault on some implementations. -
-
-
-
- cc @tenderlovemaking because red-black shape cache. Maybe the backtrace speaks to you.
-
07:01 AM Bug #20330: [BUG] Segmentation fault at 0xffffffffffffffff
- nobu (Nobuyoshi Nakada) wrote in #note-1:
> Seems related to shape and jemalloc.
Im not to sure what that means
but i don't think its an issue with jemalloc here is the stack trace for the normal ruby image
```
2024-03-23T06... -
- https://github.com/ruby/win32ole/commit/8d443417a9
-
- https://github.com/ruby/win32ole/commit/f4aff99dda
-
- https://github.com/ruby/win32ole/commit/22facf50fd
-
- 06:59 AM Revision a15b2443 (git): Update bundled gems list as of 2024-03-22