Activity
From 03/13/2024 to 03/19/2024
03/19/2024
-
11:12 PM Feature #8421: add Enumerable#find_map and Enumerable#find_all_map
- zverok (Victor Shepelev) wrote in #note-4:
> @alexbarret There is a somewhat lesser-known trick which looks pretty close to your code:
> ...
Thanks I learned something, and it makes sense thinking about it.
Both `and` and `break` aren't ... -
- jeremyevans0 (Jeremy Evans) wrote in #note-5:
> `find_map` seems like a bad name as there is no map. map implies calling the same function over all elements in a collection, and in this case, there would be a single element (or none if n... -
10:46 PM Feature #8421: add Enumerable#find_map and Enumerable#find_all_map
- `find_map` seems like a bad name as there is no map. map implies calling the same function over all elements in a collection, and in this case, there would be a single element (or none if nothing was found). Combining `find` and `then` ...
-
08:50 PM Feature #8421: add Enumerable#find_map and Enumerable#find_all_map
- @alexbarret There is a somewhat lesser-known trick which looks pretty close to your code:
```ruby
# proposal:
find_map(emails) do |email|
(matches = pattern.match(email)) && matches[:identifier]
end
# a "trick"
emails.find { |em... -
- Can we reconsider introducing `#find_map` please, especially since `#find_all_map` has been introduced as `#filter_map` in Ruby in 2.7?
Here are some examples
```ruby
require "minitest/autorun"
# Option 1
def identifier(emails, ... -
09:06 PM Feature #20350 (Closed): Return chilled string from Symbol#to_s
- During Ruby 2.7 development there was an attempt to return a frozen string from Symbol#to_s (#16150#note-22)
This had to be rolled back due to incompatibility, but now we have chilled strings (#20205)
Symbol#to_s can safely return ... -
-
- This proposal is made redundant by #20205 chilled strings. Please close.
-
- > it's debatable whether the benefit outweigh the maintenance burden long term.
Yeah, good point. And if truly necessary we could get a chilled string with `eval(str.inspect)` anyway. -
07:00 PM Feature #20205: Enable `frozen_string_literal` by default
- > Would it be possible to have a ruby API for chilled strings? Something like str.chill or String.chill(str)
It's technically very easy to implement, yes. Would need to be a separate feature request though.
Also one drawback is tha... -
- Thank you for this great feature!
Would it be possible to have a ruby API for chilled strings? Something like `str.chill` or `String.chill(str)` ...
> - `String#+@`: acts as if the string was mutable.
Nitpick: actually, `String#+@` ... -
08:27 AM Feature #20205 (Closed): Enable `frozen_string_literal` by default
- Applied in changeset commit:git|12be40ae6be78ac41e8e3f3c313cc6f63e7fa6c4.
----------
Implement chilled strings
[Feature #20205]
As a path toward enabling frozen string literals by default in the future,
this commit introduce "chilled ... -
08:01 PM Feature #20349: Pattern Matching - Expose local variable captures
- This would make every pattern matching a lot slower which seems a big no-no performance wise.
I think that's enough to reject this proposal.
Because it would force to create that binding/Hash eagerly in case `PatternMatch.last_match` i... -
05:58 PM Feature #20349 (Open): Pattern Matching - Expose local variable captures
- In Regular Expressions we have the ability to utilize `Regexp.last_match` ([link](https://ruby-doc.org/3.2.2/Regexp.html#method-c-last_match)) to access the most recent match data from a regular expression match. I would like to propose ...
-
06:14 PM Revision 0a107027 (git): [ruby/prism] Fix a diagnostic incompatibility
- This PR fixes a diagnostic incompatibility when using no anonymous keyword rest parameter:
```ruby
foo(**)
```
Note, although the actual update applies only to the `foo(**)` case, for reference,
`foo(*)` and `foo(&) are also mentioned ... -
- This PR fixes a diagnostic incompatibility for `Prism::Translation::Parser` when using constant argument:
```ruby
def foo(A)
end
```
## Parser gem (Expected)
Displays `formal argument cannot be a constant (Parser::SyntaxError)`:
```c... -
05:59 PM Revision cbcb2d46 (git): [DOC] Unify Doxygen formats (#10285)
-
- This has been fixed in the master branch. However, I'm not sure which commit fixed it.
-
10:47 AM Bug #20348 (Closed): Memory leak with method kwargs in ERB template
- Evaluating ERB templates with kwarg method calls leads to unbounded growth in memory use.
Example script:
```ruby
require "erb"
def noop(kwarg1:); end
template = ERB.new("<%= noop kwarg1: false %>")
50.times do
10_000.... - 02:18 PM Revision 5c293773 (git): Update default gems list at d7bc6f0effa1531a12b5c6b6286805 [ci skip]
-
02:17 PM Misc #20279 (Closed): Is the implementation of `respond_to_missing?` in BasicObject documentation correct? - Applied in changeset commit:git|e127289632396f268099c9815a59bc7e7f13b3ec.
----------
[Bug #20279] [DOC] Update for `BasicObject`
The current implementation raises on the call to super -
02:17 PM Revision d7bc6f0e (git): [ruby/reline] Reline 0.5.0.pre
- (https://github.com/ruby/reline/pull/614)
* Re-architecture LineEditor's internal state and rendering
* Fix test related to LineEditor re-architecture
* Bump to 0.5.0.pre.1
* Hide cursor only when updating screen. Frequent hide&show ... -
12:49 PM Revision e1272896 (git): [Bug #20279] [DOC] Update for `BasicObject`
- The current implementation raises on the call to super
-
12:33 PM Feature #19057: Hide implementation of `rb_io_t`.
- As an alternative (optional) course of action, I've released the latest head of unicorn as `unicorn-maintained` gem. You can use this instead of `unicorn` and it will work on Ruby head.
https://github.com/unicorn-ruby/unicorn
Anyone wh... -
- > From the reaction to this ticket, it is clear that forcing the "hide all the details" approach could destroy the Ruby ecosystem.
"destroy the Ruby ecosystem" seems an exaggeration if it's just `unicorn` not working, because there wa... -
- Here is the revert PR: https://github.com/ruby/ruby/pull/10283
-
- The simplest option right now is to revert this change and try again later.
@mame are there any other gems apart from `unicorn` you are concerned about? In other words, if `unicorn` makes a release, then you don't have a problem with ... -
03:07 AM Feature #19057: Hide implementation of `rb_io_t`.
- I agree with @mame. This change would break too many tests, apps, etc. We cannot accept the change at the moment.
Can we be more conservative?
Matz.
-
02:35 AM Feature #19057: Hide implementation of `rb_io_t`.
- Why don't you reconsider the "nested public interface" approach?
From the reaction to this ticket, it is clear that forcing the "hide all the details" approach could destroy the Ruby ecosystem. And there is no need to force it because... -
09:10 AM Feature #20347 (Closed): Separate docs task from all
- I would like to migrate RDoc as bundled gems at Ruby 3.5.
We need to handle `install-doc` and related task with that. I removed `docs` task from `all` and re-order `docs` task at `install-all`.
https://github.com/ruby/ruby/pull/102... -
- [Feature #20205]
As a path toward enabling frozen string literals by default in the future,
this commit introduce "chilled strings". From a user perspective chilled
strings pretend to be frozen, but on the first attempt to mutate them,
... - 05:55 AM Revision 86b15316 (git): Bump github/codeql-action from 3.24.7 to 3.24.8
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.7 to 3.24.8.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md... -
- Sounds nice. Go ahead.
Matz.
-
02:36 AM Feature #20345: Add `--target-rbconfig` option to mkmf
- Code to load the last one only.
```ruby
target_rbconfig = nil
ARGV.delete_if do |arg|
unless (opt = arg.delete_prefix("--target-rbconfig=")) == arg
target_rbconfig = opt
end
end
if target_rbconfig
# Loa... -
02:36 AM Feature #20345: Add `--target-rbconfig` option to mkmf
- > It seems ambiguous when multiple --target-rbconfig options are given.
Nice catch, I prefer to respect the last one only to allow it to be overridden by trailing arguments. -
- It seems ambiguous when multiple `--target-rbconfig` options are given.
Your patch uses the first one and leaves the rest.
I think all options should be removed, and which would be preferable?
1. load the first one only
2. load the l... -
12:27 AM Feature #20345: Add `--target-rbconfig` option to mkmf
- +1 as well.
- 02:56 AM Revision 59849fee (git): Bump actions/checkout from 4.1.1 to 4.1.2
- Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](http... - 02:17 AM Revision 6c18b247 (git): Update default gems list at 0985e587901a9039ee0f523d285ed3 [ci skip]
-
- https://github.com/ruby/resolv/commit/44ae1e8531
-
-
01:30 AM Revision ce544f8d (git): [ruby/prism] [Compatibility] Improve printf format
- For better compatibility, this patch suggests using __MINGW_PRINTF_FORMAT that GCC provides for MINGW environment.
https://github.com/ruby/prism/commit/a3a792b64f - 01:27 AM Revision 6c1e8029 (git): [ruby/did_you_mean] Do not use #inspect to avoid unexpected performance degradation
- closes https://github.com/ruby/did_you_mean/pull/100
https://github.com/ruby/did_you_mean/commit/bd11eefd6c
03/18/2024
-
08:39 PM Revision 3f5f04af (git): Remove duplicated function prototype rb_gc_disable_no_rest
-
07:09 PM Feature #20276: Introduce Fiber interfaces for Blocking operations on Ractors
- ioquatix (Samuel Williams) wrote in #note-7:
> If I had to take a guess, I'd say it's a bug with waiting on a Ractor while handling signals?
Under closer inspection, the `Thread#join` workaround should work in theory but actually dea... -
- When using a `Ractor.take` inside a different thread, `Thread#join` on the thread running `Ractor.take` fails to call `FiberScheduler.unblock`. The below code can replicate this behavior
```ruby
require "async"
class RactorWrapper
... -
06:18 PM Revision 0b34b75b (git): [PRISM] Remove unnecessary dependencies in common.mk
-
06:01 PM Feature #20345: Add `--target-rbconfig` option to mkmf
- These patches are very small and focused, this makes a lot of sense to me.
-
- Here are patches for Nokogiri and rake-compiler:
- https://github.com/kateinoigakukun/nokogiri/commit/c70ee8ea8ae2c46f84a6275ae8ef47b748dce685
- https://github.com/kateinoigakukun/rake-compiler/commit/78f99cea613c81c0562ed6b75c598b6ae38f... -
- > I ported nokogiri gem to WebAssembly/WASI with this change
Can you share a pointer to this code? As a maintainer of Nokogiri and of rake-compiler-dock I'm very interested in seeing how this might simplify the toolchain.
-
## Motivation
Today, CRuby runs on many platforms. But not all platforms are capable of running build tools (e.g. WebAssembly/WASI), so cross-target compilation against extensions libraries is essential for those platforms.
We c...-
- https://github.com/ruby/prism/commit/edece87801
-
- https://github.com/ruby/prism/commit/1219a709e4
-
- If there are many searches in the `$LOAD_PATH` in the user environment,
require will perform unnecessary searches that are not needed.
In contrast, `require_relative` is efficient because it uses a relative path.
https://github.com/ruby... -
04:02 PM Revision 802e857a (git): YJIT: Support arity=-2 cfuncs (#10268)
- This type of cfuncs shows up as consume a lot of cycles in profiles of
the lobsters benchmark, even though in the stats they don't happen that
frequently. Might be a bug in the profiling, but these calls are not
too bad to support, so mi... -
-
-
03:40 PM Feature #20329: Clean up `--dump` sub-options
- nobu (Nobuyoshi Nakada) wrote in #note-5:
>
> ...
seems like a good idea. -
- eightbitraptor (Matthew Valentine-House) wrote in #note-4:
> ```
> ...
This looks nice.
Would `--dump=insns --dump=-opt` have the same effect with `--dump=insns,-opt`? -
- This file produces argument stack underflow, since ruby 2.5.
```ruby
proc do
next if true
case nil
when "a"
next
when "b"
when "c"
proc {}
end
next unless true
end
```
```
-- raw disasm-------... -
-
-
- It's not used outside of gc.c.
-
- 11:42 AM Revision cb029fa4 (git): [rubygems/rubygems] Deprecate `bundle plugin install --local-git=`
- It's the exact same implementation as --git
https://github.com/rubygems/rubygems/commit/18eb2418c6 -
- I don't use `unicorn` so thanks for the clarification. Maybe someone who does know, can write some documentation about the current state of affairs and how to use the current head. My trivial `gem build` and `gem install` seemed to work,...
-
- > are you able to point it at the git head?
You can't just do that because Unicorn has a bunch of files that need to be generated and are not compiled. So you need a custom fork: https://github.com/k0kubun/unicorn/commit/6215d4cad7a96... -
- @mame are you able to point it at the git head?
e.g.
```ruby
gem "unicorn", git: "https://yhbt.net/unicorn.git"
# or
gem "unicorn", git: "https://github.com/socketry/unicorn.git"
```
That should get things moving again.
I... -
- This change has broken our internal CI. Because our CI contributes to assure the quality of Ruby master, it is a shame that it will not work until the release of unicorn, which we do not know when (and whether) it will be released. I hop...
-
- Followup: https://github.com/ruby/ruby/pull/10017
[Feature #13557] -
07:49 AM Revision 454b939d (git): Launchable: Remove unused codes
-
- Integer.sqrt uses Newton's method.
This pull request reduces the precision which was unnecessarily high in each calculation step. -
03:32 AM Revision dcfbe36c (git): Update unmerged RBS to debug `EBADF` error (#10275)
- Update bundled_gems
-
02:37 AM Revision e6487a92 (git): [ruby/irb] docs(help): Add latest options to ja help message
- (https://github.com/ruby/irb/pull/903)
https://github.com/ruby/irb/commit/3c6d452495 -
- * [Feature #19057] Hide implementation of `rb_io_t`
* This change has broken our internal CI. Because our CI contributes to assure the quality of Ruby master, it is a shame that it will not work until the release of unicorn, which we ...
03/17/2024
-
10:55 PM Revision dc06375c (git): [rubygems/rubygems] Ignore commented out keys in config file
- https://github.com/rubygems/rubygems/commit/c4a8d2a930
-
- This is expected as that syntax was removed. See #19918
-
- In Ruby 3.4.0's Ripper, there is the following incompatible behavior:
## Expected (Ruby 3.3)
It is expected that tokens will be returned.
```console
$ ruby -rripper -ve "p Ripper.sexp('foo[bar, &baz] += 1')"
ruby 3.3.0 (2023-1... -
- - Simplify globbed file names.
- Prefer `File.open` over `Kernel#open`.
- Swallow initializer blocks instead of line by line with flip-flop.
- Re-structure converter list. -
-
- This reverts commit 301fa452f7a9cdea922103e9c50d85a2d5652d0d.
-
-
-
- Applied in changeset commit:git|0d5b16599a4ad606619228623299b931c48b597b.
----------
[Bug #20218] Reject keyword arguments in index -
- Applied in changeset commit:git|df5ef282337764508a1e1d93459d7a280e46647c.
----------
[Bug #19918] Reject block passing in index -
- [Bug #19918]
[Bug #20218] -
-
03/16/2024
-
- This PR fixes token incompatibility for `Prism::Translation::Parser::Lexer` when using backquoted heredoc indetiner:
```ruby
<<-` FOO`
a
b
FOO
```
## Parser gem (Expected)
Returns `tXSTRING_BEG` as the first token:
```console
$... -
04:27 PM Revision 815c7e19 (git): Avoid caller-side hash allocation for f(*a, kw: 1) and f(*a, kw: 1, &block)
- Previously, this used:
```
splatarray false
duphash
getlocal/getblockparamproxy # in the block passing case
send ARGS_SPLAT|KW_SPLAT|KW_SPLAT_MUT
```
This changes the duphash to putobject, with putobject using
a frozen version of the h... -
- (https://github.com/ruby/irb/pull/901)
* Always save irb_history in HOME or XDG_CONFIG_HOME
Also split irbrc search logic from irb_history search logic as a refactor
* Remove IRB.conf[:RC_NAME_GENERATOR] because it's not configurable
... -
-
-
01:51 PM Revision 137b52a8 (git): [ruby/irb] Use markdown format for docs
- (https://github.com/ruby/irb/pull/890)
* Convert irb.rb's document into markdown format
* Hide should-be-private top-level methods from docs
* Skip xmp.rb's docs
* Declare lib/irb.rb's markup do it works in ruby/ruby too
* Ignore do... -
- https://github.com/ruby/ruby/pull/10271
I'm not sure these methods should print the warning too. -
- With this file:
```ruby
# load.rb
public def f = :ok
```
It is OK when `require`d.
```sh-session
$ ruby -r ./load.rb -e 'p f'
:ok
```
Simple `load` is OK too.
```sh-session
$ ruby -e 'load ARGV[0]; p f' load.rb
:ok
... -
09:51 AM Revision f1682407 (git): [ruby/did_you_mean] Avoid division for small length2
- https://github.com/ruby/did_you_mean/commit/cb518e251a
-
- The variable ``length2`` is an Integer, call to floor returns self.
The variables ``i`` and ``prefix_bonus`` are equally incremented, no need to keep the ``i`` variable.
https://github.com/ruby/did_you_mean/commit/4408802289 -
03:40 AM Feature #19787: Add Enumerable#uniq_map, Enumerable::Lazy#uniq_map, Array#uniq_map and Array#uniq_map!
- rubyFeedback (robert heiler) wrote in #note-6:
> Ultimately you only have to convince matz. :)
> ...
Thanks, that's a good point re: backwards compatibility.
> I am not really invested in the proposal here, so I will not comment m... -
- austin (Austin Ziegler) wrote in #note-5:
> Wouldn’t it make more sense, then, to do `uniq { … }.map { … }`? Yes, there’s a *small* bit of extra code, but it means that you’re in most cases going to be performing *less work* than either...
03/15/2024
-
- Lately there has been a few flaky YJIT CI failures where a new Ruby
thread is finding the canary on the VM stack. For example:
https://github.com/ruby/ruby/actions/runs/8287357784/job/22679508482#step:14:109
After checking a local rr r... -
-
- ```ruby
# shareable_constant_value: literal
C = [foo, bar]
```
results in
```
./ruby: [BUG] unexpected node: NODE_LIT
``` -
- This PR fixes token incompatibility for `Prism::Translation::Parser::Lexer`
when using escaped backslash in string literal:
```ruby
"\\ foo \\ bar"
```
## Parser gem (Expected)
```console
$ bundle exec ruby -Ilib -rparser/ruby33 -ve \... -
- This PR fixes a token incompatibility between Parser gem and `Prism::Translation::Parser`
for the heredocs_leading_whitespace.txt test.
https://github.com/ruby/prism/commit/7d45fb1eed -
- c20e819e8b04e84a4103ca9a036022543459c213 made calling a method
that accepts specific keywords but not a keyword splat with a keyword
splat allocating a hash when it previously did not.
Instead of duplicating the hash and removing hash e... -
-
- In preparation for https://bugs.ruby-lang.org/issues/20205.
The `frozen_string_literal` compilation option will no longer
be a boolean but a tri-state: `on/off/default`. -
-
-
- For all intent and purposes, `__FILE__` is a string literal subject
to the `# frozen_string_literal: true/false` comment and to the
global `--enable-frozen-string-literal / --disable-frozen-string-literal`
CLI flags.
https://github.com/... - 01:23 PM Revision ec4333c9 (git): [DOC] exceptions.rdoc : Add heads up about ensure not returning implicitly
- There is a weird gotcha I already forgot twice.... and regret not to have found in doc.
See https://dev.to/okuramasafumi/be-sure-ensure-doesn-t-return-value-implicitly-8gp -
01:21 PM Revision 077ac25e (git): Iterate the documentation of Module.const_missing
-
- This matches the existing style in the rest of the file.
-
-
-
- Under a configuration including `cppflags=-DUNIVERSAL_PARSER`, warnings listed below show in build time:
```
node.c:396:30: warning: initialization left-hand side might be a candidate for a format attribute [-Wsuggest-attribute=format]
... -
-
-
- > Subtle cases like { 1.0 => a, 1.00 => b } and { "\x00" => a, "\0" => b } were also discussed, and some committers wants to keep the warning for the cases, but Matz said no need to warn such cases.
Oh I see, I didn't understand that ... -
- > But we don't want to remove the warnings, so the compiler will need to warn for those cases?
At the dev meeting, Matz said that the compiler doesn't need to warn those cases. He said that just remove the warning except literally con... -
- This PR fixes an AST and token incompatibility between Parser gem and `Prism::Translation::Parser`
for dstring literal:
```ruby
"foo
#{bar}"
```
## Parser gem (Expected)
```console
$ bundle exec ruby -Ilib -rparser/ruby33 -ve \
'buf... -
- https://github.com/ruby/prism/commit/473cfed6d0
-
-
-
-
-
-
- https://github.com/ruby/stringio/commit/779f71359d
-
- I'm neutral to this particular method (could be handy). If thread safety is in mind perhaps atomic compare-and-exchange could be better than just exchange, though.
-
01:49 AM Feature #20300: Hash: set value and get pre-existing value in one call
- nobu (Nobuyoshi Nakada) wrote in #note-17:
> I want `ENV.exchange_value` rather than `Hash#exchange_value`.
Is there a reason to put it on `ENV`, but *not* on `Hash`? That seems like a needless restriction to me. -
-
- shyouhei (Shyouhei Urabe) wrote in #note-8:
> Why not:
Because I didn't think of that :)
I would be okay with it, but I think the thread safety issue is also worth solving. The implementation I'm proposing solves both the performa... -
- Yes. `add(o) unless include?(o)` isn't thread safe already. My implementation just doesn't care to improve that.
-
12:37 AM Bug #20225: Inconsistent behavior of regex matching for a regex has a null loop
- On dev meeting, matz concluded that, but I also think a null-loop bug must be fixed.
However, there are still remaining issues:
- I'm not sure "what the correct behavior of capture-aware null-loop detection".
(I also am not sure... -
12:27 AM Revision 3fcab3cd (git): [ruby/rdoc] Use readline history when ri is interactive
- https://github.com/ruby/rdoc/commit/d0074a23cc
- 12:10 AM Revision 193ebc3c (git): [ruby/rdoc] test: Add tests for RDoc::TokenStream#add_tokens, add_token ,collect_tokens and pop_token
- https://github.com/ruby/rdoc/commit/9ed530b8f9
03/14/2024
-
- This was broken during the refactoring in 22e488464a412afa58f201c49e54773aa8011320.
-
- >At least it seems useful to have some data and extra details on it (the last paragraph).
I see. Thanks for your investigation.
To be precise, there wasn't time to talk about wrapper files. We only discuss about https://bugs.ruby-l... -
- OK, thank you. I wanted to make sure my concern on that is clear.
At least it seems useful to have some data and extra details on it (the last paragraph). -
- >What about yaml and readline?
There is no conclusion yet. I understood your concern. Do not rush this. -
- @hsbt What about [yaml](https://github.com/ruby/yaml/blob/master/lib/yaml.rb) and [readline](https://github.com/ruby/readline/blob/master/lib/readline.rb)?
I think these are not worth moving to bundled gems, i.e. the gains are (AFAIK) v... -
- Thanks @Eregon and @jeremyevans0 .
I mostly agreed your comments. And I discussed this at DevMeeting 2024/03/14.
* No one against about `ostruct`. I will do that.
* We should consider to run `irb` without `gem "irb"` of Gemfile un... -
-
-
- In this example:
```ruby
C, = { foo: bar }
```
You get:
```
== disasm: #<ISeq:<main>@test.rb:1 (1,0)-(1,17)>
0000 putobject :foo ( 1)[Li]
0002 putself
0003 opt_send_witho... -
- Sorry, this is actually even simpler:
```ruby
# shareable_constant_value: literal
C = { bar => baz }
``` -
- ```ruby
foo(
# shareable_constant_value: literal
(C = { bar => baz })
)
``` -
07:19 PM Misc #20028: I'd like my commit bit back
- (I'd like to get started triaging ruby/rdoc issues and PRs ASAP... too much bitrot)
-
- GAH! Took me long enough! https://github.com/ruby/git.ruby-lang.org/pull/79 ❤️
-
-
- This is to be consistent with the mark_object_ary that is in the VM.
-
- * YJIT: Let yjit_perf.py support perf with Python disabled
* Update yjit.md about perf
* Recommend the extra interface by default -
- As preparation for https://bugs.ruby-lang.org/issues/20205
making sure the test suite is compatible with frozen string
literals is making things easier. -
- Applied in changeset commit:git|8e1831406ffd385213f67baba0d1fe6d44e9e0ea.
----------
[Feature #20265] Remove rb_newobj and RB_NEWOBJ -
- Discussed at the dev meeting, and @matz said "go ahead".
-
-
-
- 04:27 PM Revision bd42c172 (git): Backport #20096 to Ruby 3.3 (#9471)
- Fix memory overread in registry.rb
The terminator is not actually getting filled in; we're simply passing
(two) bytes of empty memory as the NUL terminator. This can lead to
garbage characters getting written to registry values.
Fix th... - 04:27 PM Revision 606dd03e (git): [Bug #20208] Revert "Set AI_ADDRCONFIG when making getaddrinfo(3) calls for outgoi… (#9791)
- Revert "Set AI_ADDRCONFIG when making getaddrinfo(3) calls for outgoing conns"
This reverts commit 673ed41c81cf5a6951bcb2c3dec82d7bd6ea7440. -
04:26 PM Revision 53f0c5a4 (git): Backport #9498 to Ruby 3.3 (#9805)
- Handle mmap failures for redblack tree cache
The redblack tree cache is totally optional, so if we can't allocate
room for the cache, then just pretend as if the cache is full if mmap
fails
Co-authored-by: Aaron Patterson <tenderlove@r... -
- merge revision(s) 2cc7a56e,b0711b1,db5d9429: [Backport #20209]
YJIT: Avoid leaks by skipping objects with a singleton class
For receiver with a singleton class, there are multiple vectors YJIT can
end up retaini... -
04:20 PM Bug #20150: Memory leak in grapheme clusters
- ruby_3_3 62de3eb5a2e5b1f0f1516dc99241c4c54a1bf691 merged revision(s) b3d612804946e841e47d14e09b6839224a79c1a4.
- 04:09 PM Revision 161545d5 (git): [ruby/reline] Ensure compatibility with frozen string literals
- (https://github.com/ruby/reline/pull/643)
Ref: https://bugs.ruby-lang.org/issues/20205
Ruby is moving forward with enabling frozen string literals
in the future.
Reline being part of the ruby-core test suite should work when
ruby is r... - 03:41 PM Revision d10afe03 (git): [ruby/irb] Rescue from exceptions raised by #name
- (https://github.com/ruby/irb/pull/899)
* Rescue from exceptions raised by #name
Irb might terminate if the class overwrites `name` and raise errors. This commit rescue irb from termination.
* fix for other unknown patterns
https://gi... -
03:40 PM Revision 3822ca98 (git): [ruby/irb] Add disable_irb command to disable debug of binding.irb
- (https://github.com/ruby/irb/pull/898)
* Add disable_irb command to disable debug of binding.irb
* disable_irb doesn't override Kernel.exit
Kernel.exit call is removed because disable_irb does not override Kernel.exit
and workaround t... -
- Right, Range is problematic, and only Range with positive indices seems an weird restriction so I think better no Range.
`Thread.each_caller_location(1, 20)` I think there are basically no use cases for this, so I wouldn't add it to k... -
- > I think omitting the first N frames is useful.
Agreed, that's the only one I want. The reason I started the issue by asking for the same parameters is purely consistency.
Now, if there are valid reasons not to support some (like ... -
- Ah I mistyped, `caller_locations(20)` is of course just setting start, `caller_locations(0, 20)` has no problem, I'll edit my post on Redmine to use the Range form, which is a problem.
-
- I think omitting the first N frames is useful.
However I see little reason to have a `length` or `Range`, one can just `break/return` out of the `Thread.each_caller_location`, and it seems pretty rare to need that.
So I think it's best t... -
- Seems fine to me. Looking at the code, I don't think it would be difficult to implement.
-
- `Thread.each_caller_location` was added to Ruby 3.2 as part of [Feature #16663] and is a very useful API for emitting warnings with a proper source location and similar use cases.
However in many of the cases where I used it, or seen ... -
- * [Feature #20300] Hash: set value and get pre-existing value in one call (eregon)
* It seems generally useful (see latest comments there).
* It is necessary for #20301 (as long as Set is implemented in Ruby, and I think it should).
-
- # The next dev meeting
**Date: 2024/04/17 13:00-17:00** (JST)
Log: *TBD*
- Dev meeting *IS NOT* a decision-making place. All decisions should be done at the bug tracker.
- Dev meeting is a place we can ask Matz, nobu, nurse and o... -
- nobu (Nobuyoshi Nakada) wrote in #note-17:
> I want `ENV.exchange_value` rather than `Hash#exchange_value`.
Agreed it's a generally useful thing (e.g. to swap an env var and later restore it).
So I think we should add it for both Hash a... -
- That implementation is incorrect (i.e. less correct than current implementation), and `Hash#exchange_value` is needed to be thread-safe for Set, see https://bugs.ruby-lang.org/issues/20301.
-
- Discussed at developers meeting. @shyouhei pointed out that `Set#add?` could be improved with a single lookup by looking at the change in size, without this proposal.
https://bugs.ruby-lang.org/issues/20301#note-8
@matz said that w... -
- I want `ENV.exchange_value` rather than `Hash#exchange_value`.
-
- That implementation using `size` is not thread-safe, even on CRuby AFAIK.
For example, if T2 calls `add?` with a new element while T1 calls `add?` with an existing element.
If T1 is just before `m = size` when T2 executes `add(o)`, the... -
- nobu (Nobuyoshi Nakada) wrote in #note-9:
> shyouhei (Shyouhei Urabe) wrote in #note-8:
> ...
My bad. Thank you for correction. -
- shyouhei (Shyouhei Urabe) wrote in #note-8:
> ```ruby
> ...
The return value is inverse.
-
- Why not:
```ruby
def add?(o)
n = size
add(o)
m = size
return n == m ? self : nil
end
```
This implementation involves only one hash lookup.
-
- What is the decision, to return 0 in both cases (like TruffleRegex behaves), and fix the behavior in Onigmo?
As @jirkamarsik explained above, that is the correct and intended behavior for the null loop optimization, which like any opt... -
- This was discussed at the February dev meeting and @matz said "give it a try." @make_now_just Can you proceed it?
- 02:18 PM Revision fafe5db7 (git): merge revision(s) b3d612804946e841e47d14e09b6839224a79c1a4: [Backport #20150] (#10253)
- Fix memory leak in grapheme clusters
[Bug #20150]
String#grapheme_cluters and String#each_grapheme_cluster leaks memory
because if the string is not UTF-8, then the created regex will not
be freed.
... -
02:15 PM Bug #20338: certain **kwsplat calls have regressed allocations over past few ruby releases
- Ah nope never mind, that PR is about methods called with a kwarg splat, which your example is not doing.
-
- I haven’t looked at this at all myself, but it tingled my “this is familiar” sense. Is this the same problem as https://github.com/ruby/ruby/pull/10151 ?
-
02:05 PM Bug #20338 (Closed): certain **kwsplat calls have regressed allocations over past few ruby releases
- Given this script:
```
class Foo
def initialize(**kwargs)
end
end
class Bar
def initialize(y:)
end
end
b = GC.stat[:total_allocated_objects]
1000.times {
Foo.new(y:1)
}
p GC.stat[:total_allocated_objects]-b
... -
- Thank you for the response Matz. I just want to clarify what you're asking for the implementation to be, based on what you're saying (let me know if I misunderstand).
> parser should warn only minimal and apparent cases, no base conve... -
- 1. parser should warn only minimal and apparent cases, no base conversion, no bignum allocation. Handling `_` in the number literals is on the border.
2. I don't want to add complicated checks since prism may be used for small devices t... -
- I understand this ticket as "should the parser be responsible for parse integer values" (because if you have the integer values, these warnings are trivial to implement). I think the parser should absolutely be responsible for parsing in...
-
01:08 PM Bug #20334: Time.to_i truncates a fractional timestamp instead of rounding up
- Bit vague to say in the docs that `to_i` and `to_f` "may return a value that rounds or truncates". Why not just say it truncates? Regardless, I can live with it :)
-
- It is the intended behavior.
http://ruby-doc.com/3.2.2/Time.html#class-Time-label-Epoch+Seconds
> Other retrieval methods such as `Time#to_i` and `Time#to_f`
> ...
-
- Simple steps that can be executed in a ruby interactive shell
```
irb(main):007> t = Time.now
=> 2024-03-14 00:23:55.983885525 +0000
irb(main):008> t.to_f
=> 1710375835.9838855
irb(main):009> t.to_i
=> 1710375835
```
Based o... -
- ruby_3_3 2a84aaf4a8c8d6d6bbb09416711922532b0033fe merged revision(s) 596db9c1f486d6609a4e97d82c8c71b54609fb6f.
-
- ruby_3_3 a889304fed63c3206f27d614ab75219271fb4ca9 merged revision(s) 6c0e58a54e3fda604386d9c409e2a9998bbc9352.
-
- ruby_3_3 577f9c7a8334bb33512f01e7db95f6fb15e280b2 merged revision(s) 37ed86fd3c798e298fad9db6e7df1f3f45e1e03b.
-
- Applied in changeset commit:git|83618f2cfa004accdd1514de7dcbba291aa7e831.
----------
[Feature #20306] Implement ruby_free_at_exit_p
ruby_free_at_exit_p is a way for extensions to determine whether they
should free all memory at shutdown. -
- Discussed at the dev meeting, and @matz said "go ahead".
-
- ruby_free_at_exit_p is a way for extensions to determine whether they
should free all memory at shutdown. -
12:06 PM Misc #20320: Using OSU Open Source Lab native ppc64le/s390x CI services trigged on pull-requests
- > I opened the following issue ticket to request adding Ubuntu jammy container images. In my understanding, maybe we need the container images to run our tests on the environment.
> ...
What I said above was my mistake. According to the... -
- Same for Complex#to_s.
-
- ```
irb(main):001:0> n = Numeric.new
=> #<Numeric:0x00007f81b2308578>
irb(main):004:0> class Numeric; def inspect = super.freeze; end
=> :inspect
irb(main):006:0> Complex(n, 1).inspect
(irb):6:in `inspect': can't modify frozen Stri... -
10:47 AM Bug #20333: segfault while running my tests
- Thanks @shyouhei that seems to be it
-
- Applied in changeset commit:git|315bde5a0f95562f58405a43456ec6715ef20d32.
----------
`Exception#set_backtrace` accept arrays of `Backtrace::Location`
[Feature #13557]
Setting the backtrace with an array of strings is lossy. The result... -
- [Feature #13557]
Setting the backtrace with an array of strings is lossy. The resulting
exception will return nil on `#backtrace_locations`.
By accepting an array of `Backtrace::Location` instance, we can rebuild
a `Backtrace` instance... -
-
- We discussed this at the dev meeting. No one remembered the discussion from over 10 years ago, so we discussed it anew and concluded that this was a no-go.
A naive API design could be `ary.sample(k, weights: [Float])`, but this would ... - 09:55 AM Revision 2a84aaf4 (git): Fix test session reuse but expire (#9824) (#10250)
- merge revision(s) 596db9c1f486d6609a4e97d82c8c71b54609fb6f: [Backport #20090]
[Feature #19370] Blocks without anonymous parameters should not
affect
---
parse.y | 4 ++--
test/... -
- Discussed at the dev meeting, and @matz (Yukihiro Matsumoto) said he wants to take time to consider it. No conclusion is reached.
-
- Discussed at the dev meeting, and @ko1 said the PR looks good to him.
- 09:42 AM Revision a889304f (git): merge revision(s) 6c0e58a54e3fda604386d9c409e2a9998bbc9352: [Backport #20198] (#10252)
- Make sure the correct error is raised for EAI_SYSTEM resolver fail
In case of EAI_SYSTEM, getaddrinfo is supposed to set more detail in
errno; however, because we call getaddrinfo on a thread now, and errno
is th... -
- This was discussed at the February dev meeting and @matz said "give it a try." @alanwu Can you please discuss with @ko1 and proceed it?
-
- Applied in changeset commit:git|8fe86feecdcd0318c9ec88c10d2698beb9878bee.
----------
[Feature #20244] Extract `chdir_lock` and its stuffs -
- [Feature #19982]
-
-
- Make the entire series of message lines a multiline string so that the
`Warning.warn` hook can receive them in a single call. -
- Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
-
-
-
- Applied in changeset commit:git|1ad366134ded1667745dd9fa70919051869f8d6c.
----------
[Feature #20293] Add `Warning.categories` -
- https://github.com/ruby/ruby/pull/10069
-
- I don't accept this proposal for several reasons:
* I don't see significant use-case
* method set for a class should be stable for consistency/understandability
* fragile method set could be bad for object shape and method caching
... -
-
-
- Applied in changeset commit:git|f36a71e26995b69ff72bc132bbcf40ad89571414.
----------
[Bug #20307] Fix `Hash#update` to make frozen copy of string keys -
-
-
-
- This reverts commit 1acbdc76d6ee73bc2a4d490f8809bd128abafc1f.
I need to remove ostruct from Rake or fix bundler example.
https://github.com/ruby/ruby/actions/runs/8277371220/job/22647605911#step:11:3428 -
- Backported to 3.3 by f8f0d342e48a38caac6d32b438c145bb581a51e6
-
- 07:53 AM Revision 577f9c7a (git): Backport 37ed86fd3c798e298fad9db6e7df1f3f45e1e03b (#10248)
- merge revision(s) 37ed86fd3c798e298fad9db6e7df1f3f45e1e03b: [Backport #--ticket=20161]
Fix memory leak in regexp grapheme clusters
[Bug #20161]
The cc->mbuf gets overwritten, so we need to free it to not leak m... - 07:28 AM Revision d5e9942a (git): Update bundled gems list at 04fc9f87be8dd352e7d892b0d6b085 [ci skip]
-
-
- https://github.com/nobu/ruby/tree/arith_seq-infinite-end
-
- Weird a little.
```ruby
seq = 0.step(Float::INFINITY, 10)
p seq.class #=> Enumerator::ArithmeticSequence
p seq.first #=> 0
p seq.first(1) #=> [0.0]
```
-
-
06:11 AM Feature #15554: warn/error passing a block to a method which never use a block
- Matz accepted to try it with `-w` (WOW!) so I'll make a patch.
- 05:22 AM Revision cc141b61 (git): Update bundled gems list at 07b40044ada7f98f67b3807dddeda7 [ci skip]
-
-
- https://github.com/ruby/stringio/commit/8522c90e4b
-
- https://github.com/ruby/stringio/commit/9cc1dfa19c
-
- https://github.com/ruby/stringio/commit/5dd52d4aec
-
- https://github.com/ruby/fcntl/commit/b946e505f1
-
- https://github.com/ruby/fcntl/commit/ed2d725505
-
- https://github.com/ruby/fcntl/commit/a201ed6682
-
- https://github.com/ruby/fcntl/commit/1c7c70fa5d
-
- https://github.com/ruby/fcntl/commit/6a6442a7f8
-
- https://github.com/ruby/fcntl/commit/a99909a90f
-
- I looked into this and the current behavior is deliberate, as there is a comment stating `should not propagate to meta-meta-class` (see `rb_freeze_singleton_class` definition in `class.c`). See related commit commit:d9a597408f0f192ff25ab...
03/13/2024
-
-
-
-
-
06:50 PM Revision 76f9cfd0 (git): [DOC] Array doc (#10199)
-
- https://github.com/ruby/prism/commit/2cdbf81c95
-
-
-
-
- This PR enables the heredocs_nested.txt that was previously skipped testing.
https://github.com/ruby/prism/commit/9c54f7f10b -
- https://github.com/ruby/prism/commit/164de502c9
-
- In the case of the `**` and `&` ambiguous prefixes, incompatibilities
remained among https://github.com/ruby/prism/issues/2513.
https://github.com/ruby/prism/commit/3b8b231aae -
-
- The following parts will not be shown for `-h` option. And not to
reach 80 columns. Some terminal emulators (Windows command prompt at
least) wrap the cursor to the next line when reaching the rightmost
column, before exceeding. -
-
- https://github.com/ruby/prism/commit/64c4f1268b
-
- https://github.com/ruby/prism/commit/097fd2a54f
-
- An explicit `false` is not equivalent to the comment being missing,
because the default can be switched with a runtime flag:
```bash
$ ruby --enable-frozen-string-literal -e 'p "foo".frozen?'
true
```
https://github.com/ruby/prism/comm... -
- This PR fixes an AST and token incompatibility between Parser gem and `Prism::Translation::Parser`
for empty xstring literal.
## Parser gem (Expected)
```console
$ bundle exec ruby -Ilib -rparser/ruby33 -ve \
'buf = Parser::Source::Buf... - 03:47 PM Revision eb408228 (git): [ruby/openssl] test_provider.rb: Make a legacy provider test optional.
- In some cases such as OpenSSL package in FreeBSD[1], the legacy provider is not
installed intentionally. So, we omit a test depending the legacy provider if the
legacy provider is not loadable.
For the test_openssl_provider_names test, ... - 03:47 PM Revision 17179142 (git): [ruby/openssl] Revert "omit tests related legacy provider"
- This reverts commit https://github.com/ruby/openssl/commit/9b7543d58869.
The case not providing the legacy provider can happen not only in FreeBSD but
also in other platforms. The fix is addressed in the next commit.
https://github.com... - 03:19 PM Revision dd5e625d (git): [ruby/openssl] test_asn1.rb: Remove the assertions of the time string format without second.
- This commit fixes the following errors in the tests.
Because the OpenSSL project changed the code to make the time string format
without second invalid. So, we drop the assertions.
```
1) Error: test_generalizedtime(OpenSSL::TestASN1): ... -
-
-
-
-
-
- This removes the assumption about SIZE_POOL_COUNT for shapes.
-
- https://github.com/ruby/prism/commit/62db99f156
-
- https://github.com/ruby/stringio/commit/0205bd1c86
-
-
- This PR makes `Prism` warn `&` interpreted as argument prefix.
This carries a similar meaning to the following Ruby warning:
```console
$ ruby -cwe "foo &bar"
-e:1: warning: `&' interpreted as argument prefix
Syntax OK
```
Previously, ... -
- This PR makes Prism warn `**` interpreted as argument prefix.
This carries a similar meaning to the following Ruby warning:
```console
$ ruby -cwe "foo **bar"
-e:1: warning: `**' interpreted as argument prefix
Syntax OK
```
Previously,... -
- Fixes ruby/prism#2480.
This PR fixes an AST incompatibility between Parser gem and `Prism::Translation::Parser`
for xstring literal with line breaks.
The following case in ruby/prism#2480 has already been addressed in ruby/prism#2576:
... -
- Looking at your crash.log, it seems pg_ext is causing the process termination. After googling around it seems a similar issue is reported to the gem: https://github.com/ged/ruby-pg/issues/311 Not sure if this is the exact problem you a...
-
- Happens when I run `rake` but not `rails test`
Rakefile is
```
require_relative "config/application"
Rails.application.load_tasks
``` -
- No sure how to debug it, I had a segfault while running the tests, maybe you will find it useful.
-
- I don't feel particularly strongly about this, but something about have `+-` in the argument feels a little clunky to me.
I understand the desire to not change the existing options like `--dump=insns`, and that we've got ourselves int... -
- > then it's important to show warnings to the user without running the code.
Indeed. But compiling is not running. That said, I see how this would force language servers to have Ruby around, and some may want to implement a Ruby langu... -
- As a language user, I would expect the parser to be able to warn about the keys that are _literally_ same (i.e. same parser nodes), like `{10.2r => :a, ... 10.2r => :b}` or (obviously more frequently) `{a: 1, .... a: 2}`, but I wouldn't ...
-
12:55 AM Feature #20331: Should parser warn hash duplication and when clause?
- I think it's important for the parser to expose these warnings. If someone uses the parser / AST for building a language server, then it's important to show warnings to the user _without_ running the code.
In general, I think it's imp... -
- Applied in changeset commit:git|a5c5f83b24a1b7024d4e7fe3bbce091634da53b2.
----------
Make `const_source_location` return the real constant as soon as defined
[Bug #20188]
Ref: https://github.com/fxn/zeitwerk/issues/281#issuecomment-18... -
- [Bug #20188]
Ref: https://github.com/fxn/zeitwerk/issues/281#issuecomment-1893228355
Previously, it would only return the real constant location once the
autoload was fully completed. -
04:46 AM Revision 0b7487b4 (git): [ruby/stringio] Various cleanup for JRuby ext
- (https://github.com/ruby/stringio/pull/85)
* Fix compile warnings on latest Java.
* Adjust one test for JRuby erroring on bad pos= value.
* Replace hard JVM synchronization with a spin lock.
* Avoid duplicate reads of state fields where... - 03:38 AM Revision 8c81a6bd (git): Bump actions/checkout in /.github/actions/setup/directories
- Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](http... -
- 03:13 AM Revision 5732e83c (git): Bump github/codeql-action from 3.24.6 to 3.24.7
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.6 to 3.24.7.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md... -
- Since it did not make sense without `--parser=prism` option, just a
duplication. Now it is `--parser=prism --dump=parsetree`. -
- https://github.com/ruby/prism/commit/1d4df7d874
-
- * [Feature #20024] SyntaxError metadata
* Can we add some information to the syntax error about what kind of error produced it?
* What is a good API? (The discussion on the ticket says a symbol for `:type`.)
* [Misc #20238] Use pr... -