Activity
From 03/08/2024 to 03/14/2024
03/14/2024
-
11:11 PM Revision c3887849 (git): Fix array allocation optimization for f(*a, kw: 1)
- This was broken during the refactoring in 22e488464a412afa58f201c49e54773aa8011320.
-
10:36 PM Feature #20309: Bundled gems for Ruby 3.5
- >At least it seems useful to have some data and extra details on it (the last paragraph).
I see. Thanks for your investigation.
To be precise, there wasn't time to talk about wrapper files. We only discuss about https://bugs.ruby-l... -
02:58 PM Feature #20309: Bundled gems for Ruby 3.5
- OK, thank you. I wanted to make sure my concern on that is clear.
At least it seems useful to have some data and extra details on it (the last paragraph). -
- >What about yaml and readline?
There is no conclusion yet. I understood your concern. Do not rush this. -
- @hsbt What about [yaml](https://github.com/ruby/yaml/blob/master/lib/yaml.rb) and [readline](https://github.com/ruby/readline/blob/master/lib/readline.rb)?
I think these are not worth moving to bundled gems, i.e. the gains are (AFAIK) v... -
- Thanks @Eregon and @jeremyevans0 .
I mostly agreed your comments. And I discussed this at DevMeeting 2024/03/14.
* No one against about `ostruct`. I will do that.
* We should consider to run `irb` without `gem "irb"` of Gemfile un... -
-
-
07:39 PM Bug #20340 (Closed): Ractor comments not applying to constant targets
- In this example:
```ruby
C, = { foo: bar }
```
You get:
```
== disasm: #<ISeq:<main>@test.rb:1 (1,0)-(1,17)>
0000 putobject :foo ( 1)[Li]
0002 putself
0003 opt_send_witho... -
- Sorry, this is actually even simpler:
```ruby
# shareable_constant_value: literal
C = { bar => baz }
``` -
- ```ruby
foo(
# shareable_constant_value: literal
(C = { bar => baz })
)
``` -
07:19 PM Misc #20028: I'd like my commit bit back
- (I'd like to get started triaging ruby/rdoc issues and PRs ASAP... too much bitrot)
-
- GAH! Took me long enough! https://github.com/ruby/git.ruby-lang.org/pull/79 ❤️
-
05:52 PM Revision c2170e5c (git): Fix typo from gloabl_object_list to global_object_list
-
- This is to be consistent with the mark_object_ary that is in the VM.
-
05:08 PM Revision b0be2961 (git): YJIT: Let yjit_perf.py support perf with Python disabled (#10246)
- * YJIT: Let yjit_perf.py support perf with Python disabled
* Update yjit.md about perf
* Recommend the extra interface by default -
04:56 PM Revision 09d8c99c (git): Ensure test suite is compatible with --frozen-string-literal
- As preparation for https://bugs.ruby-lang.org/issues/20205
making sure the test suite is compatible with frozen string
literals is making things easier. -
- Applied in changeset commit:git|8e1831406ffd385213f67baba0d1fe6d44e9e0ea.
----------
[Feature #20265] Remove rb_newobj and RB_NEWOBJ -
09:42 AM Feature #20265 (Assigned): Deprecate and remove rb_newobj and rb_newobj_of
- Discussed at the dev meeting, and @matz said "go ahead".
-
-
-
- 04:27 PM Revision bd42c172 (git): Backport #20096 to Ruby 3.3 (#9471)
- Fix memory overread in registry.rb
The terminator is not actually getting filled in; we're simply passing
(two) bytes of empty memory as the NUL terminator. This can lead to
garbage characters getting written to registry values.
Fix th... - 04:27 PM Revision 606dd03e (git): [Bug #20208] Revert "Set AI_ADDRCONFIG when making getaddrinfo(3) calls for outgoi… (#9791)
- Revert "Set AI_ADDRCONFIG when making getaddrinfo(3) calls for outgoing conns"
This reverts commit 673ed41c81cf5a6951bcb2c3dec82d7bd6ea7440. -
04:26 PM Revision 53f0c5a4 (git): Backport #9498 to Ruby 3.3 (#9805)
- Handle mmap failures for redblack tree cache
The redblack tree cache is totally optional, so if we can't allocate
room for the cache, then just pretend as if the cache is full if mmap
fails
Co-authored-by: Aaron Patterson <tenderlove@r... -
04:26 PM Revision cdcabd8a (git): Backport 3.3: YJIT memory leak fix with additional CI fixes (#9841)
- merge revision(s) 2cc7a56e,b0711b1,db5d9429: [Backport #20209]
YJIT: Avoid leaks by skipping objects with a singleton class
For receiver with a singleton class, there are multiple vectors YJIT can
end up retaini... -
04:20 PM Bug #20150: Memory leak in grapheme clusters
- ruby_3_3 62de3eb5a2e5b1f0f1516dc99241c4c54a1bf691 merged revision(s) b3d612804946e841e47d14e09b6839224a79c1a4.
- 04:09 PM Revision 161545d5 (git): [ruby/reline] Ensure compatibility with frozen string literals
- (https://github.com/ruby/reline/pull/643)
Ref: https://bugs.ruby-lang.org/issues/20205
Ruby is moving forward with enabling frozen string literals
in the future.
Reline being part of the ruby-core test suite should work when
ruby is r... - 03:41 PM Revision d10afe03 (git): [ruby/irb] Rescue from exceptions raised by #name
- (https://github.com/ruby/irb/pull/899)
* Rescue from exceptions raised by #name
Irb might terminate if the class overwrites `name` and raise errors. This commit rescue irb from termination.
* fix for other unknown patterns
https://gi... -
03:40 PM Revision 3822ca98 (git): [ruby/irb] Add disable_irb command to disable debug of binding.irb
- (https://github.com/ruby/irb/pull/898)
* Add disable_irb command to disable debug of binding.irb
* disable_irb doesn't override Kernel.exit
Kernel.exit call is removed because disable_irb does not override Kernel.exit
and workaround t... -
- Right, Range is problematic, and only Range with positive indices seems an weird restriction so I think better no Range.
`Thread.each_caller_location(1, 20)` I think there are basically no use cases for this, so I wouldn't add it to k... -
- > I think omitting the first N frames is useful.
Agreed, that's the only one I want. The reason I started the issue by asking for the same parameters is purely consistency.
Now, if there are valid reasons not to support some (like ... -
- Ah I mistyped, `caller_locations(20)` is of course just setting start, `caller_locations(0, 20)` has no problem, I'll edit my post on Redmine to use the Range form, which is a problem.
-
- I think omitting the first N frames is useful.
However I see little reason to have a `length` or `Range`, one can just `break/return` out of the `Thread.each_caller_location`, and it seems pretty rare to need that.
So I think it's best t... -
02:43 PM Feature #20335: `Thread.each_caller_location` should accept the same arguments as `caller` and `caller_locations`
- Seems fine to me. Looking at the code, I don't think it would be difficult to implement.
-
- `Thread.each_caller_location` was added to Ruby 3.2 as part of [Feature #16663] and is a very useful API for emitting warnings with a proper source location and similar use cases.
However in many of the cases where I used it, or seen ... -
- * [Feature #20300] Hash: set value and get pre-existing value in one call (eregon)
* It seems generally useful (see latest comments there).
* It is necessary for #20301 (as long as Set is implemented in Ruby, and I think it should).
-
- # The next dev meeting
**Date: 2024/04/17 13:00-17:00** (JST)
Log: *TBD*
- Dev meeting *IS NOT* a decision-making place. All decisions should be done at the bug tracker.
- Dev meeting is a place we can ask Matz, nobu, nurse and o... -
- nobu (Nobuyoshi Nakada) wrote in #note-17:
> I want `ENV.exchange_value` rather than `Hash#exchange_value`.
Agreed it's a generally useful thing (e.g. to swap an env var and later restore it).
So I think we should add it for both Hash a... -
- That implementation is incorrect (i.e. less correct than current implementation), and `Hash#exchange_value` is needed to be thread-safe for Set, see https://bugs.ruby-lang.org/issues/20301.
-
- Discussed at developers meeting. @shyouhei pointed out that `Set#add?` could be improved with a single lookup by looking at the change in size, without this proposal.
https://bugs.ruby-lang.org/issues/20301#note-8
@matz said that w... -
05:22 AM Feature #20300: Hash: set value and get pre-existing value in one call
- I want `ENV.exchange_value` rather than `Hash#exchange_value`.
-
- That implementation using `size` is not thread-safe, even on CRuby AFAIK.
For example, if T2 calls `add?` with a new element while T1 calls `add?` with an existing element.
If T1 is just before `m = size` when T2 executes `add(o)`, the... -
07:15 AM Bug #20301: `Set#add?` does two hash look-ups
- nobu (Nobuyoshi Nakada) wrote in #note-9:
> shyouhei (Shyouhei Urabe) wrote in #note-8:
> ...
My bad. Thank you for correction. -
- shyouhei (Shyouhei Urabe) wrote in #note-8:
> ```ruby
> ...
The return value is inverse.
-
- Why not:
```ruby
def add?(o)
n = size
add(o)
m = size
return n == m ? self : nil
end
```
This implementation involves only one hash lookup.
-
- What is the decision, to return 0 in both cases (like TruffleRegex behaves), and fix the behavior in Onigmo?
As @jirkamarsik explained above, that is the correct and intended behavior for the null loop optimization, which like any opt... -
- This was discussed at the February dev meeting and @matz said "give it a try." @make_now_just Can you proceed it?
- 02:18 PM Revision fafe5db7 (git): merge revision(s) b3d612804946e841e47d14e09b6839224a79c1a4: [Backport #20150] (#10253)
- Fix memory leak in grapheme clusters
[Bug #20150]
String#grapheme_cluters and String#each_grapheme_cluster leaks memory
because if the string is not UTF-8, then the created regex will not
be freed.
... -
02:15 PM Bug #20338: certain **kwsplat calls have regressed allocations over past few ruby releases
- Ah nope never mind, that PR is about methods called with a kwarg splat, which your example is not doing.
-
- I haven’t looked at this at all myself, but it tingled my “this is familiar” sense. Is this the same problem as https://github.com/ruby/ruby/pull/10151 ?
-
02:05 PM Bug #20338 (Closed): certain **kwsplat calls have regressed allocations over past few ruby releases
- Given this script:
```
class Foo
def initialize(**kwargs)
end
end
class Bar
def initialize(y:)
end
end
b = GC.stat[:total_allocated_objects]
1000.times {
Foo.new(y:1)
}
p GC.stat[:total_allocated_objects]-b
... -
- Thank you for the response Matz. I just want to clarify what you're asking for the implementation to be, based on what you're saying (let me know if I misunderstand).
> parser should warn only minimal and apparent cases, no base conve... -
08:07 AM Feature #20331: Should parser warn hash duplication and when clause?
- 1. parser should warn only minimal and apparent cases, no base conversion, no bignum allocation. Handling `_` in the number literals is on the border.
2. I don't want to add complicated checks since prism may be used for small devices t... -
- I understand this ticket as "should the parser be responsible for parse integer values" (because if you have the integer values, these warnings are trivial to implement). I think the parser should absolutely be responsible for parsing in...
-
01:08 PM Bug #20334: Time.to_i truncates a fractional timestamp instead of rounding up
- Bit vague to say in the docs that `to_i` and `to_f` "may return a value that rounds or truncates". Why not just say it truncates? Regardless, I can live with it :)
-
- It is the intended behavior.
http://ruby-doc.com/3.2.2/Time.html#class-Time-label-Epoch+Seconds
> Other retrieval methods such as `Time#to_i` and `Time#to_f`
> ...
-
- Simple steps that can be executed in a ruby interactive shell
```
irb(main):007> t = Time.now
=> 2024-03-14 00:23:55.983885525 +0000
irb(main):008> t.to_f
=> 1710375835.9838855
irb(main):009> t.to_i
=> 1710375835
```
Based o... -
- ruby_3_3 2a84aaf4a8c8d6d6bbb09416711922532b0033fe merged revision(s) 596db9c1f486d6609a4e97d82c8c71b54609fb6f.
-
- ruby_3_3 a889304fed63c3206f27d614ab75219271fb4ca9 merged revision(s) 6c0e58a54e3fda604386d9c409e2a9998bbc9352.
-
- ruby_3_3 577f9c7a8334bb33512f01e7db95f6fb15e280b2 merged revision(s) 37ed86fd3c798e298fad9db6e7df1f3f45e1e03b.
-
- Applied in changeset commit:git|83618f2cfa004accdd1514de7dcbba291aa7e831.
----------
[Feature #20306] Implement ruby_free_at_exit_p
ruby_free_at_exit_p is a way for extensions to determine whether they
should free all memory at shutdown. -
- Discussed at the dev meeting, and @matz said "go ahead".
-
- ruby_free_at_exit_p is a way for extensions to determine whether they
should free all memory at shutdown. -
12:06 PM Misc #20320: Using OSU Open Source Lab native ppc64le/s390x CI services trigged on pull-requests
- > I opened the following issue ticket to request adding Ubuntu jammy container images. In my understanding, maybe we need the container images to run our tests on the environment.
> ...
What I said above was my mistake. According to the... -
- Same for Complex#to_s.
-
- ```
irb(main):001:0> n = Numeric.new
=> #<Numeric:0x00007f81b2308578>
irb(main):004:0> class Numeric; def inspect = super.freeze; end
=> :inspect
irb(main):006:0> Complex(n, 1).inspect
(irb):6:in `inspect': can't modify frozen Stri... -
10:47 AM Bug #20333: segfault while running my tests
- Thanks @shyouhei that seems to be it
-
- Applied in changeset commit:git|315bde5a0f95562f58405a43456ec6715ef20d32.
----------
`Exception#set_backtrace` accept arrays of `Backtrace::Location`
[Feature #13557]
Setting the backtrace with an array of strings is lossy. The result... -
- [Feature #13557]
Setting the backtrace with an array of strings is lossy. The resulting
exception will return nil on `#backtrace_locations`.
By accepting an array of `Backtrace::Location` instance, we can rebuild
a `Backtrace` instance... -
-
- We discussed this at the dev meeting. No one remembered the discussion from over 10 years ago, so we discussed it anew and concluded that this was a no-go.
A naive API design could be `ary.sample(k, weights: [Float])`, but this would ... - 09:55 AM Revision 2a84aaf4 (git): Fix test session reuse but expire (#9824) (#10250)
- merge revision(s) 596db9c1f486d6609a4e97d82c8c71b54609fb6f: [Backport #20090]
[Feature #19370] Blocks without anonymous parameters should not
affect
---
parse.y | 4 ++--
test/... -
- Discussed at the dev meeting, and @matz (Yukihiro Matsumoto) said he wants to take time to consider it. No conclusion is reached.
-
- Discussed at the dev meeting, and @ko1 said the PR looks good to him.
- 09:42 AM Revision a889304f (git): merge revision(s) 6c0e58a54e3fda604386d9c409e2a9998bbc9352: [Backport #20198] (#10252)
- Make sure the correct error is raised for EAI_SYSTEM resolver fail
In case of EAI_SYSTEM, getaddrinfo is supposed to set more detail in
errno; however, because we call getaddrinfo on a thread now, and errno
is th... -
- This was discussed at the February dev meeting and @matz said "give it a try." @alanwu Can you please discuss with @ko1 and proceed it?
-
- Applied in changeset commit:git|8fe86feecdcd0318c9ec88c10d2698beb9878bee.
----------
[Feature #20244] Extract `chdir_lock` and its stuffs -
- [Feature #19982]
-
-
- Make the entire series of message lines a multiline string so that the
`Warning.warn` hook can receive them in a single call. -
- Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
-
-
-
- Applied in changeset commit:git|1ad366134ded1667745dd9fa70919051869f8d6c.
----------
[Feature #20293] Add `Warning.categories` -
- https://github.com/ruby/ruby/pull/10069
-
- I don't accept this proposal for several reasons:
* I don't see significant use-case
* method set for a class should be stable for consistency/understandability
* fragile method set could be bad for object shape and method caching
... -
-
-
- Applied in changeset commit:git|f36a71e26995b69ff72bc132bbcf40ad89571414.
----------
[Bug #20307] Fix `Hash#update` to make frozen copy of string keys -
-
-
-
- This reverts commit 1acbdc76d6ee73bc2a4d490f8809bd128abafc1f.
I need to remove ostruct from Rake or fix bundler example.
https://github.com/ruby/ruby/actions/runs/8277371220/job/22647605911#step:11:3428 -
- Backported to 3.3 by f8f0d342e48a38caac6d32b438c145bb581a51e6
-
- 07:53 AM Revision 577f9c7a (git): Backport 37ed86fd3c798e298fad9db6e7df1f3f45e1e03b (#10248)
- merge revision(s) 37ed86fd3c798e298fad9db6e7df1f3f45e1e03b: [Backport #--ticket=20161]
Fix memory leak in regexp grapheme clusters
[Bug #20161]
The cc->mbuf gets overwritten, so we need to free it to not leak m... - 07:28 AM Revision d5e9942a (git): Update bundled gems list at 04fc9f87be8dd352e7d892b0d6b085 [ci skip]
-
-
- https://github.com/nobu/ruby/tree/arith_seq-infinite-end
-
- Weird a little.
```ruby
seq = 0.step(Float::INFINITY, 10)
p seq.class #=> Enumerator::ArithmeticSequence
p seq.first #=> 0
p seq.first(1) #=> [0.0]
```
-
-
06:11 AM Feature #15554: warn/error passing a block to a method which never use a block
- Matz accepted to try it with `-w` (WOW!) so I'll make a patch.
- 05:22 AM Revision cc141b61 (git): Update bundled gems list at 07b40044ada7f98f67b3807dddeda7 [ci skip]
-
-
- https://github.com/ruby/stringio/commit/8522c90e4b
-
- https://github.com/ruby/stringio/commit/9cc1dfa19c
-
- https://github.com/ruby/stringio/commit/5dd52d4aec
-
- https://github.com/ruby/fcntl/commit/b946e505f1
-
- https://github.com/ruby/fcntl/commit/ed2d725505
-
- https://github.com/ruby/fcntl/commit/a201ed6682
-
- https://github.com/ruby/fcntl/commit/1c7c70fa5d
-
- https://github.com/ruby/fcntl/commit/6a6442a7f8
-
- https://github.com/ruby/fcntl/commit/a99909a90f
-
- I looked into this and the current behavior is deliberate, as there is a comment stating `should not propagate to meta-meta-class` (see `rb_freeze_singleton_class` definition in `class.c`). See related commit commit:d9a597408f0f192ff25ab...
03/13/2024
-
-
-
-
-
06:50 PM Revision 76f9cfd0 (git): [DOC] Array doc (#10199)
-
- https://github.com/ruby/prism/commit/2cdbf81c95
-
-
-
-
05:35 PM Revision a5ac27e9 (git): [ruby/prism] Turn on heredocs nested test for `Prism::Translation::Parser`
- This PR enables the heredocs_nested.txt that was previously skipped testing.
https://github.com/ruby/prism/commit/9c54f7f10b -
- https://github.com/ruby/prism/commit/164de502c9
-
- In the case of the `**` and `&` ambiguous prefixes, incompatibilities
remained among https://github.com/ruby/prism/issues/2513.
https://github.com/ruby/prism/commit/3b8b231aae -
-
- The following parts will not be shown for `-h` option. And not to
reach 80 columns. Some terminal emulators (Windows command prompt at
least) wrap the cursor to the next line when reaching the rightmost
column, before exceeding. -
-
- https://github.com/ruby/prism/commit/64c4f1268b
-
- https://github.com/ruby/prism/commit/097fd2a54f
-
- An explicit `false` is not equivalent to the comment being missing,
because the default can be switched with a runtime flag:
```bash
$ ruby --enable-frozen-string-literal -e 'p "foo".frozen?'
true
```
https://github.com/ruby/prism/comm... -
- This PR fixes an AST and token incompatibility between Parser gem and `Prism::Translation::Parser`
for empty xstring literal.
## Parser gem (Expected)
```console
$ bundle exec ruby -Ilib -rparser/ruby33 -ve \
'buf = Parser::Source::Buf... - 03:47 PM Revision eb408228 (git): [ruby/openssl] test_provider.rb: Make a legacy provider test optional.
- In some cases such as OpenSSL package in FreeBSD[1], the legacy provider is not
installed intentionally. So, we omit a test depending the legacy provider if the
legacy provider is not loadable.
For the test_openssl_provider_names test, ... - 03:47 PM Revision 17179142 (git): [ruby/openssl] Revert "omit tests related legacy provider"
- This reverts commit https://github.com/ruby/openssl/commit/9b7543d58869.
The case not providing the legacy provider can happen not only in FreeBSD but
also in other platforms. The fix is addressed in the next commit.
https://github.com... - 03:19 PM Revision dd5e625d (git): [ruby/openssl] test_asn1.rb: Remove the assertions of the time string format without second.
- This commit fixes the following errors in the tests.
Because the OpenSSL project changed the code to make the time string format
without second invalid. So, we drop the assertions.
```
1) Error: test_generalizedtime(OpenSSL::TestASN1): ... -
-
-
-
-
-
- This removes the assumption about SIZE_POOL_COUNT for shapes.
-
- https://github.com/ruby/prism/commit/62db99f156
-
- https://github.com/ruby/stringio/commit/0205bd1c86
-
-
- This PR makes `Prism` warn `&` interpreted as argument prefix.
This carries a similar meaning to the following Ruby warning:
```console
$ ruby -cwe "foo &bar"
-e:1: warning: `&' interpreted as argument prefix
Syntax OK
```
Previously, ... -
- This PR makes Prism warn `**` interpreted as argument prefix.
This carries a similar meaning to the following Ruby warning:
```console
$ ruby -cwe "foo **bar"
-e:1: warning: `**' interpreted as argument prefix
Syntax OK
```
Previously,... -
- Fixes ruby/prism#2480.
This PR fixes an AST incompatibility between Parser gem and `Prism::Translation::Parser`
for xstring literal with line breaks.
The following case in ruby/prism#2480 has already been addressed in ruby/prism#2576:
... -
- Looking at your crash.log, it seems pg_ext is causing the process termination. After googling around it seems a similar issue is reported to the gem: https://github.com/ged/ruby-pg/issues/311 Not sure if this is the exact problem you a...
-
- Happens when I run `rake` but not `rails test`
Rakefile is
```
require_relative "config/application"
Rails.application.load_tasks
``` -
- No sure how to debug it, I had a segfault while running the tests, maybe you will find it useful.
-
10:00 AM Feature #20329: Clean up `--dump` sub-options
- I don't feel particularly strongly about this, but something about have `+-` in the argument feels a little clunky to me.
I understand the desire to not change the existing options like `--dump=insns`, and that we've got ourselves int... -
- > then it's important to show warnings to the user without running the code.
Indeed. But compiling is not running. That said, I see how this would force language servers to have Ruby around, and some may want to implement a Ruby langu... -
08:21 AM Feature #20331: Should parser warn hash duplication and when clause?
- As a language user, I would expect the parser to be able to warn about the keys that are _literally_ same (i.e. same parser nodes), like `{10.2r => :a, ... 10.2r => :b}` or (obviously more frequently) `{a: 1, .... a: 2}`, but I wouldn't ...
-
12:55 AM Feature #20331: Should parser warn hash duplication and when clause?
- I think it's important for the parser to expose these warnings. If someone uses the parser / AST for building a language server, then it's important to show warnings to the user _without_ running the code.
In general, I think it's imp... -
- Applied in changeset commit:git|a5c5f83b24a1b7024d4e7fe3bbce091634da53b2.
----------
Make `const_source_location` return the real constant as soon as defined
[Bug #20188]
Ref: https://github.com/fxn/zeitwerk/issues/281#issuecomment-18... -
- [Bug #20188]
Ref: https://github.com/fxn/zeitwerk/issues/281#issuecomment-1893228355
Previously, it would only return the real constant location once the
autoload was fully completed. -
04:46 AM Revision 0b7487b4 (git): [ruby/stringio] Various cleanup for JRuby ext
- (https://github.com/ruby/stringio/pull/85)
* Fix compile warnings on latest Java.
* Adjust one test for JRuby erroring on bad pos= value.
* Replace hard JVM synchronization with a spin lock.
* Avoid duplicate reads of state fields where... - 03:38 AM Revision 8c81a6bd (git): Bump actions/checkout in /.github/actions/setup/directories
- Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](http... -
03:36 AM Revision 7de60d6b (git): Do not fail launchable verify command
- 03:13 AM Revision 5732e83c (git): Bump github/codeql-action from 3.24.6 to 3.24.7
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.6 to 3.24.7.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md... -
- Since it did not make sense without `--parser=prism` option, just a
duplication. Now it is `--parser=prism --dump=parsetree`. -
- https://github.com/ruby/prism/commit/1d4df7d874
-
- * [Feature #20024] SyntaxError metadata
* Can we add some information to the syntax error about what kind of error produced it?
* What is a good API? (The discussion on the ticket says a symbol for `:type`.)
* [Misc #20238] Use pr... -
03/12/2024
-
- https://github.com/ruby/prism/commit/2a2e216558
-
- https://github.com/ruby/prism/commit/f9f3620d44
-
- https://github.com/ruby/prism/commit/01d137a0cb
-
- https://github.com/ruby/prism/commit/909508296e
-
09:25 PM Feature #20276: Introduce Fiber interfaces for Blocking operations on Ractors
- If I had to take a guess, I'd say it's a bug with waiting on a Ractor while handling signals?
-
05:00 AM Feature #20276: Introduce Fiber interfaces for Blocking operations on Ractors
- On a side note, I may have unintentionally discovered an IRB bug in the process. If you run the above in IRB and use Ctrl-C to exit, IRB hangs and becomes unresponsive.
-
- ioquatix (Samuel Williams) wrote in #note-4:
> I support this proposal.
> ...
Tested on locally and it seems to work, at least with Async. Here's my code.
```ruby
Async do |task|
1.upto(3) do
r = Ractor.new do
Ractor.r... -
- This fixes some inconsistencies introduced by that PR.
-
-
- It seems to randomly fail:
```
+ launchable verify
Organization: 'ruby'
Workspace: 'ruby'
Proxy: None
Platform: 'macOS-12.7.3-x86_64-i386-64bit'
Python version: '3.12.2'
Java command: 'java'
launchable version: '1.83.0'
Authentication f... -
06:06 PM Bug #20332 (Feedback): After upgrading to ruby v 3.2.3 rb_scan_args() skips argument value
Hi,
Note: I am not an expert at ruby.
I am working on ibm_db gem, its an adapter developed using ruby C extension, which helps ruby & rails applications to connect to DB2 database.
Here is a github link for its source https://...-
- This test has failed without YJIT too:
https://rubyci.s3.amazonaws.com/debian11/ruby-master/log/20240301T063003Z.fail.html.gz
However, it somehow fails more often on "YJIT Ubuntu / check RUSTC='rustc +1.58.0'" job.
Nobody is actively l... -
- RubyVM::YJIT is conditionally defined, depending on --enable-yjit.
However, RubyVM::YJIT.enabled? is always defined as long as RubyVM::YJIT
is defined, so it seems weird to check RubyVM::YJIT.enabled? instead of
RubyVM::YJIT. -
05:38 PM Feature #20298: Introduce `Time()` type-cast / constructor.
- To give some outside perspective, Rust often uses `from` to convert from a type to another. This could be one option for us
```rb
Time.from(whatever)
``` -
- @mame I understand the example is contrived, but even the core library does different things with different arguments. Let's take [`Random.rand`](https://docs.ruby-lang.org/en/3.3/Random.html#method-c-rand) as an example:
```rb
Random.r... -
- I strongly feel "bad smell" for this proposal.
In principle, one method should do one thing.
But this syntax introduces a completly different branching depending on the arguments, which could encourage a weird method behavior.
In fa... -
- Since VS2013, `link.exe` supports `-manifest:embed` option.
[`/MANIFEST` (Create side-by-side assembly manifest)](https://learn.microsoft.com/en-us/cpp/build/reference/manifest-create-side-by-side-assembly-manifest?view=msvc-170&viewFall... -
- In practice, the `BACKTICK` is mapped either as `:tXSTRING_BEG` or `:tBACK_REF2`.
The former is used in xstrings like `` `foo` ``, while the latter is utilized as
a back reference in contexts like `` A::` ``.
This PR will make correction... -
- * Also add warnings for literals in predicates
* Also create flip-flops in while/until
https://github.com/ruby/prism/commit/a6b5c523c2 -
- Due to ruby/prism#2581, the test case for non_alphanumeric_methods.txt has also been restored.
It also solved issues with `def self.`' not limited to constants for `tBACK_REF2` token.
```console
$ bundle exec ruby -Ilib -rprism -rprism/... -
- https://github.com/ruby/prism/commit/34e521d071
-
- parse.y:2624:1: warning: unused function 'rb_parser_ary_new'
-
- This PR fixes a token incompatibility between Parser gem and `Prism::Translation::Parser` for `tBACK_REF2`:
## Parser gem (Expected)
Returns `tBACK_REF2` token:
```console
$ bundle exec ruby -Ilib -rparser/ruby33 -ve \
'buf = Parser::... -
- Due to #2579, the test case for range_begin_open_inclusive.txt has also been restored.
https://github.com/ruby/prism/commit/da173526a1 -
- This PR restores some heredoc tests that have already passed
for `Prism::Translation::Parser`.
https://github.com/ruby/prism/commit/297b9e2380 -
- This PR fixes a token incompatibility between Parser gem and `Prism::Translation::Parser` for
beginless range:
## Parser gem (Expected)
Returns `tBDOT2` token:
```console
$ bundle exec ruby -Ilib -rparser/ruby33 -ve \
'buf = Parser::S... -
- You don't need an entire bignum library, you only need multiplication and addition. Prism has all of these warnings implemented in https://github.com/ruby/ruby/blob/1e7ee871cbf10375ca149a32d71a29e5e60eed6c/prism/util/pm_integer.c. You're...
-
- > Warnings are not shown by ruby -wc.
Couldn't `ruby -c` be made to compile as well? It's marginally slower but would make sense to me. That would remove the main con from solution 2. -
01:15 PM Feature #20331 (Closed): Should parser warn hash duplication and when clause?
- # Background
Right now, parser warns duplicated hash keys (#1) and when clause (#2).
For example,
```ruby
{1 => :a, 1 => :b}
# => warning: key 1 is duplicated and overwritten on line 1
```
```ruby
case 2
when 1, 1
else
... -
- Previously, when another process sends a fatal signals such as SIGBUS
to Ruby, we could mis-interpret it as a stack overflow Ruby itself
generated. When the si_pid field is set on the signal, we shouldn't
check the si_addr field to check... -
- * [Feature #20331] Should parser warn hash duplication and when clause?
* What is the best approach to handle hash duplication warnings and when clause duplication warnings. -
- Instead of using `assert_in_out_err` directly.
-
- Fixes https://github.com/ruby/prism/pull/2515.
This PR fixes an AST and token incompatibility between Parser gem and `Prism::Translation::Parser`
for string literal with line breaks.
https://github.com/ruby/prism/commit/c58466e5bf -
- Applied in changeset commit:git|76bd586330d98b8a0023ff35c7fa6014ba3a4715.
----------
[Bug #20277] Remove stale `String` test conditionals
These instance variables for conditional execution have remained
unchanged for nearly twenty year... -
- +1
-
- These instance variables for conditional execution have remained
unchanged for nearly twenty years, since YARV merger. -
- Hm. I see. Thanks for the report.
The problem is the following sequence of operations:
* `tp.enable` - This attaches a global event handler to fire the tracepoint for all threads
* `tp.enable { ...` - When the block begins, it set... -
08:17 AM Revision 9a19cfd4 (git): [Universal Parser] Reduce dependence on RArray in parse.y
- - Introduce `rb_parser_ary_t` structure to partly eliminate RArray from parse.y
- In this patch, `parser_params->tokens` and `parser_params->ast->node_buffer->tokens` are now `rb_parser_ary_t *`
- Instead, `ast_node_all_tokens()` int... -
07:54 AM Feature #19742: Introduce `Module#anonymous?`
- A KISS version of the above is to provide `permanent_name?` only, since the other two can be derived with the help of `mod.name.nil?`, and I suspect that there are not a lot of cases in which you need to know if the name is exactly tempo...
-
- @ko1 all the same use cases arrays of strings are currently used for:
E.g. raising an error with an existing backtrace:
```ruby
raise NicerError, "some message", original_error.backtrace_locations
```
Or with some frames skipp... -
- I'm not against but could you summarize usages?
-
- > Yes, but the error mentioned above occurs
I don't get it - what are you doing that make this error happen then? -
-
- Note: https://github.com/ruby/resolv/pull/48 has been merged for this request.
-
-
- https://github.com/ruby/prism/commit/4913d112da
-
- `--dump=insns` will not be changed.
Since `+` is the separator, `insns+-opt` will be same as the current `insns_without_opt`. -
- Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
-
03/11/2024
-
-
- I support this proposal.
A simple way to deal with this right now might be the following code (I have not tested it):
```ruby
Thread.new do
other_ractor.take
end.value
```
In general, the `block`/`unblock` operations shoul... -
- Now, the name of classes and modules can be one of three things:
1. `nil`
2. Temporary
3. Permanent
Maybe it would make sense to provide matching predicates, say:
1. `mod.anonymous?`
2. `mod.temporary_name?`
3. `mod.permanen... - 07:46 PM Revision 132df4d1 (git): [ruby/prism] Document `InstanceVariableWriteNode` fields
- (https://github.com/ruby/prism/pull/2161)
* Document InstanceVariableWriteNode fields
* Reference lexing docs in name field documentation
* Update config.yml
---------
https://github.com/ruby/prism/commit/015b3a857e
Co-authored-by:... - 07:45 PM Revision e407e3f4 (git): [ruby/prism] Document `ClassVariableWriteNode` fields
- (https://github.com/ruby/prism/pull/2162)
* Make ClassVariableWriteNode operator_loc non-nullable
* Document ClassVariableWriteNode fields
* Update config.yml
---------
https://github.com/ruby/prism/commit/659b133888
Co-authored-by... -
-
- https://github.com/ruby/prism/commit/c3fcb5031f
-
- https://github.com/ruby/prism/commit/afac2d6646
-
-
- https://github.com/ruby/prism/commit/665f533373
-
- `RUN_OPTS` environment variable is set but not passed to the test
task, unlike yjit-ubuntu.yml. -
- > This bug should be fairly simple to fix by having `Kernel#freeze` go up the singleton class chain and freeze all currently instantiated singleton classes.
Yeah, that seems the smaller fix for now and at least it fixes a "should-be-i... -
- jeremyevans0 (Jeremy Evans) wrote in #note-4:
> I disagree. If you do not freeze the object's singleton class, then you can define or undefine any method in the singleton class, which is almost the same as being able to modify the obje... -
-
- Let me share the update.
The team at OSU Open Source Lab prepared the infra for us to try the ppc64le/s390x CI services.
We can log the Jenkins CI services by GitHub accounts. Right now only 2 GitHub accounts "ruby" and "junaruga" (m... - 11:00 AM Revision 08961ce8 (git): [ruby/rdoc] Allow rich definition list labels for Markdown
- Previously, any sort of "rich" markup for a definition list's label
would cause the Markdown parser to not recognize a definition list:
```ruby
md = <<~md
`one`
: This is a definition
md
doc = RDoc::Markdown.parse(md)
doc # => [doc:... - 07:26 AM Revision 7a398adc (git): [DOC] security.rdoc: fix YAML security documentation
- Since https://github.com/ruby/ruby/commit/fbb4e3f96c10de2240f2d87eac19cf6f62f65fea
`YAML` does not unmarshal arbitrary ruby objects. -
05:03 AM Revision 5c32b31a (git): Bundle unmerged rbs for testing (#10211)
-
- What will replace `insns`? I don't want to type `insns+opt` every single time. If it stays as is and `insns_without_opt` is changed to `insns-opt` (insns minus opt) or something, I'm good.
-
- Many contributors just include the word `documentation` in titles, but
not utilize `[DOC]` tag or `Documentation` label.
03/10/2024
-
-
- When multiple libraries exist in a subdirectory under `ext`, `rmdir
-p` may fail, because other directories have not been removed yet or
the parent directory has been removed by other `distclean`. `rmdir`
in GNU coreutils has `--ignore-... -
-
-
02:23 PM Feature #15554: warn/error passing a block to a method which never use a block
- Eregon (Benoit Daloze) wrote in #note-19:
> It would need to warn by default to address that.
Or you need to use $VERBOSE, or it could be a new category like `Warning[:strict]`. But it only indicates a *possible* problem, not *defini... -
-
- By replacing `ALLOBJS` suffix with intermediate file suffixes instead
of roughly removing by wildcards. Made `cleanlibs` append `.dSYM`
suffix for each word in `TARGET_SO`, not the end of the entire list. -
- Instead of separate two actions, register the post run at setup.
Co-authored-by: Naoto Ono <onoto1998@gmail.com> -
- Seems related to shape and jemalloc.
Maybe `parent_index` in `redblack_cache_ancestors` is -1?
cc @tenderlovemaking -
10:12 AM Revision b12343c3 (git): merge revision(s) d2cd903c85f38f42c6aefc6d97a1558f74d8d9db:
- [ruby/openssl] pkey/ec: constify
https://github.com/ruby/openssl/commit/6fb3499a7b
---
ext/openssl/ossl_pkey_ec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
03/09/2024
-
- No longer used or generated files/directories sometimes remain
unremoved. -
-
10:33 AM Bug #20330 (Closed): [BUG] Segmentation fault at 0xffffffffffffffff
- I get a segfault from ruby on fly.io (a platform to run full stack apps).
As you can see from the stacktracke im using a jemalloc version but im getting the same crash with the
ruby:3.3.0-slim docker image. (Thats the docker file: htt... -
-
-
-
05:46 AM Revision a6991021 (git): [ruby/rdoc] [DOC] Improve documentation of include directive file search
- Searching the file in the "current directory" could be read as the
directory from which RDoc is run. This is incorrect, as the file is
first searched in the directory containing the current documented file.
Also this directory is search... - 03:50 AM Revision 5ac6194c (git): [ruby/rdoc] Fix ToRdoc generating incorrect {label,name}-lists
- Previously, trying to round-trip label-list and name-lists with the
ToRdoc converter was not possible:
```ruby
doc = <<~RDOC
foo ::
bar ::
hi
RDOC
markup = RDoc::Markup.parse(doc)
markup # => [doc: [list: NOTE [item: ["foo ", "bar"];...
03/08/2024
-
- https://github.com/ruby/prism/commit/b7851f4c2d
-
- https://github.com/ruby/prism/commit/b0935be727
-
- Fixes https://github.com/ruby/prism/pull/2512.
This PR fixes a token incompatibility between Parser gem and `Prism::Translation::Parser`
for `HEREDOC_END` with a newline.
https://github.com/ruby/prism/commit/b67d1e0c6f -
- https://github.com/ruby/prism/commit/4dc58a533a
-
- https://github.com/ruby/prism/commit/7bbe4224a3
- 06:48 PM Revision 4e1d19c4 (git): [ruby/prism] Add initial implementation of `Regexp` validation.
- https://github.com/ruby/prism/commit/6bf1b8edf0
- 06:48 PM Revision d473256a (git): [ruby/prism] Extract a magic value to a named constant.
- https://github.com/ruby/prism/commit/54d14a35a9
- 06:48 PM Revision 82fb6a90 (git): [ruby/prism] Track both the unescaped bytes and source string for a regular expression so we can accurately set its encoding flags.
- https://github.com/ruby/prism/commit/dc6dd3a926
-
06:04 PM Bug #20321: `require': cannot load such file
- Has been done
-
- kjtsanaktsidis (KJ Tsanaktsidis) wrote in #note-10:
> Maybe I’m missing something but it looks like your build worked? I can’t see any error message and the build finishes by installing everything to the right place in /usr/local
Yes... -
- Maybe I’m missing something but it looks like your build worked? I can’t see any error message and the build finishes by installing everything to the right place in /usr/local
-
- kjtsanaktsidis (KJ Tsanaktsidis) wrote in #note-8:
> I need the output that those commands printed, though.
Get [here](https://dist.justman10000.de/log) -
03:45 PM Bug #20328: optparse omits the option's description in the --help output if the description is an Array
- Correct. The `type` (third position) must be a primitive (or custom type, example: [Versionaire](https://alchemists.io/projects/versionaire#_optionparser)).
Keep in mind -- in your first example above -- you *must* supply a required (... -
02:10 AM Bug #20328: optparse omits the option's description in the --help output if the description is an Array
- Ah ha! I suppose also adding an explicit option type class would help differentiate between option's desired value and the description lines?
```ruby
opts.on('-m', '--multiline-opt', String, 'Line one', 'Line two') do |test|
end... -
- The confusion is with the array (third argument) used with your `--multiline-opt` option. If you change it to the following, you'll get the desired result:
``` ruby
opts.on "-m", "--multiline-opt", "Line one", "Line two"
```
The ... -
- Marking `Qnil` or `Qfalse` works fine, having
an extra macro to avoid it isn't needed. -
- This PR fixes the following error for `Prism::Translation::Parser::Lexer` on the main branch:
```console
$ cat example.rb
'a' # aあ
"
#{x}
"
$ bundle exec rubocop
Parser::Source::Range: end_pos must not be less than begin_pos
/Users/koi... - 10:13 AM Revision 4756eaf5 (git): [ruby/rdoc] Fix ToMarkdown missing newlines for label-lists
- Previously, using ToMarkdown on a label-list would generate output that
could not be reparsed by the RDoc::Markdown parser:
```
md = <<~MD
apple
: a red fruit
banana
: a yellow fruit
MD
doc = RDoc::Markdown.parse(md)
doc # => [doc: [l... -
- Currently we have 5 options for `--dump` command line option.
* insns
* insns_without_opt
* yydebug(+error-tolerant)
* parsetree(+error-tolerant)
* parsetree_with_comment(+error-tolerant)
Among these, `insns_without_opt` is a v... -
09:23 AM Revision e8f796e9 (git): [ruby/irb] rdoc version lock is required
- (https://github.com/ruby/irb/pull/897)
Some features of irb do not work properly when using the old rdoc.
I have compared several major versions and found that it works as intended from 4.0.0.
This problem occurs when there is a Gemfil... - 03:27 AM Revision 86ce78d7 (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.89 to 0.9.90.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.89...v0.9.90)
---
updated-depende... -
-