Activity
From 12/29/2023 to 01/04/2024
01/04/2024
-
11:56 PM Revision 6aacbd69 (git): Free pthread_attr after setting up the thread
- [bug #20149]
-
11:44 PM Bug #19409 (Closed): Object's shape is reset after a ractor move
-
10:30 PM Bug #19409: Object's shape is reset after a ractor move
- This has been fixed by https://github.com/ruby/ruby/commit/32c4b0125f9afe11909d1c10e4133e20180e809e, please close. Thanks!
-
11:44 PM Feature #13383: [PATCH] Module#source_location
- If we decided to introduce this feature, I'm against using a plain Array. Let's use a well defined interface.
-
-
- This has been fixed in https://github.com/ruby/ruby/commit/32c4b0125f9afe11909d1c10e4133e20180e809e, please close. Thanks!
-
-
- This can be closed as I agree with the feedback given. Thanks!
-
-
- I believe this was closed prematurely due to an unrelated git commit that wrongly tagged it. Please reopen :)
-
- This is already marked for backport to 3.3, it just needs to be closed.
-
- So my PR has been merged but I believe a backport is desirable for 3.3. I'm not sure who to ping for a backport request. Thanks!
- 10:35 PM Revision dd8157f7 (git): Update default gems list at 5ff1524fde1e1014472ce78746b8f6 [ci skip]
-
10:34 PM Revision 5ff1524f (git): [ruby/erb] Version 4.0.4
- https://github.com/ruby/erb/commit/b68bfed6a8
-
- https://github.com/ruby/erb/commit/f0f68baf6b
-
09:27 PM Revision 10b9679f (git): [ruby/rdoc] Tweaks to Markup Reference
- https://github.com/ruby/rdoc/commit/05ac6dba66
-
08:51 PM Revision d65d2fb6 (git): Do not `poll` first
- Before this patch, the MN scheduler waits for the IO with the
following steps:
1. `poll(fd, timeout=0)` to check fd is ready or not.
2. if fd is not ready, waits with MN thread scheduler
3. call `func` to issue the blocking I/O call
Th... -
08:41 PM Bug #20150 (Closed): Memory leak in grapheme clusters
- GitHub PR: https://github.com/ruby/ruby/pull/9414
String#grapheme_cluters and String#each_grapheme_cluster leaks memory because if the string is not UTF-8, then the created regex will not be freed.
For example:
```ruby
str = "h... -
- PR: https://github.com/ruby/ruby/pull/9413
Fixes a memory leak pthread_attr is created, but never cleaned up
```
require 'socket'
10.times do
10_000.times do
IPSocket.getaddress("localhost")
end
puts `ps -o rss=... -
05:09 PM Bug #20148 (Rejected): Sorting not working as expected on Urdu words.
- I was trying to sort an array of Urdu characters and found out an ambiguity in the result. Here is the script that I am using.
['ا', 'پ', 'ب', 'ت', 'ٹ'].sort
Actual Result:
["ا", "ب", "ت", "ٹ", "پ"]
Expected Result:
["ا", "ب", '... -
04:37 PM Misc #20075: DevMeeting-2024-01-17
- * [Feature #13383] Module#source_location
- Matz [asked](https://github.com/ruby/dev-meeting-log/commit/9f106e4e484f6a512666d346f7854dcd05d59391#diff-c64c00cad3a8a676641bd811a5d27600e162deedc5f3bfe398a43f3c78a88673R46) for specific us... -
- I'm not sure this was already mentioned, but this feels related to 3.2's Data class.
If this is accepted, should Data classes all be immutable? To quote [the docs](https://docs.ruby-lang.org/en/3.2/Data.html):
> Data provides no me... -
- [Bug #20145]
Before this commit, both copy_compare_by_id and hash_copy will create a
copy of the ST table, so the ST table created in copy_compare_by_id will
be leaked.
h = { 1 => 2 }.compare_by_identity
10.times do
1_00... -
- @nobu should we expect a 3.3.1 release soon?
-
01:09 PM Bug #20147 (Open): FreeBSD libyaml
- I use ruby-install to manage multiple Ruby versions. Some time ago I had issues installing Ruby 3.2.2 https://github.com/postmodern/ruby-install/issues/463, and the same issue was open for ruby-build in https://github.com/rbenv/ruby-buil...
-
11:53 AM Revision 542011ff (git): [ruby/reline] Fix pasting tab-indented code crash
- (https://github.com/ruby/reline/pull/630)
https://github.com/ruby/reline/commit/90155fd0d9 -
10:09 AM Revision a4bdf267 (git): Fix version detection error of net-smtp
- https://rubyci.s3.amazonaws.com/freebsd12/ruby-master/log/20240104T083002Z.fail.html.gz
https://rubyci.s3.amazonaws.com/openbsd-current/ruby-master/log/20240104T073006Z.fail.html.gz -
09:46 AM Feature #20102: Introduce `Fiber#resuming?`
- ioquatix (Samuel Williams) wrote in #note-4:
> @Eregon I appreciate your input. I don't mind doing that, but isn't that the same for all methods on Fiber?
It is, and many methods on Fiber are already not allowed to be called for Fibers ... -
08:47 AM Revision c945a849 (git): Skip test depending on bundled gems
- Because bundled gems cannot be loaded at test-all, this test which
depends on one of the bundled gems, `rake`, always does nothing except
print an expected warning. -
05:58 AM Feature #20054: Replace the use of `def` in endless method definitions with a new sigil
- What about using '&', i.e. resulting in `&foo = method_body`? '&' is definitely associated with methods/blocks/procs, both in the parameter list of a method definition and in the `&:method_name` idiom.
-
-
02:17 AM Bug #20146 (Closed): Code using Ractor with env `RUBY_MAX_CPU=1` ends with unreachable
- ## Reproducible code
```rb
# sample-code.rb
Ractor.new { 1 }
```
```bash
RUBY_MAX_CPU=1 ruby sample-code.rb # This will not end with exit code 0
RUBY_MAX_CPU=2 ruby sample-code.rb # This ends with exit code 0 as expected
```
... -
03:52 AM Misc #20107: Update required Oracle Solaris Studio version to 12.5
- I think it is OK.
Note that Oracle Developer Studio 12.6, the latest version, have severe bug that prevent to compile Ruby ([Bug #15292]). This means that it may be needed to keep support 12.5 for a long time.
- 12:39 AM Revision 577bc825 (git): [rubygems/rubygems] remove useless comments from unpack_command.rb
- https://github.com/rubygems/rubygems/commit/7576c21295
-
12:31 AM Feature #16495: Inconsistent quotes in error messages
- ivoanjo (Ivo Anjo) wrote in #note-25:
> matz (Yukihiro Matsumoto) wrote in #note-7:
> ...
To chime in here, at Honeybadger we use this regular expression to parse the Ruby backtrace: https://github.com/honeybadger-io/honeybadger-ruby/b...
01/03/2024
-
- @Eregon I appreciate your input. I don't mind doing that, but isn't that the same for all methods on Fiber? In other words, the GVL provides a bit of a safety net.
Should we apply this model to other methods? Maybe we need to define w... -
- Could you make it `raise FiberError` if it's called on a Fiber of a different thread?
Because that's always racy (i.e. it might have changed by the time `resuming?` returns) so it seems wrong to query that for a Fiber belonging to anoth... -
-
03:51 PM Bug #20112 (Closed): Ractors not working properly in ruby 3.3.0
- I recently installed Ruby 3.3.0, and noticed that some of my scripts that use Ractors started to struggle with performance. After doing some benchmarks, I noticed that, while Ractors seem to be working well on Ruby 3.2.2, they're not wor...
-
- GitHub PR: https://github.com/ruby/ruby/pull/9411
Both copy_compare_by_id and hash_copy will create a copy of the ST table, so the ST table created in copy_compare_by_id will be leaked.
```ruby
h = { 1 => 2 }.compare_by_identity
... -
- The rb_native_thread gets reported as a memory leak by the macOS leaks
tool:
$ RUBY_FREE_AT_EXIT=1 leaks -q --atExit -- ./miniruby -e ""
STACK OF 1 INSTANCE OF 'ROOT LEAK: <calloc in ruby_xcalloc_body>':
6 dyld ... -
08:17 PM Bug #19999: Backport: .travis.yml and fixed commits
- @nagachika I sent the PR to the ruby_3_2 branch to pass Travis CI with the latest config file that exists on master and ruby_3_3 branches. You can do cherry-pick the commits or merge the PR.
https://github.com/ruby/ruby/pull/9410
I a... -
- https://github.com/ruby/prism/commit/4a9389f304
-
07:32 PM Bug #20079: alexandria testsuite began to segfault recently
- @luke-gru Can you please try this modified version of mame's patch?
```diff
diff --git a/hash.c b/hash.c
index 78e9d9a2d6..434b40c445 100644
--- a/hash.c
+++ b/hash.c
@@ -4398,6 +4398,7 @@ rb_hash_compare_by_id(VALUE hash)
- ... -
- There is a memory leak in Encoding.default_external= and
Encoding.default_internal= because the duplicated name is not freed
when overwriting.
10.times do
1_000_000.times do
Encoding.default_internal = nil
end
... -
05:20 PM Revision a25329e0 (git): [ruby/prism] Fix parsing pinned local variable pattern for numbered parameter
- Fix https://github.com/ruby/prism/pull/2094
The part of `parse_variable_call` for variables was split into a new
function `parse_variable` and used it.
https://github.com/ruby/prism/commit/4c5fd1a746 -
05:18 PM Revision 3a3fcf56 (git): [ruby/prism] Fix rational when parsing non decimal integer
- https://github.com/ruby/prism/commit/75d4331f7f
-
- https://github.com/ruby/prism/commit/c2d325a886
-
- https://github.com/ruby/prism/commit/825ff8b9ec
-
- https://github.com/ruby/prism/commit/983561988e
- 04:44 PM Revision 06a65ce6 (git): [ruby/prism] Document `IntegerNode` fields
- https://github.com/ruby/prism/commit/77280b2807
- 02:15 PM Revision fc48a679 (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.84 to 0.9.85.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.84...v0.9.85)
---
updated-depende... -
01:47 PM Revision 66e0d92d (git): [ruby/irb] Avoid completing empty input
- (https://github.com/ruby/irb/pull/832)
The candidate list for empty input is all methods + all variables +
all constants + all keywords. It's a long list that is not useful.
https://github.com/ruby/irb/commit/812dc2df7b -
01:33 PM Feature #16495: Inconsistent quotes in error messages
- It may be interesting to note that the Prism parser has adopted a style guide for error messages, which avoids using the mixed quotes, and uses backticks around token literals to render well in markdown.
https://github.com/ruby/prism/... -
01:28 PM Feature #16495: Inconsistent quotes in error messages
- matz (Yukihiro Matsumoto) wrote in #note-7:
> It was something cultural. I admit nowadays very few people use backquote as a left-hand quote, but it used to be. I also admit consistent quotes are easier for our eyes when using recent ma... -
- At least it seems inconsistent with `defined?(A += 1)` and `defined?(a += 1)` which are both `"assignment"`
-
11:00 AM Bug #20111 (Closed): `defined?` returns `expression` for assignment operators combined with fully qualified constants
- `defined?` doesn't consider &&=, ||= and other ...= operators as `assignment`:
```ruby
defined?(A::B += 1) # => "expression"
defined?(A::B &&= true) # => "expression"
defined?(A::B ||= true) # => "expression"
```
But considers ... -
- https://github.com/ruby/io-console/commit/14b35217dc
-
-
01/02/2024
-
10:17 PM Revision 8916b81b (git): [ruby/io-console] Define IO::ConsoleMode::VERSION from console.c
- https://github.com/ruby/io-console/commit/6302a2082c
-
- In an effort to further improve our documentation, this commit
introduces the concept of templating comments onto fields. I hope
to get more documentation above the nuances of specific fields this
way going forward.
With this, we templa... -
- https://github.com/ruby/prism/commit/55b049ddac
-
- https://github.com/ruby/prism/commit/a28e57c650
-
- Fix https://github.com/ruby/prism/pull/2111
https://github.com/ruby/prism/commit/21ca243d0a -
- https://github.com/ruby/prism/commit/eddd72a8ef
-
-
- Because this is a user-facing change, we also need to deal with the
fact that CRuby 3.3.0 was just released.
In order to support workflows that want to parse exactly as CRuby
parses in a specific version, this PR introduces a new option... -
-
- Before this commit, the test fails with RGENGC_CHECK_MODE enabled:
TestException#test_detailed_message_under_gc_compact_stress [test/ruby/test_exception.rb:1466]:
<"\e[1mfoo (\e[1;4mRuntimeError\e[m\e[1m)\e[m\n" +
"\e[1mbar\... -
-
04:20 PM Feature #20108 (Closed): Introduction of Happy Eyeballs Version 2 (RFC8305) in Socket.tcp
- This is an implementation of Happy Eyeballs version 2 (RFC 8305) in Socket.tcp.
### Background
Currently, `Socket.tcp` synchronously resolves names and makes connection attempts with `Addrinfo::foreach.`
This implementation has the ... -
-
- I guess this can be closed since https://github.com/ruby/ruby/pull/8949 was merged? ;)
-
- Per https://www.oracle.com/us/assets/lifetime-support-hardware-301321.pdf and https://www.oracle.com/a/ocom/docs/support/advanced-customer-support/solaris-linux-vm-lsp.pdf, 12.2, 12.3, and 12.4 are all end-of-life for "extended support"....
-
- (https://github.com/ruby/rdoc/pull/1075)
https://github.com/ruby/rdoc/commit/095b78123b -
10:39 AM Bug #20106 (Closed): Backport d3933fc753187a055a4904af82f5f3794c88c416 to fix net-http test errors
- Testing with Ruby 3.3, I observe test errors such as:
~~~
108) Failure:
TestNetHTTPS#test_skip_hostname_verification [/builddir/build/BUILD/ruby-3.3.0/test/net/http/test_https.rb:217]:
Exception raised:
<#<OpenSSL::SSL::SSLError: ... -
05:19 AM Revision 7a050638 (git): Introduce NODE_FILE
- `__FILE__` was managed by `NODE_STR` with `String` object.
This commit introduces `NODE_FILE` and `struct rb_parser_string` so that
1. `__FILE__` is detectable from AST Node
2. Reduce dependency ruby object - 02:20 AM Revision 91a0d1c4 (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.84 to 0.9.85.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.84...v0.9.85)
---
updated-depende... -
-
- Use links than plain text references.
TODO: Internationalize the RDoc hardcoded link text.
Currently RDoc hardcodes reference name with external name in English,
as "REF at -
- In rdoc files, all documents belong to the top level of each file, and
`:enddoc:` turns off `#document_self` for the entire document in the
current file. This disables cross-references to labels in that file.
Instead use `:stopdoc:` so ... -
-
- Print warning for a code like
```ruby
if __LINE__
end
# => warning: literal in condition
```
01/01/2024
-
-
- For copying, use language like "some" T_DATA objects not supported. This
is because objects like Time are supported, they don't refer to other
objects so it's okay.
For `send(obj, move: true)`, it's currently not supported to move any T... -
- Fixes [Bug #19409]
-
- Fixes [Bug #20104]
-
- (https://github.com/ruby/irb/pull/831)
https://github.com/ruby/irb/commit/5843616c78 -
-
- The line was indented, which caused it to be treated as a code block.
-
- (https://github.com/ruby/irb/pull/826)
* Fix display_document params in noautocomplete mode
* Fix wrong preposing and target order in display_document
The fixed wrong-ordered value is not used in RegexpCompletor, so this change does n... -
12:47 PM Revision c149cd3d (git): Roll net-* bundled gems from git to fix CI (#9403)
- - https://github.com/ruby/net-ftp/pull/29
- https://github.com/ruby/net-imap/pull/259
- https://github.com/ruby/net-smtp/pull/75 -
12:31 PM Revision 3e9a612d (git): [DOC] Fix wrong description about Process.waitpid2 (#9401)
-
- The private key is replaced with a public known test key published at
[RFC 9500].
Also lifetime has been extended to 10 years from 4 years.
[RFC 9500]: https://www.rfc-editor.org/rfc/rfc9500.html
https://github.com/ruby/net-http/commi... -
- (https://github.com/ruby/irb/pull/829)
* test_recovery_sigint: Ensure precondition is met
test_recovery_sigint depends on its process has SIG_DEF sigaction for
SIGINT. When its parent process set SIG_IGN which inherits to children,
the... -
- (https://github.com/ruby/irb/pull/827)
https://github.com/ruby/irb/commit/99b0017d75 -
- Ruby's IO class has a general model for streaming IO, including some hidden classes like `IO::generic_readable` and `IO::generic_writable`.
As Ruby's core IO classes evolve, gems like `openssl` (see `OpenSSL::Buffering`) need to be up... -
12/31/2023
-
-
-
-
- https://github.com/ruby/rdoc/commit/914a6af137
-
- https://github.com/ruby/win32ole/commit/76acc979bf
-
- https://github.com/ruby/win32ole/commit/afceb6814f
-
-
01:20 AM Misc #17815: Snapcraft Ruby plugin
- This can be closed. I've implemented a Ruby build plugin on v1 and v2.
-
-
- https://github.com/ruby/win32ole/commit/eba2934177
12/30/2023
-
- So I looked into this and it's this commit that introduces that behavior: 7193b404a1a56e50f8046d0382914907020c1559
Edit: create PR here https://github.com/ruby/ruby/pull/9398. I should probably add test for this, I'm just seeing if CI p... -
- Between Ruby 3.2 and 3.3, behavior changed so that Regexp#match will allocate a T_MATCH object even when there is no match. Example code:
```ruby
h = {}
GC.start
GC.disable
ObjectSpace.count_objects(h)
matches = h[:T_MATCH] || 0... -
- This should help in debugging the intermittent test failures on CI:
TestProcess#test_warmup_frees_pages [test/ruby/test_process.rb:2779]:
<201> expected but was
<202>.
12/29/2023
-
- I was able to reproduce the segfault in ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-linux] on the same file and line. I didn't try earlier rubies, just this one. However, when I downloaded all the ubuntu packages that were outlin...
-
- I created a PR that updates the Ractor docs: https://github.com/ruby/ruby/pull/9395. It doesn't go into much detail about the situation but clarifies it a bit.
Adding a `movable?` method would have have to be a separate ticket @fortho... -
- The documentation was indented one level too deep, which causes RDoc to
generate it all as a code block. -
-
- This has been fixed by @ko1 in 7718e9588b4d7d83c8f9a89dce10b06b9f97bddb, it can be closed now. It could possibly use a backport, but I'll leave that up to you guys. Thank you!
-
- https://github.com/ruby/securerandom/commit/647e5f0af8
-
- This commit also reduces the warning `'stkp' may be used
uninitialized in this function`. -
-
-
-
-
- `__LINE__` was managed by `NODE_LIT` with `Integer` object.
This commit introduces `NODE_LINE` so that
1. `__LINE__` is detectable from AST Node
2. Reduce dependency ruby object -
- (https://github.com/ruby/reline/pull/623)
https://github.com/ruby/reline/commit/38e9cb2899 -
05:50 AM Feature #20093: Syntax or keyword to reopen existing classs/modules, never to define new classs/modules
- > The only downside I see is that doesn't make it easy to define and access constants defined under that class/module.
> ...
I actually found this quite surprising:
```
irb(main):008> String.class_eval { Module.nesting }
=> []
irb... -
05:28 AM Feature #20093: Syntax or keyword to reopen existing classs/modules, never to define new classs/modules
- I commented that "class_eval / module_eval can do the same things functionally.". However, as @Eregon pointed out, there is a different rule about constants around `class_eval` / `module_eval`.
The method definition in `class_eval`/`mod... -
- Why a new keyword? If it behaves like a `class_eval`, could it be an alias?
```rb
String.reopen do
def stuff = here
end
``` - 04:05 AM Revision bc3b9356 (git): [ruby/reline] Replace `object_id` comparison with `equal?`
- (https://github.com/ruby/reline/pull/617)
https://github.com/ruby/reline/commit/63deef4ae5 - 02:43 AM Revision e86b4c29 (git): [ruby/securerandom] Increase speed of UUID generation
- https://github.com/ruby/securerandom/commit/b587b8c7cb