Activity
From 06/22/2023 to 06/28/2023
06/28/2023
-
10:08 PM Feature #19744: Namespace on read
- a very thorough proposal with an attractive modularity to it!
if i may ask a few questions:
are the described problems, apart of dependency conflicts, very common in your experience? (i've worked on several large codebases with ~10... -
10:02 PM Misc #19747: Propose Kevin Newton and Jemma Issroff as core committers
- Welcome!
-
02:59 PM Misc #19747: Propose Kevin Newton and Jemma Issroff as core committers
- I am honored, thank you! I have also sent over the information.
-
02:30 PM Misc #19747: Propose Kevin Newton and Jemma Issroff as core committers
- Thank you very much! I have sent over all of the information.
-
10:17 AM Misc #19747 (Assigned): Propose Kevin Newton and Jemma Issroff as core committers
- @kddnewton @jemmai Can you send your account information to `cvs-admin@ruby-lang.org`? Please look https://github.com/ruby/ruby/wiki/Committer-How-To#how-to-register-you-as-a-committer for its details.
-
05:14 AM Misc #19747: Propose Kevin Newton and Jemma Issroff as core committers
- Accepted. Welcome both of you!
Matz.
-
04:03 AM Misc #19747: Propose Kevin Newton and Jemma Issroff as core committers
- +1 for both
-
03:59 AM Misc #19747 (Closed): Propose Kevin Newton and Jemma Issroff as core committers
- # Proposal
I'd like to propose Kevin Newton (@kddnewton) and Jemma Issroff (@jemmai) as core committers. Now that YARP [Feature #19741] is merged, I want them to work on YARP's CRuby integration without asking other committers to merge ... -
05:47 PM Revision 27d3fa2a (git): Increase memory leak test timeout
- The test times out on some platforms, so increase the timeout.
-
05:33 PM Revision 78ecb93f (git): [ruby/irb] Reduce test pend truffleruby
- (https://github.com/ruby/irb/pull/619)
https://github.com/ruby/irb/commit/b7b071774f -
04:01 PM Revision 8f9d58a9 (git): Repair broken link
-
03:27 PM Bug #19749: Confirm correct behaviour when attaching private method with `#define_method`
- Eregon (Benoit Daloze) wrote in #note-3:
> @jeremyevans0 That does not explain why the original example defines the method as public (note I edited the description on Redmine, it was not asking the right question).
> ...
Scope visibili... -
03:10 PM Bug #19749 (Open): Confirm correct behaviour when attaching private method with `#define_method`
-
02:49 PM Bug #19749: Confirm correct behaviour when attaching private method with `#define_method`
- To clarify, this proves the top-level visibility is private:
```ruby
def foo; end
o = self
o.foo # => private method `foo' called for main:Object (NoMethodError)
``` -
02:45 PM Bug #19749: Confirm correct behaviour when attaching private method with `#define_method`
- @jeremyevans0 That does not explain why the original example defines the method as public (note I edited the description on Redmine, it was not asking the right question).
> will only consider current default scope visibility to deter... -
02:17 PM Bug #19749 (Closed): Confirm correct behaviour when attaching private method with `#define_method`
- As in #19745, it is expected that `define_method` will not use the method body (second argument/block) to determine method visibility. `define_method` will only consider current default scope visibility to determine visibility:
```rub... -
01:40 PM Bug #19749 (Closed): Confirm correct behaviour when attaching private method with `#define_method`
- This issue is a special case of https://bugs.ruby-lang.org/issues/19745:
Should dynamically added private methods via `.singleton_class.send(:define_method,...` at the top-level be accessible publicly?
See the following example:
... -
01:50 PM Revision a500eb9f (git): Fix memory leak in Ripper
- The following script leaks memory in Ripper:
```ruby
require "ripper"
20.times do
100_000.times do
Ripper.parse("")
end
puts `ps -o rss= -p #{$$}`
end
``` -
01:42 PM Revision 3d7a6bbc (git): Ensure the byte position is a valid boundary
-
01:05 PM Revision 6528cf9f (git): [DOC] Fixes for link fragments (#7981)
-
09:24 AM Bug #19745: Confirm correct behaviour when attaching private method with `#define_singleton_method`
- @itarato This example is not the same as the linked issue.
I would suggest to open a separate issue to dicuss the original example, which uses `define_method`.
(although this `define_singleton_method` example does fail on TruffleRuby... -
08:23 AM Bug #19748 (Closed): `String#byteindex` crashes when `offset` is too large
- Applied in changeset commit:git|bc3ac1872e4523334e3ed04c2bb70a55c4c43f98.
----------
[Bug #19748] Fix out-of-bound access in `String#byteindex` -
04:51 AM Bug #19748 (Closed): `String#byteindex` crashes when `offset` is too large
- ```ruby
"a".byteindex("", 1000000) #=> [BUG] Segmentation fault
``` -
08:23 AM Revision bc3ac187 (git): [Bug #19748] Fix out-of-bound access in `String#byteindex`
- 07:53 AM Revision 715c5ca4 (git): Update default gems list at b954a4ebc67d408456a102fe13051e [ci skip]
- 07:37 AM Revision b954a4eb (git): [ruby/csv] Bump version
- https://github.com/ruby/csv/commit/e090da19b4
- 07:37 AM Revision d6d60d42 (git): [ruby/csv] Fix a bug that the same line is used multiple times
- GitHub: fix https://github.com/ruby/csv/pull/279
It's happen when:
* `keep_start`/`keep_{drop,back}` are nested.
(e.g.: `strip: true, skip_lines: /.../`)
* Row separator is `\r\n`.
* `InputScanner` is used. (Small input doesn't use `... - 07:37 AM Revision 539559d3 (git): [ruby/csv] Remove nonexistent variable
- https://github.com/ruby/csv/commit/bfbd6bbf6f
- 07:37 AM Revision 1f467934 (git): [ruby/csv] parser: add one more trace
- https://github.com/ruby/csv/commit/5df650be0c
- 07:37 AM Revision 2098093f (git): [ruby/csv] docs: Add entry for backslash_quotes liberal parsing
- (https://github.com/ruby/csv/pull/280)
https://github.com/ruby/csv/commit/0dcfcd9c48 - 07:36 AM Revision f1313cae (git): [ruby/fiddle] Mark Closure, Function and Handle as write barrier
- protected
(https://github.com/ruby/fiddle/pull/129)
They don't have a mark function, so they don't need any change.
https://github.com/ruby/fiddle/commit/9bbc732aef
Co-authored-by: Jean Boussier <jean.boussier@gmail.com> - 07:36 AM Revision 135d5fa3 (git): [ruby/fiddle] Implement write barriers for Fiddle::Pointer
- (https://github.com/ruby/fiddle/pull/127)
Save from having to mark them on every minor.
https://github.com/ruby/fiddle/commit/153c09c99f
Co-authored-by: Jean Boussier <jean.boussier@gmail.com> - 07:36 AM Revision 572b432e (git): [ruby/fiddle] Fix a typo
- https://github.com/ruby/fiddle/commit/4c0c5da1a5
- 07:36 AM Revision 02661f5e (git): [ruby/fiddle] Add support for converting "C" (one character string) to char
- GitHub: fix https://github.com/ruby/fiddle/pull/96
I wanted to add a test for this but I couldn't find a function that
has a "char" argument in libc...
Reported by kojix2. Thanks!!!
https://github.com/ruby/fiddle/commit/2c863ef8ba - 07:36 AM Revision 74e04929 (git): [ruby/fiddle] Add support for more "short" variants
- https://github.com/ruby/fiddle/commit/4598e6cd50
- 07:36 AM Revision 731d2772 (git): [ruby/fiddle] Add support for more "short" variants
- https://github.com/ruby/fiddle/commit/2b22bb9d74
- 07:36 AM Revision ebf14d01 (git): [ruby/fiddle] Add support for "long" variants
- GitHub: fix https://github.com/ruby/fiddle/pull/100
Reported by David M. Lary. Thanks!!!
https://github.com/ruby/fiddle/commit/516333dd78 -
07:36 AM Revision 85937f3a (git): [ruby/fiddle] Add a helper method for reading/writing memory
- (https://github.com/ruby/fiddle/pull/123)
This commit adds two new methods, `Fiddle::Pointer.read` and
`Fiddle::Pointer.write`. Both methods take an address, and will read or
write bytes at that address respectively.
For example we can... -
07:34 AM Revision ae71bbbc (git): [ruby/syntax_suggest] [DOC] Fix method name
- https://github.com/ruby/syntax_suggest/commit/08a9afb64f
-
05:44 AM Bug #19746 (Closed): `String#index` with regexp and too large offset doesn't clear `$~`
- Applied in changeset commit:git|0cbfeb8210cd177bee95c512834c483daec36f74.
----------
[Bug #19746] `String#index` with regexp should clear `$~` unless matched -
02:55 AM Bug #19746 (Closed): `String#index` with regexp and too large offset doesn't clear `$~`
- ```ruby
/./ =~ "a"
p "x".index(/0/, 4) #=> nil
p $~ #=> #<MatchData "a">
```
while `rindex` does.
```ruby
/./ =~ "a"
p "x".rindex(/0/, 4) #=> nil
p $~ #=> nil
```
It seems since 1.9.
-
05:06 AM Revision 0cbfeb82 (git): [Bug #19746] `String#index` with regexp should clear `$~` unless matched
-
05:06 AM Revision 9e709d0f (git): Assert `$~` after `String#index` family
- 03:42 AM Revision f177d35b (git): Bump dependabot/fetch-metadata from 1.5.1 to 1.6.0
- Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.5.1 to 1.6.0.
- [Release notes](https://github.com/dependabot/fetch-metadata/releases)
- [Commits](https://github.com/dependabot/fetch-metadata/compar... -
12:23 AM Revision 3e08a536 (git): Use the same capacities for memory leak tests
06/27/2023
-
08:43 PM Revision 8aedfefb (git): [ruby/irb] Remove keyword exception from Context#evaluate because
- the value is always nil
(https://github.com/ruby/irb/pull/617)
https://github.com/ruby/irb/commit/62691384f8 -
07:51 PM Revision caddd027 (git): [ruby/irb] Move input line mutation out of `Context#evaluate`
- (https://github.com/ruby/irb/pull/615)
This makes sure `Context#evaluate` really just evaluates the input.
It will also make #575's implementation cleaner. -
04:40 PM Bug #19745 (Closed): Confirm correct behaviour when attaching private method with `#define_singleton_method`
- It is expected that `define_singleton_method` defines a public singleton method (see #18561). For `define_method`, visibility can depend on the current default visibility for the class/module scope. In any case, the visibility of the de...
-
03:46 PM Bug #19745 (Closed): Confirm correct behaviour when attaching private method with `#define_singleton_method`
- Should dynamically added private methods be accessible publicly?
See the following example?
```ruby
private def bar; end
foo = Object.new
foo.define_singleton_method(:bar, method(:bar))
foo.bar # No error.
```
The scrip... -
02:27 PM Bug #18464: RUBY_INTERNAL_EVENT_NEWOBJ tracepoint causes an interpreter crash when combined with Ractors
- Aaaahh. It's a shame, but I can understand 😓 . Thanks for the clarification :)
-
02:16 PM Bug #18464: RUBY_INTERNAL_EVENT_NEWOBJ tracepoint causes an interpreter crash when combined with Ractors
- ivoanjo (Ivo Anjo) wrote in #note-12:
> Can I bother you with a backport to 3.0 as well?
Ruby 3.0 is in security maintenance mode, and this does not appear to be a security issue: https://www.ruby-lang.org/en/downloads/branches/ -
10:58 AM Bug #18464: RUBY_INTERNAL_EVENT_NEWOBJ tracepoint causes an interpreter crash when combined with Ractors
- Thanks again @nagachika!
Can I bother you with a backport to 3.0 as well? I know that one is getting "long in the tooth" in terms of support, but having it fixed would mean this crash would not happen on any of the Ruby releases which... -
02:14 PM Revision 913e01e8 (git): Stop allocating unused backref strings at `defined?`
-
01:39 PM Revision df5ae0a5 (git): Use `rb_reg_nth_defined` instead of `rb_match_nth_defined`
-
10:19 AM Revision eaad44ad (git): [ruby/irb] Always add \n at the end of the test input in RubyLex
- test
(https://github.com/ruby/irb/pull/614)
https://github.com/ruby/irb/commit/e68c6128aa -
07:37 AM Revision 9dd86985 (git): [rubygems/rubygems] Fixup
- https://github.com/rubygems/rubygems/pull/6766
https://github.com/rubygems/rubygems/commit/c5c5797227 -
02:34 AM Feature #19744 (Closed): Namespace on read
- # What is the "Namespace on read"
This proposes a new feature to define virtual top-level namespaces in Ruby. Those namespaces can require/load libraries (either .rb or native extension) separately from the global namespace. Dependenc... -
02:15 AM Revision a99d0c15 (git): [rubygems/rubygems] Removed unused variable
- https://github.com/rubygems/rubygems/commit/68cc941bed
-
02:15 AM Revision 65c21793 (git): [rubygems/rubygems] Molinillo::DependencyGraph is initialized in Molinillo::Resolver#resolve
- https://github.com/rubygems/rubygems/commit/1c39e24c95
06/26/2023
-
07:41 PM Bug #18743: Enumerator#next / peek re-use each others stacktraces
- Oh, I understood from Matz's initial suggestion that the exceptions should be chained, but I see now what he meant. I've applied the changes you suggested, @nobu. Thank you for clarifying, and for reviewing.
-
02:03 PM Revision ec59b95c (git): [ruby/yarp] Use smaller regexp options
- https://github.com/ruby/yarp/commit/4deb7c3ae0
-
01:55 PM Revision 515bd421 (git): Update to ruby/spec@30e1c35
-
01:55 PM Revision f73fa299 (git): Update to ruby/mspec@3cf2d16
- 01:31 PM Revision 4fc8b8f0 (git): [ruby/yarp] Prevent reading/writing outside the bounds of options
- https://github.com/ruby/yarp/commit/52bed3cbe2
- 01:13 PM Revision 44197e51 (git): [ruby/yarp] Add missing snapshot
- https://github.com/ruby/yarp/commit/08f08a6cc4
-
11:09 AM Bug #19585: Ruby Fails to Build on macOS with --enable-shared and --with-jemalloc
- ruby_3_1 c87bf4d8e96819010942a00372ee518e22c76bac merged revision(s) 038f9ade3c4d965415e4956561975454cf9eeb21.
- 11:09 AM Revision c87bf4d8 (git): merge revision(s) 038f9ade3c4d965415e4956561975454cf9eeb21: [Backport #19585]
- Use tools appropriate with CC
To get rid of mysterious errors such as:
```
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/nm: error: libruby.3.3-static.a(/): The end of th... -
11:08 AM Bug #19532 (Closed): Handling of 6-byte codepoints in left_adjust_char_head in CESU-8 encoding is broken - Applied in changeset commit:git|0275614ba213dfb6f05743a16f65623bc3b6e274.
----------
merge revision(s) 2c8f287: [Backport #19532]
Fix handling of 6-byte codepoints in left_adjust_char_head in CESU-8
encoding
-... -
11:07 AM Bug #19532: Handling of 6-byte codepoints in left_adjust_char_head in CESU-8 encoding is broken
- ruby_3_1 0275614ba213dfb6f05743a16f65623bc3b6e274 merged revision(s) 2c8f287.
- 11:07 AM Revision 0275614b (git): merge revision(s) 2c8f287: [Backport #19532]
- Fix handling of 6-byte codepoints in left_adjust_char_head in CESU-8
encoding
---
enc/cesu_8.c | 23 +++++++++++++++++++----
test/ruby/enc/test_cesu8.rb | 4 ++++
2 files changed... -
10:06 AM Revision 3acf5a27 (git): Suppress warnings
-
09:25 AM Revision dc940cc7 (git): [DOC] Nested ordered lists need more indents
-
04:52 AM Revision d1b6ff42 (git): Add the chopsticks code at RubyKaigi2023
- 03:44 AM Revision 94ac77c9 (git): Bump ossf/scorecard-action from 2.1.3 to 2.2.0
- Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.3 to 2.2.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md...
06/25/2023
-
08:44 PM Revision ed587abf (git): Fix broken links
-
03:45 PM Revision 83076272 (git): [ruby/uri] String literals are frozen now
- https://github.com/ruby/uri/commit/0b6ad60af6
-
03:24 PM Revision c21436cb (git): [ruby/uri] Fix host part in relative referece #83
- In relative referece, host part can be ommitted but can not be empty.
https://github.com/ruby/uri/commit/2980f0ba02 -
08:21 AM Revision 15ec072a (git): [DOC] Parse documents under doc/yjit
-
08:21 AM Revision 0a9ef054 (git): [DOC] Parse all documents under doc/regexp
- 07:00 AM Revision 9df5b456 (git): Update bundled gems list at 2023-06-25
-
06:21 AM Bug #18464: RUBY_INTERNAL_EVENT_NEWOBJ tracepoint causes an interpreter crash when combined with Ractors
- ruby_3_2 b422c3523c419b88c6da23a4022ae8864f411b84 merged revision(s) 7bd7aee02e303de27d2cddfc5ef47e612d6782cb.
-
06:20 AM Revision b422c352 (git): merge revision(s) 7bd7aee02e303de27d2cddfc5ef47e612d6782cb: [Backport #18464]
- Fix interpreter crash caused by RUBY_INTERNAL_EVENT_NEWOBJ + Ractors
When a Ractor is created whilst a tracepoint for
RUBY_INTERNAL_EVENT_NEWOBJ is active, the interpreter crashes. This is
because during the earl... -
05:12 AM Revision 00216c8a (git): [ruby/irb] Fix process_continue(rename to should_continue?) and
- check_code_block(rename to check_code_syntax)
(https://github.com/ruby/irb/pull/611)
https://github.com/ruby/irb/commit/b7f4bfaaa4 -
03:39 AM Bug #19529: [BUG] ObjectSpace::WeakMap can segfault after compaction
- ruby_3_2 e3d10dedf106357d2b17fc8786d35035e0b366cf merged revision(s) bffadcd6d46ccfccade79ce0efb60ced8eac4483.
-
03:26 AM Bug #19529: [BUG] ObjectSpace::WeakMap can segfault after compaction
- ruby_3_2 3ebcbb537d7ae37e49c49e05b28d2cc5b324f151 merged revision(s) 548086b34e3dd125edabf5dc1e46b891fad3ea9c,3dc8cde70078ccb38f5f4b0818ad5eecded01bd5,e0cf80d666d4b5df3229f030a16d10d21323508e.
-
03:37 AM Revision 0c00fb5d (git): merge revision(s) ec14861f0d7a1e99d3e6667dee2f4c9cc426d5f3:
- Update to ruby/spec@7e680fa
---
spec/ruby/core/dir/home_spec.rb | 5 +++--
spec/ruby/core/process/spawn_spec.rb | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-) -
03:29 AM Revision e3d10ded (git): merge revision(s) bffadcd6d46ccfccade79ce0efb60ced8eac4483: [Backport #19529]
- Add guard to compaction test in WeakMap
Some platforms don't support compaction, so we should skip this test.
---
test/ruby/test_weakmap.rb | 2 ++
1 file changed, 2 insertions(+) -
03:26 AM Revision 3ebcbb53 (git): merge revision(s) 548086b34e3dd125edabf5dc1e46b891fad3ea9c,3dc8cde70078ccb38f5f4b0818ad5eecded01bd5,e0cf80d666d4b5df3229f030a16d10d21323508e: [Backport #19529]
- ObjectSpace::WeakMap: fix compaction support
[Bug #19529]
`rb_gc_update_tbl_refs` can't be used on `w->obj2wmap` because it's
not a `VALUE -> VALUE` table, but a `VALUE -> VALUE *` table, so
we need some... -
02:52 AM Bug #19323: Integer overflow in `Integer#<<`
- ruby_3_2 a048f7882a13e96080021a5bc13ef1fb293b4985 merged revision(s) 1cdf8ab07b24ebd16e93621957196e8b1d67f2ba.
-
02:52 AM Revision a048f788 (git): merge revision(s) 1cdf8ab07b24ebd16e93621957196e8b1d67f2ba: [Backport #19323]
- [Bug #19323] Raise `RangeError` instead of integer overflow
---
bignum.c | 5 ++++-
test/ruby/test_integer.rb | 18 ++++++++----------
2 files changed, 12 insertions(+), 11 deletions(-)
06/24/2023
-
10:20 PM Bug #19569 (Closed): #map on Enumerator::Lazy block arguments seem to differ from regular #map
- Applied in changeset commit:git|a14915ca4baae40f08d288a38b8bfb595500ad90.
----------
Do not have Enumeratory::Lazy#zip mark result as packed
Fixes [Bug #19569] -
10:20 PM Revision 406799ca (git): [ruby/irb] Omit nesting_level, use indent_level to build prompt
- string
(https://github.com/ruby/irb/pull/610)
https://github.com/ruby/irb/commit/f01ff0811b -
03:41 PM Revision a14915ca (git): Do not have Enumeratory::Lazy#zip mark result as packed
- Fixes [Bug #19569]
-
10:17 AM Revision c94b5f12 (git): De-duplicate parse_st.c code from st.c
-
10:17 AM Revision 3443e43b (git): Remove `st_functions_t`
-
09:18 AM Revision e02c7a73 (git): Ignore only warnings known by clang
- Clang 17 does not know warning group '-Wgnu-empty-initializer'.
-
08:00 AM Bug #19307: Fix `OpenSSL::X509::CertificateError: invalid digest` on CentOS 9 / RHEL 9
- ruby_3_2 9fca561980c6d024229d72600180b20f3f77536f merged revision(s) cd5e6cc0ea48353c88d921b885b552dc76da255c,bbf54ec334fe2edd7669a944d88d17efde49a412.
-
07:59 AM Revision 9fca5619 (git): merge revision(s) cd5e6cc0ea48353c88d921b885b552dc76da255c,bbf54ec334fe2edd7669a944d88d17efde49a412: [Backport #19307]
- Update to ruby/mspec@fef9b81
---
spec/mspec/tool/tag_from_output.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Update to ruby/spec@9d69b95
---
spec/ruby/core/array/keep_if_s... -
07:46 AM Feature #19717: `ConditionVariable#signal` is not fair when the wakeup is consistently spurious.
- I finished spiking out a bit of a POC of how this kind of handoff could work - https://github.com/ruby/ruby/pull/7977
I'm sure it is chock-a-block full of other fun bugs, but it seems to make your reproduction script work; it runs to ... -
06:32 AM Revision 97152d44 (git): [ruby/yarp] Name test methods from relative paths
- Full path name of the source directory is a useless noise as tests.
https://github.com/ruby/yarp/commit/44a7ae2e64
06/23/2023
-
11:58 PM Bug #18605: Fails to run on (newer) 32bit Windows with ucrt
- I have created a simple fix which helped to run 32-bit Ruby 2.6.x up to 3.2.x on Windows 11 without getting 'unexpected ucrtbase.dll' anymore.
Available here: https://github.com/oneclick/rubyinstaller2/issues/308#issuecomment-1605125... -
08:06 PM Misc #19679 (Closed): Migrate Wiki from bugs.ruby-lang.org to ruby/ruby GitHub repository
- 07:56 PM Revision 261e3663 (git): [ruby/yarp] Check for eof in yp_regexp_char_is_eof
- https://github.com/ruby/yarp/commit/f3fbc5bf9e
- 07:56 PM Revision 6ee106ff (git): [ruby/yarp] If ? is last char of regexp buffer, don't read beyond it.
- https://github.com/ruby/yarp/commit/1764532572
- 07:56 PM Revision 6dc23149 (git): [ruby/yarp] Don't read past the end of input parsing regex group
- https://github.com/ruby/yarp/commit/03f5a330a9
-
06:46 PM Revision 7ce6bcaf (git): Expose rb_hash_resurrect
- This is for implementing the `duphash` instruction
-
02:37 PM Revision 01507d2f (git): Skip test on Solaris SPARC
- This test fails on Solaris SPARC with the following error and I can't
figure out why:
TestGCCompact#test_moving_hashes_down_size_pools
Expected 499 to be >= 500. -
10:36 AM Feature #19057: Hide implementation of `rb_io_t`.
- byroot (Jean Boussier) wrote in #note-17:
> @ioquatix I'm not sure which change exactly is the cause, but it appears that the recent `rb_io_t` changes broke `raindrops`
I've noticed the same thing while trying to install `kgio` wit... -
10:34 AM Bug #18810: Make `Kernel#p` interruptable.
- It's because the code changed on master, https://github.com/ruby/ruby/commit/fe6b2e20e9f17ed2c2900aa72994e075ffdc7124 had that bug but master doesn't call `inspect` under `rb_uninterruptible()`.
On master:
```c
static VALUE
rb_f_p(in... -
10:26 AM Bug #18810: Make `Kernel#p` interruptable.
- Mmh, but it does work to interrupt `p`:
```
$ ruby -e 'o=Object.new; def o.inspect; loop { Thread.pass }; end; p 1; p o'
1
^C-e:1:in `pass': Interrupt
from -e:1:in `block in inspect'
from -e:1:in `loop'
from -e:1:in `inspect'
... -
10:24 AM Bug #18810: Make `Kernel#p` interruptable.
- `p` being uninterruptible means all of `object.inspect` and potential Fiber scheduler code is run under `Thread.handle_interrupt(Object => :never) { ... }`.
That seems a really bad idea, because e.g. if `inspect` would take a long time ... -
05:54 AM Revision 73529a12 (git): Declare `RHASH_AR_TABLE` and `RHASH_ST_TABLE` return non-null
- 03:52 AM Revision 00c1bd66 (git): Update default gems list at b7375770ef15c7d7b3fdf14bf1964a [ci skip]
-
03:52 AM Revision b7375770 (git): [ruby/timeout] Bump up v0.4.0
- https://github.com/ruby/timeout/commit/413194f8d2
06/22/2023
-
11:27 PM Bug #18810: Make `Kernel#p` interruptable.
- I submitted a pull request to update the Kernel#p documentation: https://github.com/ruby/ruby/pull/7975
-
11:02 PM Bug #18933: Dir.tmpdir implemented in non-Ractor-safe manner
- @nobu submitted a pull request to fix this upstream: https://github.com/ruby/tmpdir/pull/22
-
10:36 PM Bug #19293: The new Time.new(String) API is nice... but we still need a stricter version of this
- mame (Yusuke Endoh) wrote in #note-4:
> BTW Ruby 3.2.0 accidentally allows `Time.new("2023-01")`, `Time.new("2023-01-01")`, and `Time.new(" \n\n 2023-01-01 00:00:00 \n\n ")`. All of these are considered a bug, so will be prohibited ... -
06:24 PM Revision e8c93851 (git): [ruby/timeout] Raise exception instead of throw/catch for timeouts
- (https://github.com/ruby/timeout/pull/30)
throw/catch is used for non-local control flow, not for exceptional situations.
For exceptional situations, raise should be used instead. A timeout is an
exceptional situation, so it should use... -
06:21 PM Misc #19740: Block taking methods can't differentiate between a non-local return and a throw
- I'm not sure it's good to be able to differentiate, because then it could be a mess if different gems consider return/throw/break differently, e.g. if Rails wants to commit on `return` but some other library only wants to commit on "natu...
-
06:15 PM Revision b9349760 (git): Prefer `0` over `NULL` as function pointers
- SunC warns use of `NULL`, pointer to data as function pointers.
-
06:08 PM Revision 52f8de4f (git): Remove dead code in hash.c
- RHASH_TABLE_NULL_P and ar_alloc_table are no longer needed since
all Hash will have AR tables. -
05:49 PM Bug #11064: #singleton_methods for objects with special singleton_class returns an empty array
- I discussed this with @headius at RubyKaigi, and agree that it would be best to make `singleton_method` consistent with `singleton_methods`. As @matz indicated, NilClass/TrueClass/FalseClass instance methods should be considered as norm...
-
05:07 PM Revision 218a8d8e (git): [ruby/reline] Remove unused method
- (https://github.com/ruby/reline/pull/557)
`get_mbchar_byte_size_by_first_char` isn't used in Reline.
Also, this method implements the same functionality as `String#bytesize` and is unnecessary. -
04:40 PM Bug #19479 (Closed): Support IPv4-mapped IPv6 addresses in IPAddr#private?
- Applied in changeset commit:git|de51a4a13eab2c4c5917de923edde33dfed6f22f.
----------
[ruby/ipaddr] Consider IPv4-mapped IPv6 addresses private if IPv4 address is private
Fixes [Bug #19479]
https://github.com/ruby/ipaddr/commit/7faa0768d3 -
04:17 PM Bug #19479: Support IPv4-mapped IPv6 addresses in IPAddr#private?
- I submitted an upstream pull request to fix this: https://github.com/ruby/ipaddr/pull/57
-
04:40 PM Revision de51a4a1 (git): [ruby/ipaddr] Consider IPv4-mapped IPv6 addresses private if IPv4 address is private
- Fixes [Bug #19479]
https://github.com/ruby/ipaddr/commit/7faa0768d3 -
04:23 PM Revision 711cabec (git): Sync ruby/yarp to https://github.com/ruby/yarp/commit/89a00203af803032383338c943836da6bafca7d9
-
04:20 PM Revision e8fb8426 (git): [ruby/yarp] Allow for block statements after elsif and else
- https://github.com/ruby/yarp/commit/4560cab235
-
04:19 PM Revision 7fad7d34 (git): [ruby/yarp] Do not leak file descriptors
- https://github.com/ruby/yarp/commit/83c2c45b28
-
04:19 PM Revision b879528e (git): [ruby/yarp] Do not leak memory from lex modes
- https://github.com/ruby/yarp/commit/df6661740c
-
03:59 PM Revision edd48810 (git): Sync ruby/yarp with sync_default_gems
-
02:21 PM Bug #19743 (Closed): Ruby's parser seems to ignoring DOT at the end of file just after digits
- Applied in changeset commit:git|1344de56219cf83ca146c5346783f8483af534f9.
----------
[Bug #19743] All but EOF can be read again after push-back -
10:52 AM Bug #19743: Ruby's parser seems to ignoring DOT at the end of file just after digits
- Seems since 2.5.
I tried bisecting 2.5 branch, but `configure` generated with recent autoconf doesn't work. -
11:10 AM Revision 1344de56 (git): [Bug #19743] All but EOF can be read again after push-back
-
10:41 AM Feature #19742: Introduce `Module#anonymous?`
- Eregon (Benoit Daloze) wrote in #note-27:
> Regarding `Module#anonymous?`, I think it should be true for `Module.new::C = Module.new #=> #<Module:0x00007f92d6c66770>::C` (note, the `.name` of that is `"#<Module:0x00007f92d6c66770>::C"`,... -
10:38 AM Feature #19742: Introduce `Module#anonymous?`
- > I want to use this proposal to discuss this issue and whether there is anything we should do about such behaviour (or even if it's desirable).
I think it would be great to reflect it in the Module#name if a Module is no longer reachab... -
09:29 AM Feature #19742: Introduce `Module#anonymous?`
- @ioquatix oh wait, we might have two questions in our minds.
I am like: Can a module whose `name` is not `nil` be `anonymous?`. Answer is, if we want to agree with the current docs, it cannot be, because `Module#name` has to return `nil... -
08:17 AM Feature #19742: Introduce `Module#anonymous?`
- > I don't think Rails should monkey patch Module in this way either.
This may be a problem with some of rails idioms, e. g. how HashWithIndifferentAccess
arose, to give one example. While one may understand the use case (not having t... -
08:10 AM Feature #19742: Introduce `Module#anonymous?`
- > There is no semantics for anonymous? because it does not exist in Ruby yet.
I used the word "semantics" because the docs use the English word "anonymous", which is not formal, but would be surprising that `anonymous?` does not behave ... -
07:43 AM Feature #19742: Introduce `Module#anonymous?`
- > The first one is that Ruby docs (today) agree with my definition: If a module is anonymous, then its name is `nil`. If `mod.anonymous?` returned true and `mod.name` was not `nil`, we'd violate existing Ruby semantics.
There is no se... -
07:30 AM Feature #19742: Introduce `Module#anonymous?`
- @janosch-x agreed, in Zeitwerk I do my best at [reaching the original `Module#name`](https://github.com/fxn/zeitwerk/blob/main/lib/zeitwerk/real_mod_name.rb) because of that.
@ioquatix yeah, I understand your point of view. However, w... -
07:09 AM Feature #19742: Introduce `Module#anonymous?`
- fxn (Xavier Noria) wrote in #note-17:
> def self.name [...] I think overriding such a core method for an attribute that is out of reach, managed internally by Ruby, is questionable [...] Can people override `Array#size` to return 7? Yes... -
07:04 AM Feature #19742: Introduce `Module#anonymous?`
- I'm not that different, except
Anonymous to me means you don't have a name [that resolves to self]. If the module has a name that resolves to itself, it is not anonymous.
I would say a lot of the rails code should be rewritten just to ... -
06:23 AM Feature #19742: Introduce `Module#anonymous?`
- Yeah, we do not see it the same way.
Anonymous to me means you don't have a name. If the module has a name, done, it is not anonymous.
If you have a _temporary_ name, in particular you have a name.
To be honest, I would leave modules ... -
01:09 AM Feature #19742: Introduce `Module#anonymous?`
- Should setting a temporary name make a module not anonymous?
I found the following use cases in Rails:
```ruby
unless controller_class.anonymous?
controller_class.name.delete_suffix("Controller").under... -
12:42 AM Feature #19742: Introduce `Module#anonymous?`
- Oh, I thought you meant that the module has a name and had not been assigned to a constant.
If the module has a name, then not being considered to be anonymous is the least surprising definition to me.
You could also have
```rub... -
12:14 AM Feature #19742: Introduce `Module#anonymous?`
- I don't understand, is this correct or not?
```ruby
class Module
# Implementation from Rails:
def anonymous?
name == '' || name.nil?
end
end
Module.new.anonymous?
# => true
my_module = Module.new do
def self.name
"Hell... -
12:00 AM Feature #19742: Introduce `Module#anonymous?`
- Agree, but that method is not `Module#name`.
-
10:38 AM Misc #19722: DevMeeting-2023-07-13
- * [Feature #19729] Store object age in a bitmap (eightbitraptor)
* Allows more control of generational GC (number of generations, when are objects old).
* Adds a bitmap to each heap page (`heap_page->age_bits`).
* Frees up one o... -
09:44 AM Revision 8142728b (git): [rubygems/rubygems] Prefer `assert_include` over mere `assert`
- https://github.com/rubygems/rubygems/commit/140405cee6
-
09:44 AM Revision a651903a (git): [rubygems/rubygems] Prefer `assert_predicate` over mere `assert`
- https://github.com/rubygems/rubygems/commit/0d10063824
-
09:44 AM Revision 67ab8b43 (git): [rubygems/rubygems] Fix argument order of `assert_equal`
- https://github.com/rubygems/rubygems/commit/a7c015f82b
-
04:21 AM Revision ddb431c9 (git): Fix leaked FD for an empty file
-
12:42 AM Feature #19708: Support `attr_reader :foo?`
- Hey Jean & Benoit, thanks for finding those prior discussions. I tried searching for them before posting, but the question mark makes it really hard to find anything relevant, haha
I think the use case is clear: defining reader method...