Activity
From 03/13/2023 to 03/19/2023
03/19/2023
-
09:15 PM Revision 2f29044d (git): RJIT: Optimize Kernel#block_given?
-
-
-
-
-
12:57 PM Revision bcd0aa89 (git): Fix -Wclobbered warning from gcc 12
- A variable modified in `EXEC_TAG` block should be `volatile`.
```
ractor.c: In function 'ractor_try_yield':
ractor.c:1251:97: warning: argument 'obj' might be clobbered by 'longjmp' or 'vfork' [-Wclobbered]
1251 | ractor_try_yield(rb_e... -
- Applied in changeset commit:git|e7342e76dfd26237c604e42f9a59a1eaa578c94e.
----------
[Bug #19485] [DOC] Mention tabs in indentation of heredoc identifier
Co-Authored-By: sawa (Tsuyoshi Sawada) <sawadatsuyoshi@gmail.com> -
- Co-Authored-By: sawa (Tsuyoshi Sawada) <sawadatsuyoshi@gmail.com>
-
07:22 AM Feature #19541 (Feedback): Proposal: Generate frame unwinding info for YJIT code
- ## What is being propsed?
Currently, when Ruby crashes with yjit generated code on the stack, `rb_print_backtrace()` is unable to actually show any frames underneath the yjit code. For example, if you send SIGSEGV to a Ruby process ru... -
-
-
-
-
-
-
-
- to upgrade libcapstone on CI
-
-
-
-
-
-
- for test_assembler.rb to work
-
-
-
03/18/2023
-
- Applied in changeset commit:git|67dd52d59cde0d2f1ebb3e299b605ed239b59f5b.
----------
[Bug #19539] Match heredoc identifier from end of line
Not to ignore leading spaces in indented heredoc identifier. -
12:47 PM Bug #19539 (Closed): Heredocs with leading spaces inconsistency
- This is more like technical inconsistency that bothers me. Not sure someone will use this in real life, but still.
This works fine:
```
puts <<' ABC'
marker with spaces
ABC
```
But this is not:
```
puts <<-' ABC'... -
05:17 PM Bug #19540 (Rejected): Undefined variable error when combining modifier if with one-line pattern matching
- This isn't a bug, this is how Ruby works. It is unrelated to pattern matching, you get the same behavior for `x if x = foo` and `x unless x = foo`. It may be unexpected if you are not used to it, though.
-
02:33 PM Bug #19540 (Rejected): Undefined variable error when combining modifier if with one-line pattern matching
- If I try to use modifier `if` with a one-line pattern matching, the variable assigned by the pattern cannot be used inside the expression to the left of the "if":
```
x if [1] in [x]
(irb):1:in `<main>': undefined local variable or me... -
- Not to ignore leading spaces in indented heredoc identifier.
-
02:37 PM Revision e8e7ff13 (git): [ruby/reline] Fix: line longer than terminal width breaks rendering
- (https://github.com/ruby/reline/pull/516)
https://github.com/ruby/reline/commit/ae5f9b87ab -
02:36 PM Bug #19537: Regexp caching algorithm since v3.2.0 causes invalid memory access
- I have not understand the implementation in detail, but maybe this patch fixes the problem.
(No new tests have been added, existing tests pass.) -
02:28 PM Bug #18743: Enumerator#next / peek re-use each others stacktraces
- Hello again. I've modified the patch to also link to the old exception via `cause`. Let me know if it's now a reasonable solution.
Thanks,
Marcelo -
01:07 PM Bug #19536 (Closed): Frozen status loss when moving objects
- Applied in changeset commit:git|cb22d78354e201ca74eba68a8b4edefb593e6754.
----------
Fix frozen status loss when moving objects
[Bug #19536]
When objects are moved between size pools, their frozen status is lost
in the shape. This wil... -
- [Bug #19536]
When objects are moved between size pools, their frozen status is lost
in the shape. This will cause the frozen check to be bypassed when there
is an inline cache. For example, the following script should raise a
FrozenErro... -
-
- The change itself looks fine, but also I’m for obsoleting CESU-8.
-
- 06:43 AM Revision 2c8f2871 (git): Fix handling of 6-byte codepoints in left_adjust_char_head in CESU-8 encoding
-
-
- RUBY_DEBUG is too slow.
-
06:02 AM Revision 05553034 (git): merge revision(s) 96d1acfdf6c6b42f2029f44d5b5920961d6efa92: [Backport #19161]
- [Bug #19161] Check for TLS usability
On all platforms using GCC, even other than darwin.
---
configure.ac | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-) -
- ruby_3_2 f3abe5ba645839fb2a686aee18d3466b59256af0 merged revision(s) 0700d0fd1c77b4fddf803dea3c10be654df600ff,62c2082f1f726cb90d8c332fbedbecf41d5d82ec.
-
03/17/2023
-
09:32 PM Revision b9f411b3 (git): YJIT: Simplify using the BITS associated constant
- All the integer types have it.
-
08:16 PM Revision 6ba07df4 (git): YJIT: make type info more specific in gen_fixnum_cmp and gen_opt_mod (#7555)
-
- It was useful for evaluating 6068da8937d7e4358943f95e7450dae7179a7763
but I think we should remove it now to make the logic around
invalidation more straight forward. -
- This assert would've caught a bug I wrote while developing
ruby/ruby#7443 so I figured it would be good to commit it
as it could be helpful in the future. - 08:11 PM Revision 5d0a1ffa (git): YJIT: Rest and block_arg support (#7557)
- * YJIT: Rest and block_arg support
* Update bootstraptest/test_yjit.rb
---------
Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com> - 08:04 PM Revision 2d97f874 (git): * remove trailing spaces. [ci skip]
-
08:04 PM Revision c7862c68 (git): [ci skip] Move rp helper to new LLDB format
- For now, the old function still exists as `old_rp`, in order to debug
issues with this command. -
07:30 PM Bug #19535: Instance variables order is unpredictable on objects with `OBJ_TOO_COMPLEX_SHAPE_ID`
- byroot (Jean Boussier) wrote in #note-3:
> > I think it's best to make the too-complex-shape objects use an ordered hash
> ...
I sent a patch [here](https://github.com/ruby/ruby/pull/7560) that implements this solution. -
05:29 PM Bug #19535: Instance variables order is unpredictable on objects with `OBJ_TOO_COMPLEX_SHAPE_ID`
- > BTW it'd be nice to have some kind of standard performance warnings for Ruby.
Interesting. I guess we could have `Warnings[:performance] = true`, with it disabled by default. I love the idea. -
- > I think it's best to make the too-complex-shape objects use an ordered hash
I would also lean on that solution, as it's the one that give a behavior that is consistent with shapes without too much changes.
> ...
Interesting.
... -
01:06 PM Bug #19535: Instance variables order is unpredictable on objects with `OBJ_TOO_COMPLEX_SHAPE_ID`
- BTW it'd be nice to have some kind of standard performance warnings for Ruby.
For instance there would be one for TOO_COMPLEX Shape, for megamorphic calls, etc.
TruffleRuby already has some of these, but an integrated way to enable/dis... -
- I chatted with @tenderlovemaking. I think it's best to make the too-complex-shape objects use an ordered hash (such case is already much slower anyway).
TruffleRuby doesn't have a too-complex shape, so that case is not a concern for Truf... -
- ### Context
I've been helping the Mastodon folks in investigating a weird Marshal deserialization bug they randomly experience since they upgraded to Ruby 3.2: https://github.com/mastodon/mastodon/issues/23644
Ultimately the bug co... -
- So the example that sparked the idea was SHAPE_TOO_COMPLEX. It would be useful to emit a warning such as:
`warning: SomeClass has too many shapes`.
Other potential ideas could be to warn when constant caches are invalidated, or thi... -
06:26 PM Feature #19538: Performance warnings
- When does the option print a warning, for example?
-
- Suggested by @Eregon.
There are program behaviors that are supported, but that we know aren't good for performance, however it's hard for users to know about them.
Now that we have warning categories, we could add a `:performance` ... -
- Applied in changeset commit:git|7142328a94c85cc5f23630396f248b32133f87ab.
----------
[Feature #19406] Allow declarative definition of references
When using rb_data_type_struct to wrap a C struct, that C struct can
contain VALUE referen... - 07:20 PM Revision cc68d692 (git): * remove trailing spaces. [ci skip]
-
-
-
-
-
- When using rb_data_type_struct to wrap a C struct, that C struct can
contain VALUE references to other Ruby objects.
If this is the case then one must also define dmark and optionally
dcompact callbacks in order to allow these objects t... -
-
- Applied in changeset commit:git|3592b24cdc07ed89eecb39161f21fe721a89a5de.
----------
ObjectSpace::WeakMap: clean inverse reference when an entry is re-assigned
[Bug #19531]
```ruby
wmap[1] = "A"
wmap[1] = "B"
```
In the example above... -
- [Bug #19531]
```ruby
wmap[1] = "A"
wmap[1] = "B"
```
In the example above, we need to remove the `"A" => 1` inverse reference
so that when `"A"` is GCed the `1` key isn't deleted. -
- * Use an `Enumerable` as factors, instead of three arguments.
* Include `assert_operator` time in rehearsal time.
* Round up max expected time. -
- `Rc` and `RefCell` both incur runtime space costs.
In addition, `RefCell` has given us some headaches with the
non obvious borrow panics it likes to throw out. The latest
one started with 7fd53eeb46db261bbc20025cdab70096245a5cbe
and is y... -
-
03:19 PM Revision 418cf344 (git): [ruby/irb] Fix 2 minor issues in test suite
- * undefine Kernel#irb_original_require in without_rdoc method
* Don't rescue all LoadErrors/NameErrors in test_rendering.rb, just
the one for require 'yamatanooroti'
https://github.com/ruby/irb/commit/52b79806ea -
- If the flag FL_FINALIZE is set, then it's guaranteed to be in the
finalizer_table, so we can directly assume that without checking. -
- Some types of regular expressions causes invalid memory access on `#match`. Length of strings to match does not matter.
For example, for regex `/^([ab]{1,3})(a?)*$/`, `"aac"` can crash ruby.
This bug may be caused in caching algorith... -
02:29 PM Revision 11f299fa (git): YJIT: skip intermediate arrays in print_sorted_exit_counts (#7547)
- Early total_exits condition.
Replace Array#sort_by/first(how_many) with Array#max_by(how_many).
Replace Array#map/max with Array#max_by, match print_counters style for longest_name_length. -
- GitHub PR: https://github.com/ruby/ruby/pull/7553
When objects are moved between size pools, their frozen status is lost in the shape. This will cause the frozen check to be bypassed when there is an inline cache. For example, the fol... -
09:50 AM Revision c65d7b4b (git): When running `bundle lock --update <name>`, checkout locked revision of unrelated git sources directly
- Since Bundler 2.4, we will try to checkout any branch specified in the
Gemfile, while until Bundler 2.3 we would directly checkout the locked
revision.
This should not make any difference in most situations, but in some edge
cases, like... -
- This was working fine for direct dependencies using
`force_ruby_platform` explicitly through Gemfile, but not for indirect
dependencies. In general, indirect dependencies do not have this
property set, but in truffleruby this is differen... -
- This should be a very rare edge case, however, it does happen when using
a .dev version of Bundler because in that case, that's the only version
that the resolver considers, and it should not be ignored.
We could've special cased this s... -
- Just like gem sources, a "style-only" change, like adding a trailing
slash, should not expire them. -
09:50 AM Revision 7800d4ee (git): util/rubocop -A --only Style/MultipleComparison
-
-
-
-
-
-
-
-
-
- https://github.com/rubygems/rubygems/commit/97f062be05
-
- https://github.com/rubygems/rubygems/commit/aa058ff6b8
-
- https://github.com/rubygems/rubygems/commit/b595d3cf0f
-
- https://github.com/rubygems/rubygems/commit/3e4f5dc008
-
- https://github.com/rubygems/rubygems/commit/01c2b5542f
-
- https://github.com/rubygems/rubygems/commit/97e0af2518
-
- https://github.com/rubygems/rubygems/commit/02d8147243
-
- https://github.com/rubygems/rubygems/commit/965fc82cfd
-
- https://github.com/rubygems/rubygems/commit/184c03270c
-
- https://github.com/rubygems/rubygems/commit/64f437a428
-
- https://github.com/rubygems/rubygems/commit/80b57da926
-
- https://github.com/rubygems/rubygems/commit/b490379eab
-
- https://github.com/rubygems/rubygems/commit/ae3bdc0e85
-
- https://github.com/rubygems/rubygems/commit/2b056b25c3
-
- https://github.com/rubygems/rubygems/commit/c766a65885
-
- https://github.com/rubygems/rubygems/commit/dae8fc70a4
-
- https://github.com/rubygems/rubygems/commit/7c1168c623
-
- https://github.com/rubygems/rubygems/commit/04227104ac
-
- https://github.com/rubygems/rubygems/commit/295691d4dc
-
- https://github.com/rubygems/rubygems/commit/23ce9793e5
-
- https://github.com/rubygems/rubygems/commit/3594945391
-
- https://github.com/rubygems/rubygems/commit/4e77a1d1d5
-
- https://github.com/rubygems/rubygems/commit/aa95ee27a2
-
- https://github.com/rubygems/rubygems/commit/823113f39e
-
- https://github.com/rubygems/rubygems/commit/91391ceedf
-
- https://github.com/rubygems/rubygems/commit/fa2e835ed2
-
- https://github.com/rubygems/rubygems/commit/860669b08a
-
- https://github.com/rubygems/rubygems/commit/add44e56eb
-
- https://github.com/rubygems/rubygems/commit/1c3356a872
-
- https://github.com/rubygems/rubygems/commit/a875fdb535
-
- https://github.com/rubygems/rubygems/commit/5c88c77873
-
- https://github.com/rubygems/rubygems/commit/cb554f6eb7
-
- https://github.com/rubygems/rubygems/commit/fba6e94de9
-
- https://github.com/rubygems/rubygems/commit/426dd97a31
-
- https://github.com/rubygems/rubygems/commit/9aa6101942
-
- https://github.com/rubygems/rubygems/commit/f4f45ab27e
-
- https://github.com/rubygems/rubygems/commit/acb0548bf6
-
- https://github.com/rubygems/rubygems/commit/a06f8ae3bb
-
- https://github.com/rubygems/rubygems/commit/0542726fd3
-
- https://github.com/rubygems/rubygems/commit/e76088b699
-
- https://github.com/rubygems/rubygems/commit/c92c6d8e85
-
- https://github.com/rubygems/rubygems/commit/8e64298989
-
- https://github.com/rubygems/rubygems/commit/ad1fe68d97
-
- https://github.com/rubygems/rubygems/commit/48c88466b7
-
- https://github.com/rubygems/rubygems/commit/4d680320e3
-
- https://github.com/rubygems/rubygems/commit/c6de27fc6d
-
- https://github.com/rubygems/rubygems/commit/75abd2e504
-
- https://github.com/rubygems/rubygems/commit/00117e69cc
-
- https://github.com/rubygems/rubygems/commit/4a5b70b508
-
- https://github.com/rubygems/rubygems/commit/bf33d106d0
-
- https://github.com/rubygems/rubygems/commit/5070f90987
-
- https://github.com/rubygems/rubygems/commit/58e4885493
-
- https://github.com/rubygems/rubygems/commit/d8efd919db
-
- https://github.com/rubygems/rubygems/commit/976a351f8b
-
- https://github.com/rubygems/rubygems/commit/893da27e7c
-
- https://github.com/rubygems/rubygems/commit/46d5d6d1d3
-
- https://github.com/rubygems/rubygems/commit/07b0da6c24
-
- https://github.com/rubygems/rubygems/commit/fe331736d4
-
- https://github.com/rubygems/rubygems/commit/b420e287a3
-
- https://github.com/rubygems/rubygems/commit/16f381be4b
-
- https://github.com/rubygems/rubygems/commit/7750d5c460
-
- I've seen this error sometimes but never found it helpful, since the
culprit has never been thread/monitor related, so it just adds noise.
Right now I'm seeing an issue in CI where we seem to be crashing during
ensure and showing a weir... -
- https://github.com/rubygems/rubygems/commit/ac23687353
-
- https://github.com/rubygems/rubygems/commit/ef4741b7cb
-
- Otherwise we get
```
✗ rake TEST=test/rubygems/test_project_sanity.rb
Loaded suite /Users/deivid/.gem/ruby/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader
Started
E
======================================================================... -
- https://github.com/rubygems/rubygems/commit/98de85c11e
-
- https://github.com/rubygems/rubygems/commit/24d2bf9cb2
-
- https://github.com/rubygems/rubygems/commit/86b574824d
-
- To make it easier to change the default platforms that get locked later.
https://github.com/rubygems/rubygems/commit/255c4012ec -
- https://github.com/rubygems/rubygems/commit/27ed6870ce
-
- https://github.com/rubygems/rubygems/commit/3841a58095
-
- Nicer :)
https://github.com/rubygems/rubygems/commit/c0ab2893c3 -
08:58 AM Bug #19533: Behavior of ===/include? on a beginless/endless range (nil..nil) changed in ruby 3.2
- mame (Yusuke Endoh) wrote in #note-2:
> In #18580, @matz said:
> ...
Thanks for the info. This hurts not only because the behavior changed without notice (in the NEWS file) but because it broke the useful feature. Before the change, ... -
- In #18580, @matz said:
> I decided to make `include?` to raise exception for beginless/endless non-numeric ranges.
and `(nil..nil)` is considered as a non-numeric range. -
- Starting from Ruby 2.7.0 a range `nil..nil` used to match any value until 3.2.0-preview3, but 3.2.0-rc1 started to reject it.
```
% docker run -it --rm rubylang/all-ruby ./all-ruby -e 'p( (nil..nil) === 1 )'
(snip)
ruby-2.6.10 ... -
07:32 AM Bug #19534 (Closed): [ruby 3.2.1] Regular expression comparisons may be slower than in older versions.
- Hello Sir.
When scanning a string with a regular expression created using many Japanese words, there was a slowdown compared to older versions.
I hope it will be fixed.
- Environment
```
% ruby -v
ruby 3.2.1 (2023-02-08 revision ... - 04:53 AM Revision c0866f8a (git): Bump actions/cache from 3.2.6 to 3.3.1
- Bumps [actions/cache](https://github.com/actions/cache) from 3.2.6 to 3.3.1.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.co... -
- Fix indentation in vm_setivar_default
---
vm_insnhelper.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[Bug #19469] Fix crash when resizing generic iv list
The following script c... -
- ruby_3_2 b309c246ee70926d593d3857e1625202e2d0f67b merged revision(s) d78ae78fd76e556e281a743c75bea4c0bb81ed8c.
-
- Unfortunately, this change broke an existing program: #19533.
The lesson here is that it would be best to avoid changing any behavior just for the sake of consistency unless it is proven that the behavior actually confuses a large num... - 04:17 AM Revision c7ae6f6a (git): Bump actions/checkout from 3.3.0 to 3.4.0
- Bumps [actions/checkout](https://github.com/actions/checkout) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](http... - 03:38 AM Revision 53ebd484 (git): Bump ruby/setup-ruby from 1.144.0 to 1.144.1
- Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.144.0 to 1.144.1.
- [Release notes](https://github.com/ruby/setup-ruby/releases)
- [Commits](https://github.com/ruby/setup-ruby/compare/9669f3ee51dc3f4eda8447ab696b3ab19a... -
- rb_str_modify_expand: clear the string coderange
[Bug #19468]
b0b9f7201acab05c2a3ad92c3043a1f01df3e17f errornously stopped
clearing the coderange.
Since `rb_str_modify` clears it, `rb_str_modify_expand`... -
- ruby_3_2 b73a07359758a9034996752e981e09ddaffe8d87 merged revision(s) 0eb634ae73cb327ede833b72492f912792a4a9d5.
-
01:15 AM Feature #18951: Object#with to set and restore attributes around a block
- temp_set might be a better method name
-
12:50 AM Revision f29c9d6d (git): compile branch body if needed
- ```ruby
if true
THEN
else
ELSE
end
```
On this case, ELSE is not needed so that only compile THEN part.
03/16/2023
-
- * Fix temporary methods on Object leaking across test cases.
* Remove temporary classes/modules leaking across test cases. - 09:40 PM Revision 5825d7d4 (git): YJIT: Remove exit for rest and send combo (#7546)
-
- This measures the impact of changes made by @jhawthorn last year.
-
09:16 PM Revision 617c9b46 (git): Rename opes to operands on RubyVM::BaseInstruction
-
- Co-authored-by: Aaron Patterson <aaron.patterson@gmail.com>
-
-
-
-
- I closed https://github.com/ruby/ruby/pull/7543, but part of the diff
seems useful regardless, so I extracted it. -
- This reverts commit cae4342dd559e34c1ce6219593f77f0ad80286da.
This is failing a lot of CIs and nobody is actively looking into fixing
it. Let me revert this until we have a solution to it. -
03:45 PM Bug #19412: Socket starts queueing and not responding after a certain amount of requests
- Some other updates. I've been trying to undestand the `TIME_WAIT` and why it does behave the way it doesn on MacOS (but not on Linux).
This response got me ideas to try setting `linger` on:
https://stackoverflow.com/questions/3757289/wh... -
- when the pause happens it seems the socket is still kept alive, based on netstat:
(there is a huge list of those):
```
tcp4 0 0 localhost.http-alt localhost.56818 TIME_WAIT
tcp4 0 0 localhost.ht... -
- @jeremyevans0 I'm new to debugging C code. Your idea on filedescriptors seems to to be somewhat spot on.
I'm not sure if this is the right way to debug this or not, but I managed to capture "Filesystem activity" through MacOS instrum... -
- This is useful for crash triaging. It also helps to hint extension
developers about the misuse of `rb_thread_call_without_gvl()`.
Example:
$ ./miniruby -e 'Ractor.new{Ractor.receive};
Thread.new{sleep}; Process.kill:SEGV,Pr... -
- ```ruby
irb(main):001:0> "\u{10000}".encode("cesu-8").chop
=> "\xED\xA0\x80"
```
But it should be `""`.
Fix in https://github.com/ruby/ruby/pull/7510 -
- To the backport manager: in addition to the two commits above, please also ensure to backport commit [e0cf80d666d4b5df3229f030a16d10d21323508e](https://github.com/ruby/ruby/commit/e0cf80d666d4b5df3229f030a16d10d21323508e) because there c...
-
- In wmap_final_func, j is the number of elements + 1 (since j also
includes the length at the 0th index), so we should resize the buffer
to size j and the new length is j - 1. -
01:59 PM Revision 671ddb1e (git): [DOC] Enhanced RDoc for TrueClass (#7521)
-
- https://github.com/rubygems/rubygems/commit/97add0d1d7
-
- String#unpack("C*") is equivalent to String#bytes and Array#inject {|a,b| a + b } is equivalent to Array#sum.
This is a minor enhancement in terms of speed and readability. -
- @ioquatix I think you need to explain the design of your reloading and usages of anonymous modules and why it's so important that we should modify Ruby for it.
Also maybe why Zeitwerk is not enough for you.
For `labeled_module` and `... -
- @Dan0042 Right, the rule is not as simple, indeed.
Of course `a::B` is not a fully-named constant here, so this is "temporary name" for `a::B`, which is what I was thinking about.
> Since `a::B.name` is neither nil nor resolvable to ... -
- fxn (Xavier Noria) wrote in #note-26:
> We also know the coupling ends there. These entities ar highly decoupled in Ruby by design. I can have `C = Class.new; c = C; remove_const :C`, and the class in `c` is no longer reachable through ... -
01:39 AM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
- Eregon (Benoit Daloze) wrote in #note-17:
> IIRC naming of constants under a module is only done if a module is fully-named
Actually that's incorrect since 3.0
```ruby
a = Module.new
a::B = Module.new
a::B.name #=> "#<Module:0x00007f6c2... -
- * Use an `Enumerable` as factors, instead of three arguments.
-
09:37 AM Revision 5cffa69c (git): [DOC] Add missing escape
- Before:
```
* + corresponds to $+, which contains last capture group.
```
After:
```
* \+ corresponds to $+, which contains last capture group.
``` -
- Applied in changeset commit:git|b3a271665b6d45fe21e775e1c523a040caa509a9.
----------
[Feature #19442] Remove USE_RINCGC flag
Ruby doesn't compile when this is set to 0. Let's remove it. -
- Ruby doesn't compile when this is disabled, and it's not tested on CI.
We should remove it.
Co-Authored-By: Peter Zhu <peter@peterzhu.ca> -
- Ruby doesn't compile when this is set to 0. Let's remove it.
-
- Patch: https://github.com/ruby/ruby/pull/7540
-
- A tentative measures fo https://github.com/ruby/openssl/issues/606.
With OpenSSL 3.1.0, the error message at connection using "self-signed
certificate" seems to return `SSL_R_TLSV1_ALERT_UNKNOWN_CA` instead of
`SSL_R_CERTIFICATE_VERIFY_... - 03:38 AM Revision a6c447d4 (git): Bump github/codeql-action from 2.2.6 to 2.2.7
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.6 to 2.2.7.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
... -
- https://github.com/rubygems/rubygems/commit/3139587be9
-
- https://github.com/rubygems/rubygems/commit/d4938259c4
03/15/2023
-
11:50 PM Feature #19520: Support for `Module.new(name)` and `Class.new(superclass, name)`.
- This is a long thread, I was not aware of it.
Let me say that nobody can assume from the name of a class or module that the corresponding constant exists. Class and module objects get their name when they are first assigned to a const... -
- To be clear, Zeitwerk works only with constants. When you load `foo.rb`, the constant `:Foo` has to exist in `Object`, Zeitwerk does not care if the classes or modules went through an initial anonymous period. It also does not care if th...
-
- > I don't think it's uncommon to cache instances of a class in some global mapping. Does Zeitwerk reload the entire namespace or just ones that changed? I don't know enough about it. @fxn (Xavier Noria) any thoughts on how this is handle...
-
- In fact, implementing `labeled_module`/`labeled_class` like you showed above would again break these expectations, illustrating how unsafe is this API, and it's clear many people writing such tests wouldn't realize this problem (they mig...
-
- > Also, it looks like Zeitwerk absolutely can reload code and create confusion
This is again an unrealistic completely made up example and I would think an invalid usage of Zeitwerk.
For real code, you don't reload in the middle of a... -
- > As demonstrated, if users want to do this, it's already possible.
Yes, and it just doesn't matter much in practice because it almost never or never happens in real code.
The point is if the name of a Module doesn't correspond to ho... -
-
- I kept getting unused warnings for this macro on A64 macOS.
-
-
-
-
-
- Somewhat important because having the lock is a key part of the
soundness reasoning for the `unsafe` usage here. -
- ### Reproduction script
```ruby
wmap = ObjectSpace::WeakMap.new
a = "A"
b = "B"
wmap[1] = a
wmap[1] = b # the table entry with 1 is still in the list of entries to clear when `a` is GCed
a = nil
GC.start
p wmap[1] # ... -
- to see if it stabilizes Cirrus CI.
-
- brodock (Gabriel Mazetto) wrote in #note-9:
> @jeremyevans0 I've tested again in MacOS system provided ruby version:
> ...
In your pure Ruby hey-example, you have `CONCURRENCY = 512`, but your server has `BACKLOG = 50`. You would want... -
- @jeremyevans0 I've tested again in MacOS system provided ruby version:
```
ruby --version
Could not... -
- I've also tried to build something similar to "hey" in ruby and couldn´t make it crash (this is likely because of the GVL, we can´t get real concurrency):
```ruby
require 'bundler/inline'
gemfile do
source 'https://rubygems.or... -
- I've went back to my Linux machine and tried to reproduce the problem.
Using Ruby 3.0 (from the package manager), I got to make it crash only using some decent concurrency (100) and running it for longer time:
```
brodock@pop-os:~/Proj... -
03:07 PM Bug #19485: Unexpected behavior in squiggly heredocs
- sawa (Tsuyoshi Sawada) wrote in #note-3:
> For the purpose of measuring an indentation, a horizontal tab is regarded as a sequence of one to eight spaces such that the column position corresponding to its end is a multiple of eight. T... -
- Another condition could be only accept tabs in squiggly heredoc if they prefix all lines of the squiggly heredoc? (otherwise SyntaxError, including for the 2 cases in the description)
(I wish tabs would just not be accepted as indenta... -
08:40 AM Bug #19485: Unexpected behavior in squiggly heredocs
- I don't think it's a good idea to assume a tab is 8 spaces.
Regarding indentation, it might be a nice simplification to only consider the first line in the squiggly heredoc. That's what I've done in the past - it's predictable and easy ... -
07:57 AM Bug #19485: Unexpected behavior in squiggly heredocs
- nobu (Nobuyoshi Nakada) wrote in #note-2:
> My [draft] is:
> ...
I find the sentence too long and a little too difficult to parse/understand. What about something like this:
> For the purpose of measuring an indentation, a horizontal ta... -
- My [draft] is:
> Note that the "indentation" is counted like as each horizontal tabs are
> ...
Does this make sense?
[draft]: https://github.com/nobu/ruby/tree/doc-heredoc-indentation -
- * Make EC required on JIT state
Lets make EC required on the JITState object so we don't need to
`unwrap` it.
* Minor nitpicks
---------
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com> -
- Regarding the original report, there is a clear solution now with `to_h`:
```ruby
1000.times.each_slice(2).to_a.to_h
# or
1000.times.each_slice(2).to_h
``` -
- In other words, for efficiency arguments need to be passed on the stack, e.g. for JITed code.
Sure it could be possible to have special handling for "too many arguments" and do something else, but that means making Ruby slower in general... -
- My opinion as a TruffleRuby implementer is I don't think TruffleRuby will or can support that.
So at least it should be clear that's not something really supported by the Ruby language in general.
User code shouldn't pass a million argu... -
- https://github.com/rubygems/rubygems/commit/69aa007679
-
- https://github.com/rubygems/rubygems/commit/bf4382e7a7
-
- https://github.com/rubygems/rubygems/commit/4f2f2ad412
-
- * Add `rehearsal` keyword argument
* Stop repeating with the same factor -
- Applied in changeset commit:git|ca437aeb395e77125fcd2ab9bc83bbcd3e357610.
----------
rb_ary_sum: don't enter fast path if initial isn't a native numeric type.
[Bug #19530]
If the initial value isn't one of the special cased types, we ... -
- [Bug #19530]
If the initial value isn't one of the special cased types, we directly
jump to the slow path. -
- It was a bug. fixed https://github.com/ruby/ruby/pull/7507
Thank you! -
- On `f(*a, **kw)` method calls, a rest keyword parameter is identically
same Hash object is passed and it should make `#dup`ed Hahs.
fix https://bugs.ruby-lang.org/issues/19526 -
- Thanks!
-
- ruby_3_2 db28f7003f7d49cfa13871c38d10c1967282ca6b merged revision(s) 3b567eb491e460e00a66fdea8054eeb083b5dafd.
-
- YJIT: Detect and reject `send(:alias_for_send, :foo)`
Previously, YJIT failed to put the stack into the correct shape when
`BasicObject#send` calls an alias method for the send method itself.
This can manifest as... - 06:48 AM Revision 7fd53eeb (git): Remove SIGCHLD `waidpid`. (#7527)
- * Remove `waitpid_lock` and related code.
* Remove un-necessary test.
* Remove `rb_thread_sleep_interruptible` dead code. -
- `*pcnt++` just dereferences `pcnt` then increments the local variable,
but has no side effect. -
- https://github.com/rubygems/rubygems/commit/72169288ff
-
- https://github.com/rubygems/rubygems/pull/6444, I have no idea to
migrate this test to bundler example
yet
https://github.com/rubygems/rubygems/commit/0d869019bf -
- Gem::Specification#missing_extension? is heavily called from RubyGems.
We should reduce extra method call from this place.
https://github.com/rubygems/rubygems/commit/e24e59d44d -
- To the backport manager: please ensure to also backport commit [3dc8cde70078ccb38f5f4b0818ad5eecded01bd5](https://github.com/ruby/ruby/commit/3dc8cde70078ccb38f5f4b0818ad5eecded01bd5) because the fix above has a bug.
-
- [Bug #19529]
The fix for [Bug #19529] in commit 548086b contained a bug that crashes
on the following script:
```
wm = ObjectSpace::WeakMap.new
obj = Object.new
100.times do
wm[Object.new] = obj
GC.start
end
GC.compact
```
03/14/2023
-
- I'm reopening this issue.
Originally, when commit:2e7bceb34ea858649e1f975a934ce1894d1f06a6 fixed cfuncs to no longer use the VM stack for large array splats, it was thought to have fully fixed this issue, since the issue was fixed for... -
-
- Also, it looks like Zeitwerk absolutely can reload code and create confusion, and in addition, appending `file:line` information would not avoid that confusion.
https://github.com/ioquatix/zeitwerk-reload
Adjusting `remove_const` to tu... -
- > I had a call with @ioquatix (Samuel Williams), trying to explain the importance of the name that Ruby shows us, for example:
> ...
As demonstrated, if users want to do this, it's already possible.
```ruby
Foo = Module.new
#=> Foo
Foo... -
- Another thought: maybe a much simpler way to solve most of these use-cases is adding `Module#source_location`, which is the `[file, line]` at which the Module was created.
That could also work for anonymous modules, they could capture at... -
- I had a call with @ioquatix, trying to explain the importance of the name that Ruby shows us, for example:
`undefined method 'zzz' for #<Foo::Bar:0x00007efc38711fc0> (NoMethodError)`
people will of course expect that `Foo::Bar` refers ... -
- Use [bigdecimal-3.1.2](https://github.com/ruby/bigdecimal/releases/tag/v3.1.2) or later.
-
10:01 PM Bug #18604: [BUG] ERROR(VpDivd): space for remainder too small
- got same issue here with any ruby 3.1.x version:(
Any news? -
- This was used only by MJIT.
-
- * Break up jit_exec from vm_sendish
* YJIT: Implement throw instruction
* YJIT: Explain what rb_vm_throw does [ci skip] -
- brodock (Gabriel Mazetto) wrote in #note-4:
> I've also run a version of your client and got to reproduce the error (with similar output):
> ...
I tried that client program in my environment (OpenBSD/amd64), and was able to run it with... -
- @jeremyevans0
running apache benchmark with `-c1` does show some of the behavior. It will go from 0 to somethign around 16000 in 4 seconds and get stuck there, see a 3x run log:
```
ab -n 20000 -c 1 http://127.0.0.1:8080/ ... -
- * YJIT: Allow testing assembler with disasm
* YJIT: Drop new dependencies
* YJIT: Avoid address manipulation
* YJIT: Introduce assert_disasm! macro
* YJIT: Update the comment about assert_disasm -
- Please understand that while Ruby giving you the crash report
saying `[BUG] object allocation during garbage collection phase`
is the proximate cause of the problem, I'm telling you that
the ultimate cause is likely a bug in the IBM g... -
03:16 AM Bug #19527: Object allocation during garbage collection phase
- Hi everyone.
As I mentioned the first thing I did was check the issue with IBM, if you check the stack message, our application (PEC) is started, then it establish the connection to the database using IBM_GEM and this error is triggered... -
- Applied in changeset commit:git|548086b34e3dd125edabf5dc1e46b891fad3ea9c.
----------
ObjectSpace::WeakMap: fix compaction support
[Bug #19529]
`rb_gc_update_tbl_refs` can't be used on `w->obj2wmap` because it's
not a `VALUE -> VALUE` ... -
- Proposed patch: https://github.com/ruby/ruby/pull/7518
-
- Looking at the code, the `dcompact` function is wrong:
```c
static void
wmap_compact(void *ptr)
{
struct weakmap *w = ptr;
if (w->wmap2obj) rb_gc_update_tbl_refs(w->wmap2obj);
if (w->obj2wmap) rb_gc_update_tbl_refs(w... -
- Reproduction script:
```ruby
wm = ObjectSpace::WeakMap.new
obj = Object.new
100.times do |i|
GC.compact
wm[i] = obj # [BUG] Segmentation fault at 0x0000000000000001
end
```
Crash report:
```
/tmp/weakmap.rb:5: [BUG]... -
- [Bug #19529]
`rb_gc_update_tbl_refs` can't be used on `w->obj2wmap` because it's
not a `VALUE -> VALUE` table, but a `VALUE -> VALUE *` table, so
we need some dedicated iterator. -
- Proposed patch: https://github.com/ruby/ruby/pull/7519
-
- Looking at `Array#sum` implementation, it very clearly has a fast path for when all the elements of the array are native numeric types, with a fallback for other objects. But it also doesn't check the initial value type before going in t...
-
07:57 AM Bug #19530 (Closed): `Array#sum` and `Enumerable#sum` sometimes show different behaviours
- Hi everyone. 👋🏻
We recently discovered that `Array#sum` and `Enumerable#sum` will output different results in some edge cases.
Here's the smallest script I managed to write to reproduce the issue:
``` ruby
class Money
def in... - 07:07 AM Revision ac65ce16 (git): Revert SIGCHLD changes to diagnose CI failures. (#7517)
- * Revert "Remove special handling of `SIGCHLD`. (#7482)"
This reverts commit 44a0711eab7fbc71ac2c8ff489d8c53e97a8fe75.
* Revert "Remove prototypes for functions that are no longer used. (#7497)"
This reverts commit 4dce12bead3bfd91fd8... -
-
- Somehow btest-ruby is running miniruby. Not sure why.
https://github.com/ruby/ruby/actions/runs/4412043427/jobs/7731124729#step:16:402
For RJIT's experimental purposes, having just one CI is enough. I'd like
to focus on keeping .github/... - 04:08 AM Revision 5868a784 (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.65 to 0.9.67.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.65...v0.9.67)
---
updated-depende... -
- This seems to be used nowhere today.
-
- It's removed at 4445b9e2a2dda207a2b3698c042342dd794b1b35
-
- 03:39 AM Revision 1c8e69d6 (git): Bump ruby/action-slack from 3.0.0 to 3.2.1
- Bumps [ruby/action-slack](https://github.com/ruby/action-slack) from 3.0.0 to 3.2.1.
- [Release notes](https://github.com/ruby/action-slack/releases)
- [Commits](https://github.com/ruby/action-slack/compare/b6882ea6ef8f556f9f9af9ec1220d3... -
01:42 AM Revision 4e6c9567 (git): Use __builtin_ppc_get_timebase on POWER with clang
03/13/2023
-
- Unfortunately, the traces are not very helpful.
But I agree, it's likely an issue with the [IBM gem](https://github.com/ibmdb/ruby-ibmdb)
and not a Ruby issue.
Here is a guess as to what's happening: the traces indicate that it's cr... -
09:22 PM Bug #19527: Object allocation during garbage collection phase
- Seems to be identical indeed.
-
09:10 PM Bug #19527: Object allocation during garbage collection phase
- Isn't this a duplicate of #19524? I don't think you will get a different answer to this ticket from the one that was given in that ticket. The bug is indicating that a C-extension (probably, the IBM DB Adapter) is allocating during garba...
-
- We are currently developing a Ruby based web application which connects to a DB2 Database and we have been using ibm_db-5.4.0 to establish a connection, suddenly we got a error related to RUBY garbage collector PHASE.
We have checked ... -
- https://github.com/ruby/rbs/pull/1274
-
-
- I'm not sure if it was actually intended, but there's some tacit naming convention for serializers in Ruby to use `load` and `dump` as methods, likely inspired from `Marshal` and `YAML`.
Because of this it's extremely common to see co... -
06:11 PM Revision 309ff928 (git): [ruby/irb] Replace METHOD_IS_A with ===
- (https://github.com/ruby/irb/pull/542)
https://github.com/ruby/irb/commit/edd6c30e16 -
-
- ko1 (Koichi Sasada) wrote in #note-13:
> I think this reason violates (1).
What do you mean?
AFAIK https://github.com/ruby/timeout/issues/17#issuecomment-1464039853 is correct.
If it's incorrect, please point the mistake in my reas... - 03:12 PM Revision 45127c84 (git): YJIT: Handle rest+splat where non-splat < required (#7499)
-
- (https://github.com/ruby/irb/pull/541)
https://github.com/ruby/irb/commit/1dc2a406a3 -
- ... which made a test fail
http://rubyci.s3.amazonaws.com/debian10/ruby-master/log/20230313T213003Z.fail.html.gz
```
1) Failure:
TestRubyOptions#test_enable [/home/chkbuild/chkbuild/tmp/build/20230313T213003Z/ruby/test/ruby/test_ruby... -
- I think what's happening here is that tabs are not converted directly to 8 spaces, but to "move ahead to next multiple of 8 chars". So in that sense "\t" and " \t" are equivalent. It's the same behavior as `10.times{ |i| print " "*i,"\t...
-
- Yeah I know.
timeout.rb already has this workaround: https://github.com/ruby/timeout/pull/25/files
If `ThreadGroup#enclose` becomes deprecated then usages of `enclose` will become increasingly rarer and so having that workaround matter... -
- Even if `ThreadGroup` were to be deprecated in 3.3, it can't help previous versions with the current timeout.rb.
-
- https://github.com/rubygems/rubygems/pull/2216 is imcomplete to remove this method.
https://github.com/rubygems/rubygems/commit/34ef915d12 -
09:31 AM Bug #19476 (Closed): Regexp unexpected partial match
- Applied in changeset commit:git|dddc542e9b61b292d80a96d0d0efbbf58719e3be.
----------
[Bug #19476]: correct cache index computation for repetition (#7457) -
- 07:02 AM Revision 1e73bdbf (git): Update bundled gems list at 2023-03-13
-
- btest can't be used for testing RJIT because RJIT doesn't work on
miniruby. However, btest-ruby is not necessarily useful for testing RJIT
because both the runner could crash as well as the target.
TBH I'm not sure why we want to use RU... - 06:46 AM Revision 7686687a (git): * remove trailing spaces. [ci skip]
-
- Applied in changeset commit:git|e22c4e8877677ff90805e4a4dcbdef80f4220136.
----------
[Bug #19467] correct cache points and counting failure on `OP_ANYCHAR_STAR_PEEK_NEXT` (#7454) -
-
-
-
- and import a missing function
-
-
- peek_at_stack was doubly accounting for C::VM_CALL_ARGS_BLOCKARG, which
made that case always side-exit and hide this bug.
When a block handler is block param proxy, you have to set LEP's specval
as next specval instead of block param p... -
- like YJIT does
-
-
- 03:34 AM Revision 45fdc180 (git): Bump github/codeql-action from 2.2.5 to 2.2.6
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.5 to 2.2.6.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
...