Activity
From 02/16/2023 to 02/22/2023
02/22/2023
-
09:22 PM Revision e9e4e1cb (git): YJIT: Introduce Opnd::Stack (#7352)
- 09:09 PM Revision 4f48debd (git): * remove trailing spaces. [ci skip]
-
09:09 PM Revision 29ec8e15 (git): Make GC faster when RGENGC_CHECK_MODE >= 2
- We shouldn't run gc_verify_internal_consistency after every GC step
when RGENGC_CHECK_MODE >= 2, only when GC has finished. Running it
on every GC step makes it too slow. -
09:07 PM Feature #19458 (Open): Expose HEREDOC identifier
- I’d like to have access to the HEREDOC identifier.
In the ViewComponent framework I help maintain, we added a method to declare a template as such:
```ruby
class Component
erb_template <<~ERB
<h1>Hello, <%= @name %>!</h1>
... -
08:02 PM Misc #18761: provide an example wasm project
- > need more getting started instructions?
I think it may be helpful if there would be something like a "mini-tutorial", in the sense that you could go from a super simple use case (hello world), towards something that is a bit more usef... -
07:51 PM Feature #19457 (Closed): Some improvements to test-all suite
- Hi, I've been making some improvements to this suite in a branch of my own and came up with a list of changes I think are good but I would like input from developers.
1) Currently test-all with -j option does not show errors/failures ... -
07:26 PM Revision 220cdbee (git): [lldb] Add a print_flags command (#7358)
-
04:09 PM Bug #19455: Ruby 3.2: wrong Regexp encoding with non-ASCII comments
- I'm not sure that this a bug. If all non-comment characters considered in the regexp are in the US-ASCII range, it seems reasonable for US-ASCII to be used as the regexp encoding. I'll add this ticket to the next developer meeting and ...
-
10:18 AM Bug #19455 (Closed): Ruby 3.2: wrong Regexp encoding with non-ASCII comments
- comments and comment groups don't trigger the correct `Regexp#encoding` on Ruby 3.2 anymore:
```ruby
# ruby 3.1
/#a/x.encoding # => #<Encoding:US-ASCII> # OK
/(?#a)/.encoding # => #<Encoding:US-ASCII> # OK
/#ü/x.en... -
- GitHub PR: https://github.com/ruby/ruby/pull/7357
If the previous instruction is not a leaf instruction, then the PC was incremented before the instruction was ran (meaning the currently executing instruction is actually the previous ... -
01:58 PM Revision 4edb2a29 (git): [ruby/net-http] [DOC] Enhanced RDoc for Net:HTTP
- (https://github.com/ruby/net-http/pull/124)
https://github.com/ruby/net-http/commit/aaf26b21d6 -
01:14 PM Revision b112ae99 (git): Skip failing test on MSWin
-
10:00 AM Revision 65ab2c1e (git): Backport [Bug #19158] for Ruby 3.2 (#7356)
- Backport https://github.com/ruby/ruby/pull/7321
-
09:02 AM Bug #19454: Instruction `send` has nil blockiseq and ARGS_SIMPLE flag
- > It seems test-unit turns off specialized_instruction in RubyVM::InstructionSequence.compile_option.
Indeed, thank you. Where can I find the description of each compile flags?
> ...
I support the proprietary gem debugger. And this is ... -
08:42 AM Revision 6232e1b9 (git): [rubygems/rubygems] Skip extension test on jruby
- https://github.com/rubygems/rubygems/commit/38ee82c297
-
- https://github.com/rubygems/rubygems/commit/5fa0ebf09b
-
- Gem.path_separator can also be a regexp...
https://github.com/rubygems/rubygems/commit/7e6e56a5f3 -
- Will save on an error if it would be nil from an exception happening during that line
https://github.com/rubygems/rubygems/commit/d6797a04e9 -
- https://github.com/rubygems/rubygems/commit/3135ad91d4
-
- For ruby-core compat
https://github.com/rubygems/rubygems/commit/c8f85c91a8 -
- https://github.com/rubygems/rubygems/commit/f6877c29b9
-
- https://github.com/rubygems/rubygems/commit/13a6dd4992
-
- https://github.com/rubygems/rubygems/commit/a767f7b9be
-
- Also fix native extensions that load dependencies
https://github.com/rubygems/rubygems/commit/a06f9870c7 -
- https://github.com/rubygems/rubygems/commit/664f3e1e5f
-
- https://github.com/rubygems/rubygems/commit/dac1609fd5
-
- https://github.com/rubygems/rubygems/commit/3078e5834e
-
- https://github.com/rubygems/rubygems/commit/ca69a317f3
-
08:03 AM Feature #19443: Cache `Process.pid`
- > How to read comment #7 results?
It's a flat reduction on our latency (server response time) metrics.
On average, with the pid_cache shim, our server response time is 2 milliseconds faster.
Also to note, we're still seeing quit... -
02:44 AM Feature #19443: Cache `Process.pid`
- Thank you.
How to read comment [#7](https://bugs.ruby-lang.org/issues/19443#note-7) results?
-
-
- I submitted pull-requests for Ruby 3.1 and 3.2.
* [for Ruby 3.1](https://github.com/ruby/ruby/pull/7355)
* [for Ruby 3.2](https://github.com/ruby/ruby/pull/7356)
In my investigation, this issue only happened in-place build with ru... -
- 04:11 AM Revision 65ef20d2 (git): Add support for LoongArch (#7343)
- * vm_dump.c: Dump machine registers on loongarch64 Linux.
* coroutines: Support for native loongarch64 coroutines.
---------
Co-authored-by: zangruochen <zangruochen@loongson.cn> - 02:56 AM Revision 2798b13e (git): Bump actions/cache from 3.2.5 to 3.2.6
- Bumps [actions/cache](https://github.com/actions/cache) from 3.2.5 to 3.2.6.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.co... -
-
-
- Partly reverted 1ddda4c0d7d2b83658ab149e36e088961ca0b2dc
-
- https://github.com/ruby/readline-ext/commit/9245965ecd
-
- https://github.com/ruby/readline-ext/commit/efe2be6e4c
-
- https://github.com/ruby/readline-ext/commit/f034697a48
02/21/2023
-
10:07 PM Feature #18285: NoMethodError#message uses a lot of CPU/is really expensive to call
- mame (Yusuke Endoh) wrote in #note-38:
> ```
> ...
I think that's quite confusing though without the `main:Object`, because `main` has many other meanings (main script = $0, main function, etc).
So I'd suggest either:
```
undefined ... -
09:34 PM Feature #18285: NoMethodError#message uses a lot of CPU/is really expensive to call
- Thank you! :)
-
09:59 PM Revision ae9e1aee (git): Call rb_ivar_set instead of exiting for many ivars
- Previously, when we have a lot of ivars defined, we would exit via
`jit_chain_guard` for megamorphic ivars. Now if we have more than the
max depth of ivars we can call `rb_ivar_set` instead of exiting.
Using the following script:
```ru... -
09:41 PM Revision 9f8056a7 (git): YJIT: Fastpath for Module#=== (#7351)
- Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com>
Co-authored-by: Jimmy Miller <jimmy.miller@shopify.com> -
-
07:38 PM Revision 50e77b6a (git): [ruby/irb] Improve RubyLex's tests
- (https://github.com/ruby/irb/pull/484)
* Improve assert_indenting helper
Instead of putting assertions inside the `auto_indent` block, we
can just make `auto_indent` return the calculated space count, and use
it for assertion outside o... - 06:21 PM Revision 5baef075 (git): YJIT: Fix clippy issues and remove unused params (#7348)
- * YJIT: Fix clippy issues and remove unused params
* Remove an unnecessary whitespace
---------
Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com> -
-
05:13 PM Bug #19439: Marshal.load doesn't load Regexp instance variables
- Thank you!
-
- Applied in changeset commit:git|d2520b7b76759118071a16e6bca22726a5de9fb4.
----------
Marshal.load: restore instance variables on Regexp
[Bug #19439]
The instance variables were restore on the Regexp source,
not the regexp itself.
Unf... -
-
-
-
- Minitest repository does not commit its gemspec file.
-
-
-
- It seems test-unit turns off `specialized_instruction` in `RubyVM::InstructionSequence.compile_option`.
> This breaks some of the logic of the dependent program .
What is "the dependent program"? -
- ### Setup
* OS: MacOS Monterey 12.4
* VM: rbenv
* Gems: test-unit 3.5.3
* Ruby: ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [x86_64-linux]
### Problem Description
In some cases the instruction `send` has `nil` block arg... -
- > You can show your support for this issue by clicking "like" in the top right corner
Aha - I did not notice that before.
> ...
This is a situational question, though, as to what is to be considered "meaningful".
Ultimately it taps int... -
- Applied in changeset commit:git|93ac7405b80cc61930d73da04441fa09af1851e1.
----------
Add marking and sweeping time to GC.stat
There is a `time` key in GC.stat that gives us the total time spent in
GC. However, we don't know what propor... -
- 03:36 PM Revision ace116fc (git): Update default gems list at 0cde887eb9fd47b9857c9e4a7fbafc [ci skip]
-
- ruby/bigdecimal#187 has changed a behavior and ruby/spec also needed a
follow up at https://github.com/ruby/ruby/commit/0d8ef62fc293.
However, because bigdecimal is a separate gem and can be updated in
older versions of ruby, `RUBY_VERSI... -
- https://github.com/ruby/bigdecimal/commit/b66ef9fbb5
-
- * This is not supported on TruffleRuby, which requires the value to be
set before RB_GC_GUARD() is called.
* See https://github.com/oracle/truffleruby/pull/2879
https://github.com/ruby/bigdecimal/commit/7b2957922f -
- - [Feature #19437] Add marking and sweeping time to GC.stat (peterzhu2118)
- This feature records GC time in marking and sweeping phases and exposed them via a `marking_time` and `sweeping_time` key in `GC.stat`.
- This feature wil... -
- There is a `time` key in GC.stat that gives us the total time spent in
GC. However, we don't know what proportion of the time is spent between
marking and sweeping. This makes it difficult to tune the GC as we're
not sure where to focus ... -
- This commit separates the marking and sweeping phases so that marking
functions do not directly call sweeping functions. -
- [Bug #19439]
The instance variables were restore on the Regexp source,
not the regexp itself.
Unfortunately we have a bit of a chicken and egg problem.
The source holds the encoding, and the encoding need to be set on
the source to be... -
- Similarly I think we should remove all the `RGENGC_WB_PROTECTED_*` flags https://github.com/Shopify/ruby/commit/078d46c47cb0e41165e0112cd9669b3256625d8e.
- 11:00 AM Revision 61709227 (git): Update default gems list at b572f2436c70bef75126fe4e30910a [ci skip]
-
10:50 AM Revision b572f243 (git): [ruby/openssl] Stub gemspec for JRuby
- JRuby has its own implementation of the `openssl` library in
jruby-openssl. The simplest way for us to allow users to set
openssl as a gem dependency is to ship a stub gem that just
depends on jruby-openssl. This patch adds that to the g... -
10:32 AM Revision bc101f0f (git): [ruby/rdoc] Fix RDoc::Parser::Ruby not being documented
- The calls to require prevent the class from being documented.
https://github.com/ruby/rdoc/commit/76283fc42e -
- See https://github.com/jruby/jruby/issues/7644 for the root issue,
which will require fixes to JRuby's regular expression engine,
JOni.
https://github.com/ruby/strscan/commit/29a65abff2 - 10:31 AM Revision 76a4cdfb (git): [ruby/strscan] test: Run test more with fixed anchor mode
- (https://github.com/ruby/strscan/pull/60)
fix https://github.com/ruby/strscan/pull/56 -
10:31 AM Revision 260bc7cd (git): [ruby/strscan] Add test case to `test_string`
- (https://github.com/ruby/strscan/pull/58)
`string` returns the original string after `scan` is called. Current
test doesn't check this behavior and now it's covered. - 10:31 AM Revision 18e840ac (git): [ruby/strscan] Bump version
- https://github.com/ruby/strscan/commit/681cde0f27
-
- (https://github.com/ruby/strscan/pull/49)
The doc of `rest?` was unclear about return value. This commit adds the
return value to the doc. - 10:31 AM Revision a350ef9f (git): [ruby/csv] test: use mailing list ID instead of unavailable URL
- https://github.com/ruby/csv/commit/04862ccf87
-
10:31 AM Revision 2ac1efc0 (git): [ruby/csv] Use https links instead of http
- (https://github.com/ruby/csv/pull/274)
https://github.com/ruby/csv/commit/e2a06929a8 -
10:31 AM Revision 1a05d988 (git): [ruby/csv] Remove unused @double_quote_character from Parser
- (https://github.com/ruby/csv/pull/273)
https://github.com/ruby/csv/commit/e5622c53ae -
- Pick from https://github.com/rubygems/rubygems/commit/e9304aed7e43308b99e70c2f7b92028315fee8a5
-
10:28 AM Revision a47e1328 (git): [rubygems/rubygems] Give a better message when Gemfile branch does not exist
- https://github.com/rubygems/rubygems/commit/cb4fc41cbc
-
- https://github.com/rubygems/rubygems/commit/0f168516f7
-
10:28 AM Revision 4064e3e7 (git): [rubygems/rubygems] Update pub_grub
- * Replaces the wording of "is forbidden" with "cannot be used"
* Fixes the method signature of VersionRange::Empty#eql?
https://github.com/rubygems/rubygems/commit/8c6b3f130b
Co-authored-by: Daniel Colson <danieljamescolson@gmail.com> -
- We became a bit out of sync lately.
https://github.com/rubygems/rubygems/commit/6161a2610a -
- https://github.com/rubygems/rubygems/commit/c8e024359f
-
- The static list in alphabetical order seems no longer provided.
https://github.com/rubygems/rubygems/commit/a37dff7736 - 10:05 AM Revision ba2bd6d0 (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.64 to 0.9.65.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.64...v0.9.65)
---
updated-depende... -
- The dependency of extconf.h on bigdecimal.gemspec does not make sense
as far as no rule is defined for it. Also, the relationship between
extension library and gemspec file is various in default gems, and
does not work well.
https://gi... -
-
- I deployed a ruby shim of this cache to half of our servers: https://github.com/Shopify/pid_cache
Average latency: -2ms
Median latency: -2ms
p75 latency: -2ms
p99 latency: -10ms
p99.9: -30ms
-
04:46 AM Revision 6384f798 (git): Prevent "warning: ambiguity between regexp and two divisions"
- http://rubyci.s3.amazonaws.com/ubuntu/ruby-master/log/20230221T031004Z.log.html.gz
```
/home/chkbuild/chkbuild/tmp/build/20230221T031004Z/ruby/test/rubygems/test_gem_ext_cargo_builder.rb:90: warning: ambiguity between regexp and two divi... -
03:43 AM Feature #19451: Extract path and line number from SyntaxError?
- @nobu most text editors need a single line and column for each backtrace location.
As it stands, just looking at the backtrack locations is not enough. For `SyntaxError`, the editor needs to know the "first location" which is the poin... -
- `SyntaxError` can contain multiple error locations.
I'm trying https://github.com/nobu/ruby/tree/SyntaxError%23diagnostics.
I can't get what "prepend them to backtrace_locations" means.
02/20/2023
-
- i.e. don't `require 'fiber'` to use `Fiber.current`. Are there other methods we should consider too?
-
- (https://github.com/ruby/net-http/pull/123)
https://github.com/ruby/net-http/commit/220ff3f741 -
06:12 PM Feature #19428: Adding a "piped heredoc" feature
- @nobu - I'll see if I can implement a patch for this. Your steps are helpful.
@eregon - I also think the pipe character prefixed lines are hard to maintain. There are many whitespace aligned things in the wild, such as YAML, python, a... -
- IMO the examples in the description are too hard for humans to read, and very error-prone (it breaks everything if indenting one space too little).
The `| `-prefixed variant seems more readable, but I doubt we need yet another heredoc... -
- shreeve (Steve Shreeve) wrote in #note-3:
> The parser is already doing the work to be "looking for" the end of the heredoc, so detecting a "dedent/undent" is sufficient for the parser to know that the heredoc is complete.
Just an im... -
06:06 PM Feature #19451: Extract path and line number from SyntaxError?
- It's also worth mentioning that not all syntax errors have an associated path. `eval`, code piped to STDIN, and `ruby -e` can have invalid syntax but might not have an associated path. In the discussion around adding SyntaxSuggest to Rub...
-
- Is it #lineno or #line_number? I would think #line_number would look prettier,
if we add a method to SyntaxError. (Not saying we should do, or should not do,
either; just pointing at the different names above ^^^.)
Also good to see zver... -
- The calling backtrace and the location of the syntax error are separated things, so I don't think we should mix them.
Adding `SyntaxError#lineno` would make sense IMO. -
09:20 AM Feature #19451: Extract path and line number from SyntaxError?
- FWIW, `SyntaxError#path` [was added](https://rubyreferences.github.io/rubychanges/3.2.html#syntaxerrorpath) in 3.2
-
- (and while we are at it, how about column information?)
-
- There doesn't seem to be any official way to extract the path and line number from a syntax error.
There are two ways I can see us dong this:
- Provide explicit `path` and `line_number` attributes.
- Prepend them to `backtrace_loc... -
- This case wasn't eliminated before because `getinstancevariable`
could emit a warning, but that's no longer the case since Ruby
3.0. -
- Follows up [Bug #19400]
-
- Perhaps this could be discussed as "one item" in an upcoming
dev meeting, e. g. the extensions ioquatix suggested in the
last some issues raised here. Since I love introspection I
am all in favour of what can be useful for us, when wr... -
- I discussed this with @mame and it would be pretty useful if we could also get the column information from exception backtrace location, even if it was slow.
A POC:
```ruby
class Thread::Backtrace::Location
if defined?(RubyVM::... -
- Just an aside note: ActiveRecord models [redefine](https://github.com/rails/rails/blob/main/activerecord/lib/active_record/core.rb#L357) `#inspect` (and not `#name`) to achieve "informative description" effect:
```ruby
p User
User(id:... -
- I don't think Class#inspect should ever lie, so IMO there shouldn't be a way.
In the comment above, the problem is `foo` is not assigned to a proper constant, that's the obvious fix, to assign foo to a constant.
The file in which the... -
- Sure, but it's better than
```
irb(main):053:0> p foo::Bar
#<Class:0x00007fd0ad4b3860>::Bar
=> #<Class:0x00007fd0ad4b3860>::Bar
irb(main):054:0> foo::Bar.new
=> #<#<Class:0x00007fd0ad4b3860>::Bar:0x00007fd0ad81ec70>
```
-
- ioquatix (Samuel Williams) wrote in #note-4:
> So, basically, given the above, I still prefer an interface like `Class.new(..., name: ...)`.
Although I'm fine with this interface,
> ...
These names look tricky too. -
- Okay, so I tried it out, but it doesn't work consistently:
```ruby
def labeled_class(name, superclass = Object, &block)
Class.new(superclass) do
singleton_class.class_eval {define_method(:to_s) {name}; alias inspect to_s}
clas... -
- Thanks @nobu let me check it. Well, the implementation of `labeled_class` looks a bit tricky but if it works, it's good enough.
-
- ioquatix (Samuel Williams) wrote:
> Can we do better?
I'm not sure what you want to do exactly.
> ...
This is what `EnvUtil#labeled_class` does.
-
- This is the best I could come up with:
```ruby
klass = Class.new
Object.const_set("Klass", klass)
Object.send(:remove_const, "Klass")
puts klass.new
# => #<Klass:0x0000000100a9d688>
```
Can we do better?
What about som... -
- Currently `Fiber#storage` can only be called for the current Fiber (otherwise `ArgumentError`).
But it may evolve (e.g. allow to be called on different Fiber but Fiber of same thread), this is why it's Fiber#storage and not Fiber.storag... -
- @ioquatix,
> It's useful for debugging to access the storage of a different fiber.
Can you please expand on this?.. How it can be done for debugging?.. -
- It's useful for debugging to access the storage of a different fiber.
-
04:41 AM Misc #19431: DevMeeting at RubyKaigi 2023
- Updating description to include RubyKaigi ruby-core invitation.
--Sorah on behalf of RubyKaigi Organizers -
-
- ... for the toplevel.
-
-
-
- * If the receiver is a Class, use "... for class <class name>".
* If the receiver is a Module, use "... for module <module name>".
* If the receiver is an extended object (i.e., has a singleton class),
use "... for <rb_any_to_s(receive... -
- ```
42.time #=> undefined method `time' for object Integer (NoMethodError)
class Foo
privatee #=> undefined local variable or method 'privatee' for class Foo (NoMethodError)
end
s = ""
def s.foo = nil
s.bar #=> undefined meth...
02/19/2023
-
- (https://github.com/ruby/pstore/pull/8)
https://github.com/ruby/pstore/commit/01c4ccc7aa -
- (https://github.com/ruby/fileutils/pull/108)
https://github.com/ruby/fileutils/commit/bbe595cfa5 - 10:39 PM Revision 924ab1b7 (git): test/readline/test_readline.rb: skip a test x86_64-linux-(x32|i[3-6]86)
- I run a 32-bit (x86) userspace on a 64-bit kernel to save memory
and this test fails for the same reason it does on pure 32-bit
platforms.
Followup-to: 6cf7c0a48fb07a76 (test/readline/test_readline.rb: skip a test on i686-linux, 2021-11... -
-
- (https://github.com/ruby/date/pull/88)
https://github.com/ruby/date/commit/cfa7e9868b -
-
- * Remove section about experimental status
* Add references to core objects that can deconstruct -
-
- * remove false call-seq (output from Ruby parsing is cleaner)
* explain output: argument in plain words
* change parameter name in docs of #dump_shapes (typo) -
- * Add links to Binding class
* Make examples practical
* Extend possible usages description -
- * Hide freeze method (no useful docs, same as Object#freeze)
* Add dedup to call-seq of str_uminus -
-
-
-
05:49 AM Feature #19024: Proposal: Import Modules
- I wanted to update this because I've changed my thinking since the original proposal.
TL;DR
1. I agree that we should not change `require`, `require_relative`, `load` or `autoload` (at least, not in ways that would break existing usa... -
07:58 PM Revision 59f7bf96 (git): Mention when it is appropriate to document aliases in call-seq
-
- Change to handling of aliases
-
- Applied in changeset commit:git|8a59f75de7e1ee4c021a1cd79aa78f0c6cf78507.
----------
Use the development versions of minitest and debug gems
This is a preparation for a new message format of NameError.
[Feature #18285]
https://github.... -
- To use the repository version of bundled gems, we need to build a gem by
"gem build", but the repository of minitest does not include
minitest.gemspec because it uses hoe.
This change creats a dummy minitest.gemspec to pass the CI. -
- https://github.com/mame/ruby/actions/runs/4208869556/jobs/7305356097
```
WARNING: open-ended dependency on irb (>= 1.5.0) is not recommended
if irb is semantically versioned, use:
add_runtime_dependency 'irb', '~> 1.5', '>= 1.5.0'... -
- This is a preparation for a new message format of NameError.
[Feature #18285]
https://github.com/minitest/minitest/pull/942
https://github.com/ruby/debug/pull/889 -
- https://bugs.ruby-lang.org/issues/18285
https://github.com/ruby/ruby/pull/6950
https://github.com/ruby/error_highlight/commit/a7c2da052e -
- ```
$ gem build bigdecimal.gemspec
WARNING: license value 'BSD-2-clause' is invalid. Use a license identifier from
http://spdx.org/licenses or 'Nonstandard' for a nonstandard license.
Did you mean 'BSD-2-Clause'?
WARNING: See https://... -
- Ruby 3.3
(https://github.com/ruby/did_you_mean/pull/184)
This change accepts the following change of the message of NameError in
a test.
https://bugs.ruby-lang.org/issues/18285#note-37
```
old: undefined method `sizee' for #<File:...>...
02/18/2023
-
- Today I learned "Associated revisions" tab in Redmine.
-
- https://bugs.ruby-lang.org/issues/19445?tab=changesets
I missed the space between `Bug` and `#`, then linked manually. -
- Apologies, but I'm a bit confused. I see @nobu marked the issue as closed with needing backport, but I don't see any associated fix. Did I miss something?
-
- Thanks @nobu. I confirmed to fix this.
```
$ curl -s 'https://cache.ruby-lang.org/pub/misc/ci_versions/all.json' -o ruby_versions.json
ruby -v -rjson -e "min = JSON.parse(File.read('ruby_versions.json')).sort.first; p 2.2.step(by:... -
- (https://github.com/ruby/irb/pull/488)
The context argument was introduced in this change:
https://github.com/ruby/irb/commit/6806669d178f90f38b99c144bdfee06bdb93a229#diff-296327851fb7a2c307c2d0693b769f58c01aaf315972f290500d10081ee200a... -
- @sawa I wasn't planning to answer the question myself, only to point the author to the detailed documentation of how Hash defaults works, so they can answer their own question.
-
03:43 AM Bug #19448: [Hash] Using Set as default value
- @byroot (Jean Boussier), I think your comment is misleading if not irrelevant.
The issue's point is that, a key-value pair is not stored in the hash just by calling it. The relevant part in the example you cited is:
```ruby
synonyms.ke... -
06:41 AM Bug #19441: Closing an Tempfile#dup behaviour
- Thanks nobu for your answer it makes perfect sense.
My case which led to the current question comes from a Rails application which has a controller receiving a file. My input `params[:file]` hold an `ActionDispatch::Http::UploadedFile... -
-
03:05 AM Bug #19442: Remove USE_RINCGC flag
- > ruby_memprofiler_pprof - This uses USE_RINCGC, as a default value to GC_ENABLE_INCREMENTAL_MARK, although I'm not sure what for.
Because I copied this out of `gc.c` - https://github.com/ruby/ruby/blob/c024cc05efa2b5206c4bb45066d3c8...
02/17/2023
- 09:40 PM Revision c024cc05 (git): YJIT: Consolidate jit methods in JITState impl (#7336)
- These jit_* methods don't jit code, but instead check things on the
JITState. We had other methods that did the same thing that were just
added on the impl JITState. For consistency I added these methods there. -
- * YJIT: Use rb_ivar_get at the end of ivar chains
* Rename the counter to get_ivar_max_depth -
- Some more context on this ticket. @peterzhu2118 did a gem code search for `USE_RINCGC` and that returned 4 distinct gems:
1. [Rhodes 7.5.1](https://rubygems.org/gems/rhodes/versions/7.5.1) - This gem vendors the complete source code of ... -
- This test is no longer passing:
```
1)
BigDecimal#remainder returns NaN if Infinity is involved FAILED
Expected Infinity.nan?
to be truthy but was false
/home/runner/work/ruby/ruby/src/spec/ruby/library/bigdecimal/remainder_spe... -
06:38 PM Feature #18597: Strings need a named method like `dup` that doesn't duplicate if receiver is mutable
- rubyFeedback (robert heiler) wrote in #note-18:
> > And it feels like I cannot convince anyone here with any amount of rationale
> ...
This is a great response, cheers and thanks for your time. Honestly I never thought this was a huge ... -
- > And it feels like I cannot convince anyone here with any amount of rationale
Ultimately you only have to convince matz, so you could ignore what others write.
But one reason why there was a reference to real-needs above is that the r... -
06:10 PM Revision c3bae033 (git): Add asm comment to YJIT's rb_str_empty_p
-
- I'll attend.
-
11:46 AM Misc #19431: DevMeeting at RubyKaigi 2023
- I'll attend.
-
- +1
-
- JRuby currently ships its own internal bigdecimal extension as
part of the core libraries. In order for users to be able to add
bigdecimal to their Gemfile or gem dependencies, we need to stub
out the C extension and just load the extens... -
05:46 PM Revision 36e3d46d (git): [ruby/bigdecimal] Handle correctly #remainder with infinity. Fixes
- https://github.com/ruby/bigdecimal/pull/187
https://github.com/ruby/bigdecimal/commit/4b8572d452 -
03:49 PM Bug #19448: [Hash] Using Set as default value
- That's is known limitation when using Hash default value
Also your problem is that `<<` would alter the same object you put into as default object
meaning:
```ruby
h = Hash.new(Set.new)
h[:a] << 1
h[:b] << 2
p h[:c] #=> Set[1,... -
- This isn't a bug and is documented in `Hash.new` https://docs.ruby-lang.org/en/3.2/Hash.html#class-Hash-label-Default+Values
> Note that the default value is used without being duplicated. It is not advised to set the default value to... -
03:41 PM Bug #19448 (Rejected): [Hash] Using Set as default value
- When using a hash and set is used as a default value, the keys method for the hash does not return expected values.
A workaround for this is provided in the attachment. -
- This macro is broken when set to anything other than 0. And has had a
comment saying that it's broken for 3 years.
This commit deletes it and the associated logging code. It's clearly
not being used.
Co-Authored-By: Peter Zhu <peter@pe... -
02:42 PM Bug #19041: Weakref is still alive after major garbage collection
- Hi @tenderlovemaking! I'm having difficulty interpreting the results of the `ObjectSpace` dump and I'm hoping you can help.
I've adjusted the script to print out the address of the underlying object, and then (when the issue manifests... -
- [[Github PR #7310](https://github.com/ruby/ruby/pull/7310)]
This PR merges the `rgengc.h` internal header into the public internal `gc.h` header.
`rgengc.h` was introduced as part of this commit `9e6e39c3512f7a962c44dc3729c98a0f8be... -
- [Github PR #7331](https://github.com/ruby/ruby/pull/7331)
The update deps tool uses intermediary build files to verify dependencies. When these `*.i` files are generated by `gcc` the second line is always of the form
```
# 1 "/hom... -
- > PID can conflict because PID is recycled.
I don't think it's a big concern for this use case, even with PID recycling, the PID of the child can't possibly be the same than the parent.
So unless you fork several time without ever tr... -
11:10 AM Feature #19443: Cache `Process.pid`
- I think detecting fork using PID is not a good idea.
PID can conflict because PID is recycled.
We can define Process.fork_level as follows.
```
% ruby -e '
class << Process
attr_accessor :fork_level
end
Process.fork_level =... -
- Here, from my branch built in a Ubuntu jammy (22.04) based image:
```
ruby 3.3.0dev (2023-02-16T18:42:31Z cache-process-pid 0cd4797132) [aarch64-linux]
Warming up --------------------------------------
Process.pid 1.84... -
- ```ruby
require 'benchmark/ips'
Benchmark.ips do |x|
x.report("Process.pid") { Process.pid }
end
```
On macOS where `getpid()` is still cached:
```
ruby 3.2.0 (2022-12-25 revision a528908271) [arm64-darwin22]
Warming up ... -
- > However as of glibc version 2.25 the PID cache is removed and calls to getpid() always invoke the actual system call which significantly degrades the performance of existing applications.
Could you show some benchmark results with/wit... -
- * [Feature #19406] Allow declarative reference definition for rb_typed_data_struct (eightbitraptor)
* This is essentially a simpler interface for handling marking/compaction for `rb_typed_data_struct` that hold references to other Ruby... -
- - [Bug #19436] Call Cache for singleton methods can lead to "memory leaks" (byroot)
- When caching a singleton method call, the receiver becomes immortal until that call cache is updated.
- On large apps with some infrequently call... -
- I do not have any strong opinions either way, but Benoit wrote:
> The last example is just:
p.call(honyarara, fugafugafuga, hogehogehoge)
> ...
Versus:
honyarara.then(fugafugafuga, hogehogehoge, &p)
And I am not su... -
- I am not sure we should add more methods from within that
family (autoload-family). Personally I would even remove
require_relative, but I guess too much code depends on it
nowadays. -
- Personally I think it may be better to leave require(),
load() and require_relative() unchanged as-is, and instead
add a new, more sophisticated way for ruby to handle loading
of stuff in general. That one should then ideally be as fl... -
- A `Tempfile` uses a finalizer to clean up the target file.
That is the file will be removed when a dup of `Tempfile` is discarded (and also will be tried to remove again).
I don't think it is a good idea to use `Tempfile#dup`.
What do... - 03:34 AM Revision a7beb4cf (git): Bump lewagon/wait-on-check-action from 1.2.0 to 1.3.1
- Bumps [lewagon/wait-on-check-action](https://github.com/lewagon/wait-on-check-action) from 1.2.0 to 1.3.1.
- [Release notes](https://github.com/lewagon/wait-on-check-action/releases)
- [Commits](https://github.com/lewagon/wait-on-check-a... -
-
- Extracted arguments do not have keyword hash to splat.
02/16/2023
-
- Applied in changeset commit:git|c178926fbe879045fa711444a1fd9e906af23e3b.
----------
YJIT: jit_prepare_routine_call() for String#+@ missing
We saw SEGVs due to this when running with StackProf, which needs a
correct PC for RUBY_INTERNA... -
- We noticed two issues with YJIT's `String#+@` (String unary plus) implementation.
1. It has issues with GC allocation tracing. We saw it SEGV with the `Stackprof` gem
2. It has a type confusion issue from assuming that the method alw... -
- Could return a subclass.
[Bug #19444] -
- We saw SEGVs due to this when running with StackProf, which needs a
correct PC for RUBY_INTERNAL_EVENT_NEWOBJ, the same event used for
ObjectSpace allocation tracing.
[Bug #19444] -
- The following commands will cause a segmentation fault.
```
curl -s 'https://cache.ruby-lang.org/pub/misc/ci_versions/all.json' -o ruby_versions.json
ruby -rjson -e "min = JSON.parse(File.read('ruby_versions.json')).sort.first; p 2.... -
- (https://github.com/ruby/net-http/pull/122)
https://github.com/ruby/net-http/commit/06f79cda87 -
-
- It's not uncommon for database client and similar network libraries to protect themselves from Process.fork by regularly checking Process.pid
Until recently most libc would cache `getpid()` so this was a cheap check to make.
Howeve... -
- 04:25 PM Revision b4c38f3c (git): YJIT: Initial support for rest args (#7311)
- * YJIT: Initial support for rest args
* Update yjit/src/codegen.rs
---------
Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com> -
- @nobu I see you've just fixed it in [this commit](https://github.com/ruby/ruby/commit/21543ac86ce0b730c1381588d7dc9eb0e32277c7) 😅
Thanks!
I'd still like to see it removed, but I'll update the ticked description to be more reflecti... -
- nobu (Nobuyoshi Nakada) wrote in #note-1:
> I don't think option 1 and 2 are exclusive.
I'm not sure what you mean by this. Do you mean it could be both fixed _and_ removed? -
- I'm for removing many of the untested code paths in gc.c since they may be buggy and are probably not used (like this one, which doesn't even compile so clearly nobody is using it).
-
- Of course I'm **not** against the removal.
I just say removing the flag and fixing the bug are different stories. -
- I don't think option 1 and 2 are exclusive.
-
- [GitHub PR #7317](https://github.com/ruby/ruby/pull/7313)
~~Ruby doesn't compile when USE_RINCGC is disabled. It's also not being tested in CI. As @nobu has pointed out in comments on the PR, fixing it is simple.~~ This was fixed in [... -
- I'll attend.
-
- Provided `#dup` generally returns an object of the same type, I would expect to have a `Tempfile` object.
The unexpected thing was that if I replay the same scenario with `File`, I have what I expect. I was just wondering whether the ... -
- What do you expect for the `dup`ped `Tempfile` object?
An `IO` to the same file?
Or another temporary file? -
- Hello amazing ruby folks!
I classified that ticket as a "Bug" although it is perhaps something I did not understand.
Here is a ruby session:
``` ruby
irb(main):001:0> file = Tempfile.new
=> #<File:/var/folders/m2/bljzrgq160vbf... -
-
- Ok, I have a patch for it, but it's ugly: https://github.com/ruby/ruby/pull/7323
-
- Ah! the explanation is quite funny.
So the ivars are loaded fine, however, since the goal is to store the encoding, and that the encoding isn't on the regexp itself, but on the `regexp#source` which is a string, the ivars are assigned... -
- After a quick check, it's because the IVAR on Regexps is used to store the encoding:
```c
case TYPE_REGEXP:
{
VALUE str = r_bytes(arg);
int options = r_byte(arg);
int has_encoding... -
- This issue caused by https://git.ruby-lang.org/ruby.git/tree/tool/lib/bundled_gem.rb#n53.
```ruby
unless spec.extensions.empty?
spec.dependencies.clear
File.binwrite(File.join(dir, spec_dir, ".bundled.#{target}.gemspec")... -
- I can reproduce this issue with current master branch.
-
- Given that signleton classes don't have an allocator,
we can re-use these bytes to store the attached object
in `rb_classext_struct` without making it larger. - 02:40 AM Revision 1df75d65 (git): Bump actions/cache from 3.2.4 to 3.2.5
- Bumps [actions/cache](https://github.com/actions/cache) from 3.2.4 to 3.2.5.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.co... - 02:40 AM Revision 01166505 (git): Bump github/codeql-action from 2.2.1 to 2.2.4
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.1 to 2.2.4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
... - 02:39 AM Revision 9aa0f656 (git): Bump ruby/setup-ruby from 1.134.0 to 1.138.0
- Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.134.0 to 1.138.0.
- [Release notes](https://github.com/ruby/setup-ruby/releases)
- [Commits](https://github.com/ruby/setup-ruby/compare/ee26e27437bde475b19a6bf8cb73c9fa65... -
-
- * Automerge for dependabot update
* change update period with daily, we can merge it automatically when `make check` of Ubuntu was passed
* Use rebase instead of merge commit
* check all Ubuntu jobs - 12:58 AM Revision 25737306 (git): Update default gems list at 65b6411e9db31591ae2a4928acaa0b [ci skip]
-
- https://github.com/ruby/timeout/commit/e1b2448101