Activity
From 01/14/2023 to 01/20/2023
01/20/2023
-
10:49 PM Feature #15778: Expose an API to pry-open the stack frames in Ruby
- Outside of error reporting, having this or similar API will also:
- Allow IRB to display richer exception backtrace. This is helpful when used as `binding.irb`.
- Allow IRB to implement a `bt` command that's similar to `debug`'s.
... -
10:11 PM Revision 06b62cbb (git): Add `offsetof` so we can get the offset of members
- I want to get the offset of fields inside structs, but I don't want to
instantiate the struct. I need to embed the offsets inside machine
code, and I can't get the offsets without calling `new` on the struct.
This commit adds an `offse... -
10:09 PM Bug #19112: Ractor garbage collection breaks/disables all active tracepoints
- To make sure it's collected:
```ruby
puts RUBY_DESCRIPTION
ractor_id = nil
if ENV['RUN_RACTOR'] == '1'
r = Ractor.new { 10 }
ractor_id = r.object_id
r.take
puts "Ractor ran!"
else
puts "Ractor DID NOT ran!"
end
gc_times = 0
r... -
- I was just looking into this bug and it's really strange, I initially thought it had to do with single ractor mode vs multi, but if we `sleep 100` inside the ractor everything behaves as it should, so it has to do with the ractor finishi...
-
09:07 PM Revision 887d2161 (git): YJIT: Avoid BorrowError on GC.compact (#7164)
-
08:58 PM Revision 4e037075 (git): Fix typo in RHASH_ST_CLEAR
- We should be setting as.st and not as.ar.
-
- Thank you for reporting this bug and @eightbitraptor for checking that the patch works on 3.1.3. I marked that patch for backporting to 3.1.
-
05:06 PM Bug #19358: Segfault when setting RUBY_GC_HEAP_INIT_SLOTS to a low value
- Can confirm that applying the patch from https://bugs.ruby-lang.org/issues/19284 to the 3.1.3 branch fixes the issue for me.
I think this should be marked for Backport
What do you think @peterzhu2118 -
04:08 PM Bug #19358 (Closed): Segfault when setting RUBY_GC_HEAP_INIT_SLOTS to a low value
- This bug is similar to #19284
In Ruby 2.7 this works fine
```
docker run --rm -it -e RUBY_GC_HEAP_INIT_SLOTS=1 ruby:2.7 ruby -e 'puts "hello, world!"'
hello, world!
```
On Ruby 3.1 I get a segfault
```
docker run --rm -it ... -
04:58 PM Feature #19347: Add Dir.fchdir
- ko1 (Koichi Sasada) wrote in #note-3:
> At the dev meeting there are 4 ideas:
I considered the first three ideas when implementing this support. Let me add my comments on each.
> ...
The reason I used this approach is that this f... -
06:25 AM Feature #19347: Add Dir.fchdir
- At the dev meeting there are 4 ideas:
* 4 ideas
* `Dir.fchdir(int)`
* Proposed
* Consistent to the POSIX API
* Can be extended for `Dir.fchdir(dir)` and `Dir.fchdir(io)`
* `Dir.chdir(int)`
* Do not need to ad... -
04:38 PM Bug #19237 (Closed): Hash default_proc is not thread-safe to lazy-initialize value for a given key
- Applied in changeset commit:git|ffd52412ab813854d134dbbc2b60f698fe536487.
----------
Document thread-safety issues with Hash default_proc
Fixes [Bug #19237] -
05:57 AM Bug #19237: Hash default_proc is not thread-safe to lazy-initialize value for a given key
- Discussed at the dev meeting. @matz said "The performance penalty is not acceptable. Addition to the documentation looks good enough."
-
- Fixes [Bug #19237]
-
04:11 PM Bug #18666: No rule to make target 'yaml/yaml.h', needed by 'api.o' - ______________________________________________
-
11:48 AM Bug #18666 (Feedback): No rule to make target 'yaml/yaml.h', needed by 'api.o'
- @duerst This issue may cause with your environment.
-
- If you want Ractor to be an implementation detail of Worker you could do:
```ruby
class Worker
def initialize(&block)
@block = block
end
def run
block = @block
true.instance_eval { Ractor.new(&block) }
end
end
work... -
- 03:57 PM Revision 36fa4f13 (git): YJIT: get rid of unneeded `.into()`
-
03:30 PM Revision 15328302 (git): In `UNALIGNED_MEMBER_PTR` cast through `void` pointer
- Suppress warnings shown even with `-Waddress-of-packed-member`
disabled in gcc 11. -
-
-
01:40 PM Revision 76e3d853 (git): [ruby/reline] Add autoindent test for indent after bracket and newline
- https://github.com/ruby/reline/commit/3f3da7d0e2
-
- https://github.com/ruby/reline/commit/61cc580da4
- 01:06 PM Revision 0cc91871 (git): [rubygems/rubygems] Update bundle-exec man page for with_unbundled_env
- `with_clean_env` has been deprecated in `with_unbundled_env`. It already generates a deprecation warning when it uses, but this man page was still referring to it.
-
12:41 PM Revision c948a081 (git): Add a NEWS entry for [Feature #19314] [ci skip]
-
- I withdraw this proposal. We need to consider another deprecate plan.
-
- I'll document this.
-
- This is duplicated as #18381
-
11:00 AM Bug #19354: Issues with arguments validation in IO.read
- Yeah, I understand that it's caused by the way how `IO.read` is implemented.
My point is that from the end-user point of view current error message (`given 3, expected 0..2`) is slightly misleading/confusing. -
- `IO.read` opens the file given as the first argument, then delegates the other arguments to `IO#read` on the instance.
Your error happens in the delegated `IO#read`.
Since 3.0, keyword arguments are separated from mere hashes.
I thi... -
- The output from the command is mixed in this test, even when
successful.
Use the output as a part of the message on failure instead.
https://github.com/rubygems/rubygems/commit/960509a133 -
- Applied in changeset commit:git|1edef08ddadf0bd76122f830ef7953cda61c78aa.
----------
Added version policy of BASERUBY
[Misc #16671] -
- bytesplice(index, length, str, str_index, str_length) -> string
bytesplice(range, str, str_range) -> string
In these forms, the content of +self+ is replaced by str.byteslice(str_index, str_length) or str.byteslice(str_range); however... -
-
-
- [Misc #16671]
-
-
08:42 AM Feature #19236: Allow to create hashes with a specific capacity from Ruby
- Well, `Hash.new(capacity: 4096)` was definitely my first pick, so this is great news IMO.
> how about deprecating giving the keyword to Hash.new and then introducing Hash.new(capacity: 4096)?
What would be the timeline?
Depreca... -
- Discussed at the dev meeting.
@matz said that `Hash.create(capacity: 4096)` is acceptable (unless it conflicts with any major gems). However, several participants including @ko1 were a little cautious about introducing the new termino... -
-
08:14 AM Feature #19314 (Closed): String#bytesplice should support partial copy
- Applied in changeset commit:git|373e62248c9dceb660e95f1cf05fa2a4a469cd64.
----------
merge revision(s) f7b72462aa27716370c6bea1f2c240983aca9a55: [Backport #19356]
String#bytesplice should return self
In Feature #19314,... -
- Applied in changeset commit:git|373e62248c9dceb660e95f1cf05fa2a4a469cd64.
----------
merge revision(s) f7b72462aa27716370c6bea1f2c240983aca9a55: [Backport #19356]
String#bytesplice should return self
In Feature #19314,... -
- ruby_3_2 373e62248c9dceb660e95f1cf05fa2a4a469cd64 merged revision(s) f7b72462aa27716370c6bea1f2c240983aca9a55.
-
- Please backport [f7b72462aa27716370c6bea1f2c240983aca9a55](https://github.com/ruby/ruby/commit/f7b72462aa27716370c6bea1f2c240983aca9a55).
In Feature #19314, we concluded that the return value of String#bytesplice should be changed fro... -
08:13 AM Revision a0626e11 (git): Bundle RBS 2.8.4 (#7159)
-
- Fix crash when defining ivars on special constants
[Bug #19339]
---
test/ruby/test_variable.rb | 6 ++++++
vm_insnhelper.c | 5 +++++
2 files changed, 11 insertions(+) -
- ruby_3_2 1fb5eb5740d4c4f1fc34a4a50bc0482eac27b545 merged revision(s) aeddc19340c7116d48fac3080553fbb823857d16.
- 07:05 AM Revision d80a574a (git): Update bundled gems list at 2023-01-20
-
06:51 AM Bug #19286 (Closed): What should kwargs' arity be?
- Withdrawing the issue. Thank you for your participation in the discussion!
-
- Discussed at the dev meeting. @matz said the current behavior is fair, and @matsuda agreed with that. So keep it as is.
-
- # The next dev meeting
**Date: 2023/02/09 13:00-17:00** (JST)
Log: https://github.com/ruby/dev-meeting-log/blob/master/2023/DevMeeting-2023-02-09.md
- Dev meeting *IS NOT* a decision-making place. All decisions should be done at t... -
-
- Discussed at the dev meeting. @naruse said "`Time.new("2023")` is 1.9.2 feature. We can’t deprecate on 3.2.1. Need to continue the discussion for Ruby 3.3."
BTW Ruby 3.2.0 accidentally allows `Time.new("2023-01")`, `Time.new("2023-01-... -
- Discussed at the dev meeting.
Are there any real-world use cases (other than rubyspec) where you would like to prohibit `integer << large`?
@matz was initially positive about prohibiting huge object generation as early failure. How... -
- Discussed at the dev meeting. @matz is positive about the change and said he would give it a try. The message format is slightly changed as follows:
* If the receiver is a Class, `... for class <class name>` should be printed.
* If t... -
- Discussed at the dev meeting. We need to determine some detailed behaviors:
* Should `[-1].pack("C", strict: true)` raise an exception because 'C' represents unsigned char? If what you want is "wrap around", it should raise an error b... -
- String#bytesplice should return self
In Feature #19314, we concluded that the return value of String#bytesplice
should be changed from the source string to the receiver, because the source
string is useless and c... -
- ruby_3_2 6a8fcb50210f8414d76968298576e39b9fa82562 merged revision(s) 3be2acfafd3b3c6168e2266c7c6561d143d7ae5c.
-
- Applied in changeset commit:git|f66804e6f78ed4cf81896d2256743a820b05939a.
----------
don't allow setting class variable on module that's frozen [Bug #19341]
01/19/2023
-
11:28 PM Bug #15507: Thread#raise is delivered to GC context
- ❤️ Thank you for fixing this @jeremyevans0 - I was debugging some instances of our Ruby 2.7 app's test suite hanging on exit, and narrowed it down to this reproduction:
```
require 'tempfile'
def forget_about_a_tempfile
Tempfile.new(... -
- ```ruby
MyClass = Object
class MyClass2 < Object;
def call_a_method
[]
end
def call_another_method
{}
end
end
USE_RACTORS = ARGV.first == "ractor"
puts "ractors: #{USE_RACTORS ? 't' : 'f'}"
class FakeRactor
def initial... -
- During multi-ractor mode, unfortunately when calling methods often there's a call to the internal cruby function `callable_method_entry`, which
returns a cached CME or a new one. In the case that it's cached, there's a VM lock around it... -
-
06:05 PM Misc #19352: Feature #17391 was not such a good idea because now Ruby 3.2 can not install Rails v5 or v6 if they use webpacker.
- I’m not entirely sure, as I have never used a version of Rails that has webpacker (I last used Rails 4.2), so I don’t know its initialization process (whether it sees `application.rb` or an initializer). Worst case, you could put that co...
-
05:37 PM Misc #19352: Feature #17391 was not such a good idea because now Ruby 3.2 can not install Rails v5 or v6 if they use webpacker.
- > That said, this is easily monkey patched:
> ...
@Austin, That is AWESOME! Thank you for that!
Where would be the best place for that code go? In application.rb? or as an initializer or? What would you recommend?
I am asking m... -
07:39 AM Misc #19352: Feature #17391 was not such a good idea because now Ruby 3.2 can not install Rails v5 or v6 if they use webpacker.
- Personally, I preferred exists? over exist? but I can live with the change.
"If the file xy.txt exists then ...": if File.exists?("xy.txt") do
I made a gem to monkeypatch the exists? functionality.
The code from austin might however be... -
- I do not believe that this should be reversed.
There’s an older post at FastRuby indicating [version compatibility](https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html), which mostly captures something that I bel... -
- Hello,
I tried logging a GitHub issue to Rails to make them aware of this issue but they said they are no longer bugfixing Rails v6.1 anymore.
So since this IS a Ruby issue at its core this might be the best place for this.
You re... -
-
- 09:10 PM Revision bf3940a3 (git): YJIT: Refactor side_exits
-
- Note: On the new code of yjit/src/core.rs:2178, we no longer leave the state `.block=None` but `.address=Some...`, which might be important.
We assume it's actually not needed and take a risk here to minimize heap allocations, but in ca... -
06:58 PM Revision 401aa9dd (git): [ruby/net-http] [DOC] Header doc
- (https://github.com/ruby/net-http/pull/104)
https://github.com/ruby/net-http/commit/3308362d9b - 06:42 PM Revision 762a3d80 (git): Implement splat for cfuncs. Split exit exit cases to better capture where we are exiting (#6929)
- YJIT: Implement splat for cfuncs. Split exit cases
This also implements a new check for ruby2keywords as the last
argument of a splat. This does mean that we generate more code, but in
actual benchmarks where we gained speed from this (... -
- Fixes the following compilation warnings:
thread_sync.c:908:48: warning: taking address of packed member of `struct rb_queue` may result in an unaligned pointer value [-Waddress-of-packed-member]
thread_sync.c:1181:48: warning: taking ... -
- This commit avoids a separate code path for marking and moving the
callcache of the iseq. -
- This commit adds rb_gc_mark_and_move which takes a pointer to an object
and marks it during marking phase and updates references during compaction.
This allows for marking and reference updating to be combined into a
single function, whi... -
04:15 PM Misc #19265: please remove rust yjit
- It is going to be very hard to maintain 3.1 YJIT long-term. There are significant updates to the CRuby internal object structures. We're updating it in 3.2, but the older C-based code is still using the older CRuby internal structures. I...
-
- I recently encountered a CI failure when testing against `C++98` due to the lack of variadic macros. `internal/gc.h` states that
```
* @note To ruby-core: remember that this header can be possibly
* recursiv... -
- OpenBSD/sparc64 uses gcc 4.2.1 (last GPLv2 version) as the system compiler. The sparc64 backend for clang is not yet mature (last I checked), so this would make it so Ruby 3.3+ would be unlikely to be supported on OpenBSD/sparc64 (at le...
-
07:04 AM Misc #19353 (Closed): Drop gcc <= 6 and clang <= 9
- We test those old compilers using Ubuntu bionic. This OS is reaching its EOL.
Making them available would become harder.
I would like to drop supporting them. Any opinions? -
- Applied in changeset commit:git|6f3aff3961a4c5ce87e05096a1a9dcf1055b7647.
----------
[Bug #19289] Retain `ruby_abi_version` function
A few extension libraries, to hide all symbols except for necessary to
load, hardcode the symbols to b... -
- A few extension libraries, to hide all symbols except for necessary to
load, hardcode the symbols to be exported in symbol list files for
linker without even checking by `have_func`. As a workaround for such
libraries, retain `ruby_abi_... -
-
-
- It looks like rb_callinfo in iseq can only be either a Ruby object or
null, since it cannot be allocated on the stack. -
- I've noticed a strange error message when `IO.read` is called with additional positional argument:
```ruby
IO.read("a.txt", 3, 0, {mode: "r+"})
# (irb):2:in `read': wrong number of arguments (given 3, expected 0..2) (ArgumentError)
... -
- Fix re-embedding of strings during compaction
The reference updating code for strings is not re-embedding strings
because the code is incorrectly wrapped inside of a
`if (STR_SHARED_P(obj))` clause. Shared string... -
- ruby_3_2 686b38f83e70b3e1796092c71dd0b7dc2206b118 merged revision(s) d8ef0a98c670449b20436947f5ebbd327ed5ab0d.
-
12:17 PM Feature #12698: Method to delete a substring by regex match
- I now agree with https://bugs.ruby-lang.org/issues/12698#note-9. This issue can be considered to be along that line.
-
09:14 AM Feature #19314: String#bytesplice should support partial copy
- Accepted.
Matz.
-
-
- Applied in changeset commit:git|f7b72462aa27716370c6bea1f2c240983aca9a55.
----------
String#bytesplice should return self
In Feature #19314, we concluded that the return value of String#bytesplice
should be changed from the source stri... -
- Overlapping can be realized by putting the original regexp within a look-ahead.
```ruby
s = "abcdefghij"
re = /.{3}/
```
Non-overlapping count:
```ruby
s.scan(re).count # => 3
s.count(re) # => Expect 3
```
Overlapping count:
```ruby... -
- If `str.count(re)` works as `str.scan(re).size` (besides efficiency), it's acceptable. But if someone needs overlapping, they needs to explain their use-case.
Matz.
-
- Accepted, although we foresee some possible issues. One example is that people may use `nil` as a value when they only care about existence of keys (set-like usage). They should use non-nil values (e.g., true) for the case.
Matz. -
- In Feature #19314, we concluded that the return value of String#bytesplice
should be changed from the source string to the receiver, because the source
string is useless and confusing when extra arguments are added.
This change should b... -
- The test added in 90a80eb0 fails if Ruby is verbose, it outputs the
following line to stderr:
RUBY_GC_HEAP_INIT_SLOTS=100 (default value: 10000) -
- I don't think it would be default, but adding `strict:` (or any other keyword argument) is OK for me.
Matz.
-
- I discussed @usa.
* We want to backport [openssl-3.0.2 gem](https://github.com/ruby/openssl/releases/tag/v3.0.2) into `ruby_3_0` branch.
* We need keep compatibility of OpenSSL-1.1 with openssl-3.0.2 gem
* @usa is considering dropping s... -
- [Bug #19319] Fix crash in rb_str_casemap
The following code crashes on my machine:
```
GC.stress = true
str = "testing testing testing"
puts str.capitalize
```
We need to ensur... -
- ruby_3_2 1a2447ac9925e7794a7c5aa07960ad4de08e6aca merged revision(s) 979dd02e2f0a70f3f30d47c6115780d8fac6147e.
-
- Check if the argument is Thread::Backtrace::Location object
[Bug #19262]
---
ast.c | 5 +++++
test/ruby/test_ast.rb | 6 ++++++
2 files changed, 11 insertions(+) -
- ruby_3_2 08ae7f64dc52c2b61e451d6e79ebdae73d482677 merged revision(s) 273dca3aed7989120d57f80c789733d4bc870ffe.
-
01:52 AM Revision 4b42392f (git): YJIT: Use .as_side_exit() for jumps to counted exits
- Fewer cycles running nops when these jumps are not taken. Fixing all
these so when they get copy pasted in the future we save on padding. -
-
- Hey @nobu, @eregon - any further thoughts on this?
@nobu - I changed the proposal not to depend on any new platform-specific process management APIs, but instead to leverage the existing code for managing process waits in `process.c`.... -
- >I believe that for instance strscan is used to parse the Gemfile.lock. Historically Bundler simply vendored the gems it needs, but not sure how it could do that since it has a C-ext part.
Thanks. I also confirm that RubyGems/Bundler ... -
12:53 AM Feature #19351: Promote bundled gems at Ruby 3.3
- I'm OK with gems maintained by me.
-
- Fix undefined behavior in shape.c
Under strict aliasing, writing to the memory location of a different
type is not allowed and will result in undefined behavior. This was
happening in shape.c due to `rb_id_table_... -
- ruby_3_2 d7fb4629b4058eb86be03760e6b9f1f272e44147 merged revision(s) 837ef8911c638c3e2bdb6af710de7c1fac7b5f90.
01/18/2023
- 10:59 PM Revision edd00697 (git): Test some missing coverage too. (#7041)
-
- (https://github.com/ruby/net-http/pull/103)
https://github.com/ruby/net-http/commit/f6506ff889 -
08:41 PM Revision 6bb576fe (git): YJIT: implement codegen for `String#empty?` (#7148)
- YJIT: implement codegen for String#empty?
-
- The function rb_hash_iter_lev doesn't exist as it was removed.
-
- I just took a look at this and it looks like the culprit is the c dtoa function that's called in the json parser, specifically a helper function `Balloc`. It uses a lock for some reason *shrug*.
Edit: It looks like in ruby's missing/dto... -
- * Add stats so we can keep track of x86 rel32 vs register calls
To know if we get that "prime real estate" as Alan put it.
* Fix bug pointed by Alan -
03:59 PM Bug #19340: Ruby master 'make install' not installing rbs gem
- The particular issue with rbs has been fixed with https://github.com/ruby/ruby/pull/7143
> The current build-system of bundled gems is very complex
Agreed. Several recent commits show updates to it.
Given issues with whether on... -
- We discuss this issue with @mame @nobu @ko1 and @soutaro. The current build-system of bundled gems is very complex.
We decide to the following specification for building the bundled gems.
When we provide this `bundled_gems` file:
... -
03:58 PM Feature #19333: Setting (Fiber Local|Thread Local|Fiber Storage) to nil should delete value in order to avoid memory leaks.
- There is also `Thread#key?` for Fiber locals, so not just `thread_variable?`.
Above I am talking more about the performance issue than the semantic incompatibility.
Doing delete+insert is more expensive than set+set, and even much mo... -
- vo.x (Vit Ondruch) wrote in #note-3:
> BTW I don't think there would be that much fixing needed after all.
As we have seen with the `mail` gem, it can be a [huge](https://github.com/mikel/mail/pull/1439) [pain](https://github.com/mikel/... -
- Yeah, a few of these will need to be handled by rubygems/bundler.
I believe that for instance `strscan` is used to parse the `Gemfile.lock`. Historically Bundler simply vendored the gems it needs, but not sure how it could do that sin... -
- I update rails dependencies.
@vo.x Thanks for your comment. Maybe we should remove `irb` from this list.
I welcome feedback for these list and additional gem proposal like `cgi`, `erb` and others. -
09:28 AM Feature #19351: Promote bundled gems at Ruby 3.3
- vo.x (Vit Ondruch) wrote in #note-1:
> > But if we promote them to bundled gems, many of users need to add gem "csv" into their Gemfile. I'm considering to avoid this situation.
> ...
BTW I don't think there would be that much fixing n... -
- > But if we promote them to bundled gems, many of users need to add gem "csv" into their Gemfile. I'm considering to avoid this situation.
Please let gems to be gems. Please let everybody fix their Gemfiles. Don't make exceptions. The... -
- In Ruby 3.2, the default gems and bundled gems are changed only adding `syntax_suggest`. I and some committers are considering promote default gems to bundled gems again for Ruby 3.3+.
We hope to keep the current developer experience ... -
-
- https://github.com/ruby/reline/commit/d4c95f89ec
-
- https://github.com/ruby/reline/commit/268e02b155
-
- https://github.com/ruby/reline/commit/e21b69ade4
-
- RB_OBJ_WRITE already exists in rgengc.h, so we shouldn't redefine it in
gc.h. -
-
- I removed https://github.com/ruby/ruby/commit/2bbf63dd867fe3d349b1758805ad4421f2d772ab from https://github.com/ruby/ruby/pull/7061
-
- RubyGems 3.4.4 and Bundler 2.4.4 have been released. We should backport them into `ruby_3_2` branch.
https://github.com/ruby/ruby/pull/7061
I also added patch for [Bug #19298] to above pull-request. -
-
-
- Fix crash in TracePoint c_call for removed method
trace_arg->id is the ID of the original method of an aliased method. If
the original method is removed, then the lookup will fail. We should use
trace_arg->called... -
- ruby_3_2 f7e9b79f815e08e0a29fff11f77466f4ffb92520 merged revision(s) 4959e01932cf6c4d3e5e90d3e0b4fa780f754fa6.
-
- ruby_3_2 44a3043d1182acf3147935d9c1564028b5538417 merged revision(s) 2bbf63dd867fe3d349b1758805ad4421f2d772ab.
-
- Remove lib/mjit/instruction.rb
This was accidentally re-introduced in f6620037ba1477d2c337d7b511f094d6d0fbb69c.
[Bug #19298]
---
lib/mjit/instruction.rb | 2162 ------------------------------------------... -
- ruby_3_2 057eff7663a0a4bc95a4799336a2bc14ca2480f0 merged revision(s) eab7f4623fbf0488e828b75843d70c8e02dc8aa5.
-
- YJIT: Save PC and SP before calling leaf builtins (#7090)
Previously, we did not update `cfp->sp` before calling the C function of
ISEQs marked with `Primitive.attr! "inline"` (leaf builtins). This
caused the GC ... -
- common.mk: Do not invoke outdate-bundled-gems by default
If baseruby is available (and its version is different from one being
built) when compiling ruby, tool/outdate-bundled-gems.rb (which is
invoked by `make i... -
- ruby_3_2 52ea5ea9906c3a96c60a68e01b303672602a6832 merged revision(s) 291a4098cf649c027cb50c16b872455f26ad1dfb,5be0d42d2c4dc765230c76738289560f9ee37f09.
-
09:09 AM Bug #19297: Don't download content from internet to execute Ruby test suite
- For what it's worth, Bundler's main test suite should pass now without an internet connection since https://github.com/rubygems/rubygems/pull/6243.
-
- YJIT: Fix `yield` into block with >=30 locals on ARM
It's a register spill issue. Fix by moving the Qnil fill snippet to
after registers are released.
[Bug #19299]
---
test/ruby/test_yjit.rb | 1... -
- Add missing assertion
---
test/ruby/test_time.rb | 3 +++
1 file changed, 3 insertions(+)
[Bug #19296] Precheck bits of time components
---
test/ruby/test_time.rb | 15 +++++++++++++++
... -
- I think this shouldn't be backported
-
- Return 0 if there is no CFP on the EC yet
StackProf uses a signal handler to call `rb_profile_frames`. Signals
are delivered to threads randomly, and can be delivered after the thread
has been created but before... -
- ruby_3_2 89cd61890fe78e0491708f87a5df678b03fda8a3 merged revision(s) 542e984d82fa25098eb15398d716d907acc52b93.
-
- ruby_3_2 49cf0896a2934547c0764aadaec021fb37a2e96f merged revision(s) 90a80eb076429978e720e11fb17a3cbb96de3454.
-
- Ignoring debug-1.7.1 because its extensions are not built. Try: gem pristine debug --version 1.7.
Revert "Clear gem paths for each test"
This reverts commit 6698b580ddad8cfa8c5c86df9328472820d3ee6a. -
- Some chruby-related features and bug fixes.
-
- Use a commit at the top of RBS 2.8.3, not 3.0.0.dev.N.
-
- (https://github.com/ruby/reline/pull/502)
* multiline_repl do not need to depend on RubyLex
* Add auto indent test -
05:25 AM Revision 46066d0b (git): Change ArgumentError message when Comparable#clamp receives min value higher than max value
- 04:53 AM Revision 5ce3855d (git): Update default gems list at 8a771efec21c9dacad5bb8bf14b81c [ci skip]
-
- https://github.com/ruby/psych/commit/a170b8eb46
-
- https://github.com/ruby/ruby/pull/7144
-
03:02 AM Revision 8ae4e3dd (git): Clean up removed directories in ext/Setup* [ci skip]
-
- - dbm/dbm.c removed at 55cd3e4ebff8fa75854ecadcd77abbf7cf4b5823
- fiber/fiber.c removed at 521ad9a13aef1e1dae4eaff70d3e6b2e358aa095
- gdbm/gdbm.c removed at edcc29dcff1b269b7748ab83adf21b2f3f97ebff
01/17/2023
-
- We can add the option of skipping `test-syntax-suggest` to `make check`.
And Fedora can use `make test test-tool test-all test-spec` instead of `make check` for past behavior. -
- How about adding `make test-offline` and that only runs test suites which don't need any internet connection?
I think that's a better fix, those who want to test offline must accept they only test a subset, I'm confident Bundler will no... -
06:14 PM Bug #19297: Don't download content from internet to execute Ruby test suite
- For a fix on our side. We could:
## Switch to test-unit
Update `syntax_suggest` to use test unit instead of rspec (since it seems that works fine on other libraries).
This would be straight-forward, though tedious.
## Res... -
10:13 PM Feature #19333: Setting (Fiber Local|Thread Local|Fiber Storage) to nil should delete value in order to avoid memory leaks.
- Thanks for the code search link.
Regarding the usage, wouldn't it only matter if the variable was checked with `thread_variable?` or equivalent? Because `thread_variable_get(:x)` is `nil` regardless of whether it's set (to `nil`) or not... -
- There are some, yes, see https://github.com/search?q=%22Thread.current%5B%22+%22%5D+%3D+nil%22+language%3ARuby&type=code&l=Ruby
A better search with a Regexp: https://github.com/search?q=%2FThread.current%5C%5B.*%5C%5D+%3D+nil%2F+languag... -
- > The user might use nil as a "valid value"
Have you seen any examples of this? -
- I submitted a pull request to remove the prototype from the public header files: https://github.com/ruby/ruby/pull/7141
`rb_struct_s_members` is still an exported symbol as it is used internally by `marshal.c`.
One of reasons state... -
-
07:58 PM Misc #19304: Kernel vs Object documentation
- Thanks for voicing that, @zverok! I always found this confusing (i.e., some methods being defined in Kernel, not in Object), and I'd love to see the docs reflect that in some form. (1) feels like the right thing to do, so what are the ro...
-
-
- Since `then` has been introduced, I think using that is more straightforward. I withdraw this feature. Please close it.
-
06:07 PM Bug #19349: Kernel.Integer silently discards base argument that does not have a #to_int
- And likely related: in case the output of the call to `to_int` returns something that is not an integer, it gets discarded as well
```
Kernel.Integer('10', Object.new.tap { |x| x.define_singleton_method(:to_int) { '8' } })
=> 10
``` -
- The method `Kernel.Integer` has an optional argument `base`, which is the base to convert the input to:
```
irb(main):001:0> Kernel.Integer('10', 8)
=> 8
```
If the base argument is not an integer, it is converted using `#to_int`
`... -
- > An extra map/Hash per Shape to know which ivars it contains could work
Yeah that's more what I had in mind.
> ...
What about one every X shapes? This way you'd have to walk at most X shapes, and then to one hash lookup. X could b... -
- byroot (Jean Boussier) wrote in #note-5:
> IIRC Aaron mentioned that V8 use a hash table after a certain number of edges (20?).
That's the complexity I'm talking about above which IMO is not worth it (that JS completely changes its o... -
- > I suppose this could be dramatically improved by storing the iv_index inside each shape, at the expense of using a bit more memory.
Actually, nevermind, the iv_index is already in the shape. The reason it's particularly slow here is... -
- Out of curiosity I profiled this script. 99% of the time is spent in `rb_shape_get_iv_index()`, which makes sense given that it walk back up the shape tree on every access, so the deeper the tree the longer it takes.
I suppose this co... - 04:46 PM Bug #19348 (Closed): GVL being released earlier than expected when loading iseqs
- Applied in changeset commit:git|df6b72b8ff7af16a56fa48f3b4abb1d8850f4d1c.
----------
Avoid checking interrupt when loading iseq
The interrupt check will unintentionally release the VM lock when loading an iseq.
And this will cause issu... -
- When using the `debug` gem in a Rails app with Ruby 3.2, I noticed that if the VS Code editor connects to the debugger during the app boot, this error could occur:
```
DEBUGGER: ReaderThreadError: uninitialized InstructionSequence
... - 01:01 PM Revision df6b72b8 (git): Avoid checking interrupt when loading iseq
- The interrupt check will unintentionally release the VM lock when loading an iseq.
And this will cause issues with the `debug` gem's
[`ObjectSpace.each_iseq` method](https://github.com/ruby/debug/blob/0fcfc28acae33ec1c08068fb7c33703cfa68... -
- I think a new method is cleaner. Or maybe reusing `Time.iso8601`.
It feels a hack for Time.new two wildly different things based on the number of arguments and as shown here it's ambiguous.
I had the same concerns when Time.new start... -
- mame (Yusuke Endoh) wrote in #note-7:
> I don't disagree this proposal, but it would be nice if we could evaluate the effectiveness of this optimization.
https://github.com/ruby/net-protocol/pull/14 shows gains between 2% and 27%, an... -
- I heard that Java stopped the shared substring technique 10 years ago (https://www.infoq.com/news/2013/12/Oracle-Tunes-Java-String/) because of the potential for memory leaks
I don't disagree this proposal, but it would be nice if we ... -
- Applied in changeset commit:git|ed6fbb79e19bf401db0e85447fee955fd10a25c7.
----------
Fix crash when defining ivars on special constants
[Bug #19339] - 09:57 AM Revision 9399352a (git): [rubygems/rubygems] Bump rb-sys in /test/rubygems/test_gem_ext_cargo_builder/custom_name
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.54 to 0.9.56.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.54...v0.9.56)
---
updated-depende... -
- [Bug #19339]
- 08:47 AM Revision f8249eb4 (git): Update default gems list at 492d37fbbd3613b7fb180eec529860 [ci skip]
-
- https://github.com/ruby/psych/commit/67ec299c68
-
- checking whether make sets $(MAKE)... (cached) yes
checking build system type... arm-apple-darwin21.6.0
checking host system type... Invalid configuration `arm64-apple-darwin21': machine `arm64-apple' not recognized
configure: erro... -
-
-
- 07:19 AM Revision d7af0f60 (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.54 to 0.9.56.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.54...v0.9.56)
---
updated-depende... -
-
- [Bug #19292] Re-initialize tm when wday or yday is not set
---
test/ruby/test_time.rb | 3 ++-
time.c | 31 ++++++++++++++++++++++---------
2 files changed, 24 insertions(+), 10 deletion... -
- Fix integer underflow when using HEAP_INIT_SLOTS
There is an integer underflow when the environment variable
RUBY_GC_HEAP_INIT_SLOTS is less than the number of slots currently
in the Ruby heap.
[Bug #192... -
- Hi, thank you for replying. Rubygems is thread-safe but it doesn't work calling `require` inside a non-main ractor because the rubygems internal logic doesn't follow strict isolation protocol.
01/16/2023
-
- Having actually read the title of this issue, I see it's for implementing `fchdir`, not `openat` - but the point is the same, directory file descriptors are important to avoid some race conditions and Ruby doesn't really have a way to us...
-
- I have definitely wanted this before FWIW. The main use-case I've had for this feature is writing code to look at things in the `/proc` filesystem on Linux. If a process exits, its pid can be re-used, and so the same path in `/proc` can ...
-
- Recently, I was working on a program that passes file descriptors over UNIX sockets (using `send_io`/`recv_io`). For file/socket/device descriptors, this works fine using `File#reopen`. However, I found that while Ruby supports `Dir#fi...
-
- * [Feature #19347] Add Dir.fchdir (jeremyevans0)
* This method is useful when passing directory file descriptors through UNIX sockets or to child processes to avoid TOCTOU vulnerabilities.
* We already have Dir#fileno, but nothing ... -
- This reduces the code size of libyjit.a by a lot. On darwin it went from
23 MiB to 12 MiB for me. I chose ThinLTO over fat LTO for the relatively
fast build time; in case we need to debug release-build-only problems
it won't be painful. -
- No warnings from GCC 12.
-
- While trying to fix YJIT's symbol hygiene issue over at GH-7115, I found
that addr2line.c's DWARF 5 parsing is half-disabled when building with
GCC. Rust's output contains some DW_AT_rnglists_base records, which the
disabled code reads. ... -
- This kind of escape hatch can break the Ractor's assumptions so it is not accepted.
For example, we are working on making ractor-local GC and in this case an object can not be reached from other ractors without special sharing logic.
... -
- It would be nice to be able to autoload constants inside Ractors. I'm not sure why this is disabled right now because if autoloading is working properly inside threads
then my initial thought is that the autoload implementation should w... -
05:09 PM Bug #19266: URI::Generic should use URI::RFC3986_PARSER instead of URI::DEFAULT_PARSER
- After a couple of weeks with no reply I wanted to ask if I could get at least one comment on this issue?
A quick summary of the issue:
* In 2014, `URI` was updated to use a new RFC3986-compliant parser by default instead of the pre... -
- Correction to RDoc for Regexp.new
-
- Thanks for the explanation :) class_eval with string also works to change scope, apparently.
-
- Class variables work similar to constants in terms of lookup, they only use the scopes opened by `class Name/module Name/class << expr`.
`module_{eval,exec}/class_{eval,exec}` do not change that scope.
So this is expected, `EnvUtil.lab... -
- I just looked into this some more and if we want to allow the above code to work then we need to change the way the class variable cache works right now. Right now because the lookup of the class where we set the @@variables is static, i...
-
- I was looking at doing something like this:
```ruby
set_cvar = EnvUtil.labeled_class("SetCVar") do
def self.set(val)
@@a = val
end
end
set_cvar.set(1) # fill write cache
set_cvar.freeze
set_cvar.set(2) # hit write cach... -
- Thank you for reporting this bug. I opened a PR with the fix here: https://github.com/ruby/ruby/pull/7129
-
01:59 PM Bug #19154: Specify require and autoload guarantees in ractors
- > I think require/autoload in a Ractor should simply be forbidden.
That would be a resolution for this ticket. -
- luke-gru (Luke Gruber) wrote in #note-2:
> As long as there's a mutex somewhere protecting these mutations it's safe. There is a mutex around rubygems require. I only had to add `Ractor.force_shareable!` to 2 or 3 places in the rubygems ... -
- @ko1 I believe this needs to be an exception until there is a better solution.
It's likely possible to create a segfault with concurrent mutations of `$"` currently.
And anyway `require` does not work in non-main Ractors, not just `$"`... -
- The current solution/workaround to both of these memory leaks is to use concurrent-ruby's [ThreadLocalVar](https://ruby-concurrency.github.io/concurrent-ruby/master/Concurrent/ThreadLocalVar.html) (and upcoming FiberLocalVar), which is t...
-
- While the proposed idea is a good move in the right direction, it doesn't handle cases where several (a large number) threads all have the SAME thread local, and that thread local goes out of scope, e.g.
```ruby
name = ":local-#{object_... -
- This behavior has been slightly extended with the addition of
`String#scrub`. -
- I restored `ruby-talk` archives today. Sorry, I forgot to do it.
-
07:47 AM Bug #19342 (Closed): String#encode does not always throw exceptions for invalid source encodings
- I fixed the documentation (which was moved to doc/string/encode.rdoc by @nobu in commit:468ce1488d) in commit:11f28f3268. I think that this issue can therefore be closed.
-
- This was discussed in issue 6190. As you already say, it's somehow a weird case. The decision was to make transcoding from an encoding to the same encoding a no-op for performance. There was also some documentation (now in git commit com...
-
- This is a reenstatement of the explanation in commit
463633e4a934a00f869086a6ffbf84c6cb8ad630 to partially
address Bug #19342. -
- It is already warned with `$VERBOSE`, and this make to raise `ArgumentError`.
```diff
diff --git a/re.c b/re.c
index 7a743185589..f03c2b48a1e 100644
--- a/re.c
+++ b/re.c
@@ -3866,7 +3866,7 @@ reg_extract_args(int argc, VALUE *ar... -
- Hello everyone!
First, let me thank you for all your work! Ruby on Windows has helped me a lot over the years. Gems with C extensions used sometimes fail to install, but nowadays it works. Ruby Installer with MSYS2 actually works quite ... -
-
- From the ruby-loco log, which has the Ruby PR applied:
```
Copying rbs@eab5367add3469b3f614e663ba43a3debc62420a to rbs-3.0.0.dev.1
From https://github.com/ruby/rbs
* branch eab5367add3469b3f614e663ba43a3debc62420a... -
- I couldn't reproduce it.
And What should we install their versions?
1. rbs of eab5367add3469b3f614e663ba43a3debc62420a(not 3.0.0.dev.1)
2. 3.0.0.dev.1
3. rbs-2.8.3
4. Nothing, We skip to install rbs because there is no tested ve...
01/15/2023
-
11:00 PM Revision 4617b40f (git): fix typo in comments / autodoc
- replace _socktype_ with _type_ in the comments
-
05:10 PM Feature #19344 (Open): Regexp.new: stricter handling of second argument
- Since Ruby 3.2 (#18788), the second argument to `Regexp.new` can be:
1. Integer: then it is treated as a combination of `Regexp::<constant>` flags
2. String: then it is treated as a combination of string flags
3. `nil` or `false`: the... -
- So that rubygems can find the bundled rake.
-
- Disable for now, since this seems causing infinite rebuilding.
-
- I've also got parallel references to constant for which there is autoload working, with a few tweaks to the VM needed.
```ruby
rs = []
autoload :C, './test3.rb'
1000.times do
rs << Ractor.new do
C
C
C
end
end
p rs.map(&... -
- I've taken a look at this a bit and got this working:
```ruby
require 'rubygems' # get rubygems version of require
rs = []
100.times do
rs << Ractor.new do
require './c.rb'
end
end
rs.each(&:take)
p C
```
In file c.rb, it's
```r... -
07:02 AM Bug #19343 (Closed): Integer#ceildiv should respect #coerce
- https://github.com/ruby/ruby/pull/7118
This issue is similar to #19335.
```Ruby
c = Object.new
def c.coerce(other) = [other, 10]
p 1234 / c # => 123
p 1234.div(c) # => 123
p 1234.quo(c) # => (617/5)
p 1... -
05:24 AM Bug #19342 (Closed): String#encode does not always throw exceptions for invalid source encodings
- Documentation says that String#encode throws Encoding::InvalidByteSequenceError when the string isn't valid in the source encoding, but it does not always do so:
```
"\x99".encode('UTF-8', 'UTF-8')
"\x99".force_encoding('UTF-8').enc... -
- Applied in changeset commit:git|71ce7e1825c5b8fe08dd96cd77c6a379afd34256.
----------
[Bug #19335] `Integer#remainder` should respect `#coerce` (#7120)
Also `Numeric#remainder` should. -
- Also `Numeric#remainder` should.
01/14/2023
-
- ``` ruby
class SetCvar
def self.set(val)
@@a = val # inline cache
end
end
def test_set_cvar_on_frozen_object
SetCvar.set(1) # fill write cache
SetCvar.freeze
SetCvar.set(2) # hit write cache, but should check fro... -
- Last three daily builds of ruby-dev-builder have not included the rbs gem.
See https://github.com/ruby/ruby-dev-builder/actions/runs/3919887598/jobs/6701177359#step:17:284
ruby/ruby PR https://github.com/ruby/ruby/pull/7114
ruby... -
- ```ruby
1.instance_eval do
@a = 1
end
```
There's a missing check at the top of vm_setivar_fastpath, should be:
```c
if (UNLIKELY(RB_SPECIAL_CONST_P(obj))) { // example code: 1.instance_eval { @a = 1 }
rb_check_... -
- To simplify the problem, this hangs too:
```ruby
MYCONSTANT = 1
Ractor.new do
MYCONSTANT = 2
end.take
```
-
This code causes Ruby to hang:
``` ruby
rs = []
2.times do
rs << Ractor.new do
MYCONSTANT = 2
end
end
rs.each(&:take)
```
There is a problem when the warning is being outputted with multiple ractors. A thread is c...-
- Since `REVISION_H` is defined in common.mk which is appended or
included after Makefile.in, it was undefined yet at the point of the
dependency. -
09:19 AM Revision 5b26f76a (git): [ruby/reline] Correspond to refactored RubyLex
- (https://github.com/ruby/reline/pull/498)
* Correspond to refactored RubyLex
ref: https://github.com/ruby/irb/pull/503
* Fix test_yamatanooroti -
- Some background for this refactor:
1. Through a RubyLex instance's lifetime, the context passed to its methods
should be the same.
Given that `Context` is only initialised in `Irb#initialize`,
this should be true.
2. When `Rub... -
- This is likely dupe of my #18381, which was not addressed yet.
-
07:40 AM Bug #19337 (Closed): What is the difference between "default" gems and "bundled" gems?
- Although I found [some answers](https://nts.strzibny.name/ruby-stdlib-default-bundled-gems/) on the [internet](https://stdgems.org), it seems like this information should be available from Ruby itself, if it's not already.
Perhaps thi... -
01:24 AM Revision 2082ba7c (git): [ruby/psych] Remove deleted file from gemspec
- https://github.com/ruby/psych/commit/77861ff281