Activity
From 12/08/2022 to 12/14/2022
12/14/2022
- 10:37 PM Revision d20bd06a (git): Remove `require 'io/wait'` where it's no longer necessary. (#6932)
- * Remove `require 'io/wait'` as it's part of core now.
* Update ruby specs using version gates.
* Add note about why it's conditional. -
10:13 PM Revision 55f56eb6 (git): [ruby/net-http] [DOC] New doc for responses classes
- (https://github.com/ruby/net-http/pull/91)
https://github.com/ruby/net-http/commit/d394404402 -
- (https://github.com/ruby/net-http/pull/90)
https://github.com/ruby/net-http/commit/d9d829ca53 -
09:17 PM Revision 693c01d5 (git): YJIT: Remove duplicate call to jit_prepare_routine_call()
- It's idempotent.
-
08:15 PM Bug #18605: Fails to run on (newer) 32bit Windows with ucrt
- Thanks all for sharing the details!
I started a branch to replace the UCRT/MSVCRT pioinfo here: https://github.com/ruby/ruby/compare/master...larskanis:ruby:pioinfo?expand=1
My rough plan is to first replace pioinfo with a ruby-int... -
06:21 PM Revision 7a63114f (git): Remove dead code in get_next_shape_internal
- If the rb_id_table_lookup fails, then res is not updated so it cannot be
any value other than null. -
03:27 PM Revision 71dd8b3c (git): socket.rb - simplify check for the method
-
03:19 PM Bug #19233: Failed to install sqlite3 gem since 7f1ca666424849134990d022266bcd4d6636465f using Docker
- I have opened a new one because it does not reproduce against Ruby 3.1.3 Docker images.
`FROM ruby:3.1.3`
`FROM rubylang/ruby:3.1.3-focal`
#19189 says:
> Starting with Ruby 3.1.3, mkmf.rb calls to pkg-config will fail if pkg-co... -
- Isn’t this same as #19189?
-
01:48 PM Bug #19233: Failed to install sqlite3 gem since 7f1ca666424849134990d022266bcd4d6636465f using Docker
- When sqlite3-ruby's (v1.5+) extconf calls `pkg_config()`, the argument `pkg` is "/opt/ruby/lib/ruby/gems/3.2.0+2/gems/sqlite3-1.5.4/ports/x86_64-linux-gnu/sqlite3/3.40.0/lib/pkgconfig/sqlite3.pc".
In this docker container, `RbConfig::... -
- When I examine the files left in the docker container, I see this error in the `mkmf.log`:
```
package configuration for /opt/ruby/lib/ruby/gems/3.2.0+2/gems/sqlite3-1.5.4/ports/x86_64-linux-gnu/sqlite3/3.40.0/lib/pkgconfig/sqlite3.pc i... -
- Hi, I'm a co-maintainer of the sqlite3 gem and I wanted to add a little more context.
In v1.5, we simplified the `extconf.rb` by using `MakeMakefile.pkg_config` to read the `sqlite3.pc` file generated earlier during installation. Prio... -
01:07 PM Bug #19233: Failed to install sqlite3 gem since 7f1ca666424849134990d022266bcd4d6636465f using Docker
- Hi.
As a test, I also built a container as follows
```
FROM rubylang/rubyfarm:7f1ca666424849134990d022266bcd4d6636465f
# FROM rubylang/rubyfarm:88c12a29372e3f908190c6af0aa1b2ac6b78fbd1 # passes
# FROM rubylang/rubyfarm:7f1ca66642484913... -
- There are other findings so far:
* It works fine with Ruby installed locally without Docker.
* It also works fine using `gem "sqlite3", "< 1.5"`
-
- Failed to install sqlite3 gem since 7f1ca666424849134990d022266bcd4d6636465f using Docker. This issue comes from https://github.com/rails/rails/pull/46711 .
## Steps to reproduce
1. Install Docker
2. Follow this step
```
git ... -
03:14 PM Revision 9eb19a02 (git): Add more comments why CRuby uses __pioinfo
-
02:53 PM Revision 1df6d0e5 (git): objspace_dump.c: don't dump class of T_IMEMO
- They don't actually have a class.
-
02:44 PM Bug #19235: StringIO.new(encoding: "ext_enc:int_enc") doesn't set external encoding
- Though it is kinda [specified in README](https://github.com/ruby/stringio#differences-to-io) :)))
> encoding conversion is not implemented, and ignored silently. -
- The `StringIO` doesn't have a proper concept of two encodings implemented :(
Also reported here #16497 but still not fixed completely.
I'll try to look into it this weekend. -
02:37 PM Bug #19235 (Closed): StringIO.new(encoding: "ext_enc:int_enc") doesn't set external encoding
- I noticed a divergence between IO `:encoding` option documentation and StringIO's behaviour:
```ruby
io = StringIO.new('', 'w', encoding: 'utf-8:ISO-8859-1')
io.external_encoding # => #<Encoding:ISO-8859-1>
```
According to the ... -
-
- (https://github.com/ruby/net-http/pull/89)
https://github.com/ruby/net-http/commit/86b84eb307 -
10:21 AM Feature #19194 (Closed): Add Regexp.linear_time?
- https://github.com/ruby/ruby/pull/6901 has been merged.
-
- Filing this bug here in case some people may have observed it too and may have more information, and also to keep track of it for the upcoming 3.2.0 release.
After changing some settings on our CI to make sure YJIT's `code_gc` would t... -
- https://github.com/rubygems/rubygems/commit/5479d99a1d
- 08:49 AM Revision 45e84d17 (git): Update default gems list at 1a8d460534c7423091b790530bb3ea [ci skip]
-
- https://github.com/ruby/securerandom/commit/9e16b597f5
- 08:43 AM Revision 31bc403e (git): Update default gems list at 95d7b5e2e933cf74cc29782ce33b65 [ci skip]
-
- https://github.com/ruby/resolv-replace/commit/187e91d149
-
- Fixed https://github.com/ruby/date/issues/83
https://github.com/ruby/date/commit/9731a3e732 - 07:54 AM Revision f60c0808 (git): Update default gems list at 15f5842a5fe57fdc9af28494609cbd [ci skip]
-
- https://github.com/ruby/English/commit/736f819b3b
- 07:39 AM Revision d652474a (git): Update default gems list at 0b67e435ed07a2febf7c7bd4911257 [ci skip]
-
- https://github.com/ruby/abbrev/commit/8c3debac5a
-
07:12 AM Feature #19134: ** is not allowed in def foo(...)
- > IMHO if ... is used then *, ** and & should all be forbidden (a SyntaxError at parse time).
I agree with this. If you want to do that, you should take it with `def foo(*, **, &)`.
I feel that only `&` is acceptable since a block ... - 07:08 AM Revision 82b61f53 (git): Update default gems list at c6f41a3255e55d6a30bc8ef557bfba [ci skip]
-
- https://github.com/ruby/time/commit/4cebf6de3c
- 07:01 AM Revision c96ffd36 (git): Update default gems list at 989d993f5b03fbbf712554abe7f93b [ci skip]
-
- https://github.com/ruby/reline/commit/3fbb7ec2ae
-
-
06:40 AM Revision 307d2e0e (git): Skip yet another flaky Ractor test
-
- itself
- 06:18 AM Revision 00acc9b0 (git): Update default gems list at 9e4d7e99ce5686760ef2eab0d8b4f9 [ci skip]
-
- https://github.com/ruby/syslog/commit/a92b55b638
- 06:17 AM Revision c4009a2e (git): Update default gems list at e2f4b8bf77ac29b2b94fc01d6d2d63 [ci skip]
-
- https://github.com/ruby/weakref/commit/5b5f79d8a6
-
- "3.2.0+33" starts with "3.2.0+3", but it doesn't mean that they are the
same ABI version. - 05:59 AM Revision 2d5b723b (git): Fix build when enable_shared is on (#6924)
- Before this change, if enable_shared was true, the directory would have a suffix of -static and be deleted on each make install. This would cause a second make install to fail.
- 05:54 AM Revision a7cf39bb (git): Update default gems list at 87d32376d96d2c73083ac149df788e [ci skip]
-
- https://github.com/ruby/readline-ext/commit/7af996f24b
- 05:49 AM Revision a3b2719a (git): Update default gems list at 0c27c1b3fca72e638a9d91705234e7 [ci skip]
-
- https://github.com/ruby/open3/commit/38904e204d
- 05:36 AM Revision 6b41a2f9 (git): Update default gems list at 067747bb9a959808c47b32393170ca [ci skip]
-
- https://github.com/ruby/tempfile/commit/99dc1f7058
-
-
03:57 AM Revision fbedadb6 (git): Add `Regexp.linear_time?` (#6901)
-
02:29 AM Feature #19135: Support `UNIXSocket` on Windows
- I would like to share this credit with @larskanis who was instrumental to getting this PR over the finish line. It was a true team effort with hard compatibility challenges.
-
12:10 AM Feature #19232 (Feedback): add NoMatchingPatternError#matchee
- currently if you pattern match a Hash, you can inspect the #key and #matchee methods from the NoMatchingPatternKeyError
```ruby
begin
{ error: true } => { value: }
rescue NoMatchingPatternKeyError => e
e.matchee
end
# => {:err... -
12:00 AM Revision fe3cbc61 (git): [ruby/reline] Fix a misparameter of RubyLex#set_input in
- termination_checker.rb
(https://github.com/ruby/reline/pull/482)
* Fix a misparameter of RubyLex#set_input in termination_checker.rb
The keyword parameter `:context` of RubyLex#set_input became mandatory due to this commit:
https://git...
12/13/2022
-
10:13 PM Bug #19196: The string saved to Tempfile from URI.open escapes "&" character
- @ufuk thank you for that explanation. I may have jumped to conclusions when checking that response in the browser (Chrome) vs curl which unescaped the characters.
-
06:21 PM Bug #19196 (Rejected): The string saved to Tempfile from URI.open escapes "&" character
-
12:53 AM Bug #19196: The string saved to Tempfile from URI.open escapes "&" character
- The content you are reading is XML and `&` characters are there because of [XML-escaping](https://www.liquid-technologies.com/XML/EscapingData.aspx). They are not related to any kind of file encoding, `ASCII-8BIT` or `UTF-8`.
More... -
08:42 PM Revision 83c12b5b (git): [ci skip] Fix Doxygen for ROBJECT Macro
-
07:57 PM Revision 74995162 (git): socket.rb - don't load io/wait (#6922)
- See d2166c09b08fc1 and #6036 for more context.
-
- https://github.com/ruby/date/commit/6bb6d3a810
-
07:01 PM Bug #19165: Method (with no param) delegation with *, **, and ... is slow
- I made a patch https://github.com/ruby/ruby/pull/6920
This patch improves the performance of the cases which are discussed on this ticket.
However, this patch changes the calling convention and YJIT and MJIT are needed to catch up.
... - 06:37 PM Revision 25f727d4 (git): Update default gems list at a1dba60b5bec6b25e8262640228e19 [ci skip]
-
- https://github.com/ruby/irb/commit/229476ba76
-
- [ci skip]
Co-Authored-By: Peter Zhu <peter@peterzhu.ca> -
- IMHO Integer makes sense so one can step by N from 0 to infinity with `0.step(Float::INFINITY, 10)` (with `Numeric#step`), since there is no `Integer::INFINITY`.
Using Float also can cause significant errors with a big enough step or va... -
03:59 PM Bug #19231: Integer#step and Float::INFINITY - inconsistent behaviour when called with and without a block
- `0.step(Float::INFINITY, 10).each` generates Float values until Ruby 2.0 and after Ruby 2.6, but it generates Integer values between Ruby 2.1 and 2.5. The reason why the behavior changes after Ruby 2.6 is due to ArithmeticSequence.
`... -
- The initial issue was reported here https://github.com/oracle/truffleruby/issues/2797.
`0.step(Float::INFINITY, 10)` returns:
- `Integers` when called with a block
- `Floats` when called without a block
I would expect `Floats` to... -
- * YJIT: Change the default mem size to 64MiB
* Also update ruby --help
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com> -
- I think Rails CI is also affected by https://github.com/ruby/ruby/commit/7f1ca666424849134990d022266bcd4d6636465f
Details are https://github.com/rails/rails/pull/46711#issuecomment-1348396867 -
- RDoc does not consider preprocessor conditionals, but equally uses
both documents of `#if` and `#else` sides.
https://github.com/ruby/openssl/commit/ea0a112a0c -
- https://github.com/ruby/ruby/commit/6d8f396f37350b7aa9c85a097929f54a0939448b
https://github.com/ruby/ruby/commit/c8b3bd45cc3cae93ae701333202416838ee6a00c - 09:07 AM Revision 2be03fb5 (git): [ruby/openssl] Fixes OPENSSL_LIBRARY_VERSION description on
- documentation
(https://github.com/ruby/openssl/pull/559)
Adds back missing constant description on the documentation. - 09:07 AM Revision 8ab8c2d6 (git): [ruby/openssl] Enable HKDF support for LibreSSL 3.6 and later
- LibreSSL 3.6 added support for HKDF in EVP. Enable this in ossl_kdf.c.
https://github.com/ruby/openssl/commit/9bdd39a7e2 -
09:07 AM Revision d4dce27d (git): [ruby/openssl] Allow empty string to OpenSSL::Cipher#update
- For some reasons, plaintext may be empty string.
ref https://www.rfc-editor.org/rfc/rfc9001.html#section-5.8
https://github.com/ruby/openssl/commit/953592a29e - 09:07 AM Revision d92f4fe4 (git): [ruby/openssl] Use EVP_Digest{Sign,Verify} when available
- LibreSSL 3.4 added EVP_DigestSign() and EVP_DigestVerify(). Use them
when available to prepare for the addition of Ed25519 support in
LibreSSL 3.7.
https://github.com/ruby/openssl/commit/475b2bf766 -
09:07 AM Revision ce025a5c (git): [ruby/openssl] Use SHA256 instead of SHA1 where needed in tests.
- Systems such as RHEL 9 are moving away from SHA1
disabling it completely in default configuration.
https://github.com/ruby/openssl/commit/32648da2f6 -
- Applied in changeset commit:git|764da87ab02d30c578138bdb0f37e7c18f2d4371.
----------
[Bug #19195] Allow optional newlines before closing parenthesis -
-
08:56 AM Bug #19230: The openssl backend of securerandom is no longer needed
- Good catch!
I did a quick GitHub search to see if anyone might be calling this method directly, but given it's private maybe we shouldn't care? The first 10 pages showed no interesting results.
It seems [this test](https://github.c... -
- securerandom first checks if Random.urandom is available ([Line 77](https://github.com/ruby/securerandom/blob/5bfe7d6c163f7a8a45af8d2fc377ff4315f8c6a5/lib/securerandom.rb#L76-L77)), and if not available, it uses the openssl backend as a ...
-
- We only need to set outpath for that case.
-
- --revision.h and --if-change are not used simultaneously, but they might
be in the future.
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org> -
- * Avoid overwriting revision.h when .git doesn't exist
* Overwrite revision.h if it's blank -
- >May I merge the pull request on GitHub?
Yes, you can merge it. I meant commit and push to master branch directly or merge pull-request. -
- @hsbt Sorry, I'm not sure what "apply" means. May I merge the pull request on GitHub?
-
- I added write permission to @make_now_just now. Can you apply this by yourself?
-
- Segaja (Andreas Schleifer) wrote in #note-7:
> That is interesting. The second sentence from https://rubyreferences.github.io/rubyref/stdlib/bundled.html says "Unlike standard library, these gems can be updated independently from Ruby i... -
- @Segaja I'll close this because your first question was resolved now.
-
- from https://github.com/rubygems/rubygems/commit/1fdbeeabedd3cc4fffb0bb527b7c789afa44fb51
-
03:41 AM Revision 6d00053c (git): [rubygems/rubygems] Use better matcher
- Hopefully it gives a better error.
https://github.com/rubygems/rubygems/commit/5bc9ff64b6 -
12/12/2022
-
11:31 PM Feature #19197 (Open): Add Exception#root_cause
- ### Description
I would like to add a `#root_cause` method to `Exception`.
It returns the last exception in linked-list of causality chain, that is, the original exception (whose own `cause` is `nil`).
### Example
```ruby
e ... - 10:29 PM Revision 91050d34 (git): [rubygems/rubygems] Bump rb-sys in /test/rubygems/test_gem_ext_cargo_builder/custom_name
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.46 to 0.9.48.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.46...v0.9.48)
---
updated-depende... -
10:05 PM Revision 43f93511 (git): Fix parens on LIKELY in basic operators
- We want to hint to the compiler that it's likely that the BOP is
unredefined (the bit is 0). Previously we were accidentally hinting to
the compiler that it was non-zero due to a misplaced parenthesis. -
- I suspect this was for debugging? If not, these days we have source
control tools, so this wouldn't seem necessary? -
- When I am reading the string response from a URI.open, the response is not equivalent to the response body.
How to reproduce:
```
url = "https://www.podcastone.com/podcast?categoryID2=1237"
handle = URI.open(url)
=> #<Tempfile... - 09:05 PM Revision f88f2bd9 (git): [ruby/irb] Group show_doc tests and update the expectation
- (https://github.com/ruby/irb/pull/479)
https://github.com/ruby/irb/commit/bede04c14a -
- * YJIT: Generate debug info in release builds
They are helpful in case we need to do core dump debugging.
* Remove Cirrus DOC skip rule
The syntax for this is weird, and escaping [ and ] cause parse failures.
Cirrus' docs said to surr... -
08:13 PM Revision 1004d693 (git): Make it so YJIT is no longer marked as experimental (#6909)
- Tested on production workloads at Shopify for > 1 year and proven
to be quite stable. Enabling YJIT at run-time is still guarded
behind the --yjit command-line option for now. - 08:04 PM Revision 8e619b8e (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.46 to 0.9.48.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.46...v0.9.48)
---
updated-depende... -
- (https://github.com/ruby/net-http/pull/88)
https://github.com/ruby/net-http/commit/46e966be10 - 05:35 PM Revision 223d4448 (git): [ruby/irb] `show_doc` command should take non-string argument too
- (https://github.com/ruby/irb/pull/478)
Given that `show_doc` already supports syntax like `String#gsub`, it
should be able to take it in non-string form too, like `edit` and
`show_source` do. This ensures users can have a consistent syn... -
-
-
-
-
-
-
-
-
-
- shugo (Shugo Maeda) wrote in #note-8:
> `&` is allowed in 3.1, so it's a breaking change to prohibit it.
Right and `&` is not problematic re performance, it's a completely separate argument anyway.
I agree with your proposal in your... -
01:12 PM Bug #19195 (Closed): Pattern match pin becomes syntax error if there is newline before closing paren
- Syntax OK
~~~ruby
1 in ^(
1)
# => true
~~~
Syntax error. I think it should be syntax ok.
~~~ruby
1 in ^(
1
)
# => syntax error, unexpected '\n', expecting ')'
~~~
-
- In general, libraries should use `LoadError#path` instead of parsing the messages.
In addition, `.`s in a regexp don’t seem intentional. -
- Judging by the [diff](https://github.com/ruby/ruby/pull/6908) to produce this change, we would be breaking bundler -- which probably won't work 🤔
-
- https://github.com/ruby/setup-ruby/issues/415#issuecomment-1345662263
-
-
- Follow up of 1d2d25dcadda0764f303183ac091d0c87b432566
-
- https://github.com/rubygems/rubygems/commit/bc84b2d262
-
- Thank you for accepting the change and nominating me to a committer. I welcome this nomination.
-
02:06 AM Feature #19194: Add Regexp.linear_time?
- Also accepted to nominate him a committer.
Matz.
-
- Accepted.
Matz.
-
- @make_now just Thank you!
I would like to propose @make_now_just as a committer. He has made a great improvement to the Regexp engine. Ruby's Regexp engine is in a state of its own fork from onigmo, and he is a valuable person who can m... -
- https://bugs.ruby-lang.org/issues/19104#change-100542
-
- Thanks. I did create the [3.3 milestone](https://bugs.ruby-lang.org/versions/71)
-
04:51 AM Bug #19007: Unicode tables differences from Unicode.org 14.0 data
- hsbt (Hiroshi SHIBATA) wrote in #note-6:
> @duerst Is there any action for Ruby 3.2 related this? If there is nothing to do for Ruby 3.2, I'll remove this from Ruby 3.2 milestone.
No, nothing should be needed for Ruby 3.2. I removed ... -
- @duerst Is there any action for Ruby 3.2 related this? If there is nothing to do for Ruby 3.2, I'll remove this from Ruby 3.2 milestone.
-
05:00 AM Feature #19193: drop DOS TEXT mode support
- > The most important reason we are keeping "text mode" at reading is backward interoperability for old files.
agree.
> ...
I don't think so.
For example, Excel 2021 outputs CRLF newlines when creating a CSV file.
Reading as text mode ... -
- YO4 (Yoshinao Muramatsu) wrote:
> * Microsoft's most apps works without CRLF newline.
I guess you mean those apps can read without CR, but is it the default to write with LF newlines?
> ...
This is not related to reading, but writ... -
- Applied in changeset commit:git|f093b619a4863be96e6ebfa2fd58c77f4a360eae.
----------
[DOC] NEWS about [Feature #19104] -
-
- This issue has been filed at https://github.com/ruby/openssl/issues/563
-
-
- from https://github.com/rubygems/rubygems/commit/bfb0ae69776069155d2092702bfbb5a12617d85a
12/11/2022
-
- (https://github.com/ruby/net-http/pull/85)
https://github.com/ruby/net-http/commit/9d9040fb79 -
- Ugh, it's quite weird. The `:crlf_newline` option is an [encoding option](https://docs.ruby-lang.org/en/master/encodings_rdoc.html#label-Encoding+Options),
but `File.open` uses it in a way different from `String#encode`.
With `String#e... - 05:24 PM Revision e1ca089b (git): [DOC] Correct Array#compact! description
-
- Since we also skip them on GitHub Actions.
-
- * Make its usage more obvious (by providing more detailed
examples);
* Include mention of it into Random itself;
* Small cleanups of docs. -
- As per discussion in [Feature #18273], explain the
non-deterministic nature of the method. -
- And remove a patch no longer needed since we dropped Ruby 2.4 support.
https://github.com/rubygems/rubygems/commit/8939337072 -
- And configure tsort to be vendored as a dependency of Molinillo.
https://github.com/rubygems/rubygems/commit/8ec749f891 -
11:23 AM Revision 9477ec73 (git): NEWS.md: fix ticket ref position.
-
10:27 AM Revision d245c2ec (git): Fix typos [ci skip]
-
08:50 AM Feature #12813: Calling chunk_while, slice_after, slice_before, slice_when with no block
- I think this has already been implemented by now. It should be closed.
-
- * MJIT: Compile methods in batches
* MJIT: make mjit-bindgen
* MJIT: Fix RubyVM::MJIT tests -
- I suggest adding a new method named `Regexp.linear_time?` to check if matching against a given regexp can be completed in linear time by the optimization introduced in #19104 (GitHub PR [#6486](https://github.com/ruby/ruby/pull/6486)).
... -
- Applied in changeset commit:git|7055574cf9dbcabd9d440c364f3e7b7812527bde.
----------
[Bug #19182] Unicode updating targets do not need to run for each files -
12/10/2022
-
- mmizutani (Minoru Mizutani) wrote in #note-7:
> Regex fuzzing encountered an edge-case regression:
Thanks. This has nothing to do with this ticket. It's a different issue caused by my change commit:1d2d25dcadda0764f303183ac091d0c87b4... -
06:41 AM Feature #19104: Introduce the cache-based optimization for Regexp matching
- Regex fuzzing encountered an edge-case regression:
```bash
$ ruby --version
ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-linux]
$ time ruby -e 'puts /あ(?~い)/.match?("あ")'
true
0.04s user 0.04s system 74% cpu 0.118 tot... - 06:35 PM Revision ea613c63 (git): Expose need_major_gc via GC.latest_gc_info (#6791)
-
05:10 PM Feature #18951: Object#with to set and restore attributes around a block
- > The use case isn't seen as common enough, so I added 3 real world example in the description, If that's not enough I can add as much as you want, this pattern is extremely common.
@matz I have seen this pattern repeated in almost ever... -
03:55 PM Feature #18285: NoMethodError#message uses a lot of CPU/is really expensive to call
- Hey everyone! I actually had someone reach out to me (because I had blogged about this) the other day, since they had been bitten by this issue.
Interestingly, it appears that actually this keeps getting "rediscovered" in the Ruby eco... -
03:10 PM Revision 12003acb (git): Update shape capacity when removing ivar and rewriting shape transitions
- Since edc7af48acd12666a2945f30901d16b62a39f474, we now no longer have
undef ivar transitions. Instead, we rebuild the shapes table. When we do
this, we need to ensure that we retain our capacities on shapes. -
- YO4 (Yoshinao Muramatsu) wrote:
> when ```set_encoding("UTF-8")``` implicitly converts console code page to UTF-8.
I'm against more inconsistent corner cases like this for `set_encoding`.
Probably IRB should be fixed here to inherit... -
- * Issue numbers are path components but not fragments
* Align justification width to Feature lines -
-
-
- Applied in changeset commit:git|7a976c106030f37d6ab72b1abaef10e575bb8809.
----------
[Bug #19181] Separate the rule for unicode_normalize/tables.rb timestamp
It should depends on only existing data files (except for the tools),
unless ... -
-
- It should depends on only existing data files (except for the tools),
unless `ALWAYS_UPDATE_UNICODE=yes`. -
- 12:54 AM Revision 22d391dc (git): Add spec for fiber storage. (#6896)
-
12/09/2022
- 11:39 PM Revision 381e128c (git): [ruby/irb] Fix step command (https://github.com/ruby/irb/pull/477)
- The current `next` pre-command workaround on IRB source stepping
moves the location by 1 extra line. A better way is to make `debug`
skip IRB frames completely, which is what this commit does.
It also fixes the step command's test. The ... -
- * YJIT: implement getconstant YARV instruction
* Constant id is not a pointer
* Stack operands must be read after jit_prepare_routine_call
Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com> -
-
04:38 PM Feature #19193 (Assigned): drop DOS TEXT mode support
- On Windows platform, ```File.open(path, "r")``` returns an object different from "rt" and "rb". I call that DOS TEXT mode here.
DOS TEXT mode does
* crlf conversion
* 0x1a treated EOF charactor on read
and others (see Bug #19192)... -
- We forgot about that one, it's quite useful to see which capacity
we started from. -
- The documentation on the mode parameter of File.open is incomplete, I would like to clarify IO's data mode actual behavior here.
document says
```
To specify whether data is to be treated as text or as binary data, either of the fol... -
- In response to Bug #18353, STDIN.internal_encoding are set and encoding is converted explcitly on Windows platform.
For example, ```[STDIN.external_encoding, STDIN.internal_encoding] # => [Encoding::Windows-31J, Encoding::UTF-8]``` if S... -
-
- Applied in changeset commit:git|11acb7f7bcf6e80e03cf83bba863b9b3f980fdca.
----------
[Bug #19167] Remove useless conversion of classes for special const -
-
-
- In order to preserve the values when TrueClass, FalseClass or NilClass
are stored in ivars -
- I agree that the new behavior is consistent and preferable, but I don't think it should be fixed on the stable branches.
If there are any troubles on the real world applications with this issue, please let me know. -
- ruby_3_1 a1124dc162810f86cb0bff58cde24064cfc561bc merged revision(s) 58cc3c9f387dcf8f820b43e043b540fa06248da3.
-
- [Bug #19187] Fix for tzdata-2022g
---
test/ruby/test_time_tz.rb | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-) -
08:50 AM Feature #19036: Provide a way to set path for File instances created with for_fd
- Eregon (Benoit Daloze) wrote in #note-7:
> > - Should we introduce `IO#path=`?
> ...
Agree. Also briefly brainstormed some possible security issues with being able to mutate the path after init. Don't want to go there and don't really ... - 07:59 AM Revision 7c438328 (git): Update default gems list at 01cf3ab3b8ee20ad6746373ae17a56 [ci skip]
-
- https://github.com/ruby/date/commit/b7a8229041
-
- Remove all shipped files and require path on JRuby until we can
add JRuby's extension to the gem.
Temporary workaround for #48
https://github.com/ruby/date/commit/94c3becef2 -
-
- 07:37 AM Revision c668eaff (git): Update default gems list at 93ac1503be10c43978fe7ee1fec95c [ci skip]
-
-
- Pick from https://github.com/ruby/syntax_suggest/commit/daee74dcb06296fa69fe8595fdff5d93d432b30d
-
-
-
- Pick from https://github.com/rubygems/rubygems/commit/823c776d951f3c35094611473ec77f94e8bf6610
-
-
-
-
-
-
-
- 66d1900423e6fb9774c2fe72dba8c2968b54d7ab
0686e4181d04dd911316a227753ceaa96d8c6533
1a63468831524f68e73cbb068071652c6486cfc6
e1fee7f949cb6719122672fa1081c60984a5339f
232e43fd52e53f667c2c290cffb4afa524889f0f -
-
-
-
-
- I'm gonna add another type of unit shortly.
-
- There's no MJIT worker thread anymore
-
-
- https://github.com/ruby/rdoc/commit/e1679fa7e4
-
- https://github.com/ruby/rdoc/commit/fe0159de2f
-
- https://github.com/ruby/rdoc/commit/0b9dde5ab4
-
- https://github.com/ruby/erb/commit/39414f32a5
- 05:58 AM Revision db09ddf8 (git): Update default gems list at d7baa17b49a681a7436718f6219fcb [ci skip]
-
- https://github.com/ruby/etc/commit/5cac138538
-
- 04:36 AM Revision 54a6bd2f (git): Update default gems list at 95b423f93a418abc010d7bc1baab48 [ci skip]
-
- https://github.com/ruby/irb/commit/d799c5c9da
-
02:26 AM Revision 6ea3edbd (git): Fix bad code example in documentation
12/08/2022
-
- The new version has an option to merge everything into a big
`extern "C"` block and it's nicer.
More importantly, this upgrade fixes an issue where Ubuntu with Clang 12
and macOS with Clang 14 gave a one line diff for `rb_shape_t`. It w... -
-
- 09:46 PM Revision c9076d54 (git): [ruby/irb] Add show_doc as an alias to the help command
- (https://github.com/ruby/irb/pull/475)
In the long-term, we want to align with `Pry`, `byebug` and `debug` to
use the `help` command to list all commands, which is what `show_cmds`
currently does. And `show_doc` will be the command to l... -
- Applied in changeset commit:git|bb8afd7265af41a75e8889774aa26f157f146380.
----------
Freeze singleton class, not its origin
Previously, when we froze an object, we froze
`RCLASS_ORIGIN(object.singleton_class)`, which didn't freeze
`obj... - 09:05 PM Revision 12b7c129 (git): [ruby/irb] Gracefully handle missing command argument
- (https://github.com/ruby/irb/pull/473)
* Handle file loading commands' argument error gracefully
Currently, if users don't provide an argument to `source`,
`irb_load`, and `irb_require`, IRB raises `ArgumentError` with full
stacktrace.... - 09:00 PM Revision 234c3a05 (git): Update default gems list at 8bbf4e5d8dccba3adf07fb56a38c06 [ci skip]
- 08:58 PM Revision 8bbf4e5d (git): [ruby/stringio] bump up to 3.0.5
- https://github.com/ruby/stringio/commit/e62b9d78d3
-
- Previously, when we froze an object, we froze
`RCLASS_ORIGIN(object.singleton_class)`, which didn't freeze
`object.singleton_class` when it has some prepended modules.
Origin iclass are internal objects and users can't interact with
the... -
- So it's shorter on CI and the hint about how the fix the failure shows
up. It's going to print a diff locally too, but that should be fine. -
- This makes it clear what to do when the CI check
fails and should remove a few minutes of confusion
for people seeing this for the first time. - 07:11 PM Revision a87f802f (git): [ruby/irb] Kill PTY process after test is finished
- (https://github.com/ruby/irb/pull/471)
The killing/waiting logic is borrowed from ruby/debug:
https://github.com/ruby/debug/blob/ec5ae5aebd61a99dc84028d8dffa8e7e165c1ec6/test/support/test_case.rb#L107-L136 - 07:10 PM Revision 3956bb85 (git): [ruby/irb] Add "show_cmds" command to list all commands'
- descriptions
(https://github.com/ruby/irb/pull/463)
https://github.com/ruby/irb/commit/7e857655ac -
- It looks like the current way of marking objects was breaking
eightbitraptor's upcoming VWA changes and this seems to fix it. -
- I see several arguments in doing so.
First they use a non trivial amount of memory, so for various memory
profiling/mapping tools it is relevant to have visibility of the space
occupied by shapes.
Then, some pathological code can creat... -
- 03:38 PM Revision 5738ae70 (git): [DOC] Update `rb_gc_mark_locations` doc
- The documentation says that the `end` pointer will be marked
but looking at the source, that is not the case. -
- I also agree the 0-kwargs case should be supported for general use like `data.with(**changes)`, whether `changes` is empty or not. And that reads fine of course.
It's also like `Hash#merge` with no arguments.
I think `#with` with empty... -
- ioquatix (Samuel Williams) wrote in #note-6:
> Implemented in https://github.com/ruby/ruby/pull/6867.
Thanks!
> ...
I think not, AFAIK there is no need for this to be mutable.
> - Should we introduce `IO#dup(..., path:)`?
De... -
- Implemented in https://github.com/ruby/ruby/pull/6867.
Follow up discussion:
- Should we introduce `IO#path=`?
- Should we introduce `IO#dup(..., path:)`?
-
-
- Unfortunately we have to use a mock, but this test demonstrate the
mutation bug fixed in #19.
It fails on 0.2.0 but passes on 0.1.3 or 0.2.1.
https://github.com/ruby/net-protocol/commit/40a1ab687c -
- I restored some of mojibake messages of Japanese lists that are `ruby-list` and `ruby-dev`.
-
- >I'll build the simple txt archives like https://blade.ruby-lang.org/ruby-core/xxxxxx.
> ...
done. You can access the above archive like https://blade.ruby-lang.org/ruby-core/1 , https://blade.ruby-lang.org/ruby-dev/1 ...
>I'll creat... -
- Essentially, this behavior is an "unofficial" feature for internal use only (not expected to be documented), so it has not been described in doc/extension.rdoc.
> Note: In the format string, "%"PRIsVALUE can be used for Object#to_s
... - 07:24 AM Revision 516fe627 (git): Update default gems list at 6f44dc8edf5b444a45ea9f0a375a26 [ci skip]
-
- https://github.com/ruby/net-protocol/commit/06d1420936
-
- This optimization is unsafe because `dest` is allowed to be a custom
object responding to `<<` (e.g. a block wrapped in `ReadAdapter`).
So the receiver can hold onto the passed buffer for as long as it wants.
If it was guaranteed that ... -
- https://github.com/rubygems/rubygems/commit/05cb5410cb
-
- because we no longer support it
-
- 05:19 AM Revision 6fd5d2dc (git): Introduce `IO.new(..., path:)` and promote `File#path` to `IO#path`. (#6867)
- 05:13 AM Revision b2764752 (git): Update default gems list at b9d055d7604ea41f54268076622c8a [ci skip]
- 05:12 AM Revision b9d055d7 (git): [ruby/stringio] bump up to 3.0.4
- https://github.com/ruby/stringio/commit/5ba853d6ff
-
- ruby_3_0 a0a99185577794b1915eba0dc5154f09cc95e81d merged revision(s) 58cc3c9f.
-
- ruby_2_7 36cadad6434bc31bc2d60697698cd5b930c097ce merged revision(s) 58cc3c9f.
- 03:33 AM Revision 36cadad6 (git): merge revision(s) 58cc3c9f: [Backport #19187]
- [Bug #19187] Fix for tzdata-2022g
---
test/ruby/test_time_tz.rb | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-) - 03:33 AM Revision d21f9853 (git): Bump teeny
-
03:31 AM Revision 7e121dc4 (git): [ruby/logger] Another performance improvement on the Formatter by
- using Kernel#sprintf over String#%
(https://github.com/ruby/logger/pull/75)
* Prefer Kernel#sprintf over String#% for formatting Strings - 03:31 AM Revision a0a99185 (git): merge revision(s) 58cc3c9f: [Backport #19187]
- [Bug #19187] Fix for tzdata-2022g
---
test/ruby/test_time_tz.rb | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-) - 03:30 AM Revision 9de654cb (git): Bump teeny
- 03:28 AM Revision 7ab4820a (git): [ruby/logger] Only assign to `@filename` if the path is valid.
- (https://github.com/ruby/logger/pull/81)
https://github.com/ruby/logger/commit/b41d7c699c -
- 03:21 AM Revision 701251c5 (git): [ruby/logger] Drop RDoc development dependency to avoid CI failures.
- (https://github.com/ruby/logger/pull/82)
https://github.com/ruby/logger/commit/8915627234 - 02:09 AM Revision 7cd0dacb (git): Update default gems list at 9fce6014b52852265c6b34a04a2057 [ci skip]
-
- https://github.com/ruby/psych/commit/bdf20e6042
- 01:09 AM Revision 645cd94d (git): Add debug counters to RubyVM.stat (#6086)
- * Add debug counters to RubyVM.stat
* Use SIZET2NUM
Co-author: Nobuyoshi Nakada <nobu@ruby-lang.org>
* Prefix debug_counter_names