Project

General

Profile

Activity

From 10/24/2022 to 10/30/2022

10/30/2022

11:09 PM Bug #19092 (Third Party's Issue): gem uninstall exit code when multiple gem are installed and no option is given on prompt
hsbt (Hiroshi SHIBATA)
10:39 PM Bug #19092: gem uninstall exit code when multiple gem are installed and no option is given on prompt
Hello! This seems a valid problem report, I tried locally and I can reproduce. Can you open your issue at rubygems issue tracker please? (https://github.com/rubygems/rubygems/issues/new?assignees=&labels=RubyGems&template=rubygems-relate... retro (Josef Šimánek)
09:17 PM Bug #19092 (Third Party's Issue): gem uninstall exit code when multiple gem are installed and no option is given on prompt
When there are several versions of a gem to uninstall and there is a prompt with all the installed versions and it is waiting for the number of the option to uninstall, if you press ENTER then it displays an error message like this
> ...
megatux (Cristian Molina)
11:09 PM Bug #19093 (Third Party's Issue): gem uninstall, when prompting for gem selection it does not handle CTRL+D
hsbt (Hiroshi SHIBATA)
10:41 PM Bug #19093: gem uninstall, when prompting for gem selection it does not handle CTRL+D
please follow https://bugs.ruby-lang.org/issues/19092#note-1 retro (Josef Šimánek)
09:35 PM Bug #19093 (Third Party's Issue): gem uninstall, when prompting for gem selection it does not handle CTRL+D
Scenario: calling `gem uninstall some_gem` and there is more than 1 version of that gem installed
A list of the n versions of the gem is displayed and a prompt is waiting for a number of the item to uninstall.
When using ctrl+d on the ...
megatux (Cristian Molina)
02:21 PM Revision 7ed10abd (git): [ruby/bigdecimal] Suppress macro redefinition warnings
`HAVE_` macros by autoconf are defined as 1.
https://github.com/ruby/bigdecimal/commit/cd35868aa6
nobu (Nobuyoshi Nakada)
01:25 PM Bug #19091 (Closed): backport reline-0.3.1 to ruby-3.1
I am ashamed to say, last year I committed a work-in-progress file instead of the correct one to ruby/reline tree.
There is a bug that breaks scrolling on windows (with terminals other than command prompt?).
That mistake was included i...
YO4 (Yoshinao Muramatsu)
11:35 AM Revision 37593c79 (git): Ignore failure at moving revision.h [ci skip]
The source directory may be read-only. nobu (Nobuyoshi Nakada)
10:16 AM Revision 0717cb84 (git): Try -fstack-protector-strong on MinGW
The CI for MinGW has used it. nobu (Nobuyoshi Nakada)
08:13 AM Revision 28214231 (git): Run spec_guards only when spec files changed [ci skip]
nobu (Nobuyoshi Nakada)
08:06 AM Revision 00d5b7ce (git): vcs.rb: copy safe directory configuration
Now revision.tmp will be regenerated always and every times, even if
the recent file exists in the source directory, as far as using git.
On the other hand, VirtualBox mounts shared folders as root, and git
rejects the repository there a...
nobu (Nobuyoshi Nakada)
08:06 AM Revision b64514f1 (git): vcs.rb: prettify debug print
nobu (Nobuyoshi Nakada)
07:04 AM Revision 1acbcf0e (git): Update bundled gems list at 2022-10-30
git[bot]

10/29/2022

07:47 PM Revision 91c28ab2 (git): [DOC] Enhanced RDOc for IO (#6642)
In io.c treats:
#close
#close_read
#close_write
#closed
burdettelamar (Burdette Lamar)
03:53 PM Revision 572cd10a (git): Fix links and sort [ci skip]
znz (Kazuhiro NISHIYAMA)
03:25 PM Feature #19083: Add `node_id_for_backtrace_location` to ast.c
I've update the function name from node_id_for_location to node_id_for_backtrace_location. Also I attached the patch here. eileencodes (Eileen Uchitelle)
01:47 PM Revision d5fb76a6 (git): [ruby/optparse] Add tests for `load(into:)`
https://github.com/ruby/optparse/commit/51f7e060ee nobu (Nobuyoshi Nakada)
01:46 PM Revision 37291df9 (git): [ruby/optparse] #load() into hash
(https://github.com/ruby/optparse/pull/42)
OptionParser#load learns .load(into: Hash)
https://github.com/ruby/optparse/commit/2ea626fcff
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
Whyme Lyu
01:40 PM Revision 4dac53f0 (git): [ruby/optparse] Add tests for `OptionParser#load`
https://github.com/ruby/optparse/commit/fb34a1d3a3 nobu (Nobuyoshi Nakada)
01:38 PM Feature #19090: Do not duplicate an unescaped string in CGI.escapeHTML
Isn't `rb_str_dup` copy-on-write and so should be fairly cheap? Eregon (Benoit Daloze)
07:40 AM Feature #19090 (Closed): Do not duplicate an unescaped string in CGI.escapeHTML
## Proposal
Stop guaranteeing that `GGI.escapeHTML` returns a new string even if there's nothing to be escaped.
More specifically, stop calling this `rb_str_dup` https://github.com/ruby/cgi/blob/v0.3.3/ext/cgi/escape/escape.c#L72 for...
k0kubun (Takashi Kokubun)
12:06 PM Revision bc28acc3 (git): [ruby/digest] Use CommonDigest by default if available
https://github.com/ruby/digest/commit/cce9ada85e nobu (Nobuyoshi Nakada)
07:17 AM Revision c5ca250e (git): Clear `_FORTIFY_SOURCE` before definition
As clang on macOS defines this macro as 0 internally when a sanitizer
option is given, clear it before definition to suppress redefinition
warnings.
nobu (Nobuyoshi Nakada)
01:55 AM Feature #19089 (Closed): Load bundler/setup in gem_prelude.rb when "bundle exec" is used
According to @k0kubun, some people actually use the hack to work around this problem by using `--disable-gems` or `--disable-error_highlight`.
However, this is arguably far from ideal. The option `--disable-gems` is not recommended fo...
mame (Yusuke Endoh)

10/28/2022

11:10 PM Revision 5e0432f5 (git): fix ASAN error in GC
tenderlovemaking (Aaron Patterson)
06:12 PM Feature #19089: Load bundler/setup in gem_prelude.rb when "bundle exec" is used
jeremyevans0 (Jeremy Evans) wrote in #note-6:
> vo.x (Vit Ondruch) wrote in #note-2:
> ...
Ah, right. I have not realized this. Thx for pointing this out.
Eregon (Benoit Daloze) wrote in #note-8:
I completely agree with your as...
vo.x (Vit Ondruch)
05:20 PM Feature #19089: Load bundler/setup in gem_prelude.rb when "bundle exec" is used
I believe this feature hurts startup time optimizations, so from that point of view it's not great.
For instance TruffleRuby loads `did_you_mean` ahead of time, during context pre-initialization.
Similarly, CRuby could for instance sto...
Eregon (Benoit Daloze)
04:36 PM Feature #19089: Load bundler/setup in gem_prelude.rb when "bundle exec" is used
Thank you all.
All I ask is that did_you_mean, etc. be loaded by default and that their versions be controllable by Gemfile. I don't have a strong preference on how to fix it.
Now I agree that modifying Ruby is overkill for this is...
mame (Yusuke Endoh)
02:50 PM Feature #19089: Load bundler/setup in gem_prelude.rb when "bundle exec" is used
vo.x (Vit Ondruch) wrote in #note-2:
> From that POV, it would be much better if it was possible to disable did_you_mean autoloading.
That's already possible via `--disable-did_you_mean`
> ...
I agree with this 100%.
Is this fi...
jeremyevans0 (Jeremy Evans)
11:40 AM Feature #19089: Load bundler/setup in gem_prelude.rb when "bundle exec" is used
@nobu pointed out that we can load `bundler/setup` in lib/rubygems.rb instead of gem_prelude.rb.
```ruby
diff --git a/lib/rubygems.rb b/lib/rubygems.rb
index 915a899f38..b61d21050d 100644
--- a/lib/rubygems.rb
+++ b/lib/rubygems.rb
@@ -...
mame (Yusuke Endoh)
11:30 AM Feature #19089: Load bundler/setup in gem_prelude.rb when "bundle exec" is used
@deivid Thank you for your reply!
deivid (David Rodríguez) wrote in #note-3:
> I'm not sure the proposed approach will work when Bundler is installed as a default gem though?
Oops, you are right. My current patch does not work wit...
mame (Yusuke Endoh)
09:46 AM Feature #19089: Load bundler/setup in gem_prelude.rb when "bundle exec" is used
@mame That's indeed a [long standing issue](https://github.com/rubygems/rubygems/blob/master/bundler/spec/runtime/setup_spec.rb#L1305-L1308) for us and I'm very happy if it can get fixed! I'm not sure the proposed approach will work when... deivid (David Rodríguez)
08:40 AM Feature #19089: Load bundler/setup in gem_prelude.rb when "bundle exec" is used
Let me provide you different perspective. did_you_mean is development dependency, which have no benefit for runtime, where there should be error free code. From that POV, it would be much better if it was possible to disable did_you_mean... vo.x (Vit Ondruch)
07:03 AM Feature #19089 (Closed): Load bundler/setup in gem_prelude.rb when "bundle exec" is used
### Problem
Currently, we cannot specify the version of did_you_mean by using Gemfile.
For example, Ruby master bundles with did_you_mean 1.6.1 by default:
```
$ ruby -e 'p DidYouMean::VERSION'
"1.6.1"
```
Consider that we...
mame (Yusuke Endoh)
03:53 PM Misc #19088: Complex() method with `exception: false` option still raises exception when String argument is in non-ASCII-compatible encoding
Got it. Thank you. andrykonchin (Andrew Konchin)
11:06 AM Misc #19088 (Closed): Complex() method with `exception: false` option still raises exception when String argument is in non-ASCII-compatible encoding
`exception:false` is effective only for the content.
ASCII incompatible encoding strings are not subjects of parsing.
nobu (Nobuyoshi Nakada)
10:35 AM Bug #19087: String#to_c supports multiple "_"
https://github.com/ruby/ruby/pull/6645 nobu (Nobuyoshi Nakada)
10:33 AM Revision 9b462aec (git): Follow up "Rework `first_lineno` to be `int`."
nobu (Nobuyoshi Nakada)
10:04 AM Revision 1de8a428 (git): sync_default_gems.rb: do not add extra empty lines [ci skip]
nobu (Nobuyoshi Nakada)
09:36 AM Revision 4021c656 (git): [ruby/irb] Do not make non-existent XDG directory on start
(https://github.com/ruby/irb/pull/357)
https://github.com/ruby/irb/commit/298b134792
nobu (Nobuyoshi Nakada)
09:30 AM Revision 56c97a66 (git): [ruby/irb] Update regarding NO_COLOR value
https://no-color.org has been updated (jcs/no_color#83):
> Command-line software which adds ANSI color to its output by default
should check for a `NO_COLOR` environment variable that, when present
and **not an empty string** (regardles...
nobu (Nobuyoshi Nakada)
08:29 AM Revision 13e968c1 (git): [ruby/irb] Suppress sequence to inspect asian ambiguous width
https://github.com/ruby/irb/commit/a7097c5b80 nobu (Nobuyoshi Nakada)
08:29 AM Revision 7440fc3e (git): [ruby/irb] Suppress "switching inspect mode" messages
https://github.com/ruby/irb/commit/565eeb3c19 nobu (Nobuyoshi Nakada)
04:58 AM Feature #18943 (Closed): New constant caching instruction: opt_getconstant_path
This was merged at https://github.com/ruby/ruby/pull/6187. k0kubun (Takashi Kokubun)
04:15 AM Revision e6e20223 (git): sync_default_gems.rb: append orignal commit URLs to subject only log
nobu (Nobuyoshi Nakada)
02:44 AM Bug #19037: [Ruby 3.1.2] irb display color character not correct(as literal form) when set IRB.conf[:USE_COLORIZE] = true (it is default)
zw963 (Wei Zheng) wrote in #note-4:
> mame (Yusuke Endoh) wrote in #note-2:
> ...
Any update?
zw963 (Wei Zheng)
01:06 AM Feature #19078: Introduce `Fiber#storage` for inheritable fiber-scoped variables.
> Often times, this is done to avoid holding a reference to the object in the thread, effectively making it immortal.
I think the correct way to make opaque per-instance keys is something like this:
```ruby
class ConnectionPool
...
ioquatix (Samuel Williams)

10/27/2022

10:52 PM Revision 9cf027f8 (git): YJIT: Use guard_known_class() for opt_aref on Arrays (#6643)
This code used to roll its own heap object check before we made a better
version in guard_known_class(). The improved version uses one fewer
comparison, so let's use that.
alanwu (Alan Wu)
08:50 PM Revision 2812a57b (git): Update docs wrt YJIT limitations and building YJIT (#6641)
* Update docs wrt YJIT limitations and building YJIT
* Update building_ruby.md
Fix relative link
maximecb (Maxime Chevalier-Boisvert)
07:32 PM Misc #19088 (Closed): Complex() method with `exception: false` option still raises exception when String argument is in non-ASCII-compatible encoding
I've noticed a minor inconsistency of the `Complex()` method. When it is called with `exception: false` option I suppose it shouldn't raise any exception.
For instance it doesn't raise error in the following cases:
```ruby
Complex...
andrykonchin (Andrew Konchin)
07:29 PM Revision ea597257 (git): [ruby/irb] Fix warnings in test_cmd.rb
Fixes this warning:
warning: assigned but unused variable - err
https://github.com/ruby/irb/commit/298fcb57a3
peterzhu2118 (Peter Zhu)
07:29 PM Revision b260c1e8 (git): [ruby/irb] Remove unnecessary test setup
Stan Lo
07:16 PM Revision bb7067cb (git): [ruby/irb] Suppress warning for test which uses a locale non-existing on GitHub Actions
Eregon (Benoit Daloze)
07:16 PM Revision 8d784423 (git): [ruby/irb] Remove unecesary and harmful pend for TruffleRuby in TestRaiseNoBacktraceException
* Specifically the second one causes `$HOME` to be unset, which breaks `File.expand_path('~')`.
https://github.com/ruby/irb/commit/61963305f5
Eregon (Benoit Daloze)
06:03 PM Bug #19086 (Closed): Dir#entries and Dir#glob fail in stand-alone CRuby app
jeremyevans0 (Jeremy Evans)
05:47 PM Bug #19086: Dir#entries and Dir#glob fail in stand-alone CRuby app
mame (Yusuke Endoh) wrote in #note-1:
> I guess you need to call `ruby_init` and `ruby_options` instead of `ruby_setup`. I think `Dir.glob` is defined in `ruby_options`.
=_=¡ I was hoping the solution wouldn't be that simple because it ...
kyonides (Edwin Acuña)
09:44 AM Bug #19086: Dir#entries and Dir#glob fail in stand-alone CRuby app
I guess you need to call `ruby_init` and `ruby_options` instead of `ruby_setup`. I think `Dir.glob` is defined in `ruby_options`. mame (Yusuke Endoh)
04:44 PM Bug #19087 (Closed): String#to_c supports multiple "_"
I've noticed a minor inconsistent behaviour of `String#to_c` method. It does not treat a sequence of `_` character as an end of meaningful characters:
```ruby
"123".to_c # => (123+0i)
"12_3".to_c # => (123+0i)
"12__3".to_c # => (12...
andrykonchin (Andrew Konchin)
04:13 PM Feature #19085 (Closed): Improve performance some Integer and Float methods
Applied in changeset commit:git|c6f439a6a8df582416e756d7511aa4d9c72071a9.
----------
Improve performance some `Integer` and `Float` methods [Feature #19085] (#6638)
* Improve some Integer and Float methods
* Using alias and Remove unn...
S_H_ (Shun Hiraoka)
04:13 PM Revision c6f439a6 (git): Improve performance some `Integer` and `Float` methods [Feature #19085] (#6638)
* Improve some Integer and Float methods
* Using alias and Remove unnecessary code
* Remove commentout code
S_H_ (Shun Hiraoka)
03:36 PM Revision 7cf7e6c3 (git): [ruby/irb] Add missing require
Stan Lo
03:25 PM Revision 26b913c8 (git): [ruby/irb] Add test for IRB::InputCompletor::PerfectMatchedProc
This proc displays rdoc document when the input matches certain symbols
perfectly, like "String". It's commonly triggered with autocompletion
but only has 1 test case. So this commit increases its test coverage.
https://github.com/ruby/...
st0012 (Stan Lo)
10:15 AM Feature #19078: Introduce `Fiber#storage` for inheritable fiber-scoped variables.
> I feel like this encourages bad practices because people are forced to convert objects to the hash.
Often times, this is done to avoid holding a reference to the object in the thread, effectively making it immortal.
If we take th...
byroot (Jean Boussier)
08:16 AM Revision 5129ca3e (git): [ruby/rdoc] Delay `require "readline"` in case the terminal is in raw mode
shugo (Shugo Maeda)
05:36 AM Revision 739ad81f (git): [ruby/date] Check month range as civil
nobu (Nobuyoshi Nakada)
03:12 AM Revision cb80ee7a (git): [ruby/tmpdir] Warnings should contain the environment variable name
nobu (Nobuyoshi Nakada)

10/26/2022

10:20 PM Revision 792dc553 (git): YJIT: Test --yjit-verify-ctx on GitHub Actions as well (#6639)
k0kubun (Takashi Kokubun)
08:52 PM Revision a8e2d736 (git): Fix the url of Cirrus failure notifications [ci skip]
The previous one was the url of this notification action, but we want to
see a link to Cirrus CI.
This code follows https://cirrus-ci.org/guide/notifications/.
Also, head_branch was null only for pull requests from a fork, so we can
us...
k0kubun (Takashi Kokubun)
08:49 PM Feature #19078: Introduce `Fiber#storage` for inheritable fiber-scoped variables.
> Do we need the same API on Thread?
> ...
This API does not intersect with any current Thread APIs, like `Thread[]` or `Thread[]=` or `Thread.current.storage`.
However, I'm not sure what you are expecting to be different. Are thes...
ioquatix (Samuel Williams)
08:47 PM Feature #19078: Introduce `Fiber#storage` for inheritable fiber-scoped variables.
> What keys can be used?
Does Ruby provide any "Hash" -> "Symbol Table" object or mapping/conversion? Otherwise we have to do it ourselves which is O(N) vs O(1) for hash dup (CoW) internally. So it will be worse performance to force all...
ioquatix (Samuel Williams)
10:21 AM Feature #19078: Introduce `Fiber#storage` for inheritable fiber-scoped variables.
I'm generally in favor of this feature. Lots of Ruby code rely on "global" state (generally implemented as fiber locals) so whenever you spawn a new fiber or thread you lose all that context which generally breaks code.
Things I think...
byroot (Jean Boussier)
07:27 PM Revision c746f380 (git): YJIT: Support nil and blockparamproxy as blockarg in send (#6492)
Co-authored-by: John Hawthorn <john@hawthorn.email>
Co-authored-by: John Hawthorn <john@hawthorn.email>
matthewd (Matthew Draper)
07:16 PM Bug #19086 (Closed): Dir#entries and Dir#glob fail in stand-alone CRuby app
Whenever I call Dir.entries or Dir.glob using an app compiled against Ruby 3.0 on Ubuntu 22.04, I expect to get a list of files or directories present there. This does not happen if you are calling it from a stand-alone app like the one ... kyonides (Edwin Acuña)
06:16 PM Feature #19000: Data: Add "Copy with changes method" [Follow-on to #16122 Data: simple immutable value object]
> it should be an error to supply a keyword argument that the Data class does not have as members
+1 Agree!
**Please note, performance work should be planned** to ensure that such checking of the keyword args is as fast as possible...
RubyBugs (A Nonymous)
03:29 PM Revision fa0adbad (git): YJIT: Invalidate i-cache for the other cb on next_page (#6631)
* YJIT: Invalidate i-cache for the other cb on next_page
* YJIT: Invalidate only what's written by jmp_ptr
* YJIT: Move the code to the arm64 backend
k0kubun (Takashi Kokubun)
03:15 PM Revision 0dc2e1a7 (git): [ruby/irb] Remove unnecessary warning check on help command
It's not an intentional behavior of the command and it behaves
differently in different environments. So checking it actually brings
more problem than benefit.
https://github.com/ruby/irb/commit/b3203bc784
Stan Lo
03:13 PM Revision 73a0223f (git): [ruby/irb] Rename test_helper.rb to helper.rb
The name test_helper.rb conflicts with the test_helper.rb in JSON,
causing build failures. This commit renames test_helper.rb to helper.rb.
https://github.com/ruby/irb/commit/b6a92bf6b3
Co-Authored-By: Stan Lo <stan001212@gmail.com>
peterzhu2118 (Peter Zhu)
02:44 PM Revision cb95d834 (git): [ruby/irb] Don't insert new methods to Test::Unit::TestCase
Ruby CI runs irb and other Ruby core/stdlib tests in the same process.
So adding irb-specific helper to Test::Unit::TestCase could potentially
pollute other components' tests and should be avoided.
st0012 (Stan Lo)
02:44 PM Revision 2022470a (git): [ruby/irb] Suppress warnings
Co-authored-by: Peter Zhu <peter@peterzhu.ca> st0012 (Stan Lo)
02:44 PM Revision d889e810 (git): [ruby/irb] Add test for the help command
st0012 (Stan Lo)
02:44 PM Revision 40f8a781 (git): [ruby/irb] Extract without_rdoc helper
st0012 (Stan Lo)
02:40 PM Revision b795e66a (git): Add NEWS entries about YJIT [ci skip] (#6636)
k0kubun (Takashi Kokubun)
01:04 PM Feature #19085 (Closed): Improve performance some Integer and Float methods
Improve performance some `Integer` and `Float` methods written by Ruby.
benchmark:
```yml
prelude: |
int_num = 42
flo_num = 4.2
benchmark:
integer_real: |
int_num.real
float_real: |
flo_num.real
integr_im...
S_H_ (Shun Hiraoka)
11:26 AM Bug #19081 (Closed): Ractor warning shows an internal location
Applied in changeset commit:git|131c31a9209c61f84d318aa18b61f468f48b8219.
----------
[Bug #19081] Show the caller location in warning for Ractor
The internal location in ractor.rb is not usefull at all.
```
$ ruby -e 'Ractor.new {}'
<i...
nobu (Nobuyoshi Nakada)
10:43 AM Revision 131c31a9 (git): [Bug #19081] Show the caller location in warning for Ractor
The internal location in ractor.rb is not usefull at all.
```
$ ruby -e 'Ractor.new {}'
<internal:ractor>:267: warning: Ractor is experimental, ...
```
nobu (Nobuyoshi Nakada)
09:57 AM Revision a14611cd (git): Fix -Wundef warnings
nobu (Nobuyoshi Nakada)
09:57 AM Revision 287eac5e (git): Fix format specifiers for `size_t`
nobu (Nobuyoshi Nakada)
06:02 AM Revision 94f3aa21 (git): Improve Cirrus notification metadata [ci skip]
k0kubun (Takashi Kokubun)
05:49 AM Revision df436110 (git): CI skip should not be notified [ci skip]
k0kubun (Takashi Kokubun)
05:26 AM Revision 11614548 (git): Add NEWS entries about MJIT [ci skip]
k0kubun (Takashi Kokubun)
04:50 AM Revision 923aed26 (git): Start notifying Cirrus CI failures
It looks like Cirrus doesn't natively support notifications and they
recomment to use GitHub Actions for it.
https://cirrus-ci.org/guide/notifications/
Because I don't know what the payload looks like, I just added a basic
payload and d...
k0kubun (Takashi Kokubun)
01:42 AM Revision 1670e96c (git): [win32] Only include base windows types
esent.h is the header for MS essential storage engine (JET) which is not
needed in ruby. basetsd.h has existed since _MSC_VER >= 1200 (VS 6.0)
and is the preferred header to use for WCHAR.
Josh Cooper
12:53 AM Revision 1dd9511b (git): Use ruby/action-slack@v3.0.0 and ref_name (#6633)
It's moved from k0kubun to ruby org.
Also, we don't need JavaScript eval to generate branch if we use
github.ref_name, so v3.0.0 is a version that doesn't use eval.
Co-Authored-By: Nobuyoshi Nakada <nobu@ruby-lang.org>
Co-authored-by:...
k0kubun (Takashi Kokubun)

10/25/2022

11:14 PM Revision a733633c (git): Update default gems list at d6d9b5130e5545e978fc9763e9419b [ci skip]
git[bot]
11:14 PM Revision d6d9b513 (git): [ruby/erb] Version 3.0.0
k0kubun (Takashi Kokubun)
09:19 PM Revision ea989127 (git): Bundler: update docs for gemfile(5) manpage
- Add mswin/mswin64 to platforms
- Use TruffleRuby as example instead of Rubinius
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Co-authored-by: André Arko <andre@arko.net>
Takuya Noguchi
09:00 PM Bug #19084 (Closed): Using `IO::Buffer` to change an extended String affects other Strings sharing the same buffer
When two extended Strings share a buffer, and one String's buffer changes, it currently affects the other String's buffer.
Here is a snippet to demonstrate this:
```
string = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa...
jemmai (Jemma Issroff)
08:50 PM Revision 48339d5c (git): [ruby/irb] Make sure Encoding's defaults are restored
Stan Lo
04:40 PM Revision 217fdbf9 (git): [ruby/erb] url_encode: use CGI.escapeURIComponent
(https://github.com/ruby/erb/pull/23)
Ref: https://github.com/ruby/cgi/pull/26
This native implementation is much faster
and available in `cgi 0.3.3`.
https://github.com/ruby/erb/commit/2d90e9b010
byroot (Jean Boussier)
04:07 PM Revision b7644a23 (git): YJIT: GC and recompile all code pages (#6406)
when it fails to allocate a new page.
Co-authored-by: Alan Wu <alansi.xingwu@shopify.com>
k0kubun (Takashi Kokubun)
01:38 PM Feature #19083 (Closed): Add `node_id_for_backtrace_location` to ast.c
Opening a ticket to get public comments on https://github.com/ruby/ruby/pull/6593. I worked on this with Aaron Patterson.
We want to use error highlight with eval'd code, specifically ERB templates. We're able to recover the generated...
eileencodes (Eileen Uchitelle)
10:38 AM Misc #19074: DevMeeting-2022-12-01 (postponed from 11-17)
* [Bug #19079] Modules included in a DelegateClass cannot override delegate methods (jonathanhefner)
* Proposed PR: https://github.com/ruby/delegate/pull/14#pullrequestreview-1154572034
* Define delegation methods in an included mo...
byroot (Jean Boussier)
08:02 AM Revision 1d2d25dc (git): Prevent potential buffer overrun in onigmo
A code pattern `p + enclen(enc, p, pend)` may lead to a buffer overrun
if incomplete bytes of a UTF-8 character is placed at the end of a
string. Because this pattern is used in several places in onigmo,
this change fixes the issue in th...
mame (Yusuke Endoh)
07:54 AM Revision 114e71d0 (git): [ruby/tmpdir] Ignore empty environment variables
Fixes https://github.com/ruby/tmpdir/pull/17
https://github.com/ruby/tmpdir/commit/a79c727a5d
nobu (Nobuyoshi Nakada)
07:16 AM Revision 883d9c30 (git): [ruby/tmpdir] Found or raise
nobu (Nobuyoshi Nakada)
06:59 AM Revision d55f72bc (git): [ruby/tmpdir] Update supported and testing ruby versions
nobu (Nobuyoshi Nakada)
06:59 AM Revision 287c5da4 (git): [ruby/tmpdir] Make `Dir.tmpdir` more idiomatic and functional
Use `Enumerable#find` to iterate over the candidates, not `Enumerable.each`.
(this makes the code more functional, and - IMO - slightly more idiomatic,
as it avoids setting the "global" (by which I mean: non-local) `tmp`
variable from i...
Peter Vandenberk
06:56 AM Revision ba15fb70 (git): [rubygems/rubygems] Bump rb-sys in /test/rubygems/test_gem_ext_cargo_builder/custom_name
Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.31 to 0.9.34.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.31...v0.9.34)
---
updated-depende...
dependabot[bot]
05:02 AM Revision cade3aba (git): [ruby/tmpdir] Fix typo
nobu (Nobuyoshi Nakada)
04:57 AM Revision 71a5b1d4 (git): [ruby/tmpdir] [DOC] Improve documentation
https://github.com/ruby/tmpdir/commit/b9c880f2b6 nobu (Nobuyoshi Nakada)
04:52 AM Revision d76284df (git): sync_default_gems.rb: Ignore unmergeable files [ci skip]
nobu (Nobuyoshi Nakada)
04:20 AM Revision 902e459b (git): Prevent buffer overrun in regparse.c
A regexp that ends with an escape following an incomplete UTF-8 char
might cause buffer overrun. Found by OSS-Fuzz.
```
$ valgrind ./miniruby -e 'Regexp.new("\\u2d73\\0\\0\\0\\0 \\\xE6".b)'
==296213== Memcheck, a memory error d...
mame (Yusuke Endoh)
02:56 AM Bug #18933: Dir.tmpdir implemented in non-Ractor-safe manner
In Ruby 3.0, an instance variable also is not accessible from non-main Ractor. nobu (Nobuyoshi Nakada)
02:21 AM Bug #19082: Recent gRPC gem fails to build from the source in already released versions
nobu (Nobuyoshi Nakada) wrote in #note-5:
> Probably this issue will be fixed by https://github.com/grpc/grpc/pull/31151.
Ah! Yes! Thanks for the explanation about what the dollar sign does. I just built the grpc gem locally with the...
monfresh (Moncef Belyamani)
02:00 AM Bug #19082: Recent gRPC gem fails to build from the source in already released versions
Probably this issue will be fixed by https://github.com/grpc/grpc/pull/31151. nobu (Nobuyoshi Nakada)
01:46 AM Bug #19082 (Third Party's Issue): Recent gRPC gem fails to build from the source in already released versions
It seems https://github.com/grpc/grpc/pull/28976. nobu (Nobuyoshi Nakada)
01:25 AM Bug #19082 (Feedback): Recent gRPC gem fails to build from the source in already released versions
By adding the dollar sign, `$flag=` just results in an error, and `-undefined dynamic_lookup` flag will be added to `DLDFLAGS`.
That means the undefined reference just hidden by that flag.
The real cause is not related to that commit a...
nobu (Nobuyoshi Nakada)
12:56 AM Bug #19082: Recent gRPC gem fails to build from the source in already released versions
`ruby_abi_version` has not been used in prior to 3.2, and there is no such string in 3.1 source in fact.
```
linking shared-object grpc/grpc_c.bundle
Undefined symbols for architecture arm64:
"_ruby_abi_version", referenced from:...
nobu (Nobuyoshi Nakada)

10/24/2022

11:47 PM Revision ee3da378 (git): Use CXX14 to allow constexpr with non-return statements
Co-authored-by: Daniel Colson <composerinteralia@github.com> Nick Hengeveld
11:33 PM Revision fcb1a498 (git): [rubygems/rubygems] Bump rb-sys
Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.31 to 0.9.34.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.31...v0.9.34)
---
updated-depende...
dependabot[bot]
11:09 PM Feature #19078: Introduce `Fiber#storage` for inheritable fiber-scoped variables.
(Sorry, I hit submit too soon)
Currently Rails applications have to be configured with a particular concurrency model, which they do via the "Isolated Execution State". You can see the code [here](https://github.com/rails/rails/blob/...
tenderlovemaking (Aaron Patterson)
11:07 PM Feature #19078: Introduce `Fiber#storage` for inheritable fiber-scoped variables.
I think this would be very helpful in Rails where we want to keep track of a "global" database connection. Right now the database connection is a thread local, but that doesn't work for webservers that use Fibers as a concurrency model.... tenderlovemaking (Aaron Patterson)
07:42 PM Feature #19000: Data: Add "Copy with changes method" [Follow-on to #16122 Data: simple immutable value object]
> ... Sequel uses `clone` instead of `dup` (for historical reasons and because it also needs to copy singleton classes).
I think copying singleton classes into such copies might NOT be desired behaviour for `Data` objects. So, it migh...
ufuk (Ufuk Kayserilioglu)
05:54 PM Revision b652dbf6 (git): Remove iv_index_tbl_entry
jhawthorn (John Hawthorn)
05:02 PM Revision abeef41c (git): [ruby/irb] Restore standard input/output encodings after input method tests
Stan Lo
04:50 PM Bug #19082 (Third Party's Issue): Recent gRPC gem fails to build from the source in already released versions
About 10 days ago, this commit in the ruby_3_1 branch removed the "$" from "[$flag=]" on line 3073 of `configure.ac`:
https://github.com/ruby/ruby/commit/ee6cc2502664ac46edc61868d8954b626bb48e53#r87450090
This causes the installati...
monfresh (Moncef Belyamani)
04:20 PM Revision 120b747b (git): YJIT: Lazily enable YJIT after prelude (#6597)
* YJIT: Lazily enable YJIT after prelude
* Update dependencies
* Use a bit field for opt->yjit
k0kubun (Takashi Kokubun)
03:38 PM Revision 841be639 (git): [DOC] Revert previous merge (#6624)
Revert previous merge burdettelamar (Burdette Lamar)
03:33 PM Feature #19075: Binary searching for the last element
I am thinking that maybe `reverse: true` can be a good **generic** option to then spread through other methods?
* `bsearch(reverse: true)` (binary search, reverse order)
* `sort(reverse: true)` (sort, reverse order)
* `find_index(re...
zverok (Victor Shepelev)
03:08 PM Feature #19075: Binary searching for the last element
nobu (Nobuyoshi Nakada) wrote in #note-1:
> An alternative could be to add an optional (keyword) argument to `bsearch` and `bsearch_index`.
That was also my first reaction on reading this proposal. A few other options:
```
bsearch(last...
Dan0042 (Daniel DeLorme)
02:47 PM Bug #19081 (Closed): Ractor warning shows an internal location
No one wants this `<internal:ractor>` location, I think.
```
$ ruby -e 'Ractor.new {}'
<internal:ractor>:267: warning: Ractor is experimental, ...
```
https://github.com/nobu/ruby/tree/ractor-warning-location
nobu (Nobuyoshi Nakada)
02:45 PM Revision 21fa0135 (git): Split tests for `Array#shuffle` and `Array#sample`
nobu (Nobuyoshi Nakada)
02:07 PM Revision f08dee67 (git): Bump up net-http 0.3.0
hsbt (Hiroshi SHIBATA)
01:56 PM Revision bcb72f50 (git): [DOC] Add note about method names (#6620)
burdettelamar (Burdette Lamar)
01:36 PM Revision 5a861552 (git): [ruby/irb] Add a test case to cover rdoc unintalled scenario
st0012 (Stan Lo)
01:36 PM Revision b7622d79 (git): [ruby/irb] Move require out of repeated execution path
SHOW_DOC_DIALOG will be called repeatedly whenever the corresponding key
is pressed, but we only need to require rdoc once. So ideally the
require can be put outside of the proc.
And because when rdoc is not available the entire proc wi...
st0012 (Stan Lo)
01:36 PM Revision d377cc45 (git): [ruby/irb] Add tests for RelineInputMethod
st0012 (Stan Lo)
01:18 PM Bug #19080 (Rejected): String Range inclusion using `===` broken
CLosing as not a bug given it's doing what it is designed to do.
If you feel like you can imporve the documentation, feel free to open a PR on GitHub, these are always welcome.
If you think there's another behavior that would be p...
byroot (Jean Boussier)
09:30 AM Bug #19080: String Range inclusion using `===` broken
`===` uses `#cover?`, as it should be.
See #14575 and #15449.
The documentation for `#===` says "if object is between `self.begin` and `self.end`," which means `>=` and `<=`, but I agree that it could be clearer (because one _might_ ...
zverok (Victor Shepelev)
05:42 AM Bug #19080: String Range inclusion using `===` broken
You need to zero-pad the strings in order to compare them correctly by the number they express. It is an advanced thing, and people without appropriate knowledge would/should not try doing it. sawa (Tsuyoshi Sawada)
05:08 AM Bug #19080: String Range inclusion using `===` broken
I've found this which illustrates that it uses `String#cover?` but that's really confusing for me at least:
https://stackoverflow.com/questions/67234283/why-is-the-string-3-not-matched-in-a-case-statement-with-the-range-0-10/67234587#67...
baweaver (Brandon Weaver)
05:00 AM Bug #19080 (Rejected): String Range inclusion using `===` broken
When using `===` implicitly for a pattern match I noticed a behavior which I believe is a bug in Ruby. `===` does not match with `include?` for ranges of `String` types, but also does so inconsistently:
```ruby
range = '0'..'255'
...
baweaver (Brandon Weaver)
12:03 PM Revision 8bce7c1a (git): merge revision(s) 399747926c323aca4f477ac3f8870b19229f4212:
Update bundled gems list at 2022-10-24
---
NEWS.md | 2 +-
gems/bundled_gems | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
nagachika (Tomoyuki Chikanaga)
11:59 AM Revision 7c2b7229 (git): merge revision(s) c506ddac6c88b14daf4a18bddf1c1e57be8d2225:
Added assert_true and assert_false same as test-unit gem
---
tool/lib/test/unit/assertions.rb | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
nagachika (Tomoyuki Chikanaga)
10:08 AM Misc #19074: DevMeeting-2022-12-01 (postponed from 11-17)
- [Feature #19078] Introduce `Fiber#storage` for inherited fiber-scoped variables.
- Updated based on feedback, is it acceptable?
ioquatix (Samuel Williams)
09:38 AM Revision 6cca8a0c (git): Strip trailing spaces [ci skip]
nobu (Nobuyoshi Nakada)
09:28 AM Revision c7a5ca99 (git): * remove trailing spaces. [ci skip]
git[bot]
09:27 AM Revision 39974792 (git): Update bundled gems list at 2022-10-24
git[bot]
09:21 AM Revision 67ed70da (git): Refactor timeout-setting code to a function
mame (Yusuke Endoh)
09:13 AM Revision ef01482f (git): Refactor timeout-related code in re.c a little
mame (Yusuke Endoh)
09:12 AM Revision 8873c420 (git): Fix error when commit hash is removed [ci skip]
nobu (Nobuyoshi Nakada)
09:03 AM Bug #19055 (Closed): Regexp.new(regexp, timeout: nil) is intrupted by Regexp.timeout
Applied in changeset commit:git|b51b22513f6a2a514a9e614e7a9f6e0df6c0c985.
----------
Fix per-instance Regexp timeout (#6621)
Fix per-instance Regexp timeout
This makes it follow what was decided in [Bug #19055]:
* `Regexp.new(str, ti...
mame (Yusuke Endoh)
09:03 AM Revision b51b2251 (git): Fix per-instance Regexp timeout (#6621)
Fix per-instance Regexp timeout
This makes it follow what was decided in [Bug #19055]:
* `Regexp.new(str, timeout: nil)` should respect the global timeout
* `Regexp.new(str, timeout: huge_val)` should use the maximum value that
can b...
mame (Yusuke Endoh)
08:48 AM Revision 6700fa7f (git): Set timestamp path for the target path to TARGET_SO_DIR_TIMESTAMP
nobu (Nobuyoshi Nakada)
08:47 AM Revision 711b2ed5 (git): Make the timestamp path correspond to the bundled target path
So different timestamps for different paths will be used. Extentions
paths in bundled gems contain `ruby_version`, which includes the ABI
version, and the same timestamp file for different paths resulted in
build failures when it changed.
nobu (Nobuyoshi Nakada)
08:42 AM Revision 3af37328 (git): Adjust indents [ci skip]
nobu (Nobuyoshi Nakada)
08:25 AM Revision 298221df (git): Reuse RBOOL macro in rb_ivar_defined function
S_H_ (Shun Hiraoka)
08:14 AM Feature #19015: Language extension by a heredoc
> Would it also remove leading indentation like <<~HEREDOC?
Sure.
ko1 (Koichi Sasada)
05:46 AM Revision 87f432b6 (git): Update default gems list at c5f5403f6ed9e62f2a1002417e61c9 [ci skip]
git[bot]
05:45 AM Revision c5f5403f (git): [ruby/net-http] Bump version to 0.3.0
hsbt (Hiroshi SHIBATA)
12:32 AM Revision 174ddc79 (git): Skip `File.atime`/`File.mtime` tests randomly failing on Travis
Not only powerpc64le, also s390x and arm32 seem failing too. These
failures are probably caused by filesystem settings on Travis, but
unrelated to CPUs.
nobu (Nobuyoshi Nakada)
 

Also available in: Atom