Activity
From 08/24/2022 to 08/30/2022
08/30/2022
-
09:41 PM Bug #18985 (Assigned): SEGV with YJIT on aarch64-linux
- It's AWS `c6g` instance with Ubuntu 20.04.5.
```
Linux rubyci-ubuntu2004-arm 5.13.0-1022-aws #24~20.04.1-Ubuntu SMP Thu Apr 7 22:14:11 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux
```
And I build ruby with `ruby-build`. It's simply... -
03:56 PM Bug #18985: SEGV with YJIT on aarch64-linux
- Hello @hsbt.
Can you provide more details as to which version of Linux and which CPU you are running? Are you running this on a Raspberry Pi, or is this on an AWS Graviton instance?
It might also be useful for us if you can try an ... -
- When we use `-e` option with YJIT, It's always crush on aarch64-linux.
```
$ ruby --jit -e "puts :foo"
/home/chkbuild/.rbenv/versions/3.2.0-dev/lib/ruby/3.2.0+2/aarch64-linux/rbconfig.rb:305: [BUG] Segmentation fault at 0x00000e80f9... - 09:22 PM Revision f4cdfff0 (git): * 2022-08-31 [ci skip]
- 09:21 PM Revision 4a4daf00 (git): Update .cirrus.yml
-
09:21 PM Revision 5dbc725f (git): Skip linking rb_yjit_icache_invalidate on cargo test
- Co-authored-by: Kevin Newton <kddnewton@gmail.com>
-
-
-
07:51 PM Feature #18986 (Open): Raises Exception for Range#last(n) with Float::INFINITY
- When a (Numeric) argument is given to `Range#last(n)` for a Range with `Float::INFINITY`, it runs into an infinite loop (see a small code snippet below).
There is no use case for the feature as far as I can think of, and it is hard to d... -
02:16 PM Feature #18980: `it` as a default block parameter
- > One thing that this "design space analysis" keeps ignoring, ...
It doesn't (though I by no means consider it exhaustive or definitive, it is just "what I am thinking about when considering options"):
> ...
It doesn't mention `@` ... -
01:38 PM Feature #18980: `it` as a default block parameter
- zverok (Victor Shepelev) wrote in #note-26:
> My "design space analysis" was sourced by the same idea. I can say that I would NOT choose `it` (or any other name looking "regularly"), unless it would be a keyword (like `self`), having ... -
- > if you were able to design Ruby from the ground up, would you still use a syntax that you think is a name compromise and looks weird for newcomers?
My "design space analysis" was sourced by the same idea. I can say that I would NOT ... -
- > Say, I considered `yield_self` so wrong naming choice I spent the good part of that year fighting for its renaming, but at the same time I started to use it (and it DID make code better, as my colleagues agreed, you just needed to get ...
-
- > It's interesting that "Numbered parameters (_1, _2, ...) look like unused local variables" doesn't seem to resonate with you.
It did initially, but let's say I got over it. There were several factors in play:
1. I am very concern... -
10:45 AM Feature #18784: `FileUtils.rm_f` and `FileUtils.rm_rf` should not mask exceptions
- I just removed the line pointed out by @Eregon, so I guess all the workarounds added around the `FileUtils.rm_rf` in RubyGems teardown method can now be removed too!
-
- @mame I agree with your analysis, but I have to say from experience that realworld bugs hidden by this behavior are pretty hard to fix too. The warning in verbose mode sounds great, but perhaps we could also mention this in documentation...
-
07:37 AM Feature #18784: `FileUtils.rm_f` and `FileUtils.rm_rf` should not mask exceptions
- Here is a patch. Revert fa65d676ece93a1380b9e6564efa4b4566c7a44b and apply:
```diff
diff --git a/lib/fileutils.rb b/lib/fileutils.rb
index 4ba7d18..178db6e 100644
--- a/lib/fileutils.rb
+++ b/lib/fileutils.rb
@@ -1422,6 +1422,7 @... -
- We're not fully in control of this folder, even when running our own
tests, because MJIT creates some temp folders there when invoking GC.
This bite tests running in ruby-core when making the behavior of
`FileUtils.rm_rf` more strict, b... -
08:36 AM Feature #18982: Add an `exception: false` argument for Queue#push, Queue#pop, SizedQueue#push and SizedQueue#pop
- I don't think people want to exit from a `while item = queue.pop` loop because the queue would block. `for (;;) { if (errno != EAGAIN) break; ... }` is a C idiom (people often break from a loop on error, _except_ EAGAIN).
-
12:42 AM Feature #18982: Add an `exception: false` argument for Queue#push, Queue#pop, SizedQueue#push and SizedQueue#pop
- shyouhei (Shyouhei Urabe) wrote in #note-4:
> +1 for avoiding exceptions but `nil` can be problematic? Because a closed queue would also return `nil` for `pop`. You cannot distinguish if a queue is closed or would just block.
We co... -
12:15 AM Feature #18982: Add an `exception: false` argument for Queue#push, Queue#pop, SizedQueue#push and SizedQueue#pop
- > but nil can be problematic?
This was discussed in #18774:
- `#pop` on closed queue already returns `nil` with no exception. `Queue.new.tap(&:close).pop # => nil`
- `nil` make sense because you can use it in a loop such as `... -
- +1 for avoiding exceptions but `nil` can be problematic? Because a closed queue would also return `nil` for `pop`. You cannot distinguish if a queue is closed or would just block.
-
02:23 AM Revision d6acaa4d (git): Undefine `ruby_debug_log` macro before the function definition
- Fix up 27173e3735ff.
-
01:13 AM Bug #18970: CRuby adds an invalid header to bin/bundle (and others) which makes it unusable in Bash on Windows
- @nobu
Sorry the above are what I thought would work best with the ruby-loco builds. All three builds (mingw, mswin, & ucrt) are now done that way. Interesting thing that I found is that MSYS2's `which` command considers a file to ex... -
- * Check only symbol flag bits
* Check all 4 bits
08/29/2022
-
- > Unused local variables are more like `_[a-z]\w+`, the number makes the variable "anonymous" so it can't be an unused local variable
> ...
It's interesting that "Numbered parameters (`_1`, `_2`, ...) look like unused local variables" d... -
- > I forgot, is _ problematic in practice?
`_` is very widespread name to "I don't need that". TBH, till 5 min ago I thought it is processed specially in the case of parameter repetition:
```ruby
[[1, 2, 3], [4, 5, 6]].map { |i, _,... -
11:03 AM Feature #18980: `it` as a default block parameter
- The logical sigil for a single arguments would be `_` of course (given we have `_1`, `_2`, etc).
I forgot, is `_` problematic in practice?
The usage of it in irb/pry should not be an issue given the variable is explicitly declared th... -
- My 5c: I came to (almost) peace with `_1`, and we use it extensively in the codebase, and find it quite convenient.
Choosing the designation for it is a hard choice, and after years of consideration, I believe that the current solutio... -
- I don't come up with a way to fix it right away. We'd need some
experiments on a pull request. -
-
-
04:09 PM Revision d694f320 (git): Fixed width immediates (https://github.com/Shopify/ruby/pull/437)
- There are a lot of times when encoding AArch64 instructions that we
need to represent an integer value with a custom fixed width. For
example, the offset for a B instruction is 26 bits, so we store an
i32 on the instruction struct and th... -
04:09 PM Revision 46007b88 (git): A64: Only clear icache when writing out new code (https://github.com/Shopify/ruby/pull/442)
- Previously we cleared the cache for all the code in the system when we
flip memory protection, which was prohibitively expensive since the
operation is not constant time. Instead, only clear the cache for the
memory region of newly writt... -
-
-
-
-
- for now
-
- * Respect RUBY_TESTOPTS on test-all
* Increase the Cirrus timeout
* Increase the CSV test timeout - 04:09 PM Revision 5ef048e5 (git): Update yjit.md
- Add VMIL paper, update supported CPUs.
-
- * Add --yjit-dump-disasm to dump every compiled code
* Just use get_option
* Carve out disasm_from_addr
* Avoid push_str with format!
* Share the logic through asm.compile
* This seems to negatively impact the compilation speed -
- * When we're storing an immediate 0 value at a memory address, we
can use STUR XZR, Xd instead of loading 0 into a register and
then storing that register.
* When we're moving 0 into an argument register, we can use
MOV Xd, XZR ins... -
-
04:09 PM Revision 93c5a5f0 (git): Fix and re-enable String to_s, << and unary plus (https://github.com/Shopify/ruby/pull/429)
-
-
-
-
- * Remove references to explicit instruction parts
Previously we would reference individual instruction fields
manually. We can't do that with instructions that are enums, so
this commit removes those references. As a side effect, we can... -
- This should fix a version string test
-
- * Operand iterators
There are a couple of times when we're dealing with instructions
that we need to iterate through their operands. At the moment this
is relatively easy because there's an opnds field and we can work
with it directly. ... -
- Yet another case of `jit_mov_gc_ptr()` being yanked out during the
transition to the new backend, causing a crash after object movement.
The intresting wrinkle with this one is that not all callinfos are GC'ed
objects, so the old code ha... -
-
- Co-authored-by: Alan Wu <alansi.xingwu@shopify.com>
-
- * Fix a bus error on regenerate_branch
* Fix pad_size -
- * Mutate in place for register allocation
Currently we allocate a new instruction every time when we're
doing register allocation by first splitting up the instruction
into its component parts, mapping the operands and the output, and
t... -
- * Only check lowest bit for _Bool type
The `test AL, AL` got lost during porting and we were
generating `test RAX, RAX` instead. The upper bits of a `_Bool` return
type is unspecified and we were failing
`TestClass#test_singleton_class_... -
- When we're pushing instructions onto the assembler, we previously
would iterate through the instruction's operands and then assign
the output operand to it through the push_insn function. This is
easy when all instructions have a vector ... -
- Currently we use macros to define the shape of each of the
instruction building methods. This works while all of the
instructions share the same fields, but is really hard to get
working when they're an enum with different shapes. This i... - 03:47 PM Revision 1cf9f56c (git): Fix issue with expandarray, add missing jl, enable tests (https://github.com/Shopify/ruby/pull/409)
-
- 03:47 PM Revision 95dce1cc (git): Temporarily disable rb_str_concat, add CI tests (https://github.com/Shopify/ruby/pull/407)
- Make sure we can load the test-all runner and run test_yjit.rb
- 03:47 PM Revision 09c12111 (git): Port jit_rb_str_concat to new backend, re-enable cfunc lookup (https://github.com/Shopify/ruby/pull/402)
-
03:47 PM Revision 5a76a15a (git): YJIT: Implement concatarray in yjit (https://github.com/Shopify/ruby/pull/405)
- * Create code generation func
* Make rb_vm_concat_array available to use in Rust
* Map opcode to code gen func
* Implement code gen for concatarray
* Add test for concatarray
* Use new asm backend
* Add comment to C func wrapper -
- We have a large extern block in cruby.rs leftover from the port. We can
use bindgen for it now and reserve the manual declaration for just a
handful of vm_insnhelper.c functions.
Fixup a few minor discrepencies bindgen found between the... -
-
-
-
03:47 PM Revision cb15886e (git): Port opt_getinlinecache to the new backend (https://github.com/Shopify/ruby/pull/399)
-
-
-
-
- `YJIT.simulate_oom!` used to leave one byte of space in the code block,
so our test didn't expose a problem with asserting that the write
position is in bounds in `CodeBlock::set_pos`. We do the following when
patching code:
1. save cu... -
- * Port opt_aref and opt_aset to the new backend IR
* Recompute memory operands - 03:47 PM Revision b54643d1 (git): Handle out of memory tests (https://github.com/Shopify/ruby/pull/393)
-
-
-
-
-
- This port does *not* create invalidation regions to
ensure minimum invalidatable block sizes, and so it
does not port the to_s generator. - 03:47 PM Revision cad35fb2 (git): Try to run make -j in CI backend tests (https://github.com/Shopify/ruby/pull/386)
-
- * Prefer asm.store over asm.mov
* Reverse a couple of unsure changes
* Revert changes that don't work -
- * Iterator
* Use the new iterator for the X86 backend split
* Use iterator for reg alloc, remove forward pass
* Fix up iterator usage on AArch64
* Update yjit/src/backend/ir.rs
Co-authored-by: Maxime Chevalier-Boisvert <maximecheval... -
- * Port expandarray to the new backend IR
* More use of into()
* Break out live ranges
* Refactor the code further
* Reuse registers more -
- * Port gen_send_iseq to the new backend IR
* Replace occurrences of 8 by SIZEOF_VALUE
Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com> -
-
-
- * LDR instruction for AArch64
* Split loads in arm64_split when memory address displacements do not fit -
-
- * Update flags for data processing on ARM
* Update yjit/src/backend/arm64/mod.rs
Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com> -
- Previously, we patched in an x64 JMP even on A64, which resulted in
invalid machine code. Use the new assembler to generate a jump instead.
Add an assert to make sure patches don't step on each other since it's
less clear cut on A64, wh... -
- * Port invokebuiltin* insns to the new backend IR
* Fix the C_ARG_OPNDS check boundary - 03:47 PM Revision 46822ee1 (git): Enable btests now passing on arm (https://github.com/Shopify/ruby/pull/378)
-
- * Left and right shift for IR
* Update yjit/src/backend/x86_64/mod.rs
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com> -
-
-
- * Port opt_eq and opt_neq to the new backend
* Just use into() outside
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
* Use C_RET_OPND to share the register
* Revert "Use C_RET_OPND to share the register"
This reverts commi... -
-
-
-
-
- * Port setivar to the new backend IR
* Add a few more setivar test cases
* Prefer const_ptr
Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com> -
- * Port opt_minus, opt_or, and opt_and to the new IR
* Fix the Op::Or issue with push_insn
* Prefer asm.store for clarity -
-
-
-
- 03:47 PM Revision b024b18f (git): Fix block invalidation with new backend. Enable more btests on x86 (https://github.com/Shopify/ruby/pull/359)
-
-
- * Fix asm.load(VALUE)
- `<VALUE as impl Into<Opnd>>` didn't track that the value is a value
- `Iterator::map` doesn't evaluate the closure you give it until you
call `collect`. Use a for loop instead so we put the gc offsets
into th... -
- * Port gen_send_cfunc to the new backend
* Remove an obsoleted test
* Add more cfunc tests
* Use csel_e instead and more into()
Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
* Add a missing lea for build_kwa... -
-
03:47 PM Revision 24ddc07d (git): Fix live_ranges idx calculation (https://github.com/Shopify/ruby/pull/353)
- forward_pass adjusts the indexes of our opnds to reflect the new
instructions as they are generated in the forward pass. However, we were
using the old live_ranges array, for which the new indexes are
incorrect.
This caused us to previo... -
- * Convert getinstancevariable to new backend IR
* Support mem-based mem
* Use more into()
* Add tests for getivar
* Just load obj_opnd to a register
* Apply another into()
* Flip the nil-out condition
* Fix duplicated counts of si... -
-
-
-
-
-
- * Port gen_concatstring to new backend IR
* Update yjit/src/codegen.rs
Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com> -
- * Port anytostring, intern, and toregexp
* Port getspecial to the new backend (#349)
PR: https://github.com/Shopify/ruby/pull/349 -
-
-
-
-
- * Move allocation into Assembler::pos_marker
We wanted to do this to begin with but didn't because we were confused
about the lifetime parameter. It's actually talking about the lifetime
of the references that the closure captures. Sinc... -
-
-
- * A64: Fix off by one in offset encoding for BL
It's relative to the address of the instruction not the end of it.
* A64: Fix off by one when encoding B
It's relative to the start of the instruction not the end.
* A64: Add some tests... -
-
-
- The order of operands to LDADDAL were flipped and the destination
pointer was dereferenced instead of passed as an address. -
-
- It allows for reserving a specific register and prevents the register
allocator from clobbering it. Without this
`./miniruby --yjit-stats --yjit-callthreshold=1 -e0` was crashing because
the counter incrementing code was clobbering RAX i... -
-
- * Fix conditional jumps to label
* Bitmask immediates cannot be u64::MAX -
- * Better splitting for Op::Add, Op::Sub, and Op::Cmp
* Split stores if the displacement is too large
* Use a shifted immediate argument
* Split all places where shifted immediates are used
* Add more tests to the cirrus workflow -
-
-
-
- * Port duparray opcode
* Port and test splatarray -
-
-
- * Fix bitmask encoding to u32
* Fix splitting for Op::And to account for bitmask immediate - 03:47 PM Revision e9a2effd (git): Enable more btests in the CI workflows (https://github.com/Shopify/ruby/pull/334)
- * Enable more btests in the CI workflows
* Update workflows -
-
-
-
-
-
- 03:47 PM Revision f833d75b (git): Refactor YJIT branches to use PosMarker (https://github.com/Shopify/ruby/pull/333)
- * Refactor defer_compilation to use PosMarker
* Port gen_direct_jump() to use PosMarker
* Port gen_branch, branchunless
* Port over gen_jump()
* Port over branchif and branchnil
* Fix use od record_boundary_patch_point in jump_to_ne... -
-
- * get_dupn was allocating and throwing away an Assembler object instead of using the one passed in
* Uncomment remaining tests in codegen.rs, which seem to work now - 03:47 PM Revision 90137f51 (git): Implement PosMarker instruction (https://github.com/Shopify/ruby/pull/328)
- * Implement PosMarker instruction
* Implement PosMarker in the arm backend
* Make bindgen run only for clang image
* Fix if-else in cirrus CI file
* Add missing semicolon
* Try removing trailing semicolon
* Try to fix shell/YAML sy... -
- * Move to/from SP on AArch64
* Consolidate loads and stores
* Implement LDR post-index and LDR pre-index for AArch64
* Implement STR post-index and STR pre-index for AArch64
* Module entrypoints for LDR pre/post -index and STR pre/po... -
-
-
-
-
-
-
-
- * CSEL on AArch64
* Implement various Op::CSel* instructions -
- * Port print_int to the new backend
* Tests for print_int and print_str -
-
-
-
-
-
- * ADR and ADRP for AArch64
* Implement Op::Jbe on X86
* Lera instruction
* Op::BakeString
* LeaPC -> LeaLabel
* Port print_str to the new backend
* Port print_value to the new backend
* Port print_ptr to the new backend
* Write n... -
-
- 03:47 PM Revision 5e834195 (git): Exclude X0 (C_RET_REG) from allocatable registers on arm (https://github.com/Shopify/ruby/pull/319)
- * Exclude X0 (C_RET_REG) from allocatable registers on arm
* Add another small test snippett -
- Instructions for pushing all caller-save registers and the flags so that
we can implement dump_insns. -
-
- 03:47 PM Revision 8d743e96 (git): Fix compile errors on arm on the CI (https://github.com/Shopify/ruby/pull/313)
- * Fix compile errors on arm on the CI
* Fix typo -
-
-
- 03:46 PM Revision 38c2fb8a (git): Port YJIT New Backend Temp Checks to Cirrus (https://github.com/Shopify/ruby/pull/312)
- Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
-
- Previously we were using a `Box<dyn FnOnce>` to support patching the
code when jumping to labels. We needed to do this because some of the
closures that were being used to patch needed to capture local variables
(on both X86 and ARM it w... -
- * Jumps for A64 should be in # of instructions
* More splitting for Arm64
https://github.com/Shopify/ruby/pull/309 -
- * More Arm64 lowering/backend work
* We now have encoding support for the LDR instruction for loading a PC-relative memory location
* You can now call add/adds/sub/subs with signed immediates, which switches appropriately based on sign
... -
-
-
-
-
-
- * Get initial wiring up
* Split IncrCounter instruction
* Breakpoints in Arm64
* Support for ORR
* MOV instruction encodings
* Implement JmpOpnd and CRet
* Add ORN
* Add MVN
* PUSH, POP, CCALL for Arm64
* Some formatting and imp... -
- * LSL and LSR
* B.cond
* Move A64 files around to make more sense
* offset -> byte_offset for bcond -
- The output from `dbg!` was too verbose. For `test_jo` the output went
from 37 lines to 5 lines. The added index helps parsing InsnOut
indicies.
Samples:
```
test backend::tests::test_jo ... [src/backend/ir.rs:589] &self = Assembler
... -
-
-
-
-
-
-
-
-
-
-
-
-
- * Add TST instruction and AND/ANDS entrypoints for immediates
* TST/AND/ANDS for registers
* CMP instruction -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- * LDADDAL instruction
* STUR
* BL instruction
* Remove num_bits from imm and uimm
* Tests for imm_fits_bits and uimm_fits_bits
* Reorder arguments to LDADDAL -
- * MOVK instruction
* More tests for the A64 entrypoints
* Finish testing entrypoints
* MOVZ
* BR instruction -
- * Remove x86-64 dependency from codegen.rs
* Port over putnil and putobject
* Port over gen_leave()
* Complete port of gen_leave()
* Fix bug in x86 instruction splitting -
-
-
-
- * LDUR
* Fix up immediate masking
* Consume operands directly
* Consistency and cleanup
* More consistency and entrypoints
* Cleaner syntax for masks
* Cleaner shifting for encodings -
-
-
-
-
-
-
- * Initial setup for aarch64
* ADDS and SUBS
* ADD and SUB for immediates
* Revert moved code
* Documentation
* Rename Arm64* to A64*
* Comments on shift types
* Share sig_imm_size and unsig_imm_size -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- 03:45 PM Revision 18dc379a (git): * 2022-08-30 [ci skip]
-
- * Split instructions if necessary
* Add a reusable transform_insns function
* Split out comments labels from transform_insns
* Refactor alloc_regs to use transform_insns -
- PR: https://github.com/Shopify/ruby/pull/289
-
-
-
-
-
-
-
-
- > I'm not sure mjit_worker.c changes are correct.
Looks good to me. -
- Ruby 3.1 has passed all the tests with `make check`. Ruby 2.7 and Ruby 3.0 failed some tests like Socket. But these are not related to these changes.
-
- https://github.com/ruby/ruby/pull/6193 is needed by macOS 13.0(Ventura).
I created the following patches.
* for Ruby 2.7: https://github.com/ruby/ruby/pull/6297
* for Ruby 3.0: https://github.com/ruby/ruby/pull/6298
* for Ruby 3.... -
- Please do not assign ruby-core, that sends too many emails.
-
- When `Range` consists of any Numeric, according to [Official docs for Ruby-3.1.2](https://ruby-doc.org/core-3.1.2/Range.html#method-i-size), `Range#size` should,
> Returns the count of elements in self if both begin and end values ar... -
02:17 PM Feature #18959: Handle gracefully nil kwargs eg. **nil
- LevLukomskyi (Lev Lukomskyi) wrote in #note-25:
> > You need to fail when someone passes you garbage (and `nil` is a garbage value in this case), or you need to ensure better default values (e.g., `{}`) at your call sites.
> ...
You do... -
12:40 AM Feature #18959: Handle gracefully nil kwargs eg. **nil
- > You need to fail when someone passes you garbage (and `nil` is a garbage value in this case), or you need to ensure better default values (e.g., `{}`) at your call sites.
When you pass `nil` you make less allocations, also you don't... -
02:11 PM Feature #18951: Object#with to set and restore attributes around a block
- I really like Rails’ `with_options`:
```ruby
class Account < ActiveRecord::Base
with_options dependent: :destroy do |assoc|
assoc.has_many :customers
assoc.has_many :products
assoc.has_many :invoices
assoc.has_many :ex... -
- I feel like in the do/end form it's quite clear:
```ruby
obj.with(foo: "bar") do
# do something
end
```
Just like `5.times do` doesn't need to be named `exec_times` to be clear. -
- I'll add my 2 cents as well: I really really like the proposed idea and I would love to see it added to Ruby for 3.2.
However, I find `with` a little too generic as a name for the concept. Primarily, when I look at it, it doesn't tell... -
- `Range#size` should, according to [Official docs](https://ruby-doc.org/core-3.1.2/Range.html#method-i-size),
> Returns the count of elements in self if both begin and end values are numeric; otherwise, returns nil
but it doesn't wi... -
-
- * To ensure these issues are noticed early.
-
- - [Feature #18982] Add an `exception: false` argument for Queue#push, Queue#pop, SizedQueue#push and SizedQueue#pop (byroot)
- The existing exceptions (ThreadError) are a bit awkward to deal with.
- Queue is often used deep into th... -
- I'd suggest having the warning for $VERBOSE=false too (and so no warning for $VERBOSE=nil).
When such an error happens it means something is going wrong, and I'd imagine it's a lot more helpful for anyone using `rm_rf` and getting a bug... -
- Thanks @mame, a warning in `$VERBOSE` mode is definitely better than nothing :)
Thanks @eregon! I originally introduced that because one maintainer was getting test failures on her system otherwise, and because I thought we completely... -
- Those temporary directories should be separate, but I guess the issue is this line which means other things might get stored in that test temp dir:
https://github.com/ruby/ruby/blob/7bdb999d0f28c7bb9d7a35ca775e405674527e5f/test/rubygems... -
- I have talked with @matz about this issue. He said let's revert this change. Instead, it will print a warning whenever it fails to delete a file (only when `$VERBOSE = true`). I will create a patch.
-
- mame (Yusuke Endoh) wrote in #note-14:
> deivid (David Rodríguez) wrote in #note-13:
> ...
I think I have identified the mechanism. In short, my guess was correct.
* rubygems attempts to delete TMPDIR by `FileUtils.rm_rf`.
* `FileU... -
- This reverts commit 7bdb999d0f28c7bb9d7a35ca775e405674527e5f.
I think I confirmed the mechanism. GCC (invoked by MJIT) creates a
temporary file in TMPDIR, which prevents rm_rf from removing the
directory. -
- Sounds good :+1:
-
- Proposed patch: https://github.com/ruby/ruby/pull/6299
-
- This replaces [Feature #18965]
Currently these methods raise in three occasions:
- `ThreadError(queue empty)` for `#pop` in `nonblock=true` mode, and the operation would block.
- `ThreadError(queue full)` for `SizedQueue#push`... -
- Closing in favor of [Feature #18982], which propose `exception: false`.
-
05:42 AM Revision 78748a5d (git): Introduce `usage_analysis_clear`
-
- I guess it has a shared library file created by MJIT, but I want to make
sure the fact. -
08/28/2022
-
09:57 PM Revision 055fc7b1 (git): Fix comment in timev.rb
-
09:49 PM Revision aecc3b12 (git): [DOC] Enhanced RDoc for Time (#6294)
-
- baweaver (Brandon Weaver) wrote in #note-17:
> I do not see a distinct enough difference to justify `@1`, and would reiterate previous arguments that even if it is technically illegal syntax it will still be confused for instance variab... -
- > @1 syntax
In case it wasn't clear, the alternative that @jeremyevans0, @graywolf, and I talked about was not `@1` but `@`. They're different.
> ...
I discussed that at https://bugs.ruby-lang.org/issues/18980#note-8.
2+ args cases a... -
09:21 PM Feature #18980: `it` as a default block parameter
- #### Aliasing
While I understand that `_1` is not necessarily clear and immediately obvious it has seen a lot of use. Even if we were to introduce `it` or any other syntax it would effectively be an alias so as to not break compatibilit... -
- For your information, `@` was a candidate discussed and rejected when `@1` was changed to `_1`. I'm raising `it` partly because it hasn't been explicitly rejected. However, for the same reason discussed above, `@` is still a better compr...
-
04:42 PM Feature #18980: `it` as a default block parameter
- jeremyevans0 (Jeremy Evans) wrote in #note-13:
> If we are considering an alternative to `_1`, I'm going to vote again for `@` (bare at sign) (originally proposed in https://bugs.ruby-lang.org/issues/4475#note-10). This is currently in... - 03:33 PM Revision 5fcce23a (git): * 2022-08-29 [ci skip]
- 03:33 PM Revision 8799c912 (git): [rubygems/rubygems] Add platform :windows as a shortcut for all Windows platforms
- https://github.com/rubygems/rubygems/commit/f3c49ad3f7
-
03:14 PM Feature #18959: Handle gracefully nil kwargs eg. **nil
- LevLukomskyi (Lev Lukomskyi) wrote:
>
> ...
Starting with Rails 6.1 you can do:
```ruby
content_tag(:div, 'Content', class: token_list('is-hero': hero, 'is-search-page': search_page))
``` -
- LevLukomskyi (Lev Lukomskyi) wrote in #note-22:
> > I also tend to do `**(options || {})` and I don’t write hard-to-read code like `**({id: id, name: name} if id.present?)`.
> ...
I disagree that it’s the same, but more to the point,... - 07:27 AM Revision 1486ffe0 (git): [DOC] Correct article of Ractor's introduction [ci skip]
-
- `exit` command ignores the rest arguments after an exit code, while
`type` command tries to read all as files. -
- This bug is fixed by "Microsoft(R) C/C++ Optimizing Compiler Version 19.33.31629 for x64".
And applied to GitHub Actions at runner-image 20220821.1. -
- Applied in changeset commit:git|ace2eee544378eb03ea95b95c89434508325e8c8.
----------
[Bug #18963] Separate string contents by here document terminator -
08/27/2022
-
-
- > I also tend to do `**(options || {})` and I don’t write hard-to-read code like `**({id: id, name: name} if id.present?)`.
That's interesting, that you are ok for
```ruby
**(options || {})
```
but not ok for
```ruby
**(options ... -
03:16 AM Feature #18959: Handle gracefully nil kwargs eg. **nil
- It seems that `foo(*arguments)` will call `arguments.to_a` rather than `arguments.to_ary`. However, I also noticed `foo(*Object.new)` works as a single argument, which honestly seems a bit odd to me.
So:
> If we want to allow **nil, th... -
- LevLukomskyi (Lev Lukomskyi) wrote in #note-19:
> > Both @sawa and I have provided better options than your examples.
> ...
Not at all. I’ve used `**` for a *very* long time (since kwargs were introduced). But I also tend to do `**(opt... -
- 09:42 PM Revision a797ded8 (git): typos
-
-
- http://ci.rvm.jp/results/trunk-mjit@phosphorus-docker/4213386
It's failing with:
rm: cannot remove '/tmp/ruby/v3/build/trunk-mjit/tmp/test_rubygems_20220827-13666-ii8lcp': Directory not empty
rm: cannot remove '/tmp/ruby/v3/build/trunk-... - 05:04 PM Revision 4de09574 (git): * 2022-08-28 [ci skip]
- 05:04 PM Revision 381d8e43 (git): [rubygems/rubygems] Bundler: make to_lock consistent between Gem::Dependency and Bundler::Dependency
- https://github.com/rubygems/rubygems/commit/971d57cf5a
-
- Disregard that, looked in the wrong place.
~~Hmm, folks, working on implementation on the weekend, I am a bit confused. I believe I _saw_ that in 3.2 we decided to make `Struct` more flexible, but accepting positional OR keyword args re... -
- > But WITH is also SQL keyword and was recently added to ActiveRecord
It was added to `ActiveRecord::Relation`, which doesn't have any setters in its public API, and even if it did it still wouldn't be a concern in my opinion.
Sin... -
03:14 PM Feature #18951: Object#with to set and restore attributes around a block
- There are similar methods (`with_*`) across various popular gems. For example `I18n.with_locale(locale)`. But `WITH` is also SQL keyword and was recently added to `ActiveRecord` (https://github.com/rails/rails/commit/098b0eb5dbcf1a942c4e...
-
- > sole with feels vague a little, to me.
Well, the argument is that it's not alone, since it is used with at list one keyword argument.
`something.with` is vague I agree, but I believe that e.g.:
```ruby
GC.with(stress: true) d... -
- I think this would be nice to have, indeed spelling it out manually is quite verbose and then we tend to have lots of helper methods for this.
For the name, `with` seems natural to me, and it's also the name of the keyword in Python use... -
- I agree with the concept, but wonder about these names.
The meaning of `with_something_enabled` is obvious, but sole `with` feels vague a little, to me.
And `old_values` should be initialized as an empty hash, I think. -
- headius (Charles Nutter) wrote in #note-10:
> Late to the party, but why was `RegQueryInfoKey` also update to use `W`?
It seems unneeded because not using any `WCHAR` arguments.
> ...
It's done by fiddle.
https://github.com/ruby/... -
- I think those issues are revealing real problems which are worth investigating and fixing.
For instance if files are created and deleted in parallel in the same directory that seems like a good source of transient bugs waiting to happen... -
- deivid (David Rodríguez) wrote in #note-13:
> Yet this exception is showing the error when trying to remove the root directory, and not the real culprit of failing to remove one file inside. Do you know why is that?
I have no idea. P... -
- Alright, I guess it makes sense to leave things as they are.
One question I have is: I though we had removed an `ensure` that prevented the original exception from being displayed and would instead show the error when removing the roo... -
- We faced another problem on Linux.
A rubygems test uses `FileUtils.rm_rf` in `teardown`. But it randomly fails for an unknown reason (mysteriously, only on MJIT test?). This makes the `teardown` method fail to restore the environment ... -
- I think the underlying issue is we want a string append method which does not change the receiver's encoding (and instead raises an EncodingError if it would need to change it).
-
- > I hope I have not demanded anything
Yes, sorry, not what I meant, it's one of these words that has similar meaning in French, yet a radically different connotation. -
- Just to clarify I hope I have not demanded anything. "But if you want to have a go at it, that would be awesome" was all I said.
I have been trying the `buffer.force_encoding(Encoding::BINARY)` followed by `slice!` but you are right i... -
- Right, and I agree with matz that modifying ivars as the match is evaluated is problematic, I would even say it's unsound for pattern matching to have such side effects.
Testing a pattern should as much as feasible not have side effects... -
03:18 AM Feature #18408: Allow pattern match to set instance variables
- @eregon I understand what you're saying, but my statement was based on the premise "if you don't want ivars to change during match". In the PR prepared by @palkan, ivars are modified as the match is evaluated, just like local vars, and t...
-
09:04 AM Feature #18980: `it` as a default block parameter
- I also avoid using solo `_1` as I have to search for `_2` when I see `_1` in a block. It's not because of a feeling caused by the number but because the behavior of `_1` changes depending on the occurrence of `_2`.
Given that we have ... -
- FileUtils.rm_rf started to randomly fail on http://ci.rvm.jp/results/trunk-mjit@phosphorus-docker
since around https://github.com/ruby/fileutils/pull/99. - 03:56 AM Revision f97af5cd (git): * 2022-08-27 [ci skip]
-
08/26/2022
-
- > because it’s (1) wasteful
It wastes what? I don't understand this argument
> ...
This I can understand because indeed sometimes programmers can put too much in one line. However there are only two operators in that line – `if` an... -
- LevLukomskyi (Lev Lukomskyi) wrote in #note-17:
> @austin your latest example has 110 symbols, the condition should be duplicated for each new hash key, as well as the ternary operator, so it's not good. Previous example has 294 symbols... -
- Currently:
```ruby
"xyz".sub(/y/, nil) #=> TypeError: no implicit conversion of nil into String
def nil.to_hash; {} end
"xyz".sub(/y/, nil) #=> "xz"
```
Ok, the behavior is different, but it doesn't mean that we cannot implement the fea... -
- > > Currently, nobody is using `**nil` because it throws an error because `nil.to_hash` is not defined. So I don't see how adding such feature would lead to _"high probability of compatibility issues"_.
> ...
Yes, there are problems wit... -
- LevLukomskyi (Lev Lukomskyi) wrote in #note-14:
> @austin, your example is a perfect example of "overengineering".
On this, we disagree. I find the number of sigils required for `**({ id: id, name: name } if id.present?)` to be a sur... -
- If we are considering an alternative to `_1`, I'm going to vote again for `@` (bare at sign) (originally proposed in https://bugs.ruby-lang.org/issues/4475#note-10). This is currently invalid syntax, so there is no possibility of backwa...
-
- > This is a good argument, I think it would be good to add to the issue description.
I'm glad it made sense to you. Sure, I updated the issue description to include that.
> ...
I'm not sure if it's too difficult to distinguish "a metho... -
- > innocuous word
I misused `innocuous` here. I want to mean a "common word", and it's hard to notice because it's the same syntax as a local variable or method call. -
- k0kubun (Takashi Kokubun) wrote in #note-8:
> What do you mean? I thought we were talking about `_1`, not `_`. If this feature were introduced as `_`, I would use it much more often than `_1`, but [Matz finds `_` confusing](https://bugs... -
- > I regularly use _1, _2, maybe it's question of habit and getting used to it?
Matz also made that argument in the Ruby Committers vs the World 2019, saying many people started using `-> {}` after almost 100% of the people objected to t... -
- I regularly use `_1`, `_2`, maybe it's question of habit and getting used to it?
`_1` seems already used in many gems (`gem-codesearch '\b_1\b' | grep '\.rb:\s'`).
It's also a syntax used in other languages, and `_` is already establishe... -
- ## Problem
Numbered parameters (`_1`, `_2`, ...) look like unused local variables and I don't feel motivated to use them, even though I need this feature very often and always come up with `_1`.
```rb
[1, 2, 3].each { puts _1 }
```... -
- austin (Austin Ziegler) wrote in #note-55:
> Why not `Data.defclass` or `Data.deftype` or even `Data.defshape`?
Because those do not use a proper Ruby naming (no _ to separate words, aside: looks like Python matplotlib methods), they... -
- Eregon (Benoit Daloze) wrote in #note-54:
> I like `Data.define` as well, we are "defining a new subclass of Data".
> ...
Elixir uses `defmodule` for module declarations. Why not `Data.defclass` or `Data.deftype` or even `Data.defshape`? -
- I like `Data.define` as well, we are "defining a new subclass of Data".
`def` makes me thing to "define a method" since that's what the keyword of the same name does, but `Data.def` does not define a method but a class. -
- Dan0042 (Daniel DeLorme) wrote in #note-20:
> But if you don't want ivars to change during match, this *can* be fixed, for example by using temporary local vars like I suggested in #note-11. I don't think this is a fundamental problem w... -
- > it is intentional. Unsuccessful matches remain the assignment result from the internal matches
I think everyone here understood the current behavior is intentional, but the more important question would be "is it beneficial?"
> .... -
- > Why not exception: false which seems more standard and established
So after working more on using a SizedQueue in statsd-instrument, I now think `exception: false` might actually be better.
The reason is that `SizedQueue#push(ite... -
01:01 PM Bug #18899: Inconsistent argument handling in IO#set_encoding
- I ran my test against your branch, and it addresses this issue. I hope it can be incorporated soon. Thanks!
-
- Another observation is: could we opt-out of this strict behavior only on Windows, given how picky it is about deleting used files? So far the only issues found in the realworld are under Windows I believe. Fileutils already has several s...
-
- In my opinion, this is ok. I also encountered some issues in RubyGems test suite when I first enabled this behavior that led me to correct some bad tests. And it also helped me figure out realworld bugs. I understand that sometimes it ma...
-
05:34 AM Feature #18784: `FileUtils.rm_f` and `FileUtils.rm_rf` should not mask exceptions
- I also encountered a possibly related `Errno::EACCES` error on Windows (mingw) of GitHub Actions.
```
Errno::EACCES:
Permission denied @ apply2files - D:/a/_temp/d20220824-1696-gdx8qj/path/does/not/exist
```
Below are the back... -
- Unfortunately, this change affected mkmf on Appveyor (Windows).
https://ci.appveyor.com/project/ruby/ruby/builds/44579924/job/n81xmb2mqs6no7dm#L23792
```
2) Error:
TestMkmfTryConstant#test_simple:
Errno::EACCES: Permission denie... -
- catch_excep_t is a field that exists for MJIT. In the process of
rewriting MJIT in Ruby, I added API to convert 1/0 of _Bool to
true/false, and it seemed confusing and hard to maintain if you
don't use _Bool for *_p fields. -
- * [Feature #18784] `FileUtils.rm_f` and `FileUtils.rm_rf` should not mask exceptions (mame)
* I changed FileUtils.rm_f/rm_rf so that it raises a SystemCallError but Errno::ENOENT.
* But it seemed to affect mkmf on Windows. mkmf use... -
-
-
-
-
-
-
-
- 12:57 AM Revision 3504be1b (git): [ruby/irb] Require RDoc in `input-method.rb` again in a limited scope.
- RDoc is implemented as soft dependency in IRB. See how the rdoc is required in
the files. I reverted the commit below.
```
$ grep -ril rdoc lib/
lib/irb/cmd/help.rb
lib/irb/completion.rb
lib/irb/easter-egg.rb
lib/irb/input-method.rb
```...
08/25/2022
-
- `Data.new` aside, `Data.def` and `Data.define` are my current top-2 preferences. I'd be happy with either of these at this point.
But thinking about this further, I might like `Data.define` slightly more. It's a trade-off with shortn... -
-
01:34 PM Feature #16122: Data: simple immutable value object
- 1. I slightly regretted to make `Struct.new` to create a subclass, not an instance. So this time I didn't choose `new`. `create` or `generate` would have a similar issue with `new`. `define` might be a candidate. But I still prefer short...
-
- @matz Thanks for the decisions!
A few questions:
1. I am a bit concerned about using `def`, which is strongly associated with defining methods. I wouldn't want it to be a blocker (it would be really cool to have `Data` by the 3.2),... -
- We are going to implement Data class in the following spec:
* `D = Data.def(:foo, :bar)` to define a data class (subclass of Data)
* `Data.new` raises exception (unlike Struct)
* `d = D.new(1,2)` to create Data instance
* Or `d = ... -
- @austin, your example is a perfect example of "overengineering".
We could argue about "clearness", although about "conciseness" it's easy to check – option 1: 72 characters, option 2: 62 characters, so option 2 is 15% more concise, cl... -
- LevLukomskyi (Lev Lukomskyi) wrote in #note-10:
> ```ruby
> ...
I do not find the second option clearer or more concise in any way. It feels much more of line-noise.
In my code, I would opt for an explicit function that does the log... -
- I'm not that much concerned about the performance but about readability. Your solution with `compact` is probably good for that particular case but it cannot solve all other cases with an arbitrary hash plugged into the main hash on an a...
-
12:14 PM Feature #18959: Handle gracefully nil kwargs eg. **nil
- LevLukomskyi (Lev Lukomskyi) wrote in #note-10:
> If use `compact!` as a different statement then you need to make a variable, you have to make a mental effort to make up the name for that variable and repeat its name to use `compact!`. ... -
- > I meant to simply use compact! in a different statement, not in a chain.
If use `compact!` as a different statement then you need to make a variable, you have to make a mental effort to make up the name for that variable and repeat ... -
- LevLukomskyi (Lev Lukomskyi) wrote in #note-8:
> 2. => more specifically `.tap(&:compact!)` since `compact!` may return `nil` if nothing changed.
I think `tap(&:foo)` is actually not that much efficient, and `tap(&:compact!)` could be s... -
- Applied in changeset commit:git|21cac42385e1a116d287e155e461453b830640d2.
----------
Raise ArgumentError for IO.foreach with limit of 0
Makes behavior consistent with IO.readlines.
Fixes [Bug #18767] -
- OK, let's make it raise exceptions for zero length.
Matz.
-
- Makes behavior consistent with IO.readlines.
Fixes [Bug #18767] -
- matz (Yukihiro Matsumoto) wrote in #note-1:
> This is indeed an obsolete feature for long time. And the third argument is ignored (IIRC).
Unfortunately, the third argument is not ignored:
```ruby
p Regexp.new("\u1234", nil, "n").... -
- This is indeed an obsolete feature for long time. And the third argument is ignored (IIRC).
Some (old) gems still use it because they are not updated for long time. Warnings should not improve the situation (since most of them are unmai... -
- It hangs even after a retry
https://github.com/ruby/ruby/runs/7966439530?check_suite_focus=true
We contacted GitHub Suppport about this before, and we concluded that
the problem is on our end. Unfortunately we don't have a bandwidth to
... -
-
- It seems like TestMkmfTryConstant started to randomly fail, maybe
related to 96562a517d3373466ec306b5f821a41f4758d2a6 or 073f3b7e0ad94657c04573983affb9d66e6bff2c.
Some of them seem to have failed even after retries, so it feels like
the... -
- Deletes the :include: files in doc/time, which became no longer workable when @nobu pointed out that some (but not all) creator methods accept string values as well as integer-like values.
Changes to methods:
Time.utc
Time.local... -
- Ref: bfa6a8ddc84fffe0aef5a0f91b417167e124dbbf
Ref: [Bug #18826] -
03:31 PM Feature #18979 (Open): Kernel#sprintf formatting BigDecimal without the loss of precision
- Recently I stumbled upon a quirk with `Kernel#sprintf`'s `f` modifier behavior with `BigDecimal`. It seems to be not documented neither in `Kernel` documentation nor in `BegDecimal` one. Also, I didn't find previous discussions about it ...
- 03:08 PM Revision c2daa056 (git): * 2022-08-26 [ci skip]
-
- Since RDoc C parser cannot capture aliases which are using an
expression other than a single variable as the class, use an
intermediate variable for the singleton class. -
- MSP-Greg (Greg L) wrote in #note-12:
> Windows bash file 'top'
> ...
I'm not sure where the header came from.
`rbinstall.rb` doesn't use `dirname` command.
Maybe [here](https://github.com/MSP-Greg/ruby-loco-test/blob/master/mswin/cop... -
- Recently a changed was introduced to update the resolver platforms after
it has been created, in order to remove the "ruby" platform from it if
it's to be removed from the lockfile. However, it did not update the
`@resolving_only_for_rub... -
01:41 PM Bug #18978 (Feedback): Unexpected behaviour in Time.utc and Time.local when 8 arguments are passed in
- GitHub PR: https://github.com/ruby/ruby/pull/6281
Time.utc and Time.local produce inconsistent and unexpected behaviour when 8 arguments is passed in.
For example, consider the following code:
```ruby
Time.utc(2000, 1, 1, 2, 3,... -
- # The next dev meeting
**Date: 2022/09/22 13:00-17:00** (JST)
Log: https://github.com/ruby/dev-meeting-log/blob/master/DevMeeting-2022-09-22.md
- Dev meeting *IS NOT* a decision-making place. All decisions should be done at the bu... -
-
- We brielfly discussed this issue at the dev meeting. @naruse said it should behave like `String#<<` as follows. @nobu said he would try to implement this.
```ruby
s = "".force_encoding("US-ASCII")
s << 128
p s #=> "\x80"
... -
- Confirmed. Thank you for helping us @k0kubun and @st0012.
If you have any concern, please tell us here.
Matz.
-
- We discussed this at today's developers meeting. We recognize two different challenges here.
1. @st0012 and @k0kubun want to introduce IRB features that are relatively easy to maintain, such as adding or modifying IRB commands.
2. We ha... -
- We have discussed with @ktsj about the issue, and concluded it is intentional. Unsuccessful matches remain the assignment result from the internal matches, e.g.,
```
case [1,2,3]
in [a,2,3,4]
# unmatch
else
p a #=> 1 (from pa... -
- I agree with MatchData. And I think `deconstruct` for the class should be an alias to `captures` instead of `to_a`.
Matz. -
- Although not so elegant, I was thinking to add "precheck" to enumerators.
https://github.com/nobu/ruby/tree/lazy_take0 -
- The mail archive server named `blade.nagaokaut.ac.jp` is down now.
blade had some hardware issues. Prof. Hara tries to salvage mail data and rebuild blade. But It's difficult status.
I have a plan to migrate Ruby mail server includ...
08/24/2022
-
-
- I just built ruby_3_1 branch with VS 2022, and it built and passed all tests. So, no patches needed for Ruby 3.1. Please close.
-
- Yes. The Visual Studio bug has been fixed. I'll try a build see what's needed.
-
- Can you point out which commits are needed for backporting to allow Ruby 3.1 to work better with VS 2022? Then we could mark those commits for backporting. However, the decision of whether to backport is always made by the branch maint...
-
- Requested by matz in comment on #18435.
-
- I've submitted a pull request to fix this issue: https://github.com/ruby/ruby/pull/6283
-
10:22 AM Bug #18974 (Closed): Wrong line number in the rescue iseq for the exception matching code
- Script for demonstration:
```
def foo
begin
raise 'error'
rescue => e
puts e.message
end
end
puts RubyVM::InstructionSequence.of(method :foo).disasm
```
Disasm for the catch table:
```
| catch type: rescue ... -
08:48 PM Misc #18975: Propose Stan Lo (@st0012) as an IRB maintainer
- It'll be my honor to help the team maintain IRB. Thank you for nominating me for this important role.
-
- ## Background
Looking at @aycabta 's GitHub activity, he's been inactive on the Internet for 6~7 months, which means that IRB hasn't had the maintainer during that period of time. While I managed to sneak in some IRB changes when he was... -
- 2. => more specifically `.tap(&:compact!)` since `compact!` may return `nil` if nothing changed.
3. there might be also a case when you want to merge another hash under some conditions, eg.:
```ruby
{
some: 'value',
**({ id: id, na... -
- LevLukomskyi (Lev Lukomskyi) wrote in #note-6:
> `compact` way looks good indeed, although:
> ...
I think such use case would be a design failure. `nil` generally represents absence of a valid value. Sometimes having `nil` and sometime... -
- `compact` way looks good indeed, although:
1. it removes all `nil`s from the hash, which might be undesired in some cases
2. it creates hash duplicate each time, while kwargs way creates temporary hash only if a condition is met, though ... -
- I am concerned about compatibility to change this. @naruse proposed to return an ASCII-8BIT string instead of raising an exception.
-
- @nobu Looks good to me, could you commit it?
(ARG_UNUSED is not needed on `code` I think) -
- Sorry, this.
```diff
diff --git a/enc/us_ascii.c b/enc/us_ascii.c
index 08f9072c435..9d854b12245 100644
--- a/enc/us_ascii.c
+++ b/enc/us_ascii.c
@@ -7,6 +7,12 @@
# define ENCINDEX_US_ASCII 0
#endif
+static int
+us_ascii_c... -
- ```diff
diff --git a/regenc.c b/regenc.c
index 16d62fdf409..5cc3b778351 100644
--- a/regenc.c
+++ b/regenc.c
@@ -627,6 +627,10 @@ onigenc_single_byte_mbc_to_code(const UChar* p, const UChar* end ARG_UNUSED,
extern int
onigenc_single_by... -
- I submitted a pull request to always raise an exception for rstrip strings with broken coderange: https://github.com/ruby/ruby/pull/6282
That may not match the lstrip behavior exactly, as it complains about cases where the broken code... -
- After giving this some more thought, I am fairly sure this is not a bug, and I'm rejecting this. @zverok is correct, a trailing comma is an implicit splat, and you cannot have multiple splats in a multiple assignment, so a syntax error ...
-
- I agree that we should remove the restriction. I submitted a pull request for that: https://github.com/ruby/net-http/pull/66
-
05:54 PM Revision 28a34346 (git): Disable Ractor check on 32bit architectures
- Ractor verification requires storing the ractor id in the top 32 bits of
the object header. Unfortunately 32 bit machines only have 32 bits in
the object header. The verification code has a 32 bit left shift which
doesn't work on i686 ... - 05:43 PM Revision fa9f4d38 (git): * 2022-08-25 [ci skip]
-
-
- The Ruby build linked to above had incorrect bash scripts. Fixed as of now. Sorry, bad day yesterday, too many interruptions...
-
- Pull requested merged at commit:c69ad738dc7c713df547a51607917ca78df6b793
-
- Fixed by commit:5bbba76489628f4509495ebf4ba0a7aad4c0b560
-
- https://github.com/rubygems/rubygems/commit/703373b41f
Co-authored-by: Loic Nageleisen <loic.nageleisen@gmail.com> -
- I had a quick chat with @ko1, he plans to try a better implementation after RubyKaigi (mid-september).
I'll hold on this. -