Activity
From 07/05/2022 to 07/11/2022
07/11/2022
-
08:29 PM Bug #18905: :"@=".inspect is non-evaluatable
- I was bitten by the same thing last week and was actually going to open an issue myself. Thanks for raising this @qnighy.
The thing that caught me out was that the following discrepancy:
```ruby
"4_to_5".to_sym.inspect
#=> :"4_to_5... -
12:09 PM Bug #18905: :"@=".inspect is non-evaluatable
- sawa (Tsuyoshi Sawada) wrote in #note-1:
> However, among them, `:"@=".inspect` and `:"$$$$=".inspect` do not include quotations. Is that what you are at?
Ah yes, the second example is my mistake. It should have been `:"[=]="` or suc... -
07:53 AM Bug #18905: :"@=".inspect is non-evaluatable
- First, `inspect` methods are not for `eval`.
We only guarantee that `sym.name.to_sym == sym`. - 07:57 PM Revision 6e74c5c2 (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.18 to 0.9.19.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.18...v0.9.19)
---
updated-depende... -
07:54 PM Bug #18816: Ractor segfaulting MacOS 12.4 (aarch64 / M1 processor)
- I took a look at this, and it looks like we're missing a lock when deleting the fd from `waiting_fds` list. I've attached a patch that fixes the crash for me. It seems like not every request gets serviced, but I think that might be a d...
- 05:52 PM Revision ea956e5e (git): [rubygems/rubygems] Bump rb-sys in /test/rubygems/test_gem_ext_cargo_builder/custom_name
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.18 to 0.9.19.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.18...v0.9.19)
---
updated-depende... -
03:34 PM Misc #18836: DevMeeting-2022-07-21
- * [Bug #18770] Inconsistent behavior of IO/StringIO's each methods when called with nil as a separator, limit and chomp: true (jeremyevans0)
* When using `nil` separator and `chomp` keyword, should IO chomp a final line separator?
... -
-
03:05 PM Revision 66dfcbed (git): [ruby/irb] [DOC] Include updated help message (https://github.com/ruby/irb/pull/377)
- * Include updated help message
https://github.com/ruby/irb/commit/ff129f3794 - 03:02 PM Revision b1218fd3 (git): * 2022-07-12 [ci skip]
-
- Minor edits to 11 methods' documentation.
https://github.com/ruby/date/commit/00bb7f6648 -
02:38 PM Bug #18906 (Closed): coverage failed on GItHub Actions
- Applied in changeset commit:git|a871fc4d86e857b4c580604d2654877135484896.
----------
Fix a regression of b2e58b02aec73f9c350bf109c021c180fc699ccc
At that commit, I fixed a wrong conditional expression that was always
true. However, th... -
06:10 AM Bug #18906: coverage failed on GItHub Actions
- GitHub Actions log will expire, so I copy and paste it.
https://github.com/ruby/actions/runs/6857369382?check_suite_focus=true#step:9:84
```
test-tool
Run options:
--seed=60580
"--ruby=./miniruby -I./lib -I. -I.ext/com... -
- Thank you, I have send a PR: https://github.com/ruby/ruby/pull/6112
-
- coverage failed on GItHub Actions since https://github.com/ruby/actions/actions/runs/2486933939
(previous https://github.com/ruby/actions/actions/runs/2486176425 is passed)
A reproduce test is attached.
```
1) Failure:
TestCov... -
- At that commit, I fixed a wrong conditional expression that was always
true. However, that seemed to have caused a regression. [Bug #18906]
This change removes the condition to make the code always enabled.
It had been enabled until th... -
01:50 PM Bug #18907 (Closed): rb_profile_frames output includes dummy main Thread frame
- Howdy! I'm working at Datadog [on the `ddtrace` gem](https://github.com/DataDog/dd-trace-rb), and we're starting to make use of the `rb_profile_frames` API for our continuous profiler.
While comparing the output of `rb_profile_frames`... -
01:19 PM Revision 2733c049 (git): [ruby/reline] Add tests for top-level dialog color APIs
- https://github.com/ruby/reline/commit/347a468c59
-
01:00 PM Revision 6423d32e (git): Replace use of double_heap in tests with expand_heap
-
- In order to reliably test compaction we need to be able to move objects
between size pools.
In order for this to happen there must be pages in a size pool into
which we can allocate.
The existing implementation of `double_heap` only do... -
11:05 AM Misc #18888 (Assigned): Migrate ruby-lang.org mail services to Google Domains and Google Workspace
- FYI: I migrated to `ruby-lang.org` from AWS Route53 to Google Domains today. It remains old DNS records.
We will remove the obsoleted records and prepare email aliases for Ruby core members.
-
07:24 AM Bug #18893 (Closed): Don't redefine memcpy(3)
- This is fixed and will be included in the next release. Thank you!
-
06:58 AM Revision fae568ed (git): Use NO_JIT_DESCRIPTION only when needed
- Apparently 203801566a186b7b1cbe899a06d0832923a1bdf9 broke YJIT's CI.
-
- If you run tests with RUN_OPTS=--mjit, the test fixes in
https://github.com/ruby/ruby/pull/5872 don't work. -
- https://github.com/ruby/rdoc/commit/aaeb5ce1ce
-
- https://github.com/ruby/rdoc/commit/9f47234e0e
- 04:14 AM Revision c7dd5b65 (git): * 2022-07-11 [ci skip]
-
- https://github.com/ruby/rdoc/commit/87301da71b
07/10/2022
-
- Omit private aliases from Rdoc.
https://github.com/ruby/date/commit/48f9180663 -
12:07 PM Bug #18658: Need openssl 3 support for Ubuntu 22.04 (Ruby 2.7.x and 3.0.x)
- https://github.com/rbenv/ruby-build/pull/1974 is merged so one solution now is "Use ruby-build" and it will install the right openssl version whenever the system openssl version does not match.
It is not ideal that the system openssl ... -
- Issue at ruby/openssl to have a release supporting OpenSSL 1.0.1 - 3.0.0: https://github.com/ruby/openssl/issues/517.
If there is such a release it should be a no-brainer for Ruby 2.7 and 3.0 to directly support OpenSSL 3.
The next Tru... -
04:00 AM Bug #18658: Need openssl 3 support for Ubuntu 22.04 (Ruby 2.7.x and 3.0.x)
- For folks who use rbenv/ruby-build to manage ruby, https://gist.github.com/yob/08d53a003181aa0fcce9812b1b533870 describes an adapted version of the workaround by @mame that can be used to install ruby 3.0 on systems with openssl 3.0
-
- 07:38 AM Revision 072a8bf7 (git): * 2022-07-10 [ci skip]
-
-
-
-
-
-
-
-
07/09/2022
-
10:44 PM Bug #18818: Thread waitq does not retain referenced objects, can lead to use after free.
- IMO, neither ruby nor C should *ever* be in a position where they are referencing freed memory. And, although `sync_waiter` lists check `waiter->th->status != THREAD_KILLED` when they are being traversed, that would be dangerous if the ...
-
- dorianmariefr (Dorian Marié) wrote in #note-3:
> What would you suggest using instead?
Stop nesting the calls?:
```ruby
around do ... -
12:43 PM Bug #18904: Mutex and Fiber: No live threads left. Deadlock? (fatal)
- What would you suggest using instead?
-
02:44 PM Bug #18905: :"@=".inspect is non-evaluatable
- Not sure what you mean. `inspect` is expected to return a string, and the cases you mention indeed return a string respectively.
```ruby
:"@=".inspect #=> ":@="
:"[][]=".inspect #=> ":\"[][]=\""
:"$$$$=".inspect #=> ":$$$$="
```
... -
- There is an edge case where `Symbol#inspect` returns a non-evaluatable expression:
```ruby
:"@=".inspect # => :@=
:"[][]=".inspect # => :[][]=
:"$$$$=" # => :$$$$=
```
More specifically, the quotations are stripped if the follo... -
-
- It does not raise an error when setting an invalid value to SSLContext
ciphers on Ubuntu 18.04.
https://github.com/ruby/openssl/commit/8c96a69b0d -
04:08 AM Revision 2725c5db (git): Fix invalid mkdir detection on OpenBSD
- This was broken by 67e54ce4081abaa16774b93ccd33ccbd1d6c6531, which
resulted in " -d" being used as the mkdir_p program. I think this
is because $ac_install_sh has been set to '' at the point it is
used.
There's probably a better way to ...
07/08/2022
-
- This isn't a bug. `Mutex` is not designed to be reentrant, so that will always fail in recursive use. `Monitor` is only reentrant in the same fiber, and you are using a separate fiber, so that should fail as well in this case. The `Mon...
-
- Same error happens with `Monitor`
-
- Hi,
I was investigating an issue with the climate_control gem and minitest-around and it seems like the bug is coming from Ruby:
```ruby
def around(&block)
Fiber.new do |context, resume|
context.instance_exec(resume, &bloc... -
- Minor changes (mostly doc-guide compliance) to 18 or so of simpler methods (getters).
https://github.com/ruby/date/commit/00e37ba2b4 -
- https://github.com/ruby/openssl/commit/862d92de93
- 03:31 PM Revision 1c17cf68 (git): * 2022-07-09 [ci skip]
-
02:18 PM Revision 86768f1d (git): [ruby/openssl] Fix formatting in docs
- The + tag can only be used for single words. For multiple words the <tt>
tag has to be used.
https://github.com/ruby/openssl/commit/cf2f019c3e -
02:18 PM Revision 4d6a2932 (git): [ruby/openssl] Let OpenSSL choose the digest if digest for Openssl::OCSP::BasicResponse#sign is nil.
- https://github.com/ruby/openssl/commit/27efcd7e1c
-
- https://github.com/ruby/openssl/commit/a1f6cbc261
-
- LibreSSL 3.5 switched the cipher naming to match OpenSSL.
https://github.com/ruby/openssl/commit/bf198278bd -
- https://github.com/ruby/openssl/commit/b02815271f
-
- https://github.com/ruby/openssl/commit/e25fb0d0d8
- 02:18 PM Revision 09daf78f (git): [ruby/openssl] Add 'ciphersuites=' method to allow setting of TLSv1.3 cipher suites along with some unit tests (https://github.com/ruby/openssl/pull/493)
- Add OpenSSL::SSL::SSLContext#ciphersuites= method along with unit tests.
https://github.com/ruby/openssl/commit/12250c7cef - 02:18 PM Revision 0bf2dfa6 (git): [ruby/openssl] ignore pkgconfig when any openssl option is specified
- https://github.com/ruby/openssl/commit/b23fa75aa3
-
- RFC 6066 states how some wildcard SAN entries MAY be handled, but
it does not say they MUST be handled. LibreSSL 3.5.0 only handles
suffix wildcard SANs, not prefix wildcard SANs, or interior
wildcard SANs, so return early from the wild... -
-
- I'm also in favour of https://github.com/ruby/ruby/pull/6094 - It feels like the most elegant solution of those proposed
-
- And suppress unary minus operator to unsigned type warnings by VC.
-
- The masking is not only unnecessary but works only when the masking
value is a power of 2. Also suppress unary minus operator to unsigned
type warnings. -
- ```
test/ruby/test_parse.rb:1384: warning: assigned but unused variable - obj
test/ruby/test_pattern_matching.rb:1162: warning: unused literal ignored
test/ruby/test_pattern_matching.rb:1165: warning: unused literal ignored
test/ruby/tes... -
- Recently `TestThreadInstrumentation#test_join_counters` often fails as
```
<[1, 1, 1]> expected but was
<[2, 2, 2]>.
```
Probably it seems that the thread is suspended more than once.
There may be no guarantee that the subject thread n... -
07/07/2022
-
- In general it is not possible to recover from a stack overflow (be it in C or Ruby), the executing program should be considered hopelessly corrupted because e.g. it might have happened in the middle of a critical section.
So IMHO the ri... -
02:33 PM Bug #18903: Stack overflow signal handling seems to be triggered once and then not working after
- (Found by Jean Boussier)
-
- This program creates a recursive object graph and then tries to convert it to JSON with no max depth, so it stack overflows in C code that does no co-operative stack overflow checks, as the bytecode interpreter would. This therefore trig...
-
- We don't need this flag anymore. We have all the info we need via the
bitmap and the is_entries list. -
- Brings a dozen call-seq schemas into compliance with the doc guide.
Adds links to section "Argument start" where needed.
Revises (minorly) ::today.
Otherwise, does not disturb existing text.
https://github.com/ruby/date/comm... -
- Changed:
Added text to options that said just 'same as ruby -whatever'.
Added defaults.
Removed an errant tab.
https://github.com/ruby/irb/commit/dfe454cc33 -
05:49 PM Bug #18902 (Closed): Thread#value crash if the thread was killed because of a fork
- Applied in changeset commit:git|65ae2bb2e045aa8b668d3c30515f5a6cb3eb68ad.
----------
Thread#value: handle threads killed by a fork
[Bug #18902]
When a thread is killed because we forked, the `value` if left
to `Qundef`. Returning it w... -
- Reproduction script
```ruby
thr = Thread.new { sleep 10}
fork do
p thr.status # =>false
p thr.join # => #<Thread:0x00000001008ae480 /tmp/thread-join.rb:1 dead>
p thr.value # Assertion Failed: ./vm_core.h:1303:VM_ENV_FLAGS... -
- [Bug #18902]
When a thread is killed because we forked, the `value` if left
to `Qundef`. Returning it woudl crash the VM. -
05:22 PM Revision 7dd0a225 (git): [rubygems/rubygems] Fix `simulate_windows` helper
- It should also set the proper class variable so that `Gem.win_platform?`
returns true.
https://github.com/rubygems/rubygems/commit/0fbf6904d1 -
- On Windows with OpenSSL 3, the gem fails to compile with the following
error message:
ruby/src/ext/openssl/extconf.rb:188: undefined method \`sub!' for nil:NilClass
This is because $warnflags is nil. -
- Introduced by 7f64989e5c913ef7624e084badd1a43ce65b3ccc
./internal.h:110:9: warning: 'memcpy' macro redefined [-Wmacro-redefined]
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/secure/_string.h:62:9: note: prev... -
- Applied in changeset commit:git|587d2d199b3f783d03266d42d066949f8a4824d3.
----------
thread_pthread.c: call SUSPENDED event when entering native_sleep
[Bug #18900]
Thread#join and a few other codepaths are using native sleep as
a way ... -
- I got a patch for it: https://github.com/ruby/ruby/pull/6101
-
- > This seems surprising to me: the main thread that got blocked on #join was never marked as suspended, even though there's a resumed event from a different thread.
I may have missed some kind of fastpath in which we should trigger th... -
- I'd like to start by thanking @byroot for his amazing work on the [GVL Instrumentation API](https://bugs.ruby-lang.org/issues/18339). This new API is going to be really useful for those of us doing performance analysis of Ruby apps :)
... - 03:49 PM Revision 0018c264 (git): * 2022-07-08 [ci skip]
-
- [Bug #18900]
Thread#join and a few other codepaths are using native sleep as
a way to suspend the current thread. So we should call the relevant
hook when this happen, otherwise some thread may transition
directly from `RESUMED` to `REA... -
02:13 PM Bug #18898: IO#set_encoding with invalid arguments leads to a segfault
- It looks like the internal encoding should be set to `Encoding.default_internal` when an invalid encoding name is given as the second argument. The equivalent is giving `nil` as the second argument instead as far as I can tell. This sc...
-
- When similar combination of conditions are separated in two places, it
is harder to make sure the conditional blocks match each other, -
- If the page_body is a null pointer, then read_barrier_handler will
crash with an unrelated message. This commit improves the error message.
Before:
test.rb:1: [BUG] Couldn't unprotect page 0x0000000000000000, errno: Cannot allocate mem... -
- The page of src could be partially compacted, so it may contain
T_MOVED. Sweeping a page may read objects on this page, so we
need to lock the page. -
- The page we're sweeping is on the destination heap `dheap`, not the
source heap `heap`. -
- [Github PR](https://github.com/ruby/ruby/pull/6099)
This PR enables Arrays to move between size pools during compaction. This can occur if the array is mutated such that it would fit in a different size pool when embedded. It uses the... -
- The (sole) use of memcpy in our public header is now replaced to
directly call ruby_nonempty_memcpy, and the previous definition of
memcpy is now internal-only. [Bug#18893] -
-
- Assume `mkdir -p` to be race-free on recent systems.
And we do not provide install-sh anyway. -
- Applied in changeset commit:git|cd948429223223f5e299626a4695ab30e43de2ea.
----------
[Bug #18892] Reset `ARGF.lineno` after reading shebang -
-
- I'm +1 for https://github.com/ruby/ruby/pull/6094
07/06/2022
-
10:32 PM Bug #18893: Don't redefine memcpy(3)
- shyouhei (Shyouhei Urabe) wrote in #note-8:
> This is my take:
> ...
Acked-by: Alejandro Colomar <alx.manpages@gmail.com> -
- This is my take:
```patch
From 505d00311d82fdbed80688e9db792c3b54b8ee27 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3?=
<shyouhei@ruby-lang.org>
Date: Wed, 6 Jul 2022 09:18:28 +0900
Subject: [PATCH] do n... -
- Modifies RDoc to Emphasize keys instead of roots, values instead of objects.
Code:
Renames method #root? to #key? and method #roots to #keys.
Aliases method #key as #root and method #keys as #roots.
Adds testing for all fou... -
- * [Misc #18891] Expand tabs in C code (k0kubun)
* Does anybody have objections to fixing this problem? Any suggestions on how to approach this? -
-
- All things commercial.
https://github.com/ruby/date/commit/9d3bc61728 -
- 03:25 PM Revision a2e0815e (git): Switch YJIT to using rb_str_buf_append rather than rb_str_append when encodings don't match, as discussed with byroot
-
- `rb_str_concat` does a lot of type checking we can easily bypass.
```
| |compare-ruby|built-ruby|
|:--------------|-----------:|---------:|
|string_concat | 362.007k| 398.965k|
| | -| 1.10... - 03:13 PM Revision 9641f233 (git): * 2022-07-07 [ci skip]
-
03:13 PM Revision 3c61e1e7 (git): YJIT: add a counter for gc object refs in the machine code (#6089)
- Add a counter for gc object refs in the machine code
This is to gather data for the eventual implementation of
a constant pool. -
- Thank you for working on this. While the patch prevents the crash, it does not address the other odd behavior that was reported, namely that the *internal* encoding of the IO instance is set to the default *external* encoding. Shouldn'...
-
- Applied in changeset commit:git|5ef3c7ea2d1968c87f361b6615699b92cc6e5a9a.
----------
[Bug #18898] Fallback invalid external encoding to the default -
- Save the following to a file and run it:
```ruby
#!/usr/bin/env ruby
Encoding.default_external = 'utf-8'
File.open(__FILE__) do |f|
f.set_encoding('utf-8', 'invalid')
printf(
"default external: %p\ndefault internal: %p... -
- `IO#set_encoding` behaves differently when processing a single String argument than it does when processing 2 arguments (whether Strings or Encodings) in the case where the external encoding is being set to binary and the internal encodi...
-
-
- > It might be a bit difficult to find out which C files shouldn't be a target.
I noticed ruby-commit-hook/bin/auto-style.rb already knows about this. (2) doesn't have any blocker.
So I prepared a pull request: https://github.com/ruby/... - 07:03 AM Revision 53afacd0 (git): Update bundled gems list at 2022-07-06
-
02:59 AM Revision 76619bbb (git): [wasm] get rid of workaround use of older binaryen and update to latest
- We no longer need to use older version of binaryen since the blocker
issue has been resolved https://github.com/WebAssembly/binaryen/issues/4401
07/05/2022
-
- Applied in changeset commit:git|eaeb130b11fefe91aaf61f294ea32af76dada74f.
----------
[Bug #18890] newline should be insignificant after pattern label -
-
- Just to be complete with regard to stack frames, `max` doesn't show up in the stack trace in the following code even though `<=>` is called via `.max`:
```ruby
class Foo
attr_reader :x
def initialize x
@x = x
end
... -
- This feature is an alternative to Feature #18825. Instead of adding a new instruction specifically for the `.hash` method, this patch replaces `opt_newarray_max` and `opt_newarray_min` with a new instruction `opt_newarray_send`. `opt_n...
-
07:51 PM Bug #18896: Shellwords.escape(nil) returns "empty" string
- `Shellwords.escape` just converts the argument to a string before shell-escaping it, so in this context nil is equivalent to ""
```
Shellwords.escape("") #=> "''"
Shellwords.escape(42) #=> "42"
Shellwords.escape(Object.n... -
12:31 PM Bug #18896 (Rejected): Shellwords.escape(nil) returns "empty" string
- Mistakenly calling Shellwords.escape with nil as parameter had this result:
``` ruby
irb(main):002:0> Shellwords.escape(nil)
=> "''"
```
This is not helpful and resulted a hard-to-find bug when a script proceeded to use an empty s... - 05:59 PM Revision 902d1a5c (git): [rubygems/rubygems] add message when gems are requested to be updated but they are not installed
- https://github.com/rubygems/rubygems/commit/27953ffe9a
- 05:59 PM Revision 6eab8095 (git): [rubygems/rubygems] output gems already up-to-date regardless if any gems were updated
- https://github.com/rubygems/rubygems/commit/4ec608a573
-
05:09 PM Feature #18004: Add Async to the stdlib
- Or I can just close it and be patient, since I assume a scheduler will be added eventually. :)
It really would be nice to have a minimalist scheduler at some point, since the test implementations in ruby/ruby and ruby/io-wait aren't t... -
- Is it better to retitle this issue to align with larskanis's proposal or close this and start a new issue? Happy to do either!
-
- larskanis (Lars Kanis) wrote in #note-4:
> Adding the core Async gem to stdlib requires to add 4 more dependent gems. Async is a big library with a lot of supplemental gems. It makes things more complicated if some gems are in stdlib an... -
-
- So `RbConfig::CONFIG["includedir"]` does not start with double slash.
- 03:23 PM Revision c21965b2 (git): * 2022-07-06 [ci skip]
-
-
- shyouhei (Shyouhei Urabe) wrote in #note-4:
> alx (Alejandro Colomar) wrote in #note-2:
> ...
[...]
>
> ...
:-)
I'm happy to help! -
- nobu (Nobuyoshi Nakada) wrote in #note-5:
> Do we need to force the function to be inlined?
You can, but it's not the best solution.
I suggest the following patches (if you like them, I'll send them to the mailing list):
```diff
com... -
- Do we need to force the function to be inlined?
```patch
diff --git a/include/ruby/internal/memory.h b/include/ruby/internal/memory.h
index aa3464465da..0c9fa17ee92 100644
--- a/include/ruby/internal/memory.h
+++ b/include/ruby/i... -
- alx (Alejandro Colomar) wrote in #note-2:
> Actually, ISO C specifies (indirectly) that `memcpy(dest, NULL, 0)` is Undefined Behavior.
> ...
Oh, didn't know this. Thank you.
> However, I can see reasons for calling `memcpy(dest, NU... -
-
- It is unrelated to `GlobOption` at all.
-
-
-
- 12:45 AM Revision ed76ba35 (git): [rubygems/rubygems] Bump rb-sys in /test/rubygems/test_gem_ext_cargo_builder/custom_name
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.15 to 0.9.18.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.15...v0.9.18)
---
updated-depende... - 12:45 AM Revision 94aff13f (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.15 to 0.9.18.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.15...v0.9.18)
---
updated-depende... -