Activity
From 06/29/2022 to 07/05/2022
07/05/2022
-
11:32 PM Bug #18890 (Closed): parse.y: pattern label is newline-sensitive if it is dynamic
- Applied in changeset commit:git|eaeb130b11fefe91aaf61f294ea32af76dada74f.
----------
[Bug #18890] newline should be insignificant after pattern label -
-
10:11 PM Feature #18897: Add a new instruction for sending messages to ephemeral stack arrays
- Just to be complete with regard to stack frames, `max` doesn't show up in the stack trace in the following code even though `<=>` is called via `.max`:
```ruby
class Foo
attr_reader :x
def initialize x
@x = x
end
... -
- This feature is an alternative to Feature #18825. Instead of adding a new instruction specifically for the `.hash` method, this patch replaces `opt_newarray_max` and `opt_newarray_min` with a new instruction `opt_newarray_send`. `opt_n...
-
07:51 PM Bug #18896: Shellwords.escape(nil) returns "empty" string
- `Shellwords.escape` just converts the argument to a string before shell-escaping it, so in this context nil is equivalent to ""
```
Shellwords.escape("") #=> "''"
Shellwords.escape(42) #=> "42"
Shellwords.escape(Object.n... -
12:31 PM Bug #18896 (Rejected): Shellwords.escape(nil) returns "empty" string
- Mistakenly calling Shellwords.escape with nil as parameter had this result:
``` ruby
irb(main):002:0> Shellwords.escape(nil)
=> "''"
```
This is not helpful and resulted a hard-to-find bug when a script proceeded to use an empty s... - 05:59 PM Revision 902d1a5c (git): [rubygems/rubygems] add message when gems are requested to be updated but they are not installed
- https://github.com/rubygems/rubygems/commit/27953ffe9a
- 05:59 PM Revision 6eab8095 (git): [rubygems/rubygems] output gems already up-to-date regardless if any gems were updated
- https://github.com/rubygems/rubygems/commit/4ec608a573
-
05:09 PM Feature #18004: Add Async to the stdlib
- Or I can just close it and be patient, since I assume a scheduler will be added eventually. :)
It really would be nice to have a minimalist scheduler at some point, since the test implementations in ruby/ruby and ruby/io-wait aren't t... -
- Is it better to retitle this issue to align with larskanis's proposal or close this and start a new issue? Happy to do either!
-
- larskanis (Lars Kanis) wrote in #note-4:
> Adding the core Async gem to stdlib requires to add 4 more dependent gems. Async is a big library with a lot of supplemental gems. It makes things more complicated if some gems are in stdlib an... -
-
- So `RbConfig::CONFIG["includedir"]` does not start with double slash.
- 03:23 PM Revision c21965b2 (git): * 2022-07-06 [ci skip]
-
-
08:55 AM Bug #18893: Don't redefine memcpy(3)
- shyouhei (Shyouhei Urabe) wrote in #note-4:
> alx (Alejandro Colomar) wrote in #note-2:
> ...
[...]
>
> ...
:-)
I'm happy to help! -
- nobu (Nobuyoshi Nakada) wrote in #note-5:
> Do we need to force the function to be inlined?
You can, but it's not the best solution.
I suggest the following patches (if you like them, I'll send them to the mailing list):
```diff
com... -
- Do we need to force the function to be inlined?
```patch
diff --git a/include/ruby/internal/memory.h b/include/ruby/internal/memory.h
index aa3464465da..0c9fa17ee92 100644
--- a/include/ruby/internal/memory.h
+++ b/include/ruby/i... -
01:00 AM Bug #18893 (Open): Don't redefine memcpy(3)
- alx (Alejandro Colomar) wrote in #note-2:
> Actually, ISO C specifies (indirectly) that `memcpy(dest, NULL, 0)` is Undefined Behavior.
> ...
Oh, didn't know this. Thank you.
> However, I can see reasons for calling `memcpy(dest, NU... -
-
- It is unrelated to `GlobOption` at all.
-
-
-
- 12:45 AM Revision ed76ba35 (git): [rubygems/rubygems] Bump rb-sys in /test/rubygems/test_gem_ext_cargo_builder/custom_name
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.15 to 0.9.18.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.15...v0.9.18)
---
updated-depende... - 12:45 AM Revision 94aff13f (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.15 to 0.9.18.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.15...v0.9.18)
---
updated-depende... -
07/04/2022
-
08:02 PM Misc #18891: Expand tabs in C code
- Thank you for the clear and precise issue.
(2) seems very obviously the way, and it's amazing it has not been done yet.
This is the #1 problem for new (and some of the existing as well) contributors to CRuby..
If CRuby does not do t... -
07:12 PM Revision f64bb67d (git): [ruby/date] Update ext/date/date_core.c
- https://github.com/ruby/date/commit/8eb1c780fb
Co-authored-by: Peter Zhu <peter@peterzhu.ca> -
- https://github.com/ruby/date/commit/e36690f70e
-
- https://github.com/ruby/date/commit/dcc0742623
-
- https://github.com/ruby/date/commit/91c632f156
-
- https://github.com/ruby/date/commit/5c18ec031e
-
- https://github.com/ruby/date/commit/fd3ae275c3
-
- https://github.com/ruby/date/commit/ac25182c66
-
- https://github.com/ruby/date/commit/f9ecaad2ee
-
- https://github.com/ruby/date/commit/e80fee4f30
- 06:05 PM Revision 89b3133a (git): * 2022-07-05 [ci skip]
-
06:04 PM Revision 890df5f8 (git): ObjectSpace.dump: Include string coderange
- I suspect that some shared pages are invalidated because
some static string don't have their coderange set eagerly.
So the first time they are scanned, the entire memory page is
invalidated.
Being able to see the coderange in `ObjectSp... -
05:38 PM Feature #18773: deconstruct to receive a range
- Oops, I made some mistakes in my "needs disambiguation" examples. Assuming that `pre+post` members will always be returned when present, padding is only needed when the largest pattern with no rest arg is equal to `pre+post`. Which mea...
-
- So here's another option: allow `deconstruct` to return an `Enumerable` (or duck-typed). Personally, I'd *much* rather write custom optimized versions of enumerable methods than write a complicated optimized `deconstruct` method. And i...
-
- @kddeisz If we want that second option to short-circuit on min size, we need to send `min` independently of `max_potential_pre_args` and `max_potential_post_args`. E.g. we wouldn't want to accidentally return `nil` for this *(edited for...
-
- Also, your `ruby_nonempty_memcpy()` could be simplified to call `memcpy(3)` directly, without any `if`s, since `memcpy(dest, NULL, 0)` is implemented as a no-op, so you could simplify the code a little bit (remove one run-time check for ...
-
- Actually, ISO C specifies (indirectly) that `memcpy(dest, NULL, 0)` is Undefined Behavior.
See: <https://stackoverflow.com/questions/5243012/is-it-guaranteed-to-be-safe-to-perform-memcpy0-0-0>
ISO C doesn't specify the `[[gnu::nonnull]]... -
- alx (Alejandro Colomar) wrote:
> ```
> ...
This `__nonnull ((1, 2))` is the cancer. We have to work around (since we do `memcpy(somewhere, 0, 0)`). The attribute is AFAIK never any part of the standard. As your OS is already doing s... - 07:03 AM Revision b92fb786 (git): Update bundled gems list at 2022-07-04
-
01:42 AM Feature #17753: Add Module#namespace
- ioquatix (Samuel Williams) wrote in #note-25:
> To me it's consistent within the requirements of solving those two problems and maps nicely to negative and non-negative integers respectively. I realise that between the negative and non-...
07/03/2022
-
11:41 PM Feature #17753: Add Module#namespace
- @sawa Thanks for your feedback and the improved code.
Based on my own needs and other code (see <https://apidock.com/rails/ActiveSupport/Inflector/demodulize> and <https://apidock.com/rails/ActiveSupport/Inflector/deconstantize> for exa... -
06:04 PM Feature #18773: deconstruct to receive a range
- @mame and @ktsj - I definitely understand your concerns! I'm sorry I didn't make it clear in the initial report, I meant to open this ticket as the beginning of a discussion, not as the definitive solution. I would be very open to discus...
-
05:29 PM Bug #18895: Mac M1 Monterey 12.4 - Bus error at active support
- austin (Austin Ziegler) wrote in #note-4:
> shyamc (Shyam Sundhar C) wrote in #note-3:
> ...
Yea. I understand. I have plans to migrate the ruby version but for now I can't get into that. Running that in a docker container makes more s... -
- shyamc (Shyam Sundhar C) wrote in #note-3:
> I have installed the rbenv with command `arch -x86_64 brew install rbenv ruby-build`.
> ...
Yeah, don’t do that. Either one.
Unless there is something that you must absolutely link again... -
- austin (Austin Ziegler) wrote in #note-2:
> peterzhu2118 (Peter Zhu) wrote in #note-1:
> ...
I have installed the rbenv with command `arch -x86_64 brew install rbenv ruby-build`.
Also I am not sure that its an option where I can co... -
- peterzhu2118 (Peter Zhu) wrote in #note-1:
> Thank you for the bug report, however support for Ruby 2.3 has ended in 2019. Please update to Ruby 2.7.6 or later and open an issue if you still run into this issue.
This also has the fee... -
03:22 PM Bug #18895 (Feedback): Mac M1 Monterey 12.4 - Bus error at active support
- Thank you for the bug report, however support for Ruby 2.3 has ended in 2019. Please update to Ruby 2.7.6 or later and open an issue if you still run into this issue.
-
- Hi All,
I have been using intel Mac for a long time. Just moving to M1 environment. Got several issues during bundle install but was able to fix it. Now when I run 'bundle exec rails s' and any callbacks is being called, I am getting ... - 04:44 PM Revision 1c3dc087 (git): * 2022-07-04 [ci skip]
-
04:42 PM Revision fe6245b4 (git): Fix rb_fix_mul_fix on OpenBSD/mips64
- This fixes invalid and inconsistent results for the Fixnum*Fixnum case
where the result of the multiplication does not fit in 64-bit
on OpenBSD/mips64. For example:
$ for x in 1 23; do ruby31 -e 'p(54306000000000*86400)'; done
144... -
- https://github.com/ruby/ruby/pull/6087
-
04:28 AM Misc #18891: Expand tabs in C code
- Sure, I added your solution to the description.
07/02/2022
-
11:42 PM Feature #18894 (Open): Object#make_shareable
- I'm proposing a callback method for when one calls `Ractor.make_shareable(obj)`, the same way `Marshal.dump(obj)` calls `obj.marshal_dump`.
A lot of use cases in the wild involve a quick initialization of an object, only for some mor... -
- It is Undefined Behavior, by any standard ever issued.
See what I have in my system right now:
```
alx@asus5775:/usr/include$ grepc memcpy
./string.h:43:
extern void *memcpy (void *__restrict __dest, const void *__restrict _... - 03:07 PM Revision cd34f56d (git): * 2022-07-03 [ci skip]
-
-
-
-
- This concatenation of string literals is to not empty the array
initialization even if no counter is declared, but warned by clang as
suspicious. -
-
02:17 PM Misc #18891: Expand tabs in C code
- One more solution would be:
4. Do not use broken editors.
¯\\\_(ツ)\_/¯
Should be at least listed here as an option. -
- # Problem
There's no way to handle tab/space-mixed indentation of CRuby's C code properly in VSCode. It impacts the productivity of the VSCode users a lot, including myself.
# Suggested solutions
I implemented option 2 out of the fo... -
- https://github.com/ruby/pstore/commit/cb2b9dc9a9
-
- https://github.com/ruby/pstore/commit/7e56730689
-
- https://github.com/ruby/pstore/commit/23a7f5468f
-
- https://github.com/ruby/pstore/commit/c12560e59a
-
- https://github.com/ruby/pstore/commit/117177c226
-
- https://github.com/ruby/pstore/commit/8f9843ef19
-
- https://github.com/ruby/pstore/commit/8de41c1eed
-
- https://github.com/ruby/pstore/commit/c59d4a063e
-
- https://github.com/ruby/pstore/commit/81a266d88c
-
10:41 AM Revision 7b78aba5 (git): [rubygems/rubygems] Account for default gems not having remote when caching
- https://github.com/rubygems/rubygems/commit/b93d4de2ff
-
- https://github.com/rubygems/rubygems/commit/6aa4c422a7
-
06:11 AM Bug #18892 (Closed): ARGF.lineno starts from 2 when the file has shebang
- Since ruby 3.0, `ARGF.lineno` starts from 2 if the file has shebang.
Following example has `#!/usr/bin/env ruby`, and it can reproduce with the file has `#!` only.
```
$ cat f.rb
#!/usr/bin/env ruby
ARGF.each do
p ARGF.lineno... -
- Use the value as similar as other tests below.
Trying to fix sporadic “not yet valid” failures on some CIs. -
05:01 AM Feature #17753: Add Module#namespace
- @ioquatix (Samuel Williams)
The non-negative part of your code looks pretty much convoluted. To simplify your code (and define it on `Module` rather than on `Class`), it would be essentially this:
```ruby
Module.prepend(Module.new do
... -
- ```ruby
class Class
def name(offset = nil)
return super() unless offset
parts = super().split('::')
if offset >= 0
parts = parts[(parts.size - 1 - offset)..-1]
else
parts = parts[0...(parts.size + offset)]... -
01:48 AM Bug #18890 (Closed): parse.y: pattern label is newline-sensitive if it is dynamic
- The two patterns in the code below behave differently:
```ruby
def f(obj)
case obj
in foo:
0
true
in "bar":
0
true
else
false
end
end
p f({ foo: 42 }) # => true
p f({ bar: 42 }) # => false... -
- Usually, command line options are given precedence first, environment
variables next, and fall back to configuration options at last.
07/01/2022
-
- https://github.com/ruby/bigdecimal/commit/3ede8860a6
- 08:25 PM Revision 303f81ad (git): * 2022-07-02 [ci skip]
-
- This new page would be linked from method strftime in Time, Date, and DateTime, replacing the text there.
-
- ioquatix (Samuel Williams) wrote in #note-21:
> ```ruby
> ...
What is the rule behind what the argument represents? To me, your four examples except for the first one seem to suggest:
1. The nesting levels (achieved by separating the fu... -
- @tenderlovemaking what about some kind of "uplevel" concept for name:
```ruby
class A::B::C::MyClass; end
A::B::C::MyClass.name(0) # -> "MyClass"
A::B::C::MyClass.name(1) # -> "C::MyClass"
A::B::C::MyClass.name(-1) # -> "A::B::C... -
-
- Actually, `NEED_NEWLINE_DECORATOR_ON_READ_CHECK()` and `do_writeconv()` set `O_TEXT` or `O_BINARY` always on each I/O.
-
- alanwu (Alan Wu) wrote in #note-9:
> So potentially, someone could use Fiddle or some C extension
> ...
You mean we should use `O_TEXT` explicitly when calling `_wopen`? - 06:53 AM Revision 3124422b (git): Update bundled gems list at e0c6e288f0fe4c285dd4e16283835f [ci skip]
-
06:53 AM Revision e0c6e288 (git): Specify RBS commit hash to fix test failure on test-bundled-gems (#6082)
- Update RBS to v2.6.0 and specify RBS commit hash to fix test failure on test-bundled-gems
-
-
06/30/2022
-
09:20 PM Bug #18794: Windows - intermittent SEGV TestObjSpace#test_reachable_objects_during_iteration
- This test is still causing intermittent failures. I tried it locally, and (of course) it did not SEGV.
I modified the test as below:
test/objspacetest_objspace.rb
Original:
```ruby
def test_reachable_objects_during_iteration
opts =... -
09:14 PM Misc #18888: Migrate ruby-lang.org mail services to Google Domains and Google Workspace
- Thanks for the information.
We are not going to use Google Domains to send emails, but we may reconsider it. -
- Not sure if this applies to your situation, but a very quick warning based on my own experience: we use a Google Domains email address to send a fairly low volume of transactional emails, and that's enough to trigger Google's automated f...
-
- Currently mail services of ruby-lang.org including mailing lists are running on an aged server, and we have to replace it.
We are planning to migrate the mail services to Google Domains and Google Workspace (Google Groups).
The maxim... -
04:45 PM Revision 5df20a5d (git): stop CI failures.
- 302f353fd9223d020e48495eaa7a03ce5d539409 seems break the rubyspec.
@nobu please check it. - 03:52 PM Revision 51d3035d (git): * 2022-07-01 [ci skip]
-
- https://github.com/ruby/stringio/commit/16847fea32
-
02:54 PM Bug #18889 (Third Party's Issue): Segmentation fault in sequel/adapters/odbc.rb
- This isn't a Ruby bug, or a Sequel bug, the crash is in `libiodbc.2.dylib` according to the backtrace. You probably want to report the bug to the ODBC provider.
-
11:53 AM Bug #18889 (Third Party's Issue): Segmentation fault in sequel/adapters/odbc.rb
- https://github.com/jeremyevans/sequel/issues/1888
It appeared after upgrade the OS to
Darwin 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:29 PDT 2022; root:xnu-8020.121.3~4/RELEASE_ARM64_T8101 x86_64 - 02:26 PM Revision b6f6fc6e (git): YJIT: Refactor gen_opt_mod (#6078)
- Refactor gen_opt_mod in YJIT
- 02:24 PM Revision 2366e149 (git): YJIT: Handle 0 total_exits YJIT Status Display (#6079)
- handle case in YJIT stats where 0 exits causes NaN in the display
-
01:20 PM Misc #18691: An option to build Ruby with build only flags not propagated to `rbconfig.rb`.
- I just renamed this ticket's title from "An option to run `make rbconfig.rb` in a different directory" to "An option to build Ruby with build only flags not propagated to `rbconfig.rb`". It describes this ticket better.
-
- nobu (Nobuyoshi Nakada) wrote in #note-12:
> jaruga (Jun Aruga) wrote in #note-10:
> ...
I see. The ruby/ruby source `753da6deca34eb7d5d61a26cf66b014ad77ad51d` I tested includes the commit <https://github.com/ruby/ruby/commit/5c1b76a3a... -
10:58 AM Feature #18814: Ractor: add method to query incoming message queue size
I created a PR for this issue: https://github.com/ruby/ruby/pull/5973-
10:49 AM Feature #17679: Ractor incoming channel can consume unlimited resources
- Thanks @phigrofi for the hint! Definitely looks like an interesting way out of this.
-
- I created a different issue, which would help to query to incoming queue size from outside of a ractor: https://bugs.ruby-lang.org/issues/18814
Maybe this could help you. -
- https://github.com/rubygems/rubygems/commit/b1826876d0
-
09:53 AM Revision 8eb5198c (git): [rubygems/rubygems] Prevent a warning: `*' interpreted as argument prefix
- http://rubyci.s3.amazonaws.com/ubuntu2004-arm/ruby-master/log/20220630T063003Z.log.html.gz
```
[19606/21662] TestAst#test_not_cared:test/rubygems/test_gem_ext_cargo_builder/custom_name/build.rb(none):18: warning: `*' interpreted as argum... -
- Another possible optimization I just found:
Strings have a lazily computed `coderange` attribute in their flags. So if a string is allocated at boot, but only used after fork, its coderange may be computed and the string mutated.
U... -
- Statically determined value should be set statically.
-
-
- Applied in changeset commit:git|982cda9a3e908c7ab49632c46f4b1e3c0219f9f2.
----------
[Bug #18877] Let `lex_ctxt` not to eat escaped whitespace -
-
-
- If `XDG_RUNTIME_DIR` is available, test-bundled-gems fails with
old debug.gem tests. -
- * [Misc #18888] Migrate ruby-lang.org mail services to Google Domains and Google Workspace
* We are planning to migrate the mail services to Google Domains and Google Workspace (Google Groups).
* The maximum numbr of Google Dom... -
-
- This allows us to delete the disassembly code path for reference
updating.
06/29/2022
-
- This function shouldn't leak and is only needed during instruction
assembly -
- We need to dump relative offsets for inline storage entries so that
loading iseqs as an array works as well. This commit also has some
minor refactoring to make computing relative ISE information easier.
This should fix the iseq dump /... -
-
- https://github.com/rubygems/rubygems/commit/3f83236c02
- 04:49 PM Revision 118e3edc (git): Add a check-yjit-bindgen-unused target. Add to CI. (#6066)
- This fails if there are any unused rust-bindgen "allow" entries. For
that target we turn on Rust warnings (there are a lot) and grep for the
ones that correspond to unused allow entries.
I've added check-yjit-bindgen-unused as a depende... - 03:40 PM Revision b340d566 (git): * 2022-06-30 [ci skip]
-
12:26 PM Bug #18881: IO#read_nonblock raises IOError when called following buffered character IO
- There needs to be documentation to cover the corner cases no matter what. Wouldn't it be better to document the current behavior rather than add artificial limitations?
For what it's worth, I was able to reproduce the reported behavior... -
- Basically yes. Some edge cases can be considered though (e.g. IO#flush could also reset this, IO#pread could be special-case allowed (avoiding IO#seek is the reason for this method to exist), etc).
-
- Do you mean that once character oriented methods are called, all byte oriented methods always fail?
(Possibly reset by `seek`?) -
- nobu (Nobuyoshi Nakada) wrote in #note-4:
> @shyouhei Even without any conversion?
Yes. "Byte oriented and character oriented IO operations cannot be mixed at all" sounds much simpler than the current (it sometimes raises and someti... -
- @shyouhei Even without any conversion?
This is an example on macOS.
```shell
$ ruby -v -e 'r, w = IO.pipe; r.set_encoding("utf-8", "iso-8859-15"); w.write("foobar"); c = r.getc; r.ungetc(c); r.read_nonblock(3)'
ruby 3.2.0dev (2022-... -
- @nobu Yes but wouldn't it be nice if IO#read_nonblock also raises on Linux?
-
- It is an expected behavior.
On Windows, text/binary conversion is used by default, and `ungetc` pushes back the character to the conversion buffer in that case.
The error message means this situation. -
-
- jaruga (Jun Aruga) wrote in #note-10:
> I tested. And I see that the `make install` also needs the `ARCH_FLAG` to build some native extension gems.
> ...
That is because extension libraries in the bundled gems are deferred building unt... -
- I think it is correct before the change.
Which is correct?
https://github.com/ruby/ruby/commit/962a3247b1b76770930200bcce7470a54dfb25c9
-
- With some minor changes the best performance I could get is around 20% cost:
```
| |compare-ruby|built-ruby|
|:----------------------|-----------:|---------:|
|vm_struct_big_aref_hi | 149.051M| 121.849M|
... -
- Here is my performance comparison:
Firstly, with no changes (should be identical, shows some variance).
```
> make benchmark ITEM=vm_struct COMPARE_RUBY=(which ruby)
/home/samuel/.rubies/ruby-head/bin/ruby --disable=gems -rrubyge... -
- Given the following program, `thing.name` and `thing.shape` don't trigger `c_call` trace points (or any trace points actually).
```ruby
pp RUBY_VERSION
trace_point = TracePoint.new(:line, :call, :c_call, :a_call) do |trace|
put... -
- Applied in changeset commit:git|685efac05983dee44ce2d96c24f2fcb96a0aebe2.
----------
[Bug #18884] `class` cannot be just followed by modifiers -
-
-
01:03 AM Misc #18834: Significant change in loop speeds (regressing using while loop on ARM chips)
- Attached are both the Intel and ARM rbconfigs.
**Note:** both have the ruby version installed through ASDF and running the same ruby versions side-by-side.
-
12:53 AM Revision 3051d4bc (git): [rubygems/rubygems] Support ruby 2.3 and 2.4
- https://github.com/rubygems/rubygems/commit/3a9205df36
-
- https://github.com/rubygems/rubygems/commit/c9adf3ef1c