@MSP-Greg Can you figure out which commit caused this issue? I tried looking for commits before commit:631c01f5ae, but I was not able to find a likely culprit.jeremyevans0 (Jeremy Evans)
nobu (Nobuyoshi Nakada) wrote in #note-2: > I think it can be fixed by removing the optimization in the parser and leaving it to the compiler. I tried the approach of removing the optimization from the parser completely (https://gith...jeremyevans0 (Jeremy Evans)
- [Feature #10917] Add `GC.stat[:total_time]` when GC profiling enabled - @ko1 did submit a pull request which seem fine except maybe for 32bits support. - @ko1 did also measure the overhead and it appeared small. - Could this feat...byroot (Jean Boussier)
I think it's debatable which is the most common usage of `FileUtils.mkdir_p`, but even assuming the most common use case is creating a folder when it doesn't previously exist but the parent does, this optimization doesn't seem to have a ...deivid (David Rodríguez)
Doing it this way is simpler and it doesn't end up adding "/" to the list of folders, so it doesn't need to be removed later. https://github.com/ruby/fileutils/commit/df08e124cedeivid (David Rodríguez)
Now `$LOADED_FEATURES` list is being maintained by `setup` and `teardown` and, only libaries under the temporary directory will be removed. As `save_loaded_features` removes the rest libraries other than this test directory, ordinary li...nobu (Nobuyoshi Nakada)
I looked into fixing this by removing the define of `USE_MONOMANIAC_CHECK_CAPTURES_IN_ENDLESS_REPEAT`, as @mame indicated: https://github.com/ruby/ruby/commit/018922ba15eb7aea86957789d7defae9ffc43688 It ends up breaking a few specs. ...jeremyevans0 (Jeremy Evans)
I submitted a pull request to fix this: https://github.com/ruby/ruby/pull/4960 The issue is unlikely to be specific to the absence operator, I think it affects any case where a regexp takes a long time due to backtracking. In additio...jeremyevans0 (Jeremy Evans)
This method always receives an array, and we require `shellwords` unconditionally at the top of the file, so `shelljoin` will always be available. https://github.com/rubygems/rubygems/commit/05c8ac641ddeivid (David Rodríguez)
Previously they were printing the original command that was run, and telling the user to rerun it. However, the command sometimes would not match the exact command that was run (for example, when using the `--local` flag), and in any cas...deivid (David Rodríguez)
In case we have a corrupted lockfile that claims to support a platform, but it's missing platform specific gems for it, bundler has a check that detects the situation and forces a re-resolve. The result of this check is kept under the `@...deivid (David Rodríguez)
It doesn't really need converged specs, since it's only about the lockfile. https://github.com/rubygems/rubygems/commit/9cd6224b5edeivid (David Rodríguez)
Since #18011 was fixed it seems unlikely to change again. Regarding detection, in the light of https://github.com/ruby/ruby/pull/4961 it seems best to detect `(...)` via `parameters.include?([:block, :&])`.Eregon (Benoit Daloze)
This reverts commit 10d2341640c57544ca81bd21cfa60a6aff015692. TravisCI clones the head of the target branch, and it may not be the target commit at that time.nobu (Nobuyoshi Nakada)
The other way, in particular matching a substring in the gemspec summary, is brittle and no longer used since Ruby 2.0. This needed rewriting the specs that depended on that way. https://github.com/rubygems/rubygems/commit/059dbfa971deivid (David Rodríguez)
The spec was just faking an installed gemspec without any installed gem backing it up, resulting in `bundle install` claiming that the gem was already installed when it was not. https://github.com/rubygems/rubygems/commit/c35531d1c7deivid (David Rodríguez)
For interests sake, I've put together a short patch that implements option 2: Reinstating the old behaviour of returning false only when the range has `nil` at the beginning and the end. All other behaviour should remain the same.eightbitraptor (Matt V-H)
The following code breaks with a strange error: ```ruby def foo(*); ->{ super };end Ractor.make_shareable(foo) # expected Symbol ``` Output: ``` [aaron@tc ~/g/ruby (master)]$ cat test.rb def foo(*); ->{ super };end R...tenderlovemaking (Aaron Patterson)
The history indicates the current behavior is expected, and I agree. Globbing inside double quotes is not done by Linux/Unix shells, but is done on Windows: ``` C:\Users\jeremye>dir /b D* Desktop Documents Downloads C:\Users\j...jeremyevans0 (Jeremy Evans)
naruse (Yui NARUSE) wrote in #note-3: > > * Stale Feature Requests can be closed > ... Note that this isn't an autoclose (I really hate autoclose). With autoclose, there is no judgment involved from a committer. In both the bug triagi...jeremyevans0 (Jeremy Evans)
> * Already Implemented Feature Requests should be closed > ... I agree these. I think those principle are right and it follow the current operation. > * Stale Feature Requests can be closed I'm unclear about this. I know some OS...naruse (Yui NARUSE)
Thank you always for your continuous and great contribution, I really appreciate it. I read the guide draft. I understand that the two new things are as follows: * We can close a three-month stale feature request after a committer ...mame (Yusuke Endoh)
+1 It would be good to cut down on stale feature requests, and the recommendations in the draft are all very reasonable. I want to point out that I've made a number of feature requests that I would probably close myself if I had the ...Dan0042 (Daniel DeLorme)
The gem and bundle commands first load digest via openssl, so loading the digest gem would cause this warning every time one of these commands is run: ``` .../lib/ruby/gems/3.0.0/gems/digest-3.1.0/lib/digest.rb:11: warning: already init...Akinori MUSHA
* [Misc #18248] Add Feature Triaging Guide (jeremyevans0) * Is it OK to add a feature triaging guide and start using it triage feature requests? * [Bug #18066] Load did_you_mean/error_highlight even with --disable-gems (jeremyevans0) ...jeremyevans0 (Jeremy Evans)
In fact, it even conflicts with the next release's ABI version: ``` $ ruby -ve 'p RbConfig::CONFIG["ruby_version"]' ruby 3.1.0dev (2021-10-11T10:13:16Z master 0c3ac87345) [x86_64-linux] "3.1.0" ``` This mismatch can very easily r...Eregon (Benoit Daloze)
I think making `$?` Fiber-local makes sense, and unlikely to break anything. I don't see the need to deprecate `$?`, and it's certainly not worth the cost to migrate existing code to some other way to the get the status.Eregon (Benoit Daloze)
Ruby added a bug triaging guide in June 2019, and since then I've used it to reduce the number of open bugs in the tracker from over 1400 to about 300. Ruby currently has over 1200 open feature requests on the issue tracker. From a curs...jeremyevans0 (Jeremy Evans)
If a non exact name (matched as a regexp) is passed to `bundle info`, these strings might not match. https://github.com/rubygems/rubygems/commit/831edf1edfdeivid (David Rodríguez)
This reverts commit 27dd2867cda5c789efaa5078214ad2fd82adcebf. This is to fix the test I added. (I separated commits to test a new behavior of ruby-commit-hook) https://github.com/ruby/irb/commit/fe055d521ak0kubun (Takashi Kokubun)
include? should return false if comparing an IPv4 address to an IPv6 address. ipv4_mapped needs to set the correct netmask on the mapped addresses. https://github.com/ruby/ipaddr/commit/da22ef8e6cjeremyevans (Jeremy Evans)
It would be nice to use Range#cover? here, but it doesn't work correctly before Ruby 2.6. Switch to manual checks of the beginning of end of the ranges. Fixes Ruby Bug 14119 https://github.com/ruby/ipaddr/commit/f45630da31jeremyevans (Jeremy Evans)
If we explicitly disallow the creation of symlinks that point to files outside of the destination directory, we can avoid any other safety checks while creating directories, because we can be sure they will always fall under the destinat...deivid (David Rodríguez)
* Separate exception classes to be rescued or reraised * Use the filtered backtrace in the failure message * Raise a new `AssertionFailedError` with the original backtracenobu (Nobuyoshi Nakada)
@nobu I built your PR branch and confirmed that this new parsing works great with the `driver.rb` attached. Will this patch have to wait for the 3.1.0 release? Sorry I'm not sure how the whole patching and backporting processes work. ...danh337 (Dan H)
Avoid race condition in Regexp#match In certain conditions, Regexp#match could return a MatchData with missing captures. This seems to require at the least, multiple threads calling a method that calls the same ...nagachika (Tomoyuki Chikanaga)
Fix the encoding of loaded feature names [Bug #18191] The feature names loaded from the default load paths should also be in the file system encoding. --- ruby.c | 12 +++++++++++- ...nagachika (Tomoyuki Chikanaga)
Marshal.load: do not call the proc until strings have their encoding Ref: https://bugs.ruby-lang.org/issues/18141 --- marshal.c | 7 +++- spec/ruby/core/marshal/shared/load.r...nagachika (Tomoyuki Chikanaga)
In 2021, Ruby 2.5 and older are EOL. We can set the default required Ruby version to 2.6.0 to encourage people to use newer Ruby. If the command is executed with old Ruby, it falls back to 2.3.0. It's still possible to create a gem for o...okuramasafumi (Masafumi OKURA)
Unless the `:branch` option is passed. It's more efficient, and it results in less hardcoding of "master". https://github.com/rubygems/rubygems/commit/aa5c3409abdeivid (David Rodríguez)
This doesn't affect the outcome of the test, but it makes the `git commit` command inside `update_git` not fail because of not having anything to commit. https://github.com/rubygems/rubygems/commit/ad0160ed97deivid (David Rodríguez)
We want to update the original repo, not a fresh one. This went undetected because the `git commit` command inside the `update_git` method ignores failures, and in this case it was failing because all files are untracked in the new repo...deivid (David Rodríguez)
The glob information was not specified in the string representation for a source, which led to non-deterministic behaviour when generating the lockfile, since sources are sorted by this value. https://github.com/rubygems/rubygems/commit...gabriele renzi
Applied in changeset commit:git|06c3e80611b81ec8f251957328486e9b6dd18d3b. ---------- Do not allow configuration where neither static or shared library is installed Fixes [Bug #18000]jeremyevans (Jeremy Evans)
Applied in changeset commit:git|08759edea8fb75d46c3e75217e6613465426a0d2. ---------- Remove autoload for constant if the autoload fails Previously, if an autoload failed (the file was loaded, but the constant was not defined by the aut...jeremyevans (Jeremy Evans)
Previously, if an autoload failed (the file was loaded, but the constant was not defined by the autoloaded file). Ruby will try to autoload again if you delete the autoloaded file from $LOADED_FEATURES. With this change, the autoload an...jeremyevans (Jeremy Evans)
There are weird results for `Array#slice` or `Array#[]` with argument of type `Enumerator::ArithmeticSequence`. Particularly most results with negative steps are weird. For example: ```ruby @array = [0, 1, 2, 3, 4, 5] @array.sl...lxxxvi (Mario Schüttel)
Glad to have helped :) And I am sorry if my reply sounded harsh. I think we can close this, I'll let @nobu decide. Although I'm not against nobu's patch, I think it is reasonably expected behavior when using `$stderr.sync = false`.Eregon (Benoit Daloze)
>I believe the real issue here is to $stderr.sync = false, why do you do that? > ... Having buffered `$stdout` I thought that `$stderr.sync = false` will make `$stderr` to be in sync with `$stdout`. Now I understand that it was not the ...inversion (Yura Babak)
jeremyevans0 (Jeremy Evans) wrote in #note-7: > @duerst Do you know if this is still in issue in the master branch? - I suspect it is still "an issue", i.e. it still happens. - Nobody has complained about it, and so it may be that i...duerst (Martin Dürst)
Also, check if a suffix is empty, to guarantee the assumption of `onigenc_get_left_adjust_char_head` that `*s` is always accessible, even in the case of `SHARABLE_MIDDLE_SUBSTRING`.nobu (Nobuyoshi Nakada)
Previous fix didn't show the cursor or dialogs. This allows the dialogs to continue to work. https://github.com/ruby/reline/commit/651c5f63ccjeremyevans (Jeremy Evans)
Fixes a crash in IRB if a dialog is displayed and the default external encoding is not UTF-8: /home/jeremy/tmp/reline/lib/reline/line_editor.rb:731:in `write': U+2588 from UTF-8 to US-ASCII (Encoding::UndefinedConversionError) https://...jeremyevans (Jeremy Evans)
10:56 PM Bug #16953 (Feedback): Windows bash bin files removed in master
03:40 PM Feature #17760: Where we should install a header file when `gem install --user`?
02:44 PM Revision e057b9ee (git): Prefer the reentrant versions of gmtime and localtime
02:35 PM Misc #18174: DevelopersMeeting20211021Japan
02:17 PM Revision fc9f9231 (git): Update bundled_gems
12:15 PM Revision 2fa0d51a (git): [ruby/date] Bump up date version to 3.2.0
06:05 AM Revision 724c6577 (git): Remove repeated 'the' (#4966)
12:12 AM Revision fa12e3e2 (git): [ruby/fileutils] Remove counterproductive optimization
06:41 AM Bug #18155: (nil..nil).cover?(x) is true for all x since beginless ranges were introduced
11:43 PM Bug #18250 (Closed): Anonymous variables seem to break `Ractor.make_shareable`
09:33 PM Revision 5c646ca0 (git): [ruby/irb] Ignore parenthesis during completion
02:52 AM Misc #18248: Add Feature Triaging Guide
02:04 AM Misc #18248: Add Feature Triaging Guide
01:56 AM Misc #18248: Add Feature Triaging Guide
01:06 PM Revision bb66729b (git): Enhanced RDoc for Numeric#% (#4954)
12:34 PM Revision e212d051 (git): [ruby/reline] Rescue LoadError to require 'fiddle'
06:49 AM Revision b5f0e209 (git): Add comments in sync_default_gems.rb
04:50 AM Revision 391d6ab4 (git): [ruby/ipaddr] Fix include? and ipv4_mapped to allow drb tests to pass
02:40 AM Revision afb95d10 (git): Refactor sym_step_i function
02:40 AM Feature #18242: Parser makes multiple assignment sad in confusing way
06:38 AM Bug #17507: Regexp capture groups ignored sometimes in some multithreaded environments (possible race condition)
12:07 AM Revision 7e506716 (git): Newly generated gems require Ruby 2.6.0
11:04 PM Revision d03d122b (git): [rubygems/rubygems] Improve performance of Specification#missing_extensions?
03:38 PM Bug #18247 (Closed): weird results for `Array#slice` or `Array#[]` with argument of type `Enumerator::ArithmeticSequence`
05:57 AM Bug #18244: Unexpected errors output order
06:40 AM Bug #10416: Create mechanism for updating of Unicode data files downstreams when we want
12:59 AM Bug #18245 (Third Party's Issue): CSV Parser, buffer overflow issue with very specific data