Activity
From 08/04/2021 to 08/10/2021
08/10/2021
-
11:49 PM Bug #18066: Load did_you_mean/error_highlight even with --disable-gems
- I'm not sure how strongly this is related (and I'll create a new issue if necessary), but when I use a very simple script such as `ruby -e 'puts 3+4'`, I get the following output:
```
`RubyGems' were not loaded.
`error_highlight' wa... -
07:22 PM Bug #18066: Load did_you_mean/error_highlight even with --disable-gems
- I think this change makes sense. It requires quite a few test changes, though. I submitted a pull request to implement it: https://github.com/ruby/ruby/pull/4729
-
11:00 PM Bug #12540: test failures when SHARABLE_MIDDLE_SUBSTRING=1
- I think this was caused by commit:a707ab4bc8a29241440f56696098efa2f7f3ff45, which removed the term filling if SHARABLE_MIDDLE_SUBSTRING was enabled. I submitted a pull request that basically reverts that commit: https://github.com/ruby/r...
-
07:11 PM Feature #18035: Introduce general model/semantic for immutability.
- Many things discussed in the description here.
I think it's important to differentiate shallow frozen (`Kernel#frozen?`) and deep frozen (= immutable), and not try to change their meaning.
So for example overriding freeze to deep fre... -
06:33 PM Bug #18062: Ruby with enabled LTO segfaults during build
- I identified which compiler flags make this error, segmentation fault. I tested it on the latest master commit:28d03ee776af4d630556fcaad7305340cbcf9cde . I think this info helps for developers to reproduce this error on their machine.
M... -
08:54 AM Bug #18062: Ruby with enabled LTO segfaults during build
- nobu (Nobuyoshi Nakada) wrote in #note-13:
> That patch seems fine
Thx for confirmation
> ...
If would definitely make my life easier, but nobody have requested the backport of #17553 yet and I have not met the issue myself. For t... -
02:31 AM Bug #18062: Ruby with enabled LTO segfaults during build
- That patch seems fine, but maybe commit:f4ce78d5c139 and commit:9c769575bfa2 also need to be backported.
-
02:40 PM Revision c3964a31 (git): Assert for duplicated ARGF [Bug #18074]
-
02:40 PM Revision 7de7e9fd (git): Assert that each contents are read [Bug #18074]
-
10:54 AM Bug #18073: test/ruby/test_jit.rb: "error: invalid use of '__builtin_va_arg_pack ()'" on Ruby 2.7.4 on gcc 4.8.5
- > This commit is for configure only.
> ...
I did ssh login to RubyCI CentOS7 server, and checked the files between commits `fd95a18059` (previous commit for `29bbad9399`) and `29bbad9399` (first failure),
```
config.status
./.ext/i... -
10:03 AM Bug #18073: test/ruby/test_jit.rb: "error: invalid use of '__builtin_va_arg_pack ()'" on Ruby 2.7.4 on gcc 4.8.5
- jaruga (Jun Aruga) wrote in #note-4:
> I executed `git bisect` between `v2_7_3` and `v2_7_4`. And I found the following commit causes these test failures.
> ...
This commit is for configure only.
How the results of `configure` (config... -
09:02 AM Bug #18073: test/ruby/test_jit.rb: "error: invalid use of '__builtin_va_arg_pack ()'" on Ruby 2.7.4 on gcc 4.8.5
- I executed `git bisect` between `v2_7_3` and `v2_7_4`. And I found the following commit causes these test failures.
Fix 2.7 build
https://github.com/ruby/ruby/commit/29bbad939939c6dceb804aac667ba372fdee4ef5
---
I checked like t... -
07:28 AM Bug #18073: test/ruby/test_jit.rb: "error: invalid use of '__builtin_va_arg_pack ()'" on Ruby 2.7.4 on gcc 4.8.5
- I confirmed this failures are reproduced at RubyCI - CentOS 7.6(1810) x86_64 - 2.7 case.
http://rubyci.s3.amazonaws.com/centos7/ruby-2.7/log/20210810T041843Z.fail.html.gz
-
10:08 AM Revision 28d03ee7 (git): Remove root_jmpbuf in rb_thread_struct
- It has not been used since 1b82c877dfa72e8505ded149fd0e3ba956529d3f.
-
07:40 AM Bug #18072: Build error with "./configure --enable-shared"
- Thanks for the fix! I confirmed I was able to build on the latest master.
-
05:23 AM Bug #18072 (Closed): Build error with "./configure --enable-shared"
- Applied in changeset commit:git|e3dcb6204d66c62aedaf94cac336d93d0275ce2c.
----------
Run only directories or *_spec.rb files only by mspec [Bug #18072]
Not to match *.c files under spec/ruby/optional/capi/ext, in the
case of in-place b... -
02:53 AM Bug #18072: Build error with "./configure --enable-shared"
- jaruga (Jun Aruga) wrote:
> ```
> ...
The target at defs/gmake.mk:359 is `spec/%`, seems miss-firing `*.c` files.
I've missed the in-place build case.
Eregon (Benoit Daloze) wrote in #note-2:
> @nobu What's the reason to build C A... -
06:47 AM Revision 42b6dc84 (git): add some lines to delete unused TracePoint
- `TracePoint.stat` returns the "to be deleted" TP numbers, and
http://rubyci.s3.amazonaws.com/graviton2/ruby-master/log/20210810T030003Z.fail.html.gz
shows there is a "to be deleted" TP.
This patch uses only :line event and add some line... -
05:33 AM Feature #18069: `instance_exec` is just ignored when the block is originally a method
- A method is bound to the internal states of the receiver.
I don't think that removing the receiver from a method makes sense. -
05:22 AM Revision e3dcb620 (git): Run only directories or *_spec.rb files only by mspec [Bug #18072]
- Not to match *.c files under spec/ruby/optional/capi/ext, in the
case of in-place build. -
02:33 AM Bug #18074 (Closed): ARGF.read(length) exhibits short rea - Applied in changeset commit:git|8df1ace64a7695c855bf0a774e3fd70edfab0bf3.
----------
Fix ARGF.read(length) short read [Bug #18074] - 02:32 AM Revision 8df1ace6 (git): Fix ARGF.read(length) short read [Bug #18074]
-
12:24 AM Revision 510c3655 (git): .github/workflows/compilers.yml: clang-14
- It seems LLVM-14 begun.
See also
https://github.com/llvm/llvm-project/commit/08c766a7318ab37bf1d77e0c683cd3b00e700877
08/09/2021
-
11:28 PM Bug #18074: ARGF.read(length) exhibits short rea
- Proposed fix: https://github.com/ruby/ruby/pull/4727
-
11:21 PM Bug #18074: ARGF.read(length) exhibits short rea
- It was commit [4f5976c](https://github.com/ruby/ruby/commit/4f5976cbb826df462c62a0a8e72ebe91c15a7ba4) that introduced this bug:
```
commit 4f5976cbb826df462c62a0a8e72ebe91c15a7ba4
Author: matz <matz@b2dd03c8-39d4-4d8f-98ff-823fe69b0... -
11:20 PM Bug #18074: ARGF.read(length) exhibits short rea
- [`argf_read`](https://github.com/ruby/ruby/blob/v3_0_2/io.c#L12307-L12351) pseudocodized:
``` c
/* 1 */ argf_read(VALUE length)
/* 2 */ {
/* 3 */ long len = NUM2LONG(length);
/* 4 */ VALUE str = StringValue();
/* 5 */ retry:
/* ... -
11:18 PM Bug #18074 (Closed): ARGF.read(length) exhibits short rea
- If ruby is invoked with three file name arguments (which refer to extant non-empty regular files), and `ARFG.read` is called with a length argument that exceeds the combined size of the first two files[1], then only the content of the fi...
-
09:22 PM Bug #18072: Build error with "./configure --enable-shared"
- @nobu What's the reason to build C API specs extensions eagerly?
Can't we let ruby/spec build them at runtime as normal? -
04:02 PM Bug #18072: Build error with "./configure --enable-shared"
- I see the build error happens on the following commit. While it works on the previous commit. Maybe the commit causes the build error. Do you have any idea to fix it?
Build rubyspec CAPI extensions
https://github.com/ruby/ruby/commit... -
03:48 PM Bug #18072 (Closed): Build error with "./configure --enable-shared"
- I just hit the build error by `make` on my machine Fedora 34 on the latest master 9ed196e4876dd15991feee27e7dce1b67783060f .
```
$ cat /etc/fedora-release
Fedora release 34 (Thirty Four)
$ rpm -q gcc
gcc-11.2.1-1.fc34.x86_64
$ g... - 08:32 PM Revision 6771316d (git): .travis.yml: Check failures for Travis arm64 again.
- It seems the concurrent jobs are stable recently on arm64 pipeline.
Keep allowing to fail on arm32 due to a failure. -
07:56 PM Misc #18039: DevelopersMeeting20210819Japan
- * [Bug #18036] Pthread fibers become invalid on fork - different from normal fibers. (jeremyevans0)
* `fork` terminates other threads.
* When using pthread coroutine, all fibers are threads, therefore `fork` terminates all other fi... -
07:40 PM Bug #15404: Endless range has inconsistent chaining behaviour
- I don't think we should make a range of literal ranges a parse error. While a range of ranges is not useful by default, a developer could define `Range#<=>` and `Range#succ` such that a range of ranges could be useful:
```ruby
class... -
07:00 PM Feature #18069: `instance_exec` is just ignored when the block is originally a method
- I don't think the current behavior is a bug. `Method#to_proc` is currently equivalent to:
```ruby
class Method
def to_proc
method = self
->(*args, **kwargs, &block) do
method.call(*args, **kwargs, &block)
end... -
05:58 PM Bug #18073 (Closed): test/ruby/test_jit.rb: "error: invalid use of '__builtin_va_arg_pack ()'" on Ruby 2.7.4 on gcc 4.8.5
- I hit the following JIT test failures causing the following error on v2_7_4 tag (Ruby 2.7.4) with gcc 4.8.5 on RHEL 7. The tests work on Ruby 2.7.3 and also works on Ruby 3.0.2.
```
/mnt/git/ruby/ruby/.ext/include/x86_64-linux/rb_mji... -
05:57 PM Bug #18067: Composite procs with `instance_exec` aren't executed within the context of the receiver
- I think this is expected. You get the same error if you compose the proc manually, and the proc composition operators should reflect the same behavior as manual composition:
```ruby
func1 = -> (x) { x + y }
class A
def y
... -
05:52 PM Revision cc1d88da (git): Add comment about I/O that is not tty
- 05:38 PM Revision 71c20c56 (git): * 2021-08-10 [ci skip]
-
05:36 PM Revision b8f771fb (git): Update parser files of RDoc generated by the latest Racc
-
05:36 PM Revision 44635ebe (git): Update parser files of RDoc generated by the latest KPeg
-
05:36 PM Revision 6b439e9c (git): [ruby/rdoc] Use HEAD of kpeg
- I compared the results between the latest release of kpeg gem (1.1.0)
and HEAD of kpeg gem with `time` command, and the execution time is
reduced from 38.35s sec to 35.06 sec.
ref. https://github.com/evanphx/kpeg/pull/43
https://github... -
05:36 PM Revision d0825104 (git): [ruby/rdoc] Add "rake clean" task to erase generated parser files
- https://github.com/ruby/rdoc/commit/4e3e635afa
-
05:36 PM Revision b277a6d2 (git): Import copied Rakefile from original RDoc repository
-
05:36 PM Revision d8eeee97 (git): [ruby/rdoc] Move dev dependency of gettext to Gemfile
- https://github.com/ruby/rdoc/commit/a177377b6f
-
05:36 PM Revision 638c72e1 (git): [ruby/rdoc] Use single quote in Gemfile
- https://github.com/ruby/rdoc/commit/e4b68d414c
-
05:36 PM Revision b685c60b (git): Import copied Gemfile from original RDoc repository
-
05:36 PM Revision ef6dd407 (git): Import Gemfile and Rakefile of rdoc by tool/sync_default_gems.rb
-
05:19 PM Bug #18071: Bug in ruby interpreter or extension library
- I believe that this is the same issue as #17862, #17922, #17988, and https://github.com/typhoeus/ethon/issues/193.
-
03:25 PM Bug #18071 (Third Party's Issue): Bug in ruby interpreter or extension library
-
11:26 AM Bug #18071: Bug in ruby interpreter or extension library
- The backtrace shows the crash happens in the `ethon` gem (calling FFI functions), so it's very likely to be a third party bug, and should be reported there: https://github.com/typhoeus/ethon
-
11:19 AM Bug #18071 (Third Party's Issue): Bug in ruby interpreter or extension library
- ecofoote@Matthews-Mac-mini ios % pod install
Adding a custom script phase for Pod RNFBApp: [RNFB] Core Configuration
Auto-linking React Native modules for target `EcoFoote`: RNCAsyncStorage, RNCMaskedView, RNDateTimePicker, RNFBApp... -
04:34 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- > Thanks for the patch! Let me check it.
> ...
I tried the 2nd patch on an older master commit 1cb5a669d39fe741388be7ac45fc88c336b097cf , as I couldn't build on the latest master commit due to #18072 . But I still see similar or same re... -
02:58 PM Feature #10917: Add GC.stat[:total_time] when GC profiling enabled
- > That patch contains too many unrelated changes.
You mean mine? Or the original one?
If mine, most of the diff is because I renamed a bunch of `gc_prof_*` in just `gc_*` as they are no longer `GC::Profiler` specific. Also the link... -
02:09 PM Feature #10917: Add GC.stat[:total_time] when GC profiling enabled
- That patch contains too many unrelated changes.
And my concern is if `:time` is clear enough. Can you tell its unit by that name? -
10:53 AM Bug #16492: TestBugReporter#test_bug_reporter_add test failures
- I would just share my update for this ticket. I wanted to check this ticket after fixing another issue #18002 that is needed to print the result of the Ubuntu s390x on [rubyci.org](https://rubyci.org/). However I may check it in parallel...
-
10:33 AM Bug #17052: Ruby with LTO enabled has issues with SIGSEGV handler
- And it seems that the DWARF is in better shape:
~~~
$ nm ./miniruby | grep -w rb_f_kill
00000000001ddcf0 T rb_f_kill
000000000002bd88 t rb_f_kill.cold
$ nm ./miniruby | grep -w rb_f_kill | addr2line -e ./miniruby
/builddir/buil... -
10:22 AM Bug #17052: Ruby with LTO enabled has issues with SIGSEGV handler
- This is still unresolved :(
-
10:25 AM Revision 9ed196e4 (git): VC warns the same attribute used more than once
-
10:25 AM Revision b8f7e8ac (git): Include ruby.h before internal headers to suppress -Wundef warnings
-
10:23 AM Bug #18062: Ruby with enabled LTO segfaults during build
- Unfortunately, testing on other arches, the #17052 is still an issue :(
-
09:44 AM Bug #18062: Ruby with enabled LTO segfaults during build
- Testing with Ruby 3.0.2, I had to modify the patch slightly and I was able to build the Ruby as well as pass test suite. However, I'd like if you can review the modifications I did for Ruby 3.0.2 in the vm_method.c hunks (I have replaced...
-
09:17 AM Revision 5e633fb9 (git): Omit on Readline 7.0 because it's wrong behaviour for not TTY env
-
08:36 AM Revision 93ddff48 (git): Rename rb_iterate to get rid of name clash on Sun C
- 05:03 AM Revision 6f6a84f2 (git): Extended logging for debugging readline failures.
-
02:21 AM Revision 67363231 (git): Suppress a clobbered warning
-
02:21 AM Revision 4fb8a12a (git): Deprecate rb_iterate in C++
-
02:21 AM Revision 733ffa74 (git): Suppress deprecated rb_iterate declaration warnings in C++
-
02:21 AM Revision a14671a6 (git): Suppress warnings in C++2a
- * bitwise operation between different enumeration types
('ruby_value_type' and 'ruby_fl_type') is deprecated
[-Wdeprecated-enum-enum-conversion]
* volatile-qualified parameter type 'volatile int' is deprecated
[-Wdeprecated-volatile] -
02:21 AM Revision f584dc5a (git): Suppress unused-function warning when OPT_THREADED_CODE != 1
-
02:21 AM Revision 836b7047 (git): Suppress unused-variable warnings when DEBUG_INTEGER_PACK
08/08/2021
- 11:41 PM Revision dc2eb6f7 (git): * 2021-08-09 [ci skip]
- 11:40 PM Revision 48c43f77 (git): Rework the readline test to be more robust.
- - Capture that the child is started by initial log line.
- More robust handling of child status reaping.
- Direct exit without sucess mesage if `#readline` receives input. -
06:33 PM Feature #18070 (Open): `attr` should be removed
- I'm digging through some older Ruby versions and discovered that `attr` was deprecated in Ruby 1.9. We still are seeing support for it in Ruby 3.0
Unless there are internals that require its existence, is it time to remove this deprec... -
02:30 PM Feature #18069 (Open): `instance_exec` is just ignored when the block is originally a method
I know you can't `instance_exec` a proc which is generated by `Method#to_proc` because it has its original instance's context. But, in such a case, raising `ArgumentError` would be the ideal behavior.
```ruby
f = -> (x) { a + x }
...-
02:21 PM Feature #18068 (Closed): Silence LoadError only if it is for rubygems itself
- **Background**
The "Optionally load did_you_mean and RubyGems" PR (https://github.com/ruby/ruby/pull/2764) attempted to prevent raising `LoadError` when requiring `rubygems` because it might not be available optionally when Ruby is ... -
01:09 PM Bug #18067 (Rejected): Composite procs with `instance_exec` aren't executed within the context of the receiver
- ```ruby
func1 = -> (x) { x + y }
class A
def y
10
end
end
A.new.instance_exec(1, &func1) # => 11
func2 = -> (x) { x * 2 }
f = func1 >> func2
A.new.instance_exec(1, &f) # => undefined local variable or method `y' f... - 10:12 AM Revision 3a8cadcf (git): Reduce chance to receive EBADF when closing an IO from another thread.
-
08:13 AM Revision 587f501c (git): Make bit flags `reason` unsigned
-
06:43 AM Revision ca2dd6d3 (git): Use #full_message instead of #backtrace_locations
-
06:13 AM Revision f8196456 (git): Suppress warnings when GC_ENABLE_INCREMENTAL_MARK == 0
-
04:01 AM Revision 3922394c (git): Bump patchlevel.
-
04:00 AM Bug #18053: Crashes and infinite loops when generating partial backtraces in Ruby 3.0+
- ruby_3_0 c07545bbf82068f4fd92a5ccfa2b09bb96b39adb.
-
03:35 AM Bug #18053: Crashes and infinite loops when generating partial backtraces in Ruby 3.0+
- Hello Jeremy,
Thank you for your great work on the partial backtrace optimization and deep understanding for the stable branch maintenance. I'd like to adopt your 3rd option. I will merge your PR after confirming the CI passed with it. -
03:59 AM Revision c07545bb (git): Fix multiple bugs in partial backtrace optimization
- This fixes multiple bugs found in the partial backtrace
optimization added in 3b24b79.
These bugs occurs when passing a start argument to caller where
the start argument lands on a iseq frame without a pc.
Before this commit, the follow... -
03:01 AM Bug #18065: 3.0.2 - possible memory leak in Hash#transform_keys!
- ruby_3_0 d6b8b37a2608a0fbb8bcfd10356bb25f9ebbe1fe merged revision(s) e5dd40b1f3a11f48d566413ab347ce0cfdd94960.
-
03:00 AM Revision d6b8b37a (git): merge revision(s) e5dd40b1f3a11f48d566413ab347ce0cfdd94960: [Backport #18065]
- Stop force-recycling evacuated array [Bug #18065]
---
hash.c | 1 -
1 file changed, 1 deletion(-) -
12:25 AM Revision 40ccb87a (git): Show backtrace locations when I/O timed out
- 12:25 AM Revision c6398d3d (git): * 2021-08-08 [ci skip]
08/07/2021
-
08:35 PM Bug #18066: Load did_you_mean/error_highlight even with --disable-gems
- However, I am not sure what is the impact in case Ruby can be build with `--disable-gems` configuration option (if that is possible).
-
08:30 PM Bug #18066 (Rejected): Load did_you_mean/error_highlight even with --disable-gems
- I guess that did_you_mean was not possible to load without RubyGems, when it used to be bundled gem. Since it is default gem, therefore part of StdLib and always available on load path, it should not be related to --disable-gems anymore....
-
07:43 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- Eregon (Benoit Daloze) wrote in #note-8:
> Their description should still match the tested behavior though,
> ...
OK, I pushed another commit for that. -
06:18 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- BTW, Zeitwerk has its own "Ruby compatibility suite" for language details the implementation relies on. Like, you can override autoloads, remove_const does not execute autoloads, etc.: https://github.com/fxn/zeitwerk/blob/main/test/lib/z...
-
06:14 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- Indeed, to me, this belongs to the contract of these APIs and should be documented.
The documentation of `Module#autoload` should say what happens if the file is not found, if the file is found but raises, if the file is found and is ... -
06:01 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- Thanks, it's fine to modify these specs.
Their description should still match the tested behavior though,
for "does not remove the constant from Module#constants if the loaded file does not define it, but leaves it as 'undefined'"
s... -
04:24 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- jeremyevans0 (Jeremy Evans) wrote in #note-6:
> I updated the pull request to remove the constant instead of just deleting the autoload. If it passes CI, I'm fine with that approach.
Removing the constant breaks 4 specs:
```
ruby... -
03:48 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- I updated the pull request to remove the constant instead of just deleting the autoload. If it passes CI, I'm fine with that approach.
-
01:17 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- Indeed, the concept of undefined constants for me is dubious. An autoload claims that the constant should be in the given file, but you don't know until the file is evaluated. So, it has been always surprising to me that the constants AP...
-
01:14 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- I deleted my previous comment, misunderstood the situation.
Yeah, in my view if you fire an autoload, the autoload should be removed regardless of the outcome. Additionally, if the constant has not been defined, it should be removed (... -
10:53 AM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- Maybe we should remove the constant as well if we remove the autoload?
I think that would be natural and simpler semantically.
Currently there is some really strange semantics around that, which lead to a lot of complexity (e.g., the c... -
01:58 PM Revision 1fe73128 (git): Use TERM=xterm for tests on Solaris
-
12:16 PM Revision f092a960 (git): Set TERM env for some CI environments
-
11:09 AM Feature #10917: Add GC.stat[:total_time] when GC profiling enabled
- byroot (Jean Boussier) wrote in #note-6:
> Ideally we'd return a float, but as noted by @jasonrclark, it's not easy to return anything else than `size_t` without breaking the `size_t rb_gc_stat(VALUE)` C API.
If that precision is needed... -
09:32 AM Revision 6e60fc29 (git): Group commands on GitHub Actions
-
05:18 AM Revision ac7986f4 (git): Remove unneeded rb_fiber_transfer_kw declaration
-
03:50 AM Revision 9b3fcfbb (git): Suppress unused-result warnings
- * Hide read function warning in string_spec_RSTRING_PTR_read function
* The type of `read` may be `ssize_t`
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org> -
03:41 AM Bug #18065 (Closed): 3.0.2 - possible memory leak in Hash#transform_keys!
- Applied in changeset commit:git|e5dd40b1f3a11f48d566413ab347ce0cfdd94960.
----------
Stop force-recycling evacuated array [Bug #18065] -
01:06 AM Bug #18065: 3.0.2 - possible memory leak in Hash#transform_keys!
- It looks likely related to commit:84d9a9afc0b49d095541acb9832f8b12fb506e19.
-
12:03 AM Bug #18065 (Closed): 3.0.2 - possible memory leak in Hash#transform_keys!
- I found what may be a memory leak in Hash#transform_keys! in version 3.0.2
This sample code will reproduce the issue. It quickly consumes gigabytes of memory when running on 3.0.2, but has very normal memory usage on 3.0.1. I test... -
03:34 AM Revision e5dd40b1 (git): Stop force-recycling evacuated array [Bug #18065]
-
02:01 AM Bug #18062: Ruby with enabled LTO segfaults during build
- OK, how about this?
https://github.com/ruby/ruby/pull/4716
08/06/2021
-
10:40 PM Bug #13864: Rinda multicast test failures due to missing default route
- This appears to still be an issue in the master branch. I submitted an upstream pull request to fix it: https://github.com/ruby/rinda/pull/1
-
10:12 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- ```
On another side, we have an Intel CET [2], [3]:
"Control-flow Enforcement Technology (CET) provides the following capabilities to defend
against ROP/JOP style control-flow subversion attacks:
- Shadow Stack - return address prote... -
12:39 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- Thanks for the patch! Let me check it.
-
12:26 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- That seems the same as a section generated by GCC.
-
10:04 PM Bug #17183 (Closed): Float round working weirdly
- Applied in changeset commit:git|d16b68cb2204eeb5af8bd39149202b630374c67f.
----------
Use Rational for Float#round with ndigits > 14
ndigits higher than 14 can result in values that are slightly too
large due to floating point limitatio... -
10:04 PM Bug #14635 (Closed): Float#round(n) returns a wrong result when n is big
- Applied in changeset commit:git|d16b68cb2204eeb5af8bd39149202b630374c67f.
----------
Use Rational for Float#round with ndigits > 14
ndigits higher than 14 can result in values that are slightly too
large due to floating point limitatio... -
10:03 PM Revision d16b68cb (git): Use Rational for Float#round with ndigits > 14
- ndigits higher than 14 can result in values that are slightly too
large due to floating point limitations. Converting to rational
for the calculation and then back to float fixes these issues.
Fixes [Bug #14635]
Fixes [Bug #17183]
Co-... -
09:47 PM Bug #15790: Strange interaction between autoload and $LOADED_FEATURES
- This is still an issue in the master branch. One way to fix this is to delete the autoload if the constant isn't present after the file is loaded. I submitted a pull request for that: https://github.com/ruby/ruby/pull/4715
-
08:47 PM Feature #10917: Add GC.stat[:total_time] when GC profiling enabled
- > FWIW TruffleRuby and JRuby both have a :time value in GC.stat and it represents the total GC time, in milliseconds
Ah that's good to know. Thank you!
In this case I think the patch could look like this: https://github.com/Shopif... -
08:03 PM Feature #10917: Add GC.stat[:total_time] when GC profiling enabled
- FWIW TruffleRuby and JRuby both have a `:time` value in `GC.stat` and it represents the total GC time, in milliseconds (`GarbageCollectorMXBean#getCollectionTime` provides this data on the JVM)
(No GC::Profiler needed to query it)
If thi... -
11:15 AM Feature #10917: Add GC.stat[:total_time] when GC profiling enabled
- I'd like to restart the discussion on this as I recently hit the same issue.
> With incremental GC (incremental marking and lazy sweep) consume very short time for each step.
Indeed. However when running a web service, even if ind... -
07:16 PM Bug #17362 (Closed): Thread core dump
-
05:28 PM Bug #18053: Crashes and infinite loops when generating partial backtraces in Ruby 3.0+
- I committed my rewrite of backtrace generation (commit:1a05dc03f953830564c272665c47a61e53550f3e), which fixes these issues in master/3.1. I took the examples from this issue and added them as tests in that commit.
For Ruby 3.0, there ... -
05:15 PM Bug #18053 (Closed): Crashes and infinite loops when generating partial backtraces in Ruby 3.0+
- Applied in changeset commit:git|1a05dc03f953830564c272665c47a61e53550f3e.
----------
Make backtrace generation work outward from current frame
This fixes multiple bugs found in the partial backtrace
optimization added in 3b24b7914c1693... - 05:15 PM Revision 0d3520b0 (git): * 2021-08-07 [ci skip]
-
05:15 PM Revision 1a05dc03 (git): Make backtrace generation work outward from current frame
- This fixes multiple bugs found in the partial backtrace
optimization added in 3b24b7914c16930bfadc89d6aff6326a51c54295.
These bugs occurs when passing a start argument to caller where
the start argument lands on a iseq frame without a pc... -
04:46 PM Bug #18064 (Closed): Backport fix for bug 7844 (include/prepend satisfiable module dependencies are not satisfied)
-
07:32 AM Bug #18064: Backport fix for bug 7844 (include/prepend satisfiable module dependencies are not satisfied)
- Upgrading Ruby from 2.7 to 3.0 is too much work just for this bug fix
Especially when many existing gems don't work properly in 3.x
This backport is required to address
[an issue about usage of a gem](https://github.com/panorama-ed... -
07:27 AM Bug #18064 (Closed): Backport fix for bug 7844 (include/prepend satisfiable module dependencies are not satisfied)
- Bug:
https://bugs.ruby-lang.org/issues/7844
Already merged PR with fix (merged into 3.0):
https://github.com/ruby/ruby/pull/3796
I have already created a PR for backport:
https://github.com/ruby/ruby/pull/4711 -
02:16 PM Bug #18062: Ruby with enabled LTO segfaults during build
- nobu (Nobuyoshi Nakada) wrote in #note-8:
Thx, this helps. Howeverer, there is more:
~~~
(gdb) r -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems "./libexec/rdoc" --root "." --encoding=UTF-8 --all --ri -... -
12:10 PM Bug #18062: Ruby with enabled LTO segfaults during build
- vo.x (Vit Ondruch) wrote in #note-5:
> ~~~
> ...
I've missed here.
-
10:30 AM Bug #18062: Ruby with enabled LTO segfaults during build
- I should probably include a few more lines from the log which include the build options:
~~~
gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-... -
10:22 AM Bug #18062: Ruby with enabled LTO segfaults during build
- nobu (Nobuyoshi Nakada) wrote in #note-4:
> Maybe a strict aliasing issue?
The patch changes the error:
~~~
./miniruby -I./lib -I. -I.ext/common ./tool/generic_erb.rb -c -o encdb.h ./template/encdb.h.tmpl ./enc enc
<internal:ra... -
12:30 PM Bug #18054 (Closed): No rule to make target 'thread_fd_close.c', needed by 'thread_fd_close.o'
- Eregon (Benoit Daloze) wrote in #note-5:
> `make clean` is sometimes needed when building CRuby (correct C files dependencies is still a mess to this day, not CRuby-specific).
> ...
Thanks, that helped. -
11:55 AM Bug #18054: No rule to make target 'thread_fd_close.c', needed by 'thread_fd_close.o'
- duerst (Martin Dürst) wrote in #note-4:
> ```
> ...
This file should be updated, but actually wasn't.
Could you try again after removing that file? -
10:14 AM Bug #18054: No rule to make target 'thread_fd_close.c', needed by 'thread_fd_close.o'
- `make clean` is sometimes needed when building CRuby (correct C files dependencies is still a mess to this day, not CRuby-specific).
Would that help here? -
08:59 AM Bug #18054: No rule to make target 'thread_fd_close.c', needed by 'thread_fd_close.o'
- nobu (Nobuyoshi Nakada) wrote in #note-3:
> You can remove the old directory, and `ext/-test-/exts.mk` file.
Many thanks for your help. I removed both the directory and the file. Now I'm getting the following:
```
transdb.h uncha... -
11:58 AM Revision d868c8f0 (git): Make jobserver available
-
11:20 AM Misc #18039: DevelopersMeeting20210819Japan
- * [Feature #10917] Add GC.stat[:total_time] (byroot)
* Time spent in GC is a very important metric for application performance monitoring.
* Right now only `GC::Profiler` can be used, but it is ill suited when there are multiple call... -
07:35 AM Bug #7844: include/prepend satisfiable module dependencies are not satisfied
- Thanks @jeremyevans0 for informing the backport request before I create the backport ticket
A backport ticket is created:
https://bugs.ruby-lang.org/issues/18064
I have provided the reason for requesting this backport to 2.7 in th... -
04:34 AM Revision 3e7fb4b9 (git): Check the result of tigetstr
-
04:33 AM Revision 9bfb8ea6 (git): Fix caching of curses_dl
-
01:39 AM Revision 7af21a78 (git): test/reline/test_terminfo.rb: skip when setupterm fails
- http://rubyci.s3.amazonaws.com/solaris11-gcc/ruby-master/log/20210806T000008Z.fail.html.gz
```
1) Error:
Reline::Terminfo::Test#test_tigetstr:
Reline::Terminfo::TerminfoError: The terminfo database could not be found.
/export/home/...
08/05/2021
-
06:55 PM Revision e687b6f4 (git): Show Readline::VERSION for debugging
- 06:50 PM Revision 983630b5 (git): * 2021-08-06 [ci skip]
-
06:50 PM Revision 9b56668b (git): Omit test_interrupt_in_other_thread with Editline
-
06:17 PM Revision 6414334d (git): Fix reversal of assertion result
-
06:15 PM Revision cd57b39f (git): Fix control structure to preperly catch Timeout::Error
-
05:51 PM Revision 7bcbee37 (git): Fix the result of checking the existence of constants being reversed
-
05:49 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- It seems we can check if the `.note.gnu.property` exists in a binary file by the command `readelf -S --wide <file>`. The binary file `ruby` has it. But the file `libruby.so.3.1.0` doesn't it.
```
$ readelf -S --wide ruby
There are 4... -
05:10 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- By the way, I found a case generating ".note.gnu.property section" in the OpenSSL project.
https://github.com/openssl/openssl/commit/51994e505dbb1cd0dd76869ec962e2948b77b585
The commit message explains how they verified the change. S... -
03:52 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- I applied the patch for the Ruby 3.0.2 in RHEL 8, built. But I still see the failed message.
```
annocheck: Version 9.65.
Hardened: libruby.so.3.0.2: FAIL: property-note test because no .note.gnu.property section found
Hardened: Re... -
03:38 PM Bug #7844: include/prepend satisfiable module dependencies are not satisfied
- PickachuEXE on GitHub requested this be backported to 2.7: https://github.com/ruby/ruby/pull/4711 . This does affect backwards compatibility, so I'm not sure it is something that should be backported. The 2.7 branch maintainer (@usa) wi...
-
03:29 PM Bug #17806: Bad interaction between method cache, prepend, and refinements
- Hi @mk, from the description you gave, it's possible that you are running into #17725.
I would try running these two lines before requiring the test file that contains the | call:
```
iseq = RubyVM::InstructionSequence
iseq.compile... -
11:49 AM Bug #17806: Bad interaction between method cache, prepend, and refinements
- Hi @alanwu,
at GitLab we are currently working on making our application Ruby 3 ready.
We are running into a strange issue in our test suite where refinements fails to be applied when everything suggests they should be.
During m... -
02:52 PM Feature #18045: Variable Width Allocation Phase II
- Hi @duerst, thank you for the feedback. Thank you for adding it to the committer meeting, we will wait for their feedback before proceeding further.
> Using powers of 2 slot sizes is the "trusted and true" way of handling this, but ma... -
12:55 AM Feature #18045: Variable Width Allocation Phase II
- I think this should really be discussed seriously at least once at a committer's meeting. I have added it to #18039.
Using powers of 2 slot sizes is the "trusted and true" way of handling this, but may lead to some memory overhead. W... -
02:10 PM Bug #12706: Hash#each yields inconsistent number of args
- I just ran into this since I hadn't been aware of this change.
What I find odd about this change is that it introduces a new inconsistency: the behavior of related Enumerable methods such as `map` is now different to that of `each` (i... -
01:30 PM Revision bda56a03 (git): Build rubyspec CAPI extensions
-
11:32 AM Bug #18062: Ruby with enabled LTO segfaults during build
- Maybe a strict aliasing issue?
-
08:42 AM Bug #18062: Ruby with enabled LTO segfaults during build
- vo.x (Vit Ondruch) wrote in #note-2:
> I'd say it goes sideways somewhere here:
> ...
Actually, this is weird:
~~~
Breakpoint 1, vm_ccs_push (cc=0x55555595ddf0, ci=0x22f100140003, ccs=0x555555a31f80, klass=93824996623120) at ./incl... -
08:30 AM Bug #18062: Ruby with enabled LTO segfaults during build
- I'd say it goes sideways somewhere here:
https://github.com/ruby/ruby/blob/0db68f023372b634603c74fca94588b457be084c/vm_insnhelper.c#L1708
I'm not sure why the `rb_id_table_lookup` does not provide any value for `css`, but there is ... -
08:11 AM Bug #18062: Ruby with enabled LTO segfaults during build
- GDB output:
~~~
$ gdb ./miniruby
GNU gdb (GDB) Fedora 10.2-6.fc35
Copyright (C) 2021 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are fr... -
07:56 AM Bug #18062 (Closed): Ruby with enabled LTO segfaults during build
- After a while, I am trying to enable LTO for Ruby in Fedora. Previously I hit #17052, but now I observe issues much earlier during compliation already:
~~~
./miniruby -I./lib -I. -I.ext/common ./tool/generic_erb.rb -c -o encdb.h ./t... -
10:39 AM Revision 1cb5a669 (git): Show log when timed out
-
10:05 AM Bug #18054: No rule to make target 'thread_fd_close.c', needed by 'thread_fd_close.o'
- duerst (Martin Dürst) wrote in #note-2:
> Do you mean `ext/-test-/thread_fd_close` should no longer exist? Or something else?
Yes,renamed as `ext/-test-/thread_fd`.
You can remove the old directory, and `ext/-test-/exts.mk` file. -
08:08 AM Bug #18054: No rule to make target 'thread_fd_close.c', needed by 'thread_fd_close.o'
- (sorry this answer is late)
nobu (Nobuyoshi Nakada) wrote in #note-1:
> Do `ext/-test-/thread_fd` directory and `Makefile` there exist?
The directory exists, but the Makefile doesn't exist.
> ...
This says `make: *** No rule ... -
10:02 AM Feature #18063 (Open): io_uring implementation
- https://www.youtube.com/watch?v=TYq_ohhYZ9A
-
08:25 AM Revision a97837de (git): Fix a link [ci skip]
-
08:14 AM Revision ae275f67 (git): Show WorkingSetSize as RSS on Windows
-
08:11 AM Revision 228b3e43 (git): check GC.enable'd status
- Check GC.enable'd status before and after test execution.
Write this checker in gc_checker.rb, it was renamed from
gc_compact_checker.rb. -
05:48 AM Revision 405644f3 (git): Revert "Removed extinit.o from main programs"
- This reverts commit ac86fcbfd0bab8667d277aa575bc5b81e5135d3c.
This change broke "--disable-shared --with-static-linked-ext". -
05:15 AM Revision 3bb64109 (git): Use equivalent `__FILE__`
-
04:58 AM Revision 594c3df9 (git): Tests for Windows can run only on Windows
- Should not directly require "reline/windows.rb" which should be
loaded by "reline.rb". -
12:33 AM Misc #18039: DevelopersMeeting20210819Japan
- * [Feature #18045] Variable Width Allocation Phase II (peterzhu2118)
* Variable Width Allocation is a major change to Ruby internals and therefore should be discussed seriously.
08/04/2021
-
09:16 PM Feature #18045: Variable Width Allocation Phase II
- Hello! We’re still looking for feedback on this. If there are no concerns, we’ll merge it next week.
- 08:11 PM Revision bc8bc072 (git): * 2021-08-05 [ci skip]
- 08:11 PM Revision 1fd0a2e4 (git): Reenable GC at the end of test
- The test disables GC but never reenables it. Before this patch, running
all tests would have a peak RSS in the main process of >4GB. After this
patch, peak RSS in the main process is <500MB. -
04:39 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- Thanks for the patch! Let me check it.
-
04:20 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- Does it work just by adding an empty section?
-
01:37 PM Bug #18061 (Closed): Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- I found an issue in our company's internal test called "execshield" by a security tool annobin - annocheck command [1][2].
```
Hardened: libruby.so.2.7.4: FAIL: property-note test because no .note.gnu.property section found
```
H... -
02:35 PM Revision 042d4c81 (git): Remove an unused variable
-
11:39 AM Revision 5f2987d6 (git): Fix relative paths from core_assertions.rb
-
09:29 AM Revision 6e55facd (git): Run interrupt test except on Windows
-
09:29 AM Revision aba10ea6 (git): Add a load path to require 'helper'
-
09:29 AM Revision 335c1282 (git): Show the log of test_interrupt_in_other_thread when failed
-
09:29 AM Revision 17ef7a98 (git): Check the existence of the test classes
-
09:29 AM Revision 5ca0a51f (git): Add a test for handling SIGINT in other thread
-
09:29 AM Revision de93b8b0 (git): Handle SIGINT in other thread correctly
- Co-authored-by: Koichi Sasada <ko1@atdot.net>
-
09:29 AM Revision 5bb7b571 (git): Use Symbol of signal for trap
-
08:05 AM Bug #14137: Windows / MinGW - Regexp - Character Properties - General Category
- I agree with @jeremyevans0, but would like to add that
```
ruby -e 'p (/\p{L}/.match("a"))'
```
will produce `#<MatchData "a">` also in any situation that is using UTF-8. That will be on almost all current Linux/Unix,... versions, an... -
07:59 AM Revision 1f2b3f25 (git): Remove an extraneous escape
- Since a3fb97465df3, this string is not inside the here-document.
-
06:01 AM Misc #18059: Which FL_USERx are open to extension libraries?
- duerst (Martin Dürst) wrote in #note-6:
> Dan0042 (Daniel DeLorme) wrote in #note-4:
> ...
Sorry, I should have been more specific the first time round. One question is whether extension libraries are allowed to use some flags. The oth... -
03:53 AM Misc #18059: Which FL_USERx are open to extension libraries?
- Dan0042 (Daniel DeLorme) wrote in #note-4:
> Actually I have so many questions about flags,...
> ...
Yes, please!
-
03:40 AM Revision 80c180df (git): merge revision(s) b8386f7f7f6d7a7d76481e02d389d0f5211f0f2c:
- Prepend DebugSystem to VCS class only
And revert 24e5f1c982966c379220b1bbb26b4e0320180fa1, pepending to
Kernel did not affect the top level methods before 3.0.
---
tool/lib/vcs.rb | 3 ---
too...